zyounan added a comment.
Updated now. Thank you again for your patient review. :)
================
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:213
++SnippetArg;
- if (SnippetArg == CursorSnippetArg) {
+ if (ShouldPatchPlaceholder0 && SnippetArg == CursorSnippetArg) {
// We'd like to make $0 a placeholder too, but vscode does not support
----------------
nridge wrote:
> I realized the first part of the condition is now redundant: if
> `ShouldPatchPlaceholder0 == false`, then `CursorSnippetArg` will have value
> `std::numeric_limits<unsigned>::max()` and `SnippetArg == CursorSnippetArg`
> will never be true.
Aha, yes. Almost forget that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145319/new/
https://reviews.llvm.org/D145319
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
