paulwalker-arm created this revision. Herald added a project: All. paulwalker-arm requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.
Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146146 Files: clang/lib/Driver/ToolChains/Clang.cpp Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -5560,22 +5560,6 @@ RenderTargetOptions(Triple, Args, KernelOrKext, CmdArgs); - // FIXME: For now we want to demote any errors to warnings, when they have - // been raised for asking the wrong question of scalable vectors, such as - // asking for the fixed number of elements. This may happen because code that - // is not yet ported to work for scalable vectors uses the wrong interfaces, - // whereas the behaviour is actually correct. Emitting a warning helps bring - // up scalable vector support in an incremental way. When scalable vector - // support is stable enough, all uses of wrong interfaces should be considered - // as errors, but until then, we can live with a warning being emitted by the - // compiler. This way, Clang can be used to compile code with scalable vectors - // and identify possible issues. - if (isa<AssembleJobAction>(JA) || isa<CompileJobAction>(JA) || - isa<BackendJobAction>(JA)) { - CmdArgs.push_back("-mllvm"); - CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); - } - // These two are potentially updated by AddClangCLArgs. codegenoptions::DebugInfoKind DebugInfoKind = codegenoptions::NoDebugInfo; bool EmitCodeView = false;
Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -5560,22 +5560,6 @@ RenderTargetOptions(Triple, Args, KernelOrKext, CmdArgs); - // FIXME: For now we want to demote any errors to warnings, when they have - // been raised for asking the wrong question of scalable vectors, such as - // asking for the fixed number of elements. This may happen because code that - // is not yet ported to work for scalable vectors uses the wrong interfaces, - // whereas the behaviour is actually correct. Emitting a warning helps bring - // up scalable vector support in an incremental way. When scalable vector - // support is stable enough, all uses of wrong interfaces should be considered - // as errors, but until then, we can live with a warning being emitted by the - // compiler. This way, Clang can be used to compile code with scalable vectors - // and identify possible issues. - if (isa<AssembleJobAction>(JA) || isa<CompileJobAction>(JA) || - isa<BackendJobAction>(JA)) { - CmdArgs.push_back("-mllvm"); - CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); - } - // These two are potentially updated by AddClangCLArgs. codegenoptions::DebugInfoKind DebugInfoKind = codegenoptions::NoDebugInfo; bool EmitCodeView = false;
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits