[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware updated this revision to Diff 491775. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142470/new/ https://reviews.llvm.org/D142470 Files: clang/include/clang/Lex/PPCallb

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware updated this revision to Diff 491776. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142471/new/ https://reviews.llvm.org/D142471 Files: clang-tools-extra/pp-trace/PPCa

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:223 +llvm::Error Interpreter::CreateExecutor() { + const clang::TargetInfo &TI = argentite wrote: > sgraenitz wrote: > > Factoring out this function looks like an independent ch

[clang] d63e492 - [10/15][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy` and `isTUPolicy`

Author: eopXD Date: 2023-01-24T07:12:34-08:00 New Revision: d63e492562f255684f0e2b2e4eb14baf17a485d7 URL: https://github.com/llvm/llvm-project/commit/d63e492562f255684f0e2b2e4eb14baf17a485d7 DIFF: https://github.com/llvm/llvm-project/commit/d63e492562f255684f0e2b2e4eb14baf17a485d7.diff LOG: [1

[PATCH] D141767: [10/15][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy` and `isTUPolicy`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd63e492562f2: [10/15][Clang][RISCV][NFC] Don't need to check for `MaskPolicy` in `isTAPolicy`… (authored by eopXD). Changed prior to commit: https

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. In D139926#4076057 , @nridge wrote: > One other thought that has occurred to me is that as we add more semantic > tolens for punctuation, the test cases in `GetsCorrectTokens` become harder > to read. > > What would you think

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito added a comment. Oops wrong diff, i'll update it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for the fix! It looks like precommit CI found a related failure that needs to be addressed: https://buildkite.com/llvm-project/premerge-checks/builds/130589#0185ac99-1158-46b3-b6d1-52fcf5310a59 Can you also

[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

asb updated this revision to Diff 491780. asb marked an inline comment as done. asb added a comment. Add zero-length array test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142326/new/ https://reviews.llvm.org/D142326 Files: clang/test/CodeGen/RISCV/abi-empty-structs.c Index

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb updated this revision to Diff 491781. asb marked an inline comment as done. asb added a comment. - Address review comments - Refresh after adding zero-length array tests (and fix a bug this unearthed). - Add to release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142327/new/

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito updated this revision to Diff 491783. ManuelJBrito added a comment. fixed diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/include/clang/Basic/Builtins.def clang/include/

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491784. pmatos added a comment. Simplify and add tests for remaining diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl added a comment. @scchan the test expects CLANG_INSTALL_LIBDIR_BASENAME to be `lib`. Maybe in the failed test it was not true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 _

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. In D141714#4077150 , @aaron.ballman wrote: > Thank you for the fix! > > It looks like precommit CI found a related failure that needs to be > addressed: > https://buildkite.com/llvm-project/premerge-checks/builds/1305

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a comment. In D141714#4077199 , @giulianobelinassi wrote: > In D141714#4077150 , @aaron.ballman > wrote: > >> Thank you for the fix! >> >> It looks like precommit CI found a related failure t

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. In D142094#4070856 , @eopXD wrote: > In D142094#4065611 , @asb wrote: > >> In D142094#4065175

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. In D141714#4077204 , @aaron.ballman wrote: > In D141714#4077199 , > @giulianobelinassi wrote: > >> In D141714#4077150 , >> @aaron.bal

[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

luismarques added inline comments. Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:1 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --full-function-signature --filter "^define |^entry:" +// RUN: %clang_cc1

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.py to match return type as well as args

nikic added a comment. D142473 would be my proposal to fix the test churn problem going forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142373/new/ https://reviews.llvm.org/D142373 ___

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:100 SYMBOL(atoll, std::, ) +SYMBOL(atomic, std::, ) +SYMBOL(atomic, std::, ) hokein wrote: > VitaNuo wrote: > > VitaNuo wrote: > > > kadircet wrote: > > > > hokei

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11827 +def err_wasm_builtin_arg_must_be_integer_type : Error < + "%ordinal0 argument must be an integer">; } // end of sema component. ---

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491790. pmatos added a comment. Add missing newline at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.h clang/inc

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. @aaron.ballman Thanks for all the comments, I have now finished addressing those. What do you think of the current patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 _

[PATCH] D140315: [AMDGCN] Update search path for device libraries

mgorny added a comment. In D140315#4077193 , @yaxunl wrote: > @scchan the test expects CLANG_INSTALL_LIBDIR_BASENAME to be `lib`. Maybe in > the failed test it was not true. `CMAKE_INSTALL_LIBDIR=lib64`, so I guess `_BASENAME` is that as well. Reposit

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl added inline comments. Comment at: clang/test/Driver/hip-device-libs.hip:206 + +// RESDIR-SAME: "-mlink-builtin-bitcode" "[[DEVICELIB_DIR:[^"]+(/|)rocm_resource_dir(/|)lib(/|)amdgcn(/|).*]]hip.bc" +// ROCMDIR-SAME: "-mlink-builtin-bitcode" "[[DEVICELIB_DI

[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

asb added inline comments. Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:1 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --full-function-signature --filter "^define |^entry:" +// RUN: %clang_cc1 -triple

[PATCH] D142065: [SVE] Fix incorrect lowering of predicate permute builtins.

peterwaller-arm added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:6361 + def : SVE_2_Op_Pat(NAME # _S)>; + def : SVE_2_Op_Pat(NAME # _D)>; } Out of interest, is there a good reason to handle the nxv16 pattern case differently in

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491796. VitaNuo added a comment. Add early return for found symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/C

[PATCH] D142468: [clang][dataflow] Fix bug in handling of reference-typed fields.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:209 if (VD->getType()->isReferenceType()) { + assert(isValidReferenceLoc(*DeclLoc, Env) && +

[PATCH] D142477: [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006)

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The macro `_mm_test_all_ones(V)` was defined as `_mm_testc_si128((V), _mm_c

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

eopXD updated this revision to Diff 491805. eopXD edited the summary of this revision. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141768/new/ https://reviews.llvm.org/D141768 Files: clang/include/

[PATCH] D142468: [clang][dataflow] Fix bug in handling of reference-typed fields.

ymandel updated this revision to Diff 491806. ymandel added a comment. use `isa_and_nonnull` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142468/new/ https://reviews.llvm.org/D142468 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 491807. dzhidzhoev added a comment. Fixed crash for 'struct C' in no-unique-address-3.cpp. Without the fix, packedness for regular union layout in provided test and for [[no_unique_address]] union layout turns out to be different. This causes assertion on C

[PATCH] D142468: [clang][dataflow] Fix bug in handling of reference-typed fields.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:209 if (VD->getType()->isReferenceType()) { + assert(isValidReferenceLoc(*DeclLoc, Env) && + "reference-typed declarations map

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a comment. In D141714#4077207 , @giulianobelinassi wrote: > In D141714#4077204 , @aaron.ballman > wrote: > >> In D141714#4077199 , >> @giulianobelin

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

frasercrmck added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2150 + Args.MakeArgString("-mvscale-min=" + llvm::Twine(VScaleMin))); +} else if (!Val.equals("scalable")) { + // Handle the unsupported values passed to mrvv-vector-bits. -

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

kadircet added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:174 - # std::remove<> has variant algorithm. - "std::remove": ("algorithm"), - } VitaNuo wrote: > VitaNuo wrote: > > kadircet wrote: > > > VitaNuo wrote: > >

[clang] b84ac96 - [clang][dataflow] Fix bug in handling of reference-typed fields.

Author: Yitzhak Mandelbaum Date: 2023-01-24T16:10:50Z New Revision: b84ac96a35c72420b45db6385f83a5e0c516349f URL: https://github.com/llvm/llvm-project/commit/b84ac96a35c72420b45db6385f83a5e0c516349f DIFF: https://github.com/llvm/llvm-project/commit/b84ac96a35c72420b45db6385f83a5e0c516349f.diff

[PATCH] D142468: [clang][dataflow] Fix bug in handling of reference-typed fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rGb84ac96a35c7: [clang][dataflow] Fix bug in handling of reference-typed fields. (authored by ymandel). Repo

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

dblaikie added a comment. In D141826#4072609 , @Michael137 wrote: > In D141826#4059088 , @erichkeane > wrote: > >> In D141826#4059073 , @Michael137 >> wrote: >> >>> In

[clang] 377d260 - [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

Author: eopXD Date: 2023-01-24T08:13:12-08:00 New Revision: 377d2604e1ddff695cbabc50703ea34ac5df8dea URL: https://github.com/llvm/llvm-project/commit/377d2604e1ddff695cbabc50703ea34ac5df8dea DIFF: https://github.com/llvm/llvm-project/commit/377d2604e1ddff695cbabc50703ea34ac5df8dea.diff LOG: [1

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG377d2604e1dd: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

pscoro added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140628/new/ https://reviews.llvm.org/D140628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

spaits added a comment. Thank you for your response @steakhal! I am going to define a mock standard variant header. I was thinking about just copying the definitions from the original variant header but it had other headers as dependency. I will write my own variant definition one step at the t

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun added a reviewer: erichkeane. xazax.hun added a comment. Since now the patch touches Clang proper, adding one more reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

spaits updated this revision to Diff 491816. spaits added a comment. Adding mock header for std::variant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142354/new/ https://reviews.llvm.org/D142354 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyz

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

xazax.hun added a comment. Overall looks good to me, I wonder if the tests could be less manual though. E.g., instead of asserting true/false, checking if the assignment would compile. This way we can be sure that the method in ASTContext matches the behavior of the compiler (and we get notifie

[clang] 1a803e0 - [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

Author: eopXD Date: 2023-01-24T08:28:01-08:00 New Revision: 1a803e0b2ad7ea9cfe7fc832210f537fce3f5a51 URL: https://github.com/llvm/llvm-project/commit/1a803e0b2ad7ea9cfe7fc832210f537fce3f5a51 DIFF: https://github.com/llvm/llvm-project/commit/1a803e0b2ad7ea9cfe7fc832210f537fce3f5a51.diff LOG: [1

[PATCH] D141789: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a803e0b2ad7: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > >

[PATCH] D141792: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcaa61ccc8f99: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics… (authored by eopXD). Changed prior to commit: https://r

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added a comment. Thanks. Please see my comments/questions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits

[PATCH] D141793: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84c8bbe95a8a: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA (authored by eopXD). Changed prior to commit: https://reviews.llvm.org

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

erichkeane added a comment. Not a great reviewer here as I'm not particularly sure what is going on, but I 'looked at the clang parts. Comment at: clang/include/clang/AST/ASTContext.h:2828 + static bool isQualificationConvertiblePointer(QualType From, QualType To, +

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

reames added a comment. Generally supportive of having such an option, but going to defer to others on the review. I don't work enough on clang to have an opinion on code here. Comment at: clang/docs/ReleaseNotes.rst:844 take architecture extensions from ``-march`` if both

cfe-commits@lists.llvm.org

dkt01 updated this revision to Diff 491823. dkt01 added a comment. Changes recommended by HazardyKnusperkeks in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/TokenAnnota

[clang] 2b80733 - [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

Author: eopXD Date: 2023-01-24T08:38:10-08:00 New Revision: 2b807336ad385e64a7d182d5fb67bdfe449707a3 URL: https://github.com/llvm/llvm-project/commit/2b807336ad385e64a7d182d5fb67bdfe449707a3 DIFF: https://github.com/llvm/llvm-project/commit/2b807336ad385e64a7d182d5fb67bdfe449707a3.diff LOG: [1

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b807336ad38: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants (authored by eopXD). Changed prior to commit: https://reviews.l

[clang] 43854fa - [clang][deps] Add module files for input dependencies earlier

Author: Ben Langmuir Date: 2023-01-24T08:45:20-08:00 New Revision: 43854fa263d2c96aa9e6c2bc5eafd66ac9727641 URL: https://github.com/llvm/llvm-project/commit/43854fa263d2c96aa9e6c2bc5eafd66ac9727641 DIFF: https://github.com/llvm/llvm-project/commit/43854fa263d2c96aa9e6c2bc5eafd66ac9727641.diff

[PATCH] D142392: [clang][deps] Add module files for input dependencies earlier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43854fa263d2: [clang][deps] Add module files for input dependencies earlier (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder added a comment. I know it hasn't been a week yet, but can someone take a look at this? It would unblock pushing more of the approved patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142328/new/ https://reviews.llvm.org/D142328 ___

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

DavidSpickett added a comment. I was able to reproduce on AArch64 and Arm (32 bit), did not reproduce on an Intel machine which matches what you've seen so far. 62 failures on AArch64, 21 on Arm. Broadly two kinds of failure. Errors of the form `error: reference to 'std' is ambiguous`, which ha

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, yaxunl. Herald added a subscriber: kosarev. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan added a comment. In D140315#4076614 , @mgorny wrote: > I'm sorry for reporting it this late (clang's been broken for over two weeks, > so we couldn't periodically test it) but this change is causing test > regressions on Gentoo/amd64: Thanks for

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. > The way Clang handles this is to mostly go back to the original source code > (through the source manager and source location information) to grab what the > user actually wrote. The pretty printing functionality loses information like > whether something

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

craig.topper updated this revision to Diff 491834. craig.topper added a comment. Address review comment in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142144/new/ https://reviews.llvm.org/D142144 Files: clang/docs/ReleaseNotes.r

[PATCH] D142486: [OpenMP] Unconditionally link the OpenMP device RTL static library

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: c

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. Herald added a subscriber: luke. Please rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailing list cfe-co

[PATCH] D142416: [clang][deps] NFC: Remove dead code

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:180 - // incompatible modules (e.g. with differences in search paths). - CI.getHeaderS

[PATCH] D142396: [AArch64] Add the Ampere1A core

dmgreen added inline comments. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:492 +{"ampere1a", ARMV8_6A, + (AArch64::AEK_FP16 | AArch64::AEK_RAND | AArch64::AEK_SM4 | + AArch64::AEK_SHA3 | AArch64::AEK_SHA2 | AArch64::AEK_AES | Jus

[PATCH] D142490: [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an unevaluated context is not within a CXXRecordDecl or CXXMethodDecl

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. `ClassifyImplicitMemberAccess` assumes that if we are not in a static context then the `DeclContext` must be a `CXXRecordDecl` or a `CXXMethodDec

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 added a comment. Yes, I meant the `pp-trace` docs. Why would "we didn't find the included file" not be a traceable event? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

shafik added a comment. FYI, I was looking at similar issues over the weekend and put up this PR: https://reviews.llvm.org/D142490 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 ___ cfe-commits mai

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich added inline comments. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:492 +{"ampere1a", ARMV8_6A, + (AArch64::AEK_FP16 | AArch64::AEK_RAND | AArch64::AEK_SM4 | + AArch64::AEK_SHA3 | AArch64::AEK_SHA2 | AArch64::AEK_AES |

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

DavidSpickett added a comment. Hi! Comparing the changes for https://lab.llvm.org/buildbot/#/builders/17/builds/33129 and https://lab.llvm.org/buildbot/#/builders/174/builds/17069 I think you've managed to hit a crash in the host compiler we (Linaro) are using for our bots. Which is the 15.0.0

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich updated this revision to Diff 491840. philipp.tomsich added a comment. - untabify on some tabs that slipped in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142396/new/ https://reviews.llvm.org/D142396 Files: clang/test/Misc/targ

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

dyung added a comment. Hi @eopXD this change seems to be causing builds on Windows to time out for some reason. Can you take a look? - https://lab.llvm.org/buildbot/#/builders/83/builds/28484 - https://lab.llvm.org/buildbot/#/builders/172/builds/22803 - https://lab.llvm.org/buildbot/#/builders/2

[clang] 96a54b2 - [clang][deps] Account for transitive spurious dependencies

Author: Jan Svoboda Date: 2023-01-24T09:48:58-08:00 New Revision: 96a54b2258cddcb52f8c98e760b9b114a1aa4034 URL: https://github.com/llvm/llvm-project/commit/96a54b2258cddcb52f8c98e760b9b114a1aa4034 DIFF: https://github.com/llvm/llvm-project/commit/96a54b2258cddcb52f8c98e760b9b114a1aa4034.diff L

[PATCH] D142165: [clang][deps] Account for transitive spurious dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96a54b2258cd: [clang][deps] Account for transitive spurious dependencies (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[clang] beebad9 - [clang][deps] NFC: Remove dead code

Author: Jan Svoboda Date: 2023-01-24T09:49:22-08:00 New Revision: beebad9a9b230d9c491e7e09a892689dc23240aa URL: https://github.com/llvm/llvm-project/commit/beebad9a9b230d9c491e7e09a892689dc23240aa DIFF: https://github.com/llvm/llvm-project/commit/beebad9a9b230d9c491e7e09a892689dc23240aa.diff L

[PATCH] D142416: [clang][deps] NFC: Remove dead code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbeebad9a9b23: [clang][deps] NFC: Remove dead code (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. In D142196#4077708 , @jansvoboda11 wrote: > Yes, I meant the `pp-trace` docs. Why would "we didn't find the included > file" not be a traceable event? My thinking is the following: If the preprocessor cannot find the included

[PATCH] D142491: [OpenMP] Do not link the bitcode OpenMP runtime when targeting AMDGPU.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb, gregrodgers, jplehr. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision

[PATCH] D142491: [OpenMP] Do not link the bitcode OpenMP runtime when targeting AMDGPU.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, not linking in something seems fine if it works and the direction is what we always wanted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

jrtc27 added a comment. Arm and AArch64 are special because they're the architectures where `va_list` is `std::__va_list`, not a bare `__va_list_tag` or similar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D1

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

jrtc27 added a comment. This should be readily reproducible with clang -target aarch64 on any machine, though? The current lit tests are just x86 ones, which isn't great coverage of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/

[PATCH] D142396: [AArch64] Add the Ampere1A core

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK Thanks for the clarification. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142396/new/ https://reviews.llvm.org/D142396 __

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a comment. In D141714#4077631 , @giulianobelinassi wrote: >> The way Clang handles this is to mostly go back to the original source code >> (through the source manager and source location information) to grab what >> the user actual

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

tra added a subscriber: MaskRay. tra added a comment. @MaskRay - we seem to be reinventing the linker here and could use your expertise. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1217-1218 +/// 1) It defines an undefined symbol in a regular object f

[PATCH] D142388: [clang] Add builtin_nondet

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") ManuelJBrito wrote: > ManuelJBrito wrote: > > ManuelJBrito wrote: > > > eri

[PATCH] D142377: Dead links on https://clang.llvm.org/extra/clang-tidy/ #60023

This revision was automatically updated to reflect the committed changes. Closed by commit rG7722731a9a71: Correct some dead links in the clang-tidy docs (authored by s-pratik, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang-tools-extra] 7722731 - Correct some dead links in the clang-tidy docs

Author: Pratik Sharma Date: 2023-01-24T13:23:50-05:00 New Revision: 7722731a9a711f12f60bbf238c97dd07e0b9e7f8 URL: https://github.com/llvm/llvm-project/commit/7722731a9a711f12f60bbf238c97dd07e0b9e7f8 DIFF: https://github.com/llvm/llvm-project/commit/7722731a9a711f12f60bbf238c97dd07e0b9e7f8.diff

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4076851 , @aaron.ballman wrote: > I'd expect there to be a test under `clang/test/Headers/` showing that this > new header works as expected. It's covered pretty well by stddefneeds.cpp already. I can add a new one if y

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 added a comment. In D142484#4077811 , @tra wrote: > @MaskRay - we seem to be reinventing the linker here and could use your > expertise. Yeah, this reinvents a lot of logic. But I don't think there's an easy way to get around this without dupli

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrOne(),

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1217-1218 +/// 1) It defines an undefined symbol in a regular object filie. +/// 2) It defines a global symbol without hidden visibility that has not +/// yet been defined. +Ex

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1217-1218 +/// 1) It defines an undefined symbol in a regular object filie. +/// 2) It defines a global symbol without hidden visibility that has not +/// yet been defined.

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. In D141717#4074842 , @yaxunl wrote: > Can we keep the original behaviour for the old driver for HIP? Only enable > the change for the new driver. That's probably fair because AFAIK that will still use the `clang-offload-bundler

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty added inline comments. Comment at: clang/include/clang/Driver/Options.td:4141 HelpText<"Warn on language extensions">, MarshallingInfoFlag>; +def p : Flag<["-"], "p">, HelpText<"Enable mcount instrumentation with prof">, Flags<[CC1Option]>; def pg : Flag<["-"], "pg

[clang] 4ab2246 - [AMDGPU] Remove dot1 and dot6 features from clang for gfx11

Author: Stanislav Mekhanoshin Date: 2023-01-24T10:52:42-08:00 New Revision: 4ab2246d486ba30c4b2d654323a0c0b97565c0f1 URL: https://github.com/llvm/llvm-project/commit/4ab2246d486ba30c4b2d654323a0c0b97565c0f1 DIFF: https://github.com/llvm/llvm-project/commit/4ab2246d486ba30c4b2d654323a0c0b97565c0

<    1   2   3   4   >