asb added inline comments.
================ Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:1 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --full-function-signature --filter "^define |^entry:" +// RUN: %clang_cc1 -triple riscv32 -target-feature +f -target-abi ilp32f -emit-llvm %s -o - \ ---------------- luismarques wrote: > Assume you updated this test with the not yet committed > `--full-function-signature` option and forgot to remove that before updating > the patch? > Please also check if the newly added `%s` below are supposed to be there. The newly added %s are correct - it was an issue in the earlier patch that didn't impact update_cc_test_checks but did impact lit. I think in order to land this ahead of the update_test_checks I'd remove this line and add perhaps add a FIXME comment to refresh the file once that patch lands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142326/new/ https://reviews.llvm.org/D142326 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
