frasercrmck added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2150
+ Args.MakeArgString("-mvscale-min=" + llvm::Twine(VScaleMin)));
+ } else if (!Val.equals("scalable")) {
+ // Handle the unsupported values passed to mrvv-vector-bits.
----------------
craig.topper wrote:
> frasercrmck wrote:
> > Is this check right? I don't see mention of "scalable" in the commit
> > description. Should this be a plain `else`?
> "scalable" allows you to cancel the option appearing earlier on the command
> line. Similar to why most bool options have a "no-" version. It's let you do
> thing like append to CFLAGS to override a global setting in a make file.
Makes sense, thanks. I'm happy to include it as an option value, now that it's
documented.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142144/new/
https://reviews.llvm.org/D142144
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
