[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:418-419 + this->emitLabel(IncLabel); + if (Inc && !this->discard(Inc)) +return false; + if (!this->jump(CondLabel)) aaron.ballman

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 491644. iana added a comment. Fix the broken tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files: clang-tools-extra/clang-include-fixer/find-all-symbols/STLPos

[clang] 01eb01c - [clang][Lex] Add back PPCallbacks::FileNotFound

Author: Jonas Hahnfeld Date: 2023-01-24T09:52:27+01:00 New Revision: 01eb01c7fd7ad6f569ad4d7bf65b5327ac111955 URL: https://github.com/llvm/llvm-project/commit/01eb01c7fd7ad6f569ad4d7bf65b5327ac111955 DIFF: https://github.com/llvm/llvm-project/commit/01eb01c7fd7ad6f569ad4d7bf65b5327ac111955.diff

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Hahnfeld marked an inline comment as done. Closed by commit rG01eb01c7fd7a: [clang][Lex] Add back PPCallbacks::FileNotFound (authored by Hahnfeld). Repository: rG LL

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I checked a second time and couldn't find other API docs. I've now pushed this change for now (also to get it included in `release/16.x`), but please let me know for any follow-ups. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/loops.cpp:278 + +namespace RangeForLoop { + constexpr int localArray() { aaron.ballman wrote: > You should also add failure tests where the range-based for

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime created this revision. lime added reviewers: aaron.ballman, erichkeane, cor3ntin, clang-language-wg. lime added a project: clang. Herald added a subscriber: yaxunl. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. D137531

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:100 SYMBOL(atoll, std::, ) +SYMBOL(atomic, std::, ) +SYMBOL(atomic, std::, ) VitaNuo wrote: > kadircet wrote: > > hokein wrote: > > > Conceptually, this (and other

[clang] ecbf5db - [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

Author: eopXD Date: 2023-01-24T01:08:58-08:00 New Revision: ecbf5db88d285f72fbd0126be9c20f790d603b23 URL: https://github.com/llvm/llvm-project/commit/ecbf5db88d285f72fbd0126be9c20f790d603b23 DIFF: https://github.com/llvm/llvm-project/commit/ecbf5db88d285f72fbd0126be9c20f790d603b23.diff LOG: [6

[PATCH] D141756: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecbf5db88d28: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is… (authored by eopXD). Changed prior to commit: https://re

[clang] 2a16e1f - [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

Author: eopXD Date: 2023-01-24T01:20:55-08:00 New Revision: 2a16e1ff7d2735001dbe40e607823857f4bedd0e URL: https://github.com/llvm/llvm-project/commit/2a16e1ff7d2735001dbe40e607823857f4bedd0e DIFF: https://github.com/llvm/llvm-project/commit/2a16e1ff7d2735001dbe40e607823857f4bedd0e.diff LOG: [7

[PATCH] D141759: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a16e1ff7d27: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU (authored by eopXD). Changed prior to commit: https://reviews

[PATCH] D142439: Fix C++11 warnings in RangeSetTest.cpp

philipp.tomsich created this revision. Herald added a subscriber: steakhal. Herald added a project: All. philipp.tomsich requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes the following warnings: llvm/clang/unittests/St

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

DavidSpickett added a comment. Hi folks, I'm one of the owners of the AArch64 bot you're seeing the failure on. I will try to reproduce it myself and see if I can find what's going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ http

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

KKoovalsky added a comment. @nridge I have fixed the issues. Thank you for supporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140619/new/ https://reviews.llvm.org/D140619 ___ cfe-commits mailing l

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 491661. usaxena95 edited the summary of this revision. usaxena95 added a comment. Use `getDefinition` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 Files: clang

[PATCH] D141194: [clang][Interp] Implement bitcasts

tbaeder added a comment. Note that this "implementation" is based on my knowledge about what bitcasts are, so no idea. Is that documented anywhere or should I check `ExprConstant.cpp`, //or// is this implementation fine for the time being (IIRC this was needed to make a stdlib header work)? R

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1417-1418 + assert(!BD->getHoldingVar()); // FIXME + if (!this->allocateVariable(BD, BD->getBinding())) +return false; +} aaron.ballman wrote: > Is this corr

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.py to match return type as well as args

luismarques added a comment. Do we actually want to include the `dso_local` in the full signature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142373/new/ https://reviews.llvm.org/D142373 ___ cfe-commi

[PATCH] D142440: [clangd] Don't show 'auto' type hint when type deduction fails

nridge created this revision. nridge added reviewers: sammccall, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes htt

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] d595b59 - [FPEnv] Fix complex operations in strictfp mode

Author: Serge Pavlov Date: 2023-01-24T16:40:11+07:00 New Revision: d595b59d5c9c8e56c3b3d142912ee16a02071690 URL: https://github.com/llvm/llvm-project/commit/d595b59d5c9c8e56c3b3d142912ee16a02071690 DIFF: https://github.com/llvm/llvm-project/commit/d595b59d5c9c8e56c3b3d142912ee16a02071690.diff

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd595b59d5c9c: [FPEnv] Fix complex operations in strictfp mode (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.py to match return type as well as args

asb added a comment. In D142373#4076198 , @luismarques wrote: > Do we actually want to include the `dso_local` in the full signature? That's a fair question. I could imagine it's useful to include these attributes in some test scenarios and not in othe

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke updated this revision to Diff 491667. luke added a comment. Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142199/new/ https://reviews.llvm.org/D142199 Files: .github/workflows/release-tasks.yml clang/docs/conf.py fl

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke added a comment. In D142199#4073815 , @tstellar wrote: > LGTM. Can you add something to the release notes about this. Done. Do any build machines need to be upgraded before this is landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

kiranchandramohan added a comment. The flang website (flang.llvm.org) or flang.llvm.org/docs are built from these. Would you know whether there are changes required are there? https://github.com/llvm/llvm-zorg/blob/main/zorg/buildbot/builders/SphinxDocsBuilder.py Repository: rG LLVM Github M

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke added a comment. In D142199#4076287 , @kiranchandramohan wrote: > The flang website (flang.llvm.org) or flang.llvm.org/docs are built from > these. Would you know whether there are changes required are there? > https://github.com/llvm/llvm-zorg/bl

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

tbaeder updated this revision to Diff 491674. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140803/new/ https://reviews.llvm.org/D140803 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h clang/test/AST/Interp/loops.cpp Index: clang/test/AST/Int

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

dmgreen added reviewers: lenary, tmatheson, pratlucas. dmgreen added a comment. I believe this is correct, according to at least one reference I have. FEAT_SSBS isn't spelled out very clearly in the reference manual though. Adding some more people who might be able to check. Repository: rG L

[PATCH] D142396: [AArch64] Add the Ampere1A core

dmgreen added a comment. Sounds OK, but do you mind splitting FeatureFuseAddSub2RegAndConstOne into a separate patch. They seem to be logically separable, and it can help in case there are problems found in one of the patches. Comment at: llvm/include/llvm/TargetParser/AArch6

[PATCH] D141762: [8/15][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1c6ec1041f: [8/15][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc (authored by eopXD). Repository: rG LLVM Github Mono

[clang] 5a1c6ec - [8/15][Clang][RISCV][NFC] Always emit PolicyAttr in riscv_vector_builtin_cg.inc

Author: eopXD Date: 2023-01-24T02:25:25-08:00 New Revision: 5a1c6ec1041f19806f3e94c3cb750b9072087c14 URL: https://github.com/llvm/llvm-project/commit/5a1c6ec1041f19806f3e94c3cb750b9072087c14 DIFF: https://github.com/llvm/llvm-project/commit/5a1c6ec1041f19806f3e94c3cb750b9072087c14.diff LOG: [8

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:597 + assert(CV.size() > 0 && "Uncolored block"); + for (BasicBlock *EHPadBB : CV) +if (auto *EHPad = dyn_cast(EHPadBB->getFirstN

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

lenary added a comment. SSBS is not mandatory from v8.5a onwards. More details/citation inline. NB: This will need a rebase, because @dmgreen changed how crypto is handled in these bitmaps yesterday. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:311 inline

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

philipp.tomsich added a comment. When looking at "ARM DDI 0487G.a", on page A2-68 under the heading "Additional functionality added to Armv8.0 in later releases" in the definition-list item "FEAT_SSBS, Speculative Store Bypass Safe": > This feature is OPTIONAL in Armv8.0 implementations and man

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

lenary added a comment. In D142410#4076389 , @philipp.tomsich wrote: > When looking at "ARM DDI 0487G.a", on page A2-68 under the heading > "Additional functionality added to Armv8.0 in later releases" in the > definition-list item "FEAT_SSBS, Speculat

[PATCH] D142448: [clang][Interp] Handle TypeTraitExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only light testing here, since the value we're emit

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.py to match return type as well as args

luismarques added a comment. I'm probably not the best person to review this but, for what it's worth, it LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142373/new/ https://reviews.llvm.org/D142373 ___

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

mgorny created this revision. mgorny added reviewers: rupprecht, tstellar, MaskRay, thesamesam. Herald added a project: All. mgorny requested review of this revision. The LLVMTestingAnnotations library that is now used by unittests is not installed as part of LLVM. In order to make it possible to

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142449/new/ https://reviews.llvm.org/D142449 ___ cfe-commits mailing list cfe-

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. Ping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

mgorny added a comment. Thanks for the superfast review! I'll push it later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142449/new/ https://reviews.llvm.org/D142449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D142454: [analyzer] Update satest dependencies

manas created this revision. manas added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. manas requested review of this revisi

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491707. pmatos added a comment. Further tests for use of tables in conditional branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/A

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.py to match return type as well as args

nikic added a comment. Please give me a day to propose another alternative... Seeing D142452 we now have three different patches that would like to change UTC output, so I really think we need that `--version` flag. Repository: rG LLVM Github Monorepo CHA

[PATCH] D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast

bam added a comment. I'm sorry but I'm not familiar with the codebase, so I can't help, unfortunately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24888/new/ https://reviews.llvm.org/D24888 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1915-1916 + +if (const CXXDestructorDecl *Dtor = ElemRecord->getDestructor(); +Dtor && !Dtor->isTrivial()) { + for (size_t I = 0, E = Des

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder updated this revision to Diff 491709. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/

[PATCH] D140315: [AMDGCN] Update search path for device libraries

er/Inputs/rocm_resource_dir/include" "-internal-isystem" "/usr/local/include" "-internal-isystem" "/usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/include" "-internal-externc-isystem" "/include" "-internal-

[clang] 0f8b995 - [clang] Fix linking to LLVMTestingAnnotations in standalone build

Author: Michał Górny Date: 2023-01-24T13:21:24+01:00 New Revision: 0f8b995b63620c3eb57610f958f66691d38d7185 URL: https://github.com/llvm/llvm-project/commit/0f8b995b63620c3eb57610f958f66691d38d7185 DIFF: https://github.com/llvm/llvm-project/commit/0f8b995b63620c3eb57610f958f66691d38d7185.diff

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f8b995b6362: [clang] Fix linking to LLVMTestingAnnotations in standalone build (authored by mgorny). Herald added a project: clang. Repository: r

[PATCH] D142439: Fix C++11 warnings in RangeSetTest.cpp

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'm not that confident around gtest macros, but this doesn't look harmful. Thanks for taking the time and fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks good. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.py to match return type as well as args

asb added a comment. In D142373#4076584 , @nikic wrote: > Please give me a day to propose another alternative... Seeing D142452 > we now have three different patches that > would like to change UTC output, so I really

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 491718. ckandeler marked an inline comment as done. ckandeler added a comment. Added test cases from review comment and made them pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://review

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added a comment. Thanks for the test cases! All fixed, except: > // variable template specialization > // parameter and argument lists are missing semantic tokens > template <> > constexpr int V = 5; Argument list fixed. I didn't manage to make the parameter list work. Repository:

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 491717. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

carlosgalvezp added a comment. LGTM, really useful check! Would be nice to get some more eyes on the implementation, it's fairly advanced for my basic AST knowledge. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.or

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This remove the last uses of GlobalObject::getAlignment and marks

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:106 -SYMBOL(atomic_exchange_explicit, std::, ) -SYMBOL(atomic_fetch_add, std::, ) -SYMBOL(atomic_fetch_add_explicit, std::, ) Looks like the regex filters too many s

[clang] 16cea04 - Fix the Clang sphinx build

Author: Aaron Ballman Date: 2023-01-24T08:21:53-05:00 New Revision: 16cea040d032deb1dae5538db0937888c02fc7f4 URL: https://github.com/llvm/llvm-project/commit/16cea040d032deb1dae5538db0937888c02fc7f4 DIFF: https://github.com/llvm/llvm-project/commit/16cea040d032deb1dae5538db0937888c02fc7f4.diff

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 491728. carlosgalvezp added a comment. Add HeaderFileExtensions and ImplementationFileExtensions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 491729. carlosgalvezp added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files: clang-tools-extra/clang-tidy/tool/ClangTidyMain.c

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 491731. carlosgalvezp edited the summary of this revision. carlosgalvezp added a comment. Remove newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 Files:

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp added a comment. Friendly ping @njames93 , see my previous comment about `TrimFirstChar`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D141144 ___ cfe-

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:13 + +#include + Not sure if this is allowed in the repo or if we should use something equivalent from ADT.

[PATCH] D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix

kito-cheng accepted this revision. kito-cheng added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142016/new/ https://reviews.llvm.org/D142016 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit, otherwise I don't have concerns. Comment at: clang/lib/Sema/SemaExpr.cpp:2717 +if ((MightBeImplicitMember = ThisClass->Equals(Class) || +

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140598/new/ https://reviews.llvm.org/D140598 ___ cfe-commits mailing lis

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich updated this revision to Diff 491738. philipp.tomsich added a comment. - Split off new (Ampere1A-specific) fusion case - Updated the Ampere1A SubtargetFeature list to include (hopefully) all features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

courbet added inline comments. Comment at: clang/include/clang/AST/CharUnits.h:73 + /// fromQuantity - Construct a CharUnits quantity from an llvm::Align + /// quantity. `Maybe`* Comment at: clang/lib/CodeGen/CGObjCMac.cpp:1991 +

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

kito-cheng added a comment. > I don't have a preference here, is any of __riscv_RVV_CSR/ > __riscv_rvv_csr_type / __riscv_rvv_csr_t suitable? Either is fine to me at this stage, I expect they will be drop soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

kito-cheng added a comment. Agree with @jrtc27 about the test function name, we could keep the function name in the test file, that's also reduce lots of diff which is not really necessary. e.g. `vint8mf8_t test_vaadd_vv_i8mf8(vint8mf8_t op1, vint8mf8_t op2, size_t vl)` keep same name rather t

[PATCH] D140250: Define NULL in its own header

aaron.ballman added subscribers: echristo, dblaikie, aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I'd expect there to be a test under `clang/test/Headers/` showing that this new header works as expected. Comment at: llvm/test/De

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

kito-cheng added a comment. As a RISC-V GCC maintainer: GCC 14 is targeting on RVV intrinsic 1.0, but segment load store and rounding mode stuff might not meet the release, so the status will be pretty close to clang/LLVM (with @eopXD's changes, `__riscv_` prefix and those simplification stuffs

[PATCH] D142454: [analyzer] Update satest dependencies

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'm not using this docker file, so I don't mind changing it. It probably won't hurt :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142454/n

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang. Herald added subscribers: carlosgalvezp, shchenz, kbarton, nemanjai. Herald adde

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 491747. KyleFromKitware retitled this revision from "[pp-trace] Print HashLoc parameter" to "[pp-trace] Print HashLoc/Introducer parameter". KyleFromKitware added a comment. Printed Introducer parameter in Pragma methods. CHANGES SINCE LAST ACTION

[clang] d9eece9 - [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

Author: Stefan Gränitz Date: 2023-01-24T15:17:18+01:00 New Revision: d9eece916a8a9b370e1f90e6461c612d12c55729 URL: https://github.com/llvm/llvm-project/commit/d9eece916a8a9b370e1f90e6461c612d12c55729 DIFF: https://github.com/llvm/llvm-project/commit/d9eece916a8a9b370e1f90e6461c612d12c55729.diff

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgraenitz marked an inline comment as done. Closed by commit rGd9eece916a8a: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet… (authored

[clang] e0a2818 - [clang][RISCV] Fix ABI mismatch between GCC and Clang (extension of integers on stack)

Author: Alex Bradbury Date: 2023-01-24T14:20:28Z New Revision: e0a28188d2b53427bc90cdf7f7899c64af102489 URL: https://github.com/llvm/llvm-project/commit/e0a28188d2b53427bc90cdf7f7899c64af102489 DIFF: https://github.com/llvm/llvm-project/commit/e0a28188d2b53427bc90cdf7f7899c64af102489.diff LOG:

[PATCH] D140401: [clang][RISCV] Fix ABI mismatch between GCC and Clang (extension of integers on stack)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0a28188d2b5: [clang][RISCV] Fix ABI mismatch between GCC and Clang (extension of integers on… (authored by asb). Herald added a project: clang. Hera

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski accepted this revision. awarzynski added a comment. Thanks for the updates, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 ___ cfe-commits mai

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar added a subscriber: gkistanova. tstellar added a comment. @luke You'll need to contact the bot owners so they can update machine. The workers running the publish-sphinx-docs will need to be updated too. @gkistanova should be able to help. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

dang added a comment. LGTM for the ExtractAPI changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141961/new/ https://reviews.llvm.org/D141961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D142467: [Tooling] Add stdlib::Symbol::all() and stdlib::Symbol::qualified_name()

sammccall created this revision. sammccall added a reviewer: VitaNuo. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These address some remaining reasons to #include StdSymbolMap.inc directly. Repos

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- -- -fno-delayed-template-pa

[PATCH] D142468: [clang][dataflow] Fix bug in handling of reference-typed fields.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch fixes a subtle bug in

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: Al

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") erichkeane wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > shaf

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: kbarton, nemanjai. Herald adde

[PATCH] D142388: [clang] Add builtin_nondet

erichkeane added inline comments. Comment at: clang/test/CodeGen/builtins-nondet.c:3 + +typedef float float4 __attribute__((ext_vector_type(4))); + ManuelJBrito wrote: > shafik wrote: > > erichkeane wrote: > > > Add some examples for 'bool' and vector-bool as wel

[PATCH] D142467: [Tooling] Add stdlib::Symbol::all() and stdlib::Symbol::qualified_name()

sammccall updated this revision to Diff 491766. sammccall added a comment. oops, helps if I run tests on the right branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142467/new/ https://reviews.llvm.org/D142467 Files: clang/include/clang/Tooli

[clang] 1ab7e76 - [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

Author: eopXD Date: 2023-01-24T07:03:33-08:00 New Revision: 1ab7e76887e3c6ff1ca82b3970a0aae71895d848 URL: https://github.com/llvm/llvm-project/commit/1ab7e76887e3c6ff1ca82b3970a0aae71895d848 DIFF: https://github.com/llvm/llvm-project/commit/1ab7e76887e3c6ff1ca82b3970a0aae71895d848.diff LOG: [9

[PATCH] D141764: [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ab7e76887e3: [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes`… (authored by eopXD). Repository: rG LLVM Github Monorep

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito updated this revision to Diff 491767. ManuelJBrito added a comment. Add tests with bool and bool-vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/test/CodeGen/builtins-no

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware updated this revision to Diff 491772. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142465/new/ https://reviews.llvm.org/D142465 Files: clang-tools-extra/clang-tidy/Ex

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 491774. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace

  1   2   3   4   >