dmgreen added a comment.

Sounds OK, but do you mind splitting FeatureFuseAddSub2RegAndConstOne into a 
separate patch. They seem to be logically separable, and it can help in case 
there are problems found in one of the patches.



================
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:476
+    {"ampere1a", ARMV8_6A,
+     (AArch64::AEK_FP16 | AArch64::AEK_RAND | AArch64::AEK_SM4 | 
AArch64::AEK_SHA3 |
+      AArch64::AEK_SHA2 | AArch64::AEK_AES  | AArch64::AEK_MTE |
----------------
Can you clang-format the patch, otherwise lines get a little longer than they 
should be for llvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142396/new/

https://reviews.llvm.org/D142396

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to