courbet added inline comments.
================ Comment at: clang/include/clang/AST/CharUnits.h:73 + /// fromQuantity - Construct a CharUnits quantity from an llvm::Align + /// quantity. ---------------- `Maybe`* ================ Comment at: clang/lib/CodeGen/CGObjCMac.cpp:1991 + return ConstantAddress(C, C->getValueType(), + CharUnits::fromQuantity(C->getAlign())); ---------------- I'm wondering whetehr we could just do away with this conversion and store a `MaybeAlign` in `GlobalValue` instead. The only uses of `Address::getAlign()` is to creata another `Address` or do `Address::getAlign()->getAsAlign()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142459/new/ https://reviews.llvm.org/D142459 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
