[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto l

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein added a comment. oops, sorry for the trouble it caused, and thanks for @kadircet fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140875/new/ https://reviews.llvm.org/D140875 ___ cfe-commi

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. > How does this affect LTO? More detailed answer. We work with bitcode files only when use `lto`. If we don't use `lto` clang produces `.o` file that are already contains target information. We don't work with function attributes to get subtarget without lto. Rep

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

nridge added a comment. In D140619#4058232 , @KKoovalsky wrote: > Hey! I can see that the build: > https://reviews.llvm.org/harbormaster/build/311598/ failed, but I am not sure > whether this is related to my change. Could someone take a look? I can r

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

nridge added a comment. By the way, I also got linker errors when trying to build this patch in a shared-libs build. Resolved by adding `clangASTMatchers` to `clang_target_link_libraries` in `clang-tools-extra/clangd/tool/CMakeLists.txt`. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

nridge added a comment. In D140619#4067940 , @nridge wrote: > I can reproduce the failures locally with the patch applied. (The failures seem to have to do with `ExtractFunction` segfaulting when invoked at a particular location in the code in `check.te

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. In D139705#4067774 , @lattner wrote: > Got it this time, sorry for the confusion! Confirmed that I received the invitation. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] e74f9e7 - [include-mapping] Parse zombie_names.html into a removed symbols map.

Author: Viktoriia Bakalova Date: 2023-01-20T08:53:31Z New Revision: e74f9e7885078e7c847b2672a70b6743731aa53a URL: https://github.com/llvm/llvm-project/commit/e74f9e7885078e7c847b2672a70b6743731aa53a DIFF: https://github.com/llvm/llvm-project/commit/e74f9e7885078e7c847b2672a70b6743731aa53a.diff

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe74f9e788507: [include-mapping] Parse zombie_names.html into a removed symbols map. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CH

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet created this revision. kadircet added reviewers: hokein, cor3ntin, aaron.ballman. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was regressed in ca619613801233ef2def8c3cc7d311d5ed0033cb

[clang] b7894eb - [clang][Interp] Initialize remaining InlineDescriptor fields

Author: Timm Bäder Date: 2023-01-20T10:04:16+01:00 New Revision: b7894ebf8439c0141614fbb8bfc1a27a0a67e946 URL: https://github.com/llvm/llvm-project/commit/b7894ebf8439c0141614fbb8bfc1a27a0a67e946 DIFF: https://github.com/llvm/llvm-project/commit/b7894ebf8439c0141614fbb8bfc1a27a0a67e946.diff LO

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

This revision was automatically updated to reflect the committed changes. Closed by commit rGea4fd668c2cd: [clang] fix crash on generic lambda with lambda in decltype (authored by v1nh1shungry). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140838/ne

[clang] ea4fd66 - [clang] fix crash on generic lambda with lambda in decltype

Author: v1nh1shungry Date: 2023-01-20T17:11:07+08:00 New Revision: ea4fd668c2cd88d13b36a5d64e3dedb1106340bc URL: https://github.com/llvm/llvm-project/commit/ea4fd668c2cd88d13b36a5d64e3dedb1106340bc DIFF: https://github.com/llvm/llvm-project/commit/ea4fd668c2cd88d13b36a5d64e3dedb1106340bc.diff

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. I've created one more patch connected with lto https://reviews.llvm.org/D142191 and it also uses attributes of functions as the way to get right TargetMachine in linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D142187: [clang] Fix typos in member initializers

ilya-biryukov added a comment. Randomly chiming in here. I never had a good model of where `CorrectDelayedTyposInExpr`, but wanted to note that `ActOnFullExpr` also calls it. This may be fine, I just wanted to mention it as it stood out. Comment at: clang/lib/Sema/SemaDeclCXX

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. One idea discussed in comments to the KDevelop merge request, which I haven't mentioned here is this: remove the preamble files immediately after creating and opening them. This is safe on Unix-like OSes, because every file that is still open will not actually be deleted

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added a comment. Friendly ping! BTW, I'm planning on future changes to designated initializers. This is the first step. I hope to get rid of the template stuff in the followup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https:

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld created this revision. Hahnfeld added reviewers: jansvoboda11, ahoppen. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This callback was r

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

Hahnfeld added a comment. In D119708#4062632 , @jansvoboda11 wrote: > If the plan is to eventually upstream that part of Cling, I'm fine with > re-adding a safe version of this API. I'll be honest here and say that I personally find it unlikely that th

cfe-commits@lists.llvm.org

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2544 SmallVector Contexts; + static SmallVector Scopes; dkt01 wrote: > HazardyKnusperkeks wrote: > > Why static? > The AnnotatingParser object lifetime is too short to

[PATCH] D141811: [clang-format] Allow trailing return types in macros

HazardyKnusperkeks added a comment. In D141811#4064428 , @rymiel wrote: > In D141811#4055485 , > @HazardyKnusperkeks wrote: > >> What about `decltype(auto)`? > > Turns out this is a problem even without this patc

[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. The task-clock improvement is likely noise, but there's definitely a code size / max-rss win here. Comment at: clang/include/clang/Basic/BuiltinHeaders.def:9 +// +// Thi

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. A constraint is that the user should be able to choose the library with a single list of arguments, as displayed with `-print-multi-lib`. Therefore I'm sceptical about making the selection mechanism too expressive, because `-print-multi-lib` can't explain that t

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:52 + AArch64::AEK_RDM | AArch64::AEK_RCPC | AArch64::AEK_DOTPROD | + AArch64::AEK_SM4 | AArch64::AEK_SHA3 | AArch64::AEK_BF16| + AArch64::AEK_SH

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 2 inline comments as done. TIFitis added a comment. I'm planning on merging the patch early next week. If you'd like to see any changes or need more time to review, please let me know :) Akash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

svenvh added a comment. In D142033#4062671 , @bader wrote: > Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to > validate function attributes other than `convergent`? It's not obvious that > presence of `nounwind` attribute is

[clang] 1495210 - [OpenCL] Always add nounwind attribute for OpenCL

Author: Sven van Haastregt Date: 2023-01-20T12:01:22Z New Revision: 1495210914997bcd0ca6937be0ae3cd6809b5ef5 URL: https://github.com/llvm/llvm-project/commit/1495210914997bcd0ca6937be0ae3cd6809b5ef5 DIFF: https://github.com/llvm/llvm-project/commit/1495210914997bcd0ca6937be0ae3cd6809b5ef5.diff

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG149521091499: [OpenCL] Always add nounwind attribute for OpenCL (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke created this revision. luke added reviewers: kuhnel, Shivamgupta1234, mehdi_amini. Herald added subscribers: kosarev, pmatos, kerbowa, arphaman, jvesely. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. luke requested review of this revision. Herald added subscribers: llv

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke added inline comments. Comment at: flang/docs/DiagnosticsReference.md:1 +% This file intentionally left blank. Silences a warning about a missing reference from the automatically generated FlangCommandLineReference.rst This is pretty hairy and it will link

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D78028: move shebangs from python2 to python3

RKSimon added a comment. @LocutusOfBorg - a grep of llvm-project *.py files is not finding many matches for python2 - I'm assuming this was handled (e.g. update_cc_test_checks.py was updated in D129590 ). There might still be a few missed cases (or references t

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886 ___

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman added a comment. In D139705#4067774 , @lattner wrote: > Got it this time, sorry for the confusion! Thank you for the help, Chris! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ ht

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

clementval added a comment. Just small nit Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:628-629 +int64_t mapTypeBits = 0x00; +auto mapOp = map_operands[i]; +auto mapTypeOp = map_types[i]; + auto should be spelled out here. Repository:

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I just checked and this "simplified" version of the callback would give us enough information to implement all we need in ROOT (plus some, the `bool` return value is nicer than temporarily playing with `SuppressIncludeNotFoundError`). For an upstream test, I could impl

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto &Spelling : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variet

[PATCH] D142187: [clang] Fix typos in member initializers

hokein added a comment. In D142187#4068092 , @ilya-biryukov wrote: > Randomly chiming in here. > I never had a good model of where `CorrectDelayedTyposInExpr`, but wanted to > note that `ActOnFullExpr` also calls it. This may be fine, I just wanted to

[PATCH] D142187: [clang] Fix typos in member initializers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4103 + /*RecoverUncorrectedTypos=*/true); + if (!FD->getType()->isDependentType() && !Init.get()->isTypeDependent()) { +Init = ConvertMemberDefaultIn

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar added inline comments. Herald added a subscriber: asb. Comment at: flang/docs/ComplexOperations.md:37 **FIR** -```c func.func @_QPpow_self(%arg0: !fir.ref>) -> !fir.complex<4> { Do these changes have any affected on the output html? Is there another w

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4101 - ExprResult Init = InitExpr; - if (!FD->getType()->isDependentType() && !InitExpr->isTypeDependent()) { -Init = ConvertMemberDefaultInitExpression(F

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet updated this revision to Diff 490793. kadircet marked 3 inline comments as done. kadircet added a comment. assert on usability of initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142187/new/ https://reviews.llvm.org/D142187 Files

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added a comment. since we modify the python script, could you please update its artifacts (`StdSymbolMap.inc`, `CSymbolMap`) as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 __

[PATCH] D142187: [clang] Fix typos in member initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142187/new/ https://reviews.llvm.org/D142187

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke added inline comments. Comment at: flang/docs/ComplexOperations.md:37 **FIR** -```c func.func @_QPpow_self(%arg0: !fir.ref>) -> !fir.complex<4> { tstellar wrote: > Do these changes have any affected on the output html? Is there another way > to specify t

[PATCH] D142001: [clang] Use FP options from AST for emitting code for casts

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142001/new/ https://reviews.llvm.org/D142001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] 58751f9 - [clang-format] SortUsingDeclarations support lexicographic order

Author: Backl1ght Date: 2023-01-20T21:34:57+08:00 New Revision: 58751f943f2f6dd78dd3363fc70ea1728044ee0b URL: https://github.com/llvm/llvm-project/commit/58751f943f2f6dd78dd3363fc70ea1728044ee0b DIFF: https://github.com/llvm/llvm-project/commit/58751f943f2f6dd78dd3363fc70ea1728044ee0b.diff LOG

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58751f943f2f: [clang-format] SortUsingDeclarations support lexicographic order (authored by Backl1ght). Repository: rG LLVM Github Monorepo CHANG

[clang] 65cf77d - [clang] Use FP options from AST for emitting code for casts

Author: Serge Pavlov Date: 2023-01-20T20:47:43+07:00 New Revision: 65cf77d218cf8b6aee2dbe252f55120311c8 URL: https://github.com/llvm/llvm-project/commit/65cf77d218cf8b6aee2dbe252f55120311c8 DIFF: https://github.com/llvm/llvm-project/commit/65cf77d218cf8b6aee2dbe252f55120311c8.diff

[PATCH] D142001: [clang] Use FP options from AST for emitting code for casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65cf77d218cf: [clang] Use FP options from AST for emitting code for casts (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added a comment. The code changes look good to me, the only real question I have left is whether this will be enabled by enough folks to be worth adding a default-off diagnostic. My intuition is that this is useful functionality for the folks who use `-icf=all` and when I look aro

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 490801. tblah added a comment. Update to ensure that generated code for Options.td does not try to reference clang::CodegenOpts::StackArrays. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://revi

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille updated this revision to Diff 490804. serge-sans-paille added a comment. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang-tools-extra. Fix build + make StringLiteral initialization constexpr. CHANGES SINCE LAST ACTION https://reviews.ll

[clang] ebd9a24 - [clang] Fix typos in member initializers

Author: Kadir Cetinkaya Date: 2023-01-20T15:20:31+01:00 New Revision: ebd9a2477e69ed35b83256ae93cc7e069f5a37c4 URL: https://github.com/llvm/llvm-project/commit/ebd9a2477e69ed35b83256ae93cc7e069f5a37c4 DIFF: https://github.com/llvm/llvm-project/commit/ebd9a2477e69ed35b83256ae93cc7e069f5a37c4.dif

[PATCH] D142187: [clang] Fix typos in member initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebd9a2477e69: [clang] Fix typos in member initializers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D142027: [Assignment Tracking][NFC] Replace LLVM command line option with a new module flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Orlando marked an inline comment as done. Closed by commit rG4ece50737d53: [Assignment Tracking][NFC] Replace LLVM command line option with a module flag (authored by O

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 490810. tblah added a comment. Fix newly added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files: clang/docs/tools/clang-formatted-files.txt flang/include

[clang] 0a996c8 - [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag

Author: OCHyams Date: 2023-01-20T14:36:16Z New Revision: 0a996c82a75f330f3d01541381569c8cd2cd6190 URL: https://github.com/llvm/llvm-project/commit/0a996c82a75f330f3d01541381569c8cd2cd6190 DIFF: https://github.com/llvm/llvm-project/commit/0a996c82a75f330f3d01541381569c8cd2cd6190.diff LOG: [Assi

[PATCH] D142029: [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a996c82a75f: [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag (authored by Orlando). Herald added a project: clang. Herald adde

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king added a comment. Thanks rsmith! Since I do not have commit privileges, can you land this for me, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141441/new/ https://reviews.llvm.org/D141441

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 490824. VitaNuo added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add re-generated symbol maps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Added the re-generated symbol maps to this patch as per @hokein's request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 ___ cfe-comm

[clang] 75fbb5d - [clang][nfc] refactor Module::Header to use OptionalFileEntryRef

Author: Richard Howell Date: 2023-01-20T07:23:11-08:00 New Revision: 75fbb5d2238f1824f03d205b699061a115d5effc URL: https://github.com/llvm/llvm-project/commit/75fbb5d2238f1824f03d205b699061a115d5effc DIFF: https://github.com/llvm/llvm-project/commit/75fbb5d2238f1824f03d205b699061a115d5effc.diff

[PATCH] D142113: [clang][nfc] refactor Module::Header to use OptionalFileEntryRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75fbb5d2238f: [clang][nfc] refactor Module::Header to use OptionalFileEntryRef (authored by rmaz). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4066920 , @dblaikie wrote: > Don't let me hold this up - I think it all feels a bit too ad-hoc for my own > preferences (feels like there should be fairly general solutions to this - > rather than playing whack-

[PATCH] D139774: [libclang] Add API to set temporary directory location

erichkeane added inline comments. Comment at: llvm/lib/Support/Unix/Path.inc:1450 void system_temp_directory(bool ErasedOnReboot, SmallVectorImpl &Result) { Result.clear(); So I was asked to take a look at this, and I believe that changing this function i

[PATCH] D142187: [clang] Fix typos in member initializers

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4101 - ExprResult Init = InitExpr; - if (!FD->getType()->isDependentType() && !InitExpr->isTypeDependent()) { -Init = ConvertMemberDefaultInitExpression(FD, InitExpr, InitLoc); + ExprResult I

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. Is LLVMTargetParser a library In D141581#4057177 , @fpetrogalli wrote: > In D141581#4056825 , @barannikov88 > wrote: > >> clangBasic and clangDriver already have a dependency on Target

[PATCH] D140805: [clang][Interp] Add ArrayElemPtr{,Pop} opcode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140805/new/ https://reviews.llvm.org/D140805

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. So, what's the actual dependency here? Do libBasic and libDriver just need the header to be generated or does it actually need to link to the library? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://rev

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069053 , @tstellar wrote: > [...] > It's still not clear to me why LLVM_LINK_COMPONENTS does not work. Is > LLVMTargetParser a library? Yes, `LLVMTargetParser` is a library built located in `llvm/lib/TargetParse

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069078 , @tstellar wrote: > So, what's the actual dependency here? Do libBasic and libDriver just need > the header to be generated or does it actually need to link to the library? Just the header. Repository:

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

nikic added a comment. FAILED: tools/mlir/test/lib/Dialect/Linalg/CMakeFiles/MLIRLinalgTestPasses.dir/TestLinalgHoisting.cpp.o CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1 -DMLIR_INCLUDE_TESTS -DMLI

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to remove the erroneous lax vector conversion warning for CStyl

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I don't think this is the correct way to specify dependencies if it's just an issue of the header being included before a generated file it needs has been generated. Are there other places in the code where a generated header file is included by another header? Repo

cfe-commits@lists.llvm.org

dkt01 marked an inline comment as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2544 SmallVector Contexts; + static SmallVector Scopes; HazardyKnusperkeks wrote: > dkt01 wrote: > > HazardyKnusperkeks wrote: > > > Why sta

cfe-commits@lists.llvm.org

dkt01 updated this revision to Diff 490859. dkt01 added a comment. Changes as suggested by HazardyKnusperkeks in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/TokenAnnot

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069123 , @tstellar wrote: > I don't think this is the correct way to specify dependencies if it's just an > issue of the header being included before a generated file it needs has been > generated. Are there oth

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

vsapsai added a comment. Thanks for the review, Bruno! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124286/new/ https://reviews.llvm.org/D124286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] 6ba4afb - [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2023-01-20T10:18:18-06:00 New Revision: 6ba4afb4d6f2f8f293ad704a37de4139c5c8c0f0 URL: https://github.com/llvm/llvm-project/commit/6ba4afb4d6f2f8f293ad704a37de4139c5c8c0f0 DIFF: https://github.com/llvm/llvm-project/commit/6ba4afb4d6f2f8f293ad704a37de4139c5c8c0f0.di

[clang] ed7a46a - [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

Author: Volodymyr Sapsai Date: 2023-01-20T10:18:18-06:00 New Revision: ed7a46a8de77087447936965044e2faf734102e5 URL: https://github.com/llvm/llvm-project/commit/ed7a46a8de77087447936965044e2faf734102e5 DIFF: https://github.com/llvm/llvm-project/commit/ed7a46a8de77087447936965044e2faf734102e5.di

[PATCH] D140073: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ba4afb4d6f2: [ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D140073?vs=487045&id=490868#toc Repository:

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed7a46a8de77: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes… (authored by vsapsai). Repository: rG LLVM Github Monor

[clang] cf17561 - [NFC] Reformat isBuiltinSupported with early exit

Author: serge-sans-paille Date: 2023-01-20T17:20:14+01:00 New Revision: cf1756146d386667a80501fb8161505d12950804 URL: https://github.com/llvm/llvm-project/commit/cf1756146d386667a80501fb8161505d12950804 DIFF: https://github.com/llvm/llvm-project/commit/cf1756146d386667a80501fb8161505d12950804.d

[clang] 4707468 - Add support for clang-cl's option `-fexcess-precision`.

Author: Zahira Ammarguellat Date: 2023-01-20T11:25:36-05:00 New Revision: 47074683c906f920cb7bba462beeb57ca4b84ab0 URL: https://github.com/llvm/llvm-project/commit/47074683c906f920cb7bba462beeb57ca4b84ab0 DIFF: https://github.com/llvm/llvm-project/commit/47074683c906f920cb7bba462beeb57ca4b84ab0

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47074683c906: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than the missing template test. Comment at: clang/test/Parser/lax-conv.cpp:4 +// RUN: %clang_cc1 -triple=powerpc64-ibm-aix -target-feature +altivec -target-fe

[clang] 7c59dea - [NFC]Fix github identification.

Author: Alexey Bataev Date: 2023-01-20T08:40:38-08:00 New Revision: 7c59deaa1150a1bccf8090ba798ba93fdfe335e0 URL: https://github.com/llvm/llvm-project/commit/7c59deaa1150a1bccf8090ba798ba93fdfe335e0 DIFF: https://github.com/llvm/llvm-project/commit/7c59deaa1150a1bccf8090ba798ba93fdfe335e0.diff

[PATCH] D142228: [clangd] Disable tests that are incompatible with Windows

andrewng created this revision. andrewng added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. andrewng requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These tests e

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. > Maybe multi-lib handling should split into another patch? I can do this. But if I separate I still can't choose one that should be merged firstly, they will be needed to merge both at once, because tests will fail. If separate them right way (fixes for multilibs i

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev, sandeepkosuri, cchen, jyu2. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald ad

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7249 // checking for any calls inside an Order region if (Scope->isOpenMPOrderClauseScope()) Diag(LParenLoc, diag::err_omp_unexpected_call_to_omp_runtime_api); Maybe better

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7249 // checking for any calls inside an Order region if (Scope->isOpenMPOrderClauseScope()) Diag(LParenLoc, diag::err_omp_unexpected_call_to_omp_runtime_api); ABatae

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7249 // checking for any calls inside an Order region if (Scope->isOpenMPOrderClauseScope()) Diag(LParenLoc, diag::err_omp_unexpected_call_to_omp_runtime_api); tianshilei199

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

steven_wu added a comment. In D136315#4067205 , @calebzulawski wrote: > One thing to throw into the mix: Apple's clang has a default sysroot > configured, so with the default system compiler, there is no way to replicate > this "build without a sysroot

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

maryammo updated this revision to Diff 490895. maryammo added a comment. Adding test for template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Sema/SemaOverload.cpp clang/test/Pars

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 updated this revision to Diff 490896. tianshilei1992 added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno added a comment. Test failure is unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142077/new/ https://reviews.llvm.org/D142077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233 ___

[clang] c4fa504 - [AArch64] Enable libm vectorized functions via SLEEF

Author: Daniel Kiss Date: 2023-01-20T18:52:38+01:00 New Revision: c4fa504f797f68297c252dc91a24c7d37c1de4df URL: https://github.com/llvm/llvm-project/commit/c4fa504f797f68297c252dc91a24c7d37c1de4df DIFF: https://github.com/llvm/llvm-project/commit/c4fa504f797f68297c252dc91a24c7d37c1de4df.diff L

  1   2   >