ABataev added inline comments.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:7249 // checking for any calls inside an Order region if (Scope->isOpenMPOrderClauseScope()) Diag(LParenLoc, diag::err_omp_unexpected_call_to_omp_runtime_api); ---------------- tianshilei1992 wrote: > ABataev wrote: > > Maybe better to check it here to avoid too early exit? > > ``` > > if (Scope && Scope->...) > > ``` > But does it make sense to continue? I'm not that sure. Yes, we can get some extra diagnostics, which may be helpful Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits