nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land.
LGTM other than the missing template test. ================ Comment at: clang/test/Parser/lax-conv.cpp:4 +// RUN: %clang_cc1 -triple=powerpc64-ibm-aix -target-feature +altivec -target-feature -vsx -fsyntax-only -verify=expected,aix %s + +void dummy(vector unsigned int a); ---------------- Can you also add one template test? ``` template <typename VEC> VEC __attribute__((noinline)) test(vector unsigned char a, vector unsigned char b) { return (VEC)(a * b); } vector unsigned char test1(vector unsigned char a, vector unsigned char b) { return test<vector unsigned char>(a, b); } vector unsigned long long test2(vector unsigned char a, vector unsigned char b) { return test<vector unsigned long long>(a, b); } ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142222/new/ https://reviews.llvm.org/D142222 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits