[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal

[PATCH] D141789: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 490386. eopXD edited the summary of this revision. eopXD added a comment. Update code: Address review comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141789/new/ https://reviews.llvm.org/D141789

[PATCH] D142001: [clang] Use FP options from AST for emitting code for casts

2023-01-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Overall looks reasonable. One question about testing. Comment at: clang/test/CodeGen/X86/avx512dq-builtins-constrained.c:7 -// FIXME: Every instance of "fpexcept.maytrap" is wrong. +// Any cases of "fpexcept.maytrap" in this test are clang bugs. + -

[PATCH] D141789: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

2023-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141789/new/ https://reviews.llvm.org/D141789 ___

[clang] 741cb06 - [clang][Interp][NFC] Remove unused functions

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T09:22:57+01:00 New Revision: 741cb06cab5f3943c8037cfec89fc8663d6e4ae6 URL: https://github.com/llvm/llvm-project/commit/741cb06cab5f3943c8037cfec89fc8663d6e4ae6 DIFF: https://github.com/llvm/llvm-project/commit/741cb06cab5f3943c8037cfec89fc8663d6e4ae6.diff LO

[clang] 1221af9 - [clang][Interp] Use placement new to construct opcode args into vector

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T09:22:57+01:00 New Revision: 1221af99281c87d35c65110a75f87893ff0fc947 URL: https://github.com/llvm/llvm-project/commit/1221af99281c87d35c65110a75f87893ff0fc947 DIFF: https://github.com/llvm/llvm-project/commit/1221af99281c87d35c65110a75f87893ff0fc947.diff LO

[clang] d44f4fa - [clang][Interp][NFC] Initialize constants as ~0u

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T09:22:57+01:00 New Revision: d44f4fac424d70e7c8c463ad9f44a228fc61e9e5 URL: https://github.com/llvm/llvm-project/commit/d44f4fac424d70e7c8c463ad9f44a228fc61e9e5 DIFF: https://github.com/llvm/llvm-project/commit/d44f4fac424d70e7c8c463ad9f44a228fc61e9e5.diff LO

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1221af99281c: [clang][Interp] Use placement new to construct opcode args into vector (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

2023-01-19 Thread Mike Hommey via Phabricator via cfe-commits
glandium added a comment. In D136651#4064260 , @glandium wrote: > This broke our mac builds with errors like: > > ld64.lld: error: undefined symbol: CFRunLoopRun > >>> referenced by > tools/clang/tools/clang-stat-cache/CMakeFiles/clang-stat-cache.dir

[PATCH] D141793: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA

2023-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Herald added a subscriber: luke. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vmsgt.c:10 -// CHECK-RV64-LABEL: @test_vmsgt_vv_i8mf8_b64( -// CHECK-RV64-NEXT: entry: Why does this t

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

2023-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Herald added a subscriber: luke. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:96 struct Policy { - bool IsUnspecified = false; + const bool IsUnspecified = false; enum PolicyType { Should this be a class

[clang] 6b0cd49 - [clang][Interp] Check Field initialization after constructor call

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T09:42:22+01:00 New Revision: 6b0cd497b0fb584bdc0650b585c5bd1ed9edfc99 URL: https://github.com/llvm/llvm-project/commit/6b0cd497b0fb584bdc0650b585c5bd1ed9edfc99 DIFF: https://github.com/llvm/llvm-project/commit/6b0cd497b0fb584bdc0650b585c5bd1ed9edfc99.diff LO

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b0cd497b0fb: [clang][Interp] Check Field initialization after constructor call (authored by tbaeder). Changed prior to commit: https://reviews.ll

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:479 +} +// FIXME: !!this is a hacky way to collect macro references. +std::vector Macros; hokein wrote: > kadircet wrote: > > this might behave slightly different

[PATCH] D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix

2023-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142016/new/ https://reviews.llvm.org/D142016 ___

[PATCH] D141793: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 490396. eopXD added a comment. Recover mis-deleted test cases, which are the instructions with a mask destination register. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141793/new/ https://reviews.llvm.org/D141

[PATCH] D142006: [mlir][bufferization] Fix getAliasingOpOperand/OpResult for non-bufferizable ops

2023-01-19 Thread Matthias Springer via Phabricator via cfe-commits
springerm updated this revision to Diff 490397. springerm added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142006/new/ https://reviews.llvm.org/D142006 Fil

[PATCH] D142006: [mlir][bufferization] Fix getAliasingOpOperand/OpResult for non-bufferizable ops

2023-01-19 Thread Matthias Springer via Phabricator via cfe-commits
springerm updated this revision to Diff 490398. springerm added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142006/new/ https://reviews.llvm.org/D142006 Files: mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterfac

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

2023-01-19 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D138546#4053538 , @cpsauer wrote: > @nridge, I took a shot at the change you suggested. Confirming that this what > you were thinking of, removing `inferTargetAndDriverMode` from database load > and replacing it with a call to

[PATCH] D141793: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA

2023-01-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141793/new/ https://reviews.llvm.org/D141793 ___

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 490400. eopXD added a comment. Update code: Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://reviews.llvm.org/D141796 Files: clang/include/clang/Support/RISCVVIntri

[PATCH] D78028: move shebangs from python2 to python3

2023-01-19 Thread Gianfranco Costamagna via Phabricator via cfe-commits
LocutusOfBorg added a comment. Herald added a subscriber: jsetoain. This is still relevant, python2 is dead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78028/new/ https://reviews.llvm.org/D78028 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 490407. eopXD marked an inline comment as done. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://reviews.llvm.org/D141796 Files: clang/include/clang/Support/RIS

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

2023-01-19 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 490412. serge-sans-paille added a comment. Thanks @nikic for the review. Remarks taken into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142026/new/ https://reviews.llvm.org/D142026 Files: clang/lib/Driver/Driver.cpp llvm/in

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 490416. eopXD added a comment. Herald added a subscriber: arphaman. Update test cases under test/CodeGen/RISCV/rvv-intrinsics-handcrafted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. > We can easily check the actual character at the given position in the client, > so I could just merge the two highlighting kinds. Thanks! Note that it might not be as easy at the face of templates, eg: #define LESS < template LESS typename T > class A {}; > No

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 490417. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.llvm.org/D142085 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Support/RISCVVInt

[clang] 5b54cf1 - [clang][Interp] Unify visiting variable declarations

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T10:46:16+01:00 New Revision: 5b54cf1a2892767fe949826a32d7820732028a38 URL: https://github.com/llvm/llvm-project/commit/5b54cf1a2892767fe949826a32d7820732028a38 DIFF: https://github.com/llvm/llvm-project/commit/5b54cf1a2892767fe949826a32d7820732028a38.diff LO

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b54cf1a2892: [clang][Interp] Unify visiting variable declarations (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D13681

[clang-tools-extra] ccb6749 - [clangd] Simplify some tests in IncludeCleanerTests, NFC

2023-01-19 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-01-19T10:48:54+01:00 New Revision: ccb67491f0dd55c5bd8ed5f71cb802422bfaa969 URL: https://github.com/llvm/llvm-project/commit/ccb67491f0dd55c5bd8ed5f71cb802422bfaa969 DIFF: https://github.com/llvm/llvm-project/commit/ccb67491f0dd55c5bd8ed5f71cb802422bfaa969.diff LO

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

2023-01-19 Thread Nikita Popov via Phabricator via cfe-commits
nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142026/new/ https://reviews.llvm.org/D142026 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-19 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/Standa

[clang] 9308014 - [clang][Interp] Diagnose uninitialized array record fields

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T11:07:51+01:00 New Revision: 9308014195e2f091c0025ef4aa26ece080b7da8d URL: https://github.com/llvm/llvm-project/commit/9308014195e2f091c0025ef4aa26ece080b7da8d DIFF: https://github.com/llvm/llvm-project/commit/9308014195e2f091c0025ef4aa26ece080b7da8d.diff LO

[PATCH] D136828: [clang][Interp] Diagnose uninitialized array record fields

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9308014195e2: [clang][Interp] Diagnose uninitialized array record fields (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: s.egerton, simoncook. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: cla

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD added a comment. These changes described are based on patch(es) under review. This patch should land after D142085 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142094/new/ https://reviews.llvm.org/D142094

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

2023-01-19 Thread J. Ryan Stinnett via Phabricator via cfe-commits
jryans added a comment. @calebzulawski The toolchain is selected based on the target, see Driver::getToolChain . Various groups do target macOS from Linux hosts. I'm not quite s

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/ https://reviews.llvm.org/D136751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 2aa23ff - [clang][Interp][NFCI] Pull IsConstantContext into State

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T12:16:03+01:00 New Revision: 2aa23ff263a012afaf0dbb05d96a7301fc6cbb57 URL: https://github.com/llvm/llvm-project/commit/2aa23ff263a012afaf0dbb05d96a7301fc6cbb57 DIFF: https://github.com/llvm/llvm-project/commit/2aa23ff263a012afaf0dbb05d96a7301fc6cbb57.diff LO

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

2023-01-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. @kazu Thanks for dealing with this! I'd like to build on this and create llvm variants of the C++20 countl_zero/countr_zero/countl_one/countr_one template functions similar to what I did for popcount in D132407 (and have MathExtras.h

[clang] fddf641 - [clang][Interp][NFC] Remove shift error checking code duplication

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T12:18:26+01:00 New Revision: fddf6418e8492a544c9bfdb42a4dbc949d9dc2ee URL: https://github.com/llvm/llvm-project/commit/fddf6418e8492a544c9bfdb42a4dbc949d9dc2ee DIFF: https://github.com/llvm/llvm-project/commit/fddf6418e8492a544c9bfdb42a4dbc949d9dc2ee.diff LO

[clang] 9ee0d74 - [clang][Interp][NFC] Move CheckDivRem() implementation into Interp.cpp

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T12:18:34+01:00 New Revision: 9ee0d7494eb35f5addefcb730cdf5c002ddeacd2 URL: https://github.com/llvm/llvm-project/commit/9ee0d7494eb35f5addefcb730cdf5c002ddeacd2 DIFF: https://github.com/llvm/llvm-project/commit/9ee0d7494eb35f5addefcb730cdf5c002ddeacd2.diff LO

[clang] 490e821 - [clang][Interp] Implement missing compound assign operators

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T12:24:56+01:00 New Revision: 490e8214fca48824beda8b508d6d6bbbf3d8d9a7 URL: https://github.com/llvm/llvm-project/commit/490e8214fca48824beda8b508d6d6bbbf3d8d9a7 DIFF: https://github.com/llvm/llvm-project/commit/490e8214fca48824beda8b508d6d6bbbf3d8d9a7.diff LO

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG490e8214fca4: [clang][Interp] Implement missing compound assign operators (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D137071?vs=474273&id=490444#toc Repository: rG LLVM

[PATCH] D142101: [clang] [extract-api] Don't crash for category in libclang APIs

2023-01-19 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: zixuw. Herald added a subscriber: arphaman. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove failure conditions fo

[clang] 2dbcfd2 - Revert "[clang][Interp][NFC] Move CheckDivRem() implementation into Interp.cpp"

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T12:37:20+01:00 New Revision: 2dbcfd298f7cb1454ca16f544b7df980ec8fc17d URL: https://github.com/llvm/llvm-project/commit/2dbcfd298f7cb1454ca16f544b7df980ec8fc17d DIFF: https://github.com/llvm/llvm-project/commit/2dbcfd298f7cb1454ca16f544b7df980ec8fc17d.diff LO

[PATCH] D142101: [clang] [extract-api] Don't crash for category in libclang APIs

2023-01-19 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 490447. dang added a comment. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142101/new/ https://reviews.llvm.org/D142101 Files: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp cl

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. AFAIK we need a name and an email address so the commit can be attributed properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 __

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

2023-01-19 Thread Evan Smal via Phabricator via cfe-commits
evansmal added a comment. In D141283#4065117 , @tbaeder wrote: > AFAIK we need a name and an email address so the commit can be attributed > properly. The commit can be attributed to Evan Smal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 85acfc6 - Revert "[clang][Interp][NFC] Remove shift error checking code duplication"

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T13:03:20+01:00 New Revision: 85acfc64257b133dcdc1d39f0ea07a0dc30a3656 URL: https://github.com/llvm/llvm-project/commit/85acfc64257b133dcdc1d39f0ea07a0dc30a3656 DIFF: https://github.com/llvm/llvm-project/commit/85acfc64257b133dcdc1d39f0ea07a0dc30a3656.diff LO

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 490452. hokein marked 3 inline comments as done. hokein added a comment. address comments: - rename to computeUnusedIncludesExperimental - use PragmaInclude from preamble, limit the scope of the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:609 + Config::UnusedIncludesPolicy::Experiment) +Pragmas.record(*Clang); // Copy over the macros in the preamble region of the main file, and combine kadircet wrote: > ho

[PATCH] D141280: [clang] Build UsingType for elaborated type specifiers.

2023-01-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 490455. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141280/new/ https://reviews.llvm.org/D141280 Files: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp clang/inc

[clang] 1499cce - [clang] Improve diagnostic for "initializer-string for char array is too long"

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Evan Smal Date: 2023-01-19T13:13:08+01:00 New Revision: 1499cce2646cbf4dd78f8534a4e71bd856b10994 URL: https://github.com/llvm/llvm-project/commit/1499cce2646cbf4dd78f8534a4e71bd856b10994 DIFF: https://github.com/llvm/llvm-project/commit/1499cce2646cbf4dd78f8534a4e71bd856b10994.diff LOG

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1499cce2646c: [clang] Improve diagnostic for "initializer-string for char array is too long" (authored by evansmal, committed by tbaeder). Changed

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-19 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 490457. ckandeler marked 2 inline comments as done. ckandeler added a comment. Made token name more generic, added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.or

[PATCH] D139926: [clangd] Add semantic token for angle brackets

2023-01-19 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D139926#4064769 , @kadircet wrote: >> We can easily check the actual character at the given position in the >> client, so I could just merge the two highlighting kinds. > > Thanks! Note that it might not be as easy at the fa

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

2023-01-19 Thread Evan Smal via Phabricator via cfe-commits
evansmal added a comment. @tbaeder Thank you! :^) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

2023-01-19 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD added a comment. @asb I just saw the cancellation of the sync-up call today. Regarding the branch out on 01/24 I think it would be good to have these incompatible changes into LLVM 16. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142094/new

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Really didn't expect this: https://lab.llvm.org/buildbot/#/builders/214/builds/5415 Command Output (stderr): -- + : 'RUN: at line 1' + /scratch/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang -cc1 -internal-isystem /scratch/powerllvm/powerllvm

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/ParsedAST.h:111 + const include_cleaner::PragmaIncludes *getPragmaIncludes() const; + can you add a comme

[clang] 0f5a81c - [clang][Interp][NFC] Remove shift error checking code duplication

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T13:52:47+01:00 New Revision: 0f5a81cb445bb26769d68d3944b6af79072b0cd0 URL: https://github.com/llvm/llvm-project/commit/0f5a81cb445bb26769d68d3944b6af79072b0cd0 DIFF: https://github.com/llvm/llvm-project/commit/0f5a81cb445bb26769d68d3944b6af79072b0cd0.diff LO

[clang] f6ea1af - Revert "[clang][Interp] Implement missing compound assign operators"

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T13:52:47+01:00 New Revision: f6ea1af9a4b71d27de2dde629224af1220c5c85b URL: https://github.com/llvm/llvm-project/commit/f6ea1af9a4b71d27de2dde629224af1220c5c85b DIFF: https://github.com/llvm/llvm-project/commit/f6ea1af9a4b71d27de2dde629224af1220c5c85b.diff LO

[clang] 8df7e81 - Revert "[clang][Interp] Unify visiting variable declarations"

2023-01-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-01-19T13:52:47+01:00 New Revision: 8df7e818de45c367dc497e28d4d0e5a1fa1e64fe URL: https://github.com/llvm/llvm-project/commit/8df7e818de45c367dc497e28d4d0e5a1fa1e64fe DIFF: https://github.com/llvm/llvm-project/commit/8df7e818de45c367dc497e28d4d0e5a1fa1e64fe.diff LO

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

2023-01-19 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. My bot is a Mac. It doesn't set any env vars (other than the ones that lit always sets). In theory it shouldn't matter since tests aren't supposed to depend on system headers. (Tangential: maybe there should be a flag to turn this off and %clang should expand to `clang`

[clang] 6ad1b40 - Optimize OptTable::findNearest implementation and usage

2023-01-19 Thread via cfe-commits
Author: serge-sans-paille Date: 2023-01-19T14:16:29+01:00 New Revision: 6ad1b4095172373590134afff19a7fbad9d7889d URL: https://github.com/llvm/llvm-project/commit/6ad1b4095172373590134afff19a7fbad9d7889d DIFF: https://github.com/llvm/llvm-project/commit/6ad1b4095172373590134afff19a7fbad9d7889d.d

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

2023-01-19 Thread serge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ad1b4095172: Optimize OptTable::findNearest implementation and usage (authored by serge-sans-paille). Changed prior to commit: https://reviews.ll

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

2023-01-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D141744#4063661 , @alexander-shaposhnikov wrote: > @aaron.ballman - thanks for the review, I've updated the release notes. > Regarding LanguageExtensions.rst - somehow I don't see any appropriate > sections in Langua

Re: [clang] 2dbcfd2 - Revert "[clang][Interp][NFC] Move CheckDivRem() implementation into Interp.cpp"

2023-01-19 Thread Roman Lebedev via cfe-commits
Reminder to please always mention the reason for the revert/recommit in the commit message. On Thu, Jan 19, 2023 at 2:37 PM Timm Bäder via cfe-commits wrote: > > > Author: Timm Bäder > Date: 2023-01-19T12:37:20+01:00 > New Revision: 2dbcfd298f7cb1454ca16f544b7df980ec8fc17d > > URL: > https://git

[clang-tools-extra] e70ca7b - [clang] Build UsingType for elaborated type specifiers.

2023-01-19 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-01-19T14:20:38+01:00 New Revision: e70ca7b35319a3621f9d9c6475926428f8c5c000 URL: https://github.com/llvm/llvm-project/commit/e70ca7b35319a3621f9d9c6475926428f8c5c000 DIFF: https://github.com/llvm/llvm-project/commit/e70ca7b35319a3621f9d9c6475926428f8c5c000.diff LO

[PATCH] D141280: [clang] Build UsingType for elaborated type specifiers.

2023-01-19 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe70ca7b35319: [clang] Build UsingType for elaborated type specifiers. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D141

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-19 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 490468. VitaNuo added a comment. Remove variant logic in generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/Stand

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

2023-01-19 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. I've seen s390x and AIX builders break here, probably a problem with big-endian machines? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071

[PATCH] D141716: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.

2023-01-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 490470. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141716/new/ https://reviews.llvm.org/D141716 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironm

[PATCH] D141716: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.

2023-01-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:792 + // fields are printed. + llvm::dbgs() << "DeclToLoc:\n"; + for (auto [D, L] : DeclToLoc) sgatev wrote: > Shouldn

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

2023-01-19 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D136651#4064474 , @glandium wrote: > In D136651#4064260 , @glandium > wrote: > >> This broke our mac builds with errors like: >> >> ld64.lld: error: undefined symbol: CFRunLoopRun >

[clang-tools-extra] 939dce1 - [clangd] Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-01-19T14:31:40+01:00 New Revision: 939dce12f9f35f7e0953a036c16e89d30011d047 URL: https://github.com/llvm/llvm-project/commit/939dce12f9f35f7e0953a036c16e89d30011d047 DIFF: https://github.com/llvm/llvm-project/commit/939dce12f9f35f7e0953a036c16e89d30011d047.diff LO

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG939dce12f9f3: [clangd] Implement unused include warnings with include-cleaner library. (authored by hokein).

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

2023-01-19 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. I just verified that that does indeed happen, and it does: $ strace out/gn/bin/clang --target=x86_64-apple-macos -x c -c /dev/null 2>&1 | grep xcrun access("/usr/bin/xcrun", F_OK) = -1 ENOENT (No such file or directory) Repository: rG LLVM Github Monorep

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

2023-01-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. You should also add a release note for the changes. Comment at: clang/lib/Sema/SemaOverload.cpp:10920 - // If we can fix the conversion, suggest the FixIts. - for (std::vector::iterator HI = Cand->Fix.Hints.begin(), - HE = Cand->Fix.Hint

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-19 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 490476. VitaNuo added a comment. Restore variant logic for overloads. Remove broken logic for accepted variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-01-19 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 490478. VitaNuo added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp clang/to

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

2023-01-19 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. In D141899#4061237 , @zixuan-wu wrote: > With considering > https://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility I think > we need make consensus to choose one option from following 2 options. > > 1. Remove X86amx

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

2023-01-19 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D141992#4063978 , @ChuanqiXu wrote: >> Ah, Windows build failures are obviously relevant :) One gotcha here is >> going to be to chase down all the sizes of the records on different >> platforms. > > The failure shouldn't

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

2023-01-19 Thread Caleb Zulawski via Phabricator via cfe-commits
calebzulawski added a comment. I don't think we necessarily need to revert due to the xcrun quirk since I think it's harmless, though I can provide a follow up change if necessary. I just checked Rust's source as a comparison and it appears that for macOS targets it will always attempt to invo

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

2023-01-19 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 490490. erichkeane added a comment. Fix clang-format, hopefully this saves me from the bots ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141954/new/ https://reviews.llvm.org/D141954 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaC

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

2023-01-19 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D136315#4065426 , @calebzulawski wrote: > I don't think we necessarily need to revert due to the xcrun quirk since I > think it's harmless, though I can provide a follow up change if necessary. I > just checked Rust's source

[clang] c441f65 - [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.

2023-01-19 Thread Yitzhak Mandelbaum via cfe-commits
Author: Yitzhak Mandelbaum Date: 2023-01-19T14:33:32Z New Revision: c441f65f9183a4d1d7f5ecc63b4e32a42e09367e URL: https://github.com/llvm/llvm-project/commit/c441f65f9183a4d1d7f5ecc63b4e32a42e09367e DIFF: https://github.com/llvm/llvm-project/commit/c441f65f9183a4d1d7f5ecc63b4e32a42e09367e.diff

[PATCH] D141716: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.

2023-01-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rGc441f65f9183: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`. (authored by ym

[PATCH] D142113: [clang][nfc] refactor Module::Header to use OptionalFileEntryRef

2023-01-19 Thread Richard Howell via Phabricator via cfe-commits
rmaz created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor the `Module::Header` class to use an `OptionalFileEntryRef` instead of a `FileEntr

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

2023-01-19 Thread Richard Howell via Phabricator via cfe-commits
rmaz abandoned this revision. rmaz added a comment. Its going to be less work to refactor TopheaderNames to use FileEntryRef, so went that way instead. First step is here: https://reviews.llvm.org/D142113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

2023-01-19 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. In D142094#4065175 , @eopXD wrote: > @asb I just saw the cancellation of the sync-up call today. Regarding the > branch out on 01/24 I think it would be good to have these incompatible > changes into LLVM 16. Sorry for missing ther

[PATCH] D142001: [clang] Use FP options from AST for emitting code for casts

2023-01-19 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 490504. sepavloff added a comment. Use --implicit-check-not in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142001/new/ https://reviews.llvm.org/D142001 Files: clang/lib/CodeGen/CGExprScalar.cpp c

[PATCH] D139921: [include-cleaner] Ranking of providers based on hints

2023-01-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ChuanqiXu. LG, just nits really! Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:133 + + Header(std::in

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

2023-01-19 Thread Caleb Zulawski via Phabricator via cfe-commits
calebzulawski added a comment. In D136315#4065481 , @thakis wrote: > In D136315#4065426 , @calebzulawski > wrote: > >> I don't think we necessarily need to revert due to the xcrun quirk since I >> think it's har

[clang] ee700de - [AArch64] Armv9-A implies FP16

2023-01-19 Thread David Green via cfe-commits
Author: David Green Date: 2023-01-19T15:37:50Z New Revision: ee700dec052a0336798fb2570faec31719b53f8d URL: https://github.com/llvm/llvm-project/commit/ee700dec052a0336798fb2570faec31719b53f8d DIFF: https://github.com/llvm/llvm-project/commit/ee700dec052a0336798fb2570faec31719b53f8d.diff LOG: [

[PATCH] D142087: [AArch64] Armv9-A implies FP16

2023-01-19 Thread Dave Green via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee700dec052a: [AArch64] Armv9-A implies FP16 (authored by dmgreen). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed p

[PATCH] D142118: [HIP] Unbundler allows missing host entry

2023-01-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: sstefan1, MaskRay. Herald added a reviewer: jdoerfert. clang-offload-bundler should allow missing host entry when unbundling with option --a

[PATCH] D139774: [libclang] Add API to set temporary directory location

2023-01-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D139774#4063131 , @vedgy wrote: > After a discussion under the corresponding KDevelop merge request, I can see > 4-6 alternative ways to address the temporary directory issue: > > 1. Add an option to store the //preamble

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

2023-01-19 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. With this, I now get: FAILED: bin/clangd-fuzzer : && /usr/lib/icecream/libexec/icecc/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializer

  1   2   3   >