erichkeane added a comment. In D141992#4063978 <https://reviews.llvm.org/D141992#4063978>, @ChuanqiXu wrote:
>> Ah, Windows build failures are obviously relevant :) One gotcha here is >> going to be to chase down all the sizes of the records on different >> platforms. > > The failure shouldn't be related the patch since the patch itself should only > cause static assert failures. I saw you guys have already found the solutions > in D141954 <https://reviews.llvm.org/D141954>. So I am going to land this. No, that patch was talking about the libcxx issue. The windows issues I saw in pre-commit CI on this patch were it hitting your assert all over the place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
