rjmccall added a comment. Overall looks reasonable. One question about testing.
================ Comment at: clang/test/CodeGen/X86/avx512dq-builtins-constrained.c:7 -// FIXME: Every instance of "fpexcept.maytrap" is wrong. +// Any cases of "fpexcept.maytrap" in this test are clang bugs. + ---------------- Can you use `FileCheck --implicit-check-not` to verify this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142001/new/ https://reviews.llvm.org/D142001 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
