[clang-tools-extra] 5091357 - [clangd] Disable ScopedMemoryLimit on tsan builds

Author: Kadir Cetinkaya Date: 2023-01-17T09:09:08+01:00 New Revision: 5091357e1ba8bc709680c327fe71a90676f86197 URL: https://github.com/llvm/llvm-project/commit/5091357e1ba8bc709680c327fe71a90676f86197 DIFF: https://github.com/llvm/llvm-project/commit/5091357e1ba8bc709680c327fe71a90676f86197.dif

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { tkuchta wrote: > browneee wrote: > > The `s_label` represents

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 489720. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp Index: clang/test/AST/I

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:200 + using ExprVisitorFunc = std::function; + bool visitConditional(const AbstractConditionalOperator *E, +ExprVisitorFunc VisitFunc); tbaeder wrote: > er

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 489722. ckandeler marked 2 inline comments as done. ckandeler retitled this revision from "[clangd] Add semantic tokens for angle brackets" to "[clangd] Add semantic token for angle brackets". ckandeler added a comment. Added test cases, merged the two High

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM ,thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422

[clang] b164b04 - [Clang] Convert test to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-01-17T10:08:57+01:00 New Revision: b164b047f2b41ff0c0a3ede3baa29c230c78cd32 URL: https://github.com/llvm/llvm-project/commit/b164b047f2b41ff0c0a3ede3baa29c230c78cd32 DIFF: https://github.com/llvm/llvm-project/commit/b164b047f2b41ff0c0a3ede3baa29c230c78cd32.diff

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

hokein added a comment. Have you run the script on the zombie_names page? Does it work? Comment at: clang/tools/include-mapping/gen_std.py:67 required=True) + parser.add_argument('-output', + default='SymbolMap.inc',

[clang] b3eb004 - [C++20] [Modules] Only diagnose the non-inline external variable

Author: Chuanqi Xu Date: 2023-01-17T17:48:09+08:00 New Revision: b3eb004ca78f522c91c0d83bafeab2ee753417c8 URL: https://github.com/llvm/llvm-project/commit/b3eb004ca78f522c91c0d83bafeab2ee753417c8 DIFF: https://github.com/llvm/llvm-project/commit/b3eb004ca78f522c91c0d83bafeab2ee753417c8.diff LO

[PATCH] D141905: [C++20] [Modules] Only diagnose the non-inline external variable definitions in header units

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3eb004ca78f: [C++20] [Modules] Only diagnose the non-inline external variable (authored by ChuanqiXu). Herald added a project: clang. Herald added a

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

LuoYuanke added a comment. @zixuan-wu, changing x86_amx would break our internal code. May I know the motivation to change the type? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141899/new/ https://reviews.llvm.org/D141899 __

[PATCH] D140415: [flang] stack arrays pass

jeanPerier added inline comments. Herald added a subscriber: sunshaoce. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:104 + + bool operator!=(const InsertionPoint &rhs) const { +return (location != rhs.location) || It's better to negate the `==

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice created this revision. paperchalice added reviewers: phosek, Ericson2314. Herald added a subscriber: Enna1. Herald added a project: All. paperchalice requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

KKoovalsky added a comment. Hey! I can see that the build: https://reviews.llvm.org/harbormaster/build/311598/ failed, but I am not sure whether this is related to my change. Could someone take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains created this revision. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address part of https://github.com/llvm/llvm-project/issues/60079. Deleted and Defaulted fu

[PATCH] D141892: Implement modernize-use-constraints

njames93 added a comment. In D141892#4057722 , @ccotter wrote: > 2. replace the non `_v` templates to the `_v` variants `is_same` -> > `is_same_v` or the equivalent concept `same_as` See D137302 Repository: rG LLVM

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada created this revision. domada added reviewers: dpalermo, skatrak, kiranktp, RogerV-AMD, NimishMishra, jsjodin. Herald added subscribers: pmatos, asb, guansong, kbarton, hiraditya, jgravelle-google, sbc100, yaxunl, nemanjai, dschuff. Herald added a project: All. domada requested review of t

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

foad added a comment. Herald added a subscriber: luke. In D141798#4055050 , @barannikov88 wrote: > It would be nice to have comments reflecting the new behavior in the case of > 0 / max value. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

jmorse added a comment. Hi, In D141381#4056661 , @fdeazeve wrote: > While SROA will not touch this: > > define @foo(ptr %arg) { > call void @llvm.dbg.declare(%arg, [...], metadata !DIExpression()) > > It completely destroys the debug information p

[PATCH] D140377: [clang][Interp] Compound assign operators for FP values

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140377/new/ https://reviews.llvm.org/D140377

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 489753. tblah marked 7 inline comments as done. tblah added a comment. - Implement operator!= as !(operator==) - Move insertion point computation to StackArraysAnalysisWrapper::analyseFunction - Remove special-casing for join(allocated, unknown) - Add processin

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:120 + // which operations we intend to rewrite before it calls the pattern rewriter + llvm::SmallDenseMap insertionPoints; + jeanPerier wrote: > It is definitely weird to me

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

Backl1ght added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141694/new/ https://reviews.llvm.org/D141694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6458218 - [docs] Add llvm & clang release notes for LoongArch

Author: Weining Lu Date: 2023-01-17T20:56:57+08:00 New Revision: 64582189b3fc6a65f6dc2e5205da3b6ff71beb93 URL: https://github.com/llvm/llvm-project/commit/64582189b3fc6a65f6dc2e5205da3b6ff71beb93 DIFF: https://github.com/llvm/llvm-project/commit/64582189b3fc6a65f6dc2e5205da3b6ff71beb93.diff LO

[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64582189b3fc: [docs] Add llvm & clang release notes for LoongArch (authored by SixWeining). Changed prior to commit: https://reviews.llvm.org/D141

Re: [clang] f2d301f - Revert "[codegen] Store address of indirect arguments on the stack"

Apologies, I’ll do it next time! In the meantime, the reason was posted in D141381 > On Jan 16, 2023, at 13:59, Roman Lebedev wrote: > > Reminder to please always mention the reason for the revert/recommit > in the commit message. > > On Mon, Jan 16, 2023 at 7:05 PM Felipe de Azevedo Piovezan

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

asb added a comment. In D141380#4053535 , @Hahnfeld wrote: > Yes, this is correct: The JITLink backend for RISC-V doesn't (yet) register > the eh frames into libunwind, so throwing and catching exceptions through > JITted code doesn't work (yet). I know

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. In D141381#4058327 , @jmorse wrote: > Curious -- that feels like the kind of thing we should be able to support, > but adding more "special handling" to SROA isn't great. Agreed! I'll have a look to see how far SROA is from bei

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein added a comment. In D141580#4052496 , @sammccall wrote: > To offer the opposing argument: if DeclResult is just a bad idea, then using > it consistently/right might be worse than using it as little as possible. > > FWIW, I find every piece of code

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

lebedev.ri added a comment. In D141899#4058173 , @LuoYuanke wrote: > @zixuan-wu, changing x86_amx would break our internal code. May I know the > motivation to change the type? I just want to point out that generally "causes [too much] churn downstream"

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

tschuett added a comment. - Can "x86.AMX" be a named constant somewhere? I found a lot of copies. - Release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141899/new/ https://reviews.llvm.org/D141899 __

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 489787. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

courbet created this revision. courbet added reviewers: hokein, alexfh. Herald added a project: All. courbet requested review of this revision. Herald added a project: clang. To match variables that are direct-initialized. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141925

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

LuoYuanke added a comment. In D141899#4058683 , @lebedev.ri wrote: > In D141899#4058173 , @LuoYuanke > wrote: > >> @zixuan-wu, changing x86_amx would break our internal code. May I know the >> motivation to cha

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

courbet updated this revision to Diff 489790. courbet added a comment. fix ddoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141925/new/ https://reviews.llvm.org/D141925 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/unittests/AST

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

tschuett added a comment. The summary only says what you are doing. I am missing something about why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141899/new/ https://reviews.llvm.org/D141899 ___ cfe-co

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

asb added a comment. Herald added a subscriber: luke. In D141666#4050692 , @eklepilkina wrote: > We are interested in proper support for `Zicsr` and `Zifencei`. Could someone > look at patch or explain why these extensions were included by default? As

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

courbet updated this revision to Diff 489794. courbet added a comment. fix doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141925/new/ https://reviews.llvm.org/D141925 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/unittests/ASTM

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

courbet updated this revision to Diff 489796. courbet added a comment. Regenerate doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141925/new/ https://reviews.llvm.org/D141925 Files: clang/docs/LibASTMatchersReference.html clang/include/clang

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4054348 , @v.g.vassilev wrote: > In D131858#4052031 , @erichkeane > wrote: > >> In D131858#4052026 , @v.g.vassilev >> wrote: >> >

[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4058807 , @erichkeane wrote: > In D131858#4054348 , @v.g.vassilev > wrote: > >> In D131858#4052031 , @erichkeane >> wrote: >> >

[PATCH] D141929: Add support for clang-cl's option /Qfexcess-precision.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, mdtoguchi. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5387 + return RD->canPassInRegisters(); +return true; } Is there good reason to return true for all non-record types? Should we instead be limiting the types that can make

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

Jake-Egan added a comment. In D137058#4057424 , @ChuanqiXu wrote: > In D137058#4056647 , @Jake-Egan > wrote: > >> Hi, this new test fails on AIX >> https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/

[clang] 123223a - [clang-repl] XFAIL riscv targets in simple-exception test case

Author: Alex Bradbury Date: 2023-01-17T14:28:15Z New Revision: 123223ab87ca50d1ce4f8c08128d0237b3d31c84 URL: https://github.com/llvm/llvm-project/commit/123223ab87ca50d1ce4f8c08128d0237b3d31c84 DIFF: https://github.com/llvm/llvm-project/commit/123223ab87ca50d1ce4f8c08128d0237b3d31c84.diff LOG:

[PATCH] D141380: [clang-repl] XFAIL riscv targets in simple-exception test case

This revision was automatically updated to reflect the committed changes. Closed by commit rG123223ab87ca: [clang-repl] XFAIL riscv targets in simple-exception test case (authored by asb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141380/new/ ht

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

erichkeane added a comment. In D140423#4055722 , @Michael137 wrote: > In D140423#4052442 , @aaron.ballman > wrote: > >> In D140423#4052271 , @dblaikie >> wrote: >> >>>

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

erichkeane added a comment. This seems innocuous enough/easy enough to use. I'd like a comment on the functions at least and types in TemplateBase.h to specify that this is for printing-policy only? Alternatively (and perhaps MUCH more appreciated) would be to make sure we mark the defaulted

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. In D141892#4058273 , @njames93 wrote: > In D141892#4057722 , @ccotter wrote: > >> 2. replace the non `_v` templates to the `_v` variants `is_same` -> >> `is_same_v` or the equivalent conc

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Thank you for comments! > The key aspect this patch misses right now is the versioning issue - I is > still marked as 2.0. I can update `I` extension version or separate diffrent isa versions as you mentioned. I can fix comments and make proposed by community chang

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

nikic added a comment. From a very cursory look, this looks pretty nice. It looks like we pretty much get rid of AMX-specific knowledge in the middle-end entirely, which is the point of target extension types. Regarding bitcasts, it's worth mentioning that there was some recent discussion abou

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} pmatos wrote: > erichkeane wrote: > > pmatos wrote: > > > erichkea

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:200 + using ExprVisitorFunc = std::function; + bool visitConditional(const AbstractConditionalOperator *E, +ExprVisitorFunc VisitFunc); tbaeder wrote: >

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

nikic added a comment. I think it would also be fine to retain the Type::isX86_AMXTy(), at least for now. That would reduce this patch to mostly the representation change, without the change to check for the type in a different way. Comment at: llvm/lib/IR/Core.cpp:655 -LLVMT

[PATCH] D141690: [clang] fix consteval ctor code generation assert

ilya-biryukov added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1338 + llvm::StructType *STy = dyn_cast(Val->getType()); + if (STy && STy->canLosslesslyBitCastTo(Dest.getElementType())) { for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) {

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added a comment. Erroneous test are required Comment at: clang/include/clang/AST/OpenMPClause.h:310-314 + /// Fetches list of variables associated with this clause. + Expr *getIteratorRef() { +return (static_cast(this) +->template getTrailingObject

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

barannikov88 added a comment. I couldn't find an example of creating "resume unwindabort" in the patch series. Is it yet to be done? Could you show a source code example where such an instruction should be generated? (By the frontend or an IR pass.) I couldn't get it from the RFC. Repository:

[clang] 12cb1cb - Revert "[clang] Instantiate concepts with sugared template arguments"

Author: Erich Keane Date: 2023-01-17T07:29:31-08:00 New Revision: 12cb1cb3720de8d164196010123ce1a8901d8122 URL: https://github.com/llvm/llvm-project/commit/12cb1cb3720de8d164196010123ce1a8901d8122 DIFF: https://github.com/llvm/llvm-project/commit/12cb1cb3720de8d164196010123ce1a8901d8122.diff L

[PATCH] D141935: [OpenMP] Make `-Xarch_host` and `-Xarch_device` for for OpenMP offloading

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. Clan

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. In D141826#4058866 , @erichkeane wrote: > This seems innocuous enough/easy enough to use. I'd like a comment on the > functions at least and types in TemplateBase.h to specify that this is for > printing-policy only? Alter

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

erichkeane added a comment. In D141826#4059073 , @Michael137 wrote: > In D141826#4058866 , @erichkeane > wrote: > >> This seems innocuous enough/easy enough to use. I'd like a comment on the >> functions at le

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added a comment. In D137058#4055275 , @ChuanqiXu wrote: > In D137058#4050188 , @dblaikie > wrote: > >> I really don't think this is the right thing to do - the Split DWARF code, >> for instance, has sup

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 489824. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.org/D141855 Files: clang/tools/include-mapping/gen_std.py Index: cla

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 489827. VitaNuo added a comment. Remove extra whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.org/D141855 Files: clang/tools/include-mapping/gen_std.py Index: cla

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

nathanchance added a comment. > I’ll have to filter the warnings to see if there are any other instances with > other operators that appear problematic. I count a single warning that triggers for an arithmetic operator (which might be a bug): ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

beanz added a comment. Re-using the `VerifyDebug` action really doesn't make sense. That's not what the DXIL validator does, and it will be a source of confusion forever. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.ll

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 489828. VitaNuo added a comment. Adjust argument value set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.org/D141855 Files: clang/tools/include-mapping/gen_std.py Index: c

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Yes, ofc I've run it, I wouldn't send a patch otherwise :) Comment at: clang/tools/include-mapping/gen_std.py:67 required=True) + parser.add_argument('-output', + def

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4215 + // Call validator for dxc. + if (IsDXCMode()) { +Action *LastAction = Actions.back(); Shouldn't the validator only run if we are targeting DXIL? Also we should probably add the `-V

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a comment. In D141625#4053067 , @steven_wu wrote: > @akyrtzi has the good idea. It is really hard to control `Decl*` to get values > to get an unstable iteration order from the small tests, going beyond 32 decls > to get out of SmallPtrSet'

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

dblaikie added a comment. In D141826#4059088 , @erichkeane wrote: > In D141826#4059073 , @Michael137 > wrote: > >> In D141826#4058866 , @erichkeane >> wrote: >> >>> Thi

[clang-tools-extra] 2486c8d - [clangd] Disable modernize-macro-to-enum tidy check

Author: Kadir Cetinkaya Date: 2023-01-17T17:12:07+01:00 New Revision: 2486c8d7bb377fccfc269472e59d748ece277c88 URL: https://github.com/llvm/llvm-project/commit/2486c8d7bb377fccfc269472e59d748ece277c88 DIFF: https://github.com/llvm/llvm-project/commit/2486c8d7bb377fccfc269472e59d748ece277c88.dif

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

kpn added a comment. Are we testing _Complex multiply or subtraction anywhere? I have a vague memory of multiply not working correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 ___

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

shafik added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5387 + return RD->canPassInRegisters(); +return true; } erichkeane wrote: > Is there good reason to return true for all non-record types? Should we > instead be limiting the ty

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

zahiraam updated this revision to Diff 489833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-options.c ==

[PATCH] D141784: [clang][Interp] Fix binary comma operators

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141784/new/ https://reviews.llvm.org/D141784 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

Hahnfeld added subscribers: v.g.vassilev, Hahnfeld. Hahnfeld added a comment. Herald added a subscriber: ributzka. Herald added a project: All. Hello, sorry for the late heads-up, but this functionality is used by ROOT: https://github.com/root-project/root/blob/f58cccf5ce7fd67894c7fd9e9e74d3f37bc

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

dblaikie added a comment. In D141381#4056661 , @fdeazeve wrote: > In hindsight, this should have been obvious. > While SROA will not touch this: > > define @foo(ptr %arg) { > call void @llvm.dbg.declare(%arg, [...], metadata !DIExpression()) > > It

[PATCH] D141944: [include-mapping] Fix gen_std.py test

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141944 Files: clang/to

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

shafik added a comment. Interesting it looks like neither gcc nor MSVC diagnose this either but it looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141803/new/ https://reviews.llvm.org/D141803 ___

[PATCH] D140959: RFC: Multilib prototype

simon_tatham added a comment. "Make difficult things possible": perhaps it might be useful to make sure it's at least //possible// to express a complex boolean function of the basic predicates, even if it's cumbersome? (So that, for example, you could make an attribute conditional on "this cc1

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4056831 , @steven_wu wrote: > Actually, sorting in `numberAnonymousDeclsWithin` doesn't work for some > reasons. The reason for this doesn't work is `ASTWriter::WriteDeclContextLexicalBlock` also iterates on `DeclC

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. @dblaikie Do we have any bots running reverse iteration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/ https://reviews.llvm.org/D141625 ___ cfe-commits mailing list

[PATCH] D141935: [OpenMP] Make `-Xarch_host` and `-Xarch_device` work for OpenMP offloading

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141935/new/ https://reviews.llvm.org/D141935 ___

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

tschuett added a comment. EXPANSIVE_CHECKS will reshuffle the llvm::sort input: https://lists.llvm.org/pipermail/llvm-dev/2018-April/122576.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141625/new/ https://reviews.llvm.org/D141625 __

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar added a comment. @aaron.ballman do you think that we should call ```CheckImplicitConversion``` only for arithemetic compound assignment operators like +=, -=, /=, *= and %= ? For bitwiseAssign operators (|=, &=, ^=) and shiftAssign operators (<<= and >>=) we may have to check the s

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

thetruestblue accepted this revision. thetruestblue added a comment. This seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141550/new/ https://reviews.llvm.org/D141550 ___ cfe-commit

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice new testcase snippets, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124286/new/ https://reviews.llvm.org/D124286 _

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4055516 , @diseraluca wrote: > In D140756#4051383 , @aaron.ballman > wrote: > >> LGTM aside from some minor things you can correct when landing. >> > > Thank you fo

[clang] eec516a - [OpenMP] Make `-Xarch_host` and `-Xarch_device` work for OpenMP offloading

Author: Joseph Huber Date: 2023-01-17T12:38:56-06:00 New Revision: eec516a0954a5a91490ac4b6e86196e9813d9185 URL: https://github.com/llvm/llvm-project/commit/eec516a0954a5a91490ac4b6e86196e9813d9185 DIFF: https://github.com/llvm/llvm-project/commit/eec516a0954a5a91490ac4b6e86196e9813d9185.diff

[PATCH] D141935: [OpenMP] Make `-Xarch_host` and `-Xarch_device` work for OpenMP offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeec516a0954a: [OpenMP] Make `-Xarch_host` and `-Xarch_device` work for OpenMP offloading (authored by jhuber6). Repository: rG LLVM Github Monorep

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 489881. TIFitis added a comment. Addressed reviewer comments. Updated printer and parser to remove the IntegerAttr from appearing. Removed none from map type modifiers, absence of other modifiers implicitly means none. This helps keep it in closer to the spe

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. Hi -has anybody any more concern on this change? I'd like to submit it as soon as possible to unlock @mgorny . Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. one more regression bisected to this: https://bugs.chromium.org/p/chromium/issues/detail?id=1408177 `incomplete type 'blink::ResourceClient' used in type trait expression` I'll try to come up with a smaller repro Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

bryanpkc requested changes to this revision. bryanpkc added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/modules-ts.cpp:23 // -// CHECK-USE: -cc1 +// CHECK-USE: -cc1{{[^[:xdigit:]]}} // CHECK-USE-SAME: -emit-obj

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 5 inline comments as done. TIFitis added a comment. In D131915#4056730 , @kiranchandramohan wrote: > LGTM. Thanks for making the changes and for your patience. Please wait a > couple of days to give other reviewers a chance to have a look

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits mailing lis

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4059540 , @tschuett wrote: > EXPANSIVE_CHECKS will reshuffle the llvm::sort input: > https://lists.llvm.org/pipermail/llvm-dev/2018-April/122576.html This is a slightly different concern. The problem to catch is ite

[clang] 09e4449 - [PS5] Handle visibility options same as PS4

Author: Paul Robinson Date: 2023-01-17T11:27:51-08:00 New Revision: 09e4449901d7fc780806778181cf3136c1e08e98 URL: https://github.com/llvm/llvm-project/commit/09e4449901d7fc780806778181cf3136c1e08e98 DIFF: https://github.com/llvm/llvm-project/commit/09e4449901d7fc780806778181cf3136c1e08e98.diff

  1   2   3   >