beanz added inline comments.
================
Comment at: clang/lib/Driver/Driver.cpp:4215
+ // Call validator for dxc.
+ if (IsDXCMode()) {
+ Action *LastAction = Actions.back();
----------------
Shouldn't the validator only run if we are targeting DXIL? Also we should
probably add the `-Vd` flag to opt out.
================
Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:169
+ : ToolChain(D, Triple, Args) {
+ if (Args.hasArg(options::OPT_dxc_validator_path_EQ))
+ getProgramPaths().push_back(
----------------
If this option isn't specified we should probably search for `dxv` relative to
`clang` and on the `PATH`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141705/new/
https://reviews.llvm.org/D141705
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
