[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:17 + +static const llvm::StringSet<> ValueTraits = { +"alignment_of", I'm guessing this list was obtained in some automatic way - could we document th

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-c

[clang] 7c4a70f - [Driver] Add crtfastmath.o on Solaris if appropriate

Author: Rainer Orth Date: 2023-01-13T10:08:33+01:00 New Revision: 7c4a70f8f6f37c0d22770fa60e079aaf8928a01c URL: https://github.com/llvm/llvm-project/commit/7c4a70f8f6f37c0d22770fa60e079aaf8928a01c DIFF: https://github.com/llvm/llvm-project/commit/7c4a70f8f6f37c0d22770fa60e079aaf8928a01c.diff L

[PATCH] D141596: [Driver] Add crtfastmath.o on Solaris if appropriate

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c4a70f8f6f3: [Driver] Add crtfastmath.o on Solaris if appropriate (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141596/new/ https://revie

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. We are interested in proper support for `Zicsr` and `Zifencei`. Could someone look at patch or explain why these extensions were included by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://re

[PATCH] D141598: [clang] Redefine some AVR specific macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG16f9451b0761: [clang] Redefine some AVR specific macros (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141598/new/ https://reviews.l

[clang] 16f9451 - [clang] Redefine some AVR specific macros

Author: Ben Shi Date: 2023-01-13T17:22:15+08:00 New Revision: 16f9451b07619cd84e0b88ff17ca2b27a2c1f9cc URL: https://github.com/llvm/llvm-project/commit/16f9451b07619cd84e0b88ff17ca2b27a2c1f9cc DIFF: https://github.com/llvm/llvm-project/commit/16f9451b07619cd84e0b88ff17ca2b27a2c1f9cc.diff LOG:

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

TWeaver abandoned this revision. TWeaver added a comment. Hi all, thanks for your time and effort reviewing this patch. I'm going to close this now due to the lack of interest in it's current form. thanks again and happy coding, Tom CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136156

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

owenpan added a comment. In D141230#4048069 , @seanptmaher wrote: > The use case I was using this with was running diff formatting of very large > diffs (automated mass refactors changing thousands of files) on the chromium > codebase -- I'm not sure h

[PATCH] D141608: [include-cleaner] Don't consider the underlying type of Decltype MemberProvider as a use

kadircet added a comment. I am a little skeptical about this one. I think it's somewhat an obscure pattern, and probably warrants a use of the type when it can be deduced and the user code is accessing members (relying on the type more than an opaque manner). So what about waiting on this patch

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

owenpan added a reviewer: rymiel. owenpan added a comment. We should get this patch landed. Can we use `Michael Kirk ` as the author (see the same/similar patch at https://bugs.llvm.org/show_bug.cgi?id=28654) because @Eitot hasn't responded for quite some time now? Repository: rG LLVM Githu

[PATCH] D140547: Perform access checking to private members in simple requirement.

uabelho added a comment. Hi, When I run the new testcase clang/test/SemaCXX/invalid-requirement-requires-expr.cpp with ASAN binaries the test fails like FAIL: Clang :: SemaCXX/invalid-requirement-requires-expr.cpp (1 of 1) TEST 'Clang :: SemaCXX/invalid-requirement-req

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik added a comment. In D141572#4050492 , @ChuanqiXu wrote: > @philnik when I run `ninja libcxx-generate-files` locally, it says `ninja: > error: unknown target 'libcxx-generate-files'`. The following off is my > configuring command: > > cmake -G

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

sebastian-ne added a comment. The debian pre-checkin test is unfortunately quite unstable. I see the same failures in D141469 for example. This looks good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14153

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 488914. tblah added a comment. Updating patch context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files: clang/docs/tools/clang-formatted-files.txt flang/includ

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 488916. 4vtomat marked 8 inline comments as done. 4vtomat added a comment. [NFC] Refactor the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/tes

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 488918. 4vtomat added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.r

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. (This needs to run the updated dump script from D138446 ) I'm not sure what the strict //benefit// of squishing the two options together is, but I support it

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 488924. 4vtomat added a comment. NFC, refactoring the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Fixes https://github.com/llvm/llvm-project/issues/59927 Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++20 is more strict when erroring out due to incomplete types. Thus

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

ilya-biryukov added a reviewer: kadircet. ilya-biryukov added a subscriber: kadircet. ilya-biryukov added a comment. There is potentially a way to move less code by keeping all declarations at place and only moving bodies of definitions of constructors and destructors to the `.cpp` file. Not sur

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat added a comment. Since there's some accidentally pushed code. The old revision is moved to this one, sorry.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 __

[PATCH] D140547: Perform access checking to private members in simple requirement.

ilya-biryukov added a comment. In D140547#4050752 , @uabelho wrote: > Anyone else see this? I have not checked, but I would not be surprised if we hit the stack size limits with asan enabled @usaxena95, maybe reduce the number of instantiations from `10

[PATCH] D141459: [RISCV] Use Zvl*b as a lower bound for VScaleRange.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141459/new/ https://reviews.llvm.org/D141459 ___

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

tbaeder updated this revision to Diff 488935. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140668/new/ https://reviews.llvm.org/D140668 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

tbaeder updated this revision to Diff 488936. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140668/new/ https://reviews.llvm.org/D140668 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:203 + const FileEntry *IncludedHeader, + std::optional StandardHeader) { if (ExportStack.empty()) just saying `StandardHead

[PATCH] D141608: [include-cleaner] Don't consider the underlying type of Decltype MemberProvider as a use

hokein added a comment. In D141608#4050739 , @kadircet wrote: > I am a little skeptical about this one. I think it's somewhat an obscure > pattern, and probably warrants a use of the type when it can be deduced and > the user code is accessing members (

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 488943. ccotter added a comment. - Finish stengthening CHECK-FIXES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files: clang-tools-extra/clang-tidy/cppcoreguide

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter marked 2 inline comments as done. ccotter added a comment. Thanks for pointing that out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 ___ cfe-commits

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter added a comment. My latest update to the diff was the result of a rebase, then addressing the final comments. What I've been doing is something like git pull upstream main --rebase # make more edits git commit -am arc diff --update D141133 upstream/main I'm not sure if this

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

kadircet added a comment. In D141671#4050928 , @ilya-biryukov wrote: > There is potentially a way to move less code by keeping all declarations at > place and only moving bodies of definitions of constructors and destructors > to the `.cpp` file. > Not

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 15 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} erichkeane wrote: > Note tha

[PATCH] D141307: [WIP] Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 488949. Leporacanthicus added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. > What happens with code like this > > void foo(bar&& B) { > std::move(B); > } My new check does not flag this function, although it looks like another check flagged the move expression: `ignoring return value of function declared with const attribute [clang-dia

Re: [PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

I'll try and look into it this weekend and have some sort of updated news for you by monday? Faisal Vali On Thu, Jan 12, 2023 at 10:40 PM Shafik Yaghmour via Phabricator < revi...@reviews.llvm.org> wrote: > shafik added a comment. > > Is this PR still workable or does it need a major rework and

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1293 Actions.PushLambdaScope(); + Actions.ActOnLambdaIntroducer(Intro, getCurScope()); aaron.ballman wrote: > Typically, we call an `ActOn` method after having parsed the construct

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman added a comment. In D139705#4050216 , @v1nh1shungry wrote: > If this patch is okay to land, could you please help me commit it? Thanks a > lot! I'm happy to, what name and email address would you like used for patch attribution? Alternat

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12488 + // FIXME: The invoke isn't applying the right attributes either + llvm::AttrBuilder KernelAttrs(C, CGF.CurFn->getAttributes().getFnAttrs()); + KernelAttrs.addAttribute("enqueued-block"); ---

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp added a comment. In D141133#4051068 , @ccotter wrote: > My latest update to the diff was the result of a rebase, then addressing the > final comments. What I've been doing is something like > > git pull upstream main --rebase > # make m

[PATCH] D135658: demangle OptFunction trace names

Trass3r updated this revision to Diff 488959. Trass3r added a comment. I can only refer to my last comment, even in latest trunk that code is still active for the codegen passes. But meanwhile I found the corresponding new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg added a comment. > Having as few code in headers as possible is the general style guide in LLVM, > so I'd rather err towards that and put definitions out-of-line as much as > possible. Therefore if we can getaway by just moving definitions out-of-line, > while keeping rest of the hea

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. > I'm happy to, what name and email address would you like used for patch > attribution? I'd like "v1nh1shungry" and "v1nh1shun...@outlook.com". Thank you! > Alternatively, it seems that you've had a few patches accepted in the > project, so you could apply for co

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman added a comment. In D139705#4051178 , @v1nh1shungry wrote: >> I'm happy to, what name and email address would you like used for patch >> attribution? > > I'd like "v1nh1shungry" and "v1nh1shun...@outlook.com". Thank you! > >> Alternatively

[clang] eaa1f46 - [clang][NFC] Remove dependency on DataLayout::getPrefTypeAlignment

Author: Guillaume Chatelet Date: 2023-01-13T13:19:19Z New Revision: eaa1f46f11f523104be54de058e812c9d7059819 URL: https://github.com/llvm/llvm-project/commit/eaa1f46f11f523104be54de058e812c9d7059819 DIFF: https://github.com/llvm/llvm-project/commit/eaa1f46f11f523104be54de058e812c9d7059819.diff

[clang] 84e3fdc - Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

Author: Takuya Shimizu Date: 2023-01-13T08:21:41-05:00 New Revision: 84e3fdc019412adc09b18a49063e006bd6e7efaa URL: https://github.com/llvm/llvm-project/commit/84e3fdc019412adc09b18a49063e006bd6e7efaa DIFF: https://github.com/llvm/llvm-project/commit/84e3fdc019412adc09b18a49063e006bd6e7efaa.diff

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

aaron.ballman closed this revision. aaron.ballman added a comment. In D140860#4050402 , @hazohelet wrote: > I added the release note. > >> Also, do you need someone to commit on your behalf? If so, what name and >> email address would you like used for p

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 'Params' is a member of the ByteCodeEmitter. We o

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:451 +- Add ``-Wcompare-function-pointers`` to warn about comparisons that may have + their behavior change when using ``icf=all``. aaron.ballman wrote: > This makes it more clear this

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal added a comment. Hi @shafik! Thanks for the review. I don't have commit access and am unsure what I should do to get this committed. Can you let me know what I need to do next? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ ht

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

aaron.ballman added a comment. > Add something like a bool IsDefaulted somewhere in Clang, e.g., in > TemplateArgument and consult it from the TypePrinter. This would be much > simpler but requires adding a field on one of the Clang types I think this might be worth exploring as a cleaner solut

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12488 + // FIXME: The invoke isn't applying the right attributes either + llvm::AttrBuilder KernelAttrs(C, CGF.CurFn->getAttributes().getFnAttrs()); + KernelAttrs.addAttribute("enqueued-block"); ---

[PATCH] D131858: [clang] Track the templated entity in type substitution.

aaron.ballman added a comment. In D131858#4050112 , @rsmith wrote: > In D131858#3957630 , @arphaman > wrote: > >> This change has caused a failure in Clang's stage 2 CI on the green dragon >> Darwin CI: >> http

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg updated this revision to Diff 488976. massberg added a comment. Clean up code and only mode definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 Files: clang-tools-extra/clang-doc/Repre

[PATCH] D141671: Move definitions to prevent incomplete types.

massberg added a comment. I have updated the code. It turned out that much less code has to be moved than I initially thought. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 _

[PATCH] D141240: [SVE][Builtins] Add metadata to intrinsic calls for builtins that don't define the result of inactive lanes.

paulwalker-arm added a comment. Just a heads up that I'm likely to abandon this patch because as predicted implementing dedicated intrinsics is looking like the better design and most all the code generation plumbing is already present and so even the implementation is minimal. Repository:

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4051336 , @aaron.ballman wrote: > In D131858#4050112 , @rsmith wrote: > >> In D131858#3957630 , @arphaman >> wrote: >> >>> This ch

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. @arphaman I see you're part of the original report too, if you could try to revert the workaround and test it, it would be nice too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D13

[PATCH] D131858: [clang] Track the templated entity in type substitution.

aaron.ballman added a comment. In D131858#4051352 , @erichkeane wrote: > In D131858#4051336 , @aaron.ballman > wrote: > >> In D131858#4050112 , @rsmith wrote: >> >>> In

[PATCH] D141547: Fix format for `case` in .proto files

fowles updated this revision to Diff 488979. fowles added a comment. Move from lit test to unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/ https://reviews.llvm.org/D141547 Files: clang/lib/Format/UnwrappedLineParser.cpp cla

[PATCH] D140547: Perform access checking to private members in simple requirement.

erichkeane added a subscriber: aaron.ballman. erichkeane added a comment. In D140547#4050936 , @ilya-biryukov wrote: > In D140547#4050752 , @uabelho wrote: > >> Anyone else see this? > > I have not checked, but I

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor things you can correct when landing. Comment at: clang/bindings/python/clang/cindex.py:1550-1557 +class Foo { +

Re: r241356 - StmtIterator: Put stmt and decl group pointer into a union.

___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D6376: Fix JSON compilation database command unescaping.

___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. The most recent versions of this patch contains squashed changes from these reviews: - D139278 "[AArch64] Use string comparison for ArchInfo equality." This fixes the test failures with shared libraries, which were caused by each sh

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. Worth noting that this had to be reworked because both D127812 and D137838 went in since this was reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. This fixes #57170 (59771 was closed as a dupe of that one). I think this LG, but I'd appreciate a second set of eyes on it as there have been plenty of changes in this area recently. Repository: rG LLVM Github Monorep

[PATCH] D141671: Move definitions to prevent incomplete types.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! (btw, i know it's too late already, but in theory clangd has a code action called move definition out-of-line, could help with such refactorings in the future, if you didn't

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

mstorsjo updated this revision to Diff 488982. mstorsjo added a comment. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, mgester

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} pmatos wrote: > erichkeane wrote: > > Note that it seems this is l

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

erichkeane added a comment. I think that makes sense to me, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140838/new/ https://reviews.llvm.org/D140838 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

jrtc27 added a comment. Because they used to be part of I and then a later version of the RISC-V spec split them out in an incompatible way. GCC/binutils bit the bullet and split them out last(?) year but LLVM has yet to make that breaking change. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein updated this revision to Diff 488985. hokein added a comment. Check for the ActOnTemplatedFriendTag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141580/new/ https://reviews.llvm.org/D141580 Files: clang/lib/Parse/ParseDeclCXX.cpp clan

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

hokein added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2069-2078 +if (auto *TagDecl = Actions.ActOnTag( +getCurScope(), TagType, TUK, StartLoc, SS, Name, NameLoc, attrs, AS, +DS.getModulePrivateSpecLoc(), TParams, Owned, IsDependen

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes GH#53983. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141690 Files: clang/lib/Code

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. Note, I just did the revert of the workaround myself here: 498bf3424d011235d420e02e80e135fae646d537 I won't see the failure on https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/ until Tue

[PATCH] D141671: Move definitions to prevent incomplete types.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM! Looks much cleaner now, BTW. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 ___ cfe-

[PATCH] D141690: [clang] fix consteval ctor code generation assert

luken-google added a comment. See: https://github.com/llvm/llvm-project/issues/53983 I can add a release note and some testing, but wanted feedback that this was the right approach. The problem is when generating code for the constructor for the `bar` element inside of `MyStruct`, `Dest` has an

[clang] bf5c17e - [clang][NFC] Remove dependency on DataLayout::getPrefTypeAlignment

Author: Guillaume Chatelet Date: 2023-01-13T15:01:29Z New Revision: bf5c17ed0f402f603782d28264dab1157994c43d URL: https://github.com/llvm/llvm-project/commit/bf5c17ed0f402f603782d28264dab1157994c43d DIFF: https://github.com/llvm/llvm-project/commit/bf5c17ed0f402f603782d28264dab1157994c43d.diff

[PATCH] D141690: [clang] fix consteval ctor code generation assert

ilya-biryukov added a comment. The change seems reasonable. Could you add a test with a crasher repro and some validation of the generated IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141690/new/ https://reviews.llvm.org/D141690

[PATCH] D138792: [AArch64] Improve TargetParser API

pratlucas accepted this revision. pratlucas added a comment. LGTM with a tiny nit. Feel free to fix it when landing the changes. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:164-166 + CPUFeatures CPUFeature; // ? + StringRef DependentFeatures; //

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

v1nh1shungry added a comment. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140838/new/ https://reviews.llvm.org/D140838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

hokein updated this revision to Diff 488995. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141670/new/ https://reviews.llvm.org/D141670 Files: clang-tools-extra/in

[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:203 + const FileEntry *IncludedHeader, + std::optional StandardHeader) { if (ExportStack.empty()) kadircet wrote: > just sayi

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 488996. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/

[clang] 18b0d2c - [analyzer] Fix a FIXME. NFCI

Author: Benjamin Kramer Date: 2023-01-13T16:15:16+01:00 New Revision: 18b0d2c5d9762070f7c579f2e7ecaa105db7 URL: https://github.com/llvm/llvm-project/commit/18b0d2c5d9762070f7c579f2e7ecaa105db7 DIFF: https://github.com/llvm/llvm-project/commit/18b0d2c5d9762070f7c579f2e7ecaa105db7.dif

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488999. pmatos added a comment. Fix tests after changing name mangling and error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:3-35 +// NOLINTBEGIN +namespace std { +template +struct remove_reference; + +template +struct remove_reference { njames

[clang-tools-extra] e435f56 - [include-cleaner] Remove a stale FIXME.

Author: Haojian Wu Date: 2023-01-13T16:26:27+01:00 New Revision: e435f56815435422a63f5e9e9aad6959428e96c2 URL: https://github.com/llvm/llvm-project/commit/e435f56815435422a63f5e9e9aad6959428e96c2 DIFF: https://github.com/llvm/llvm-project/commit/e435f56815435422a63f5e9e9aad6959428e96c2.diff LO

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 489005. pmatos added a comment. Rename test that still had tables in its name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTCont

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

Backl1ght created this revision. Backl1ght added reviewers: MyDeveloperDay, rymiel. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix https://github.com/llvm/

[PATCH] D141690: [clang] fix consteval ctor code generation assert

ilya-biryukov added a subscriber: jyknight. ilya-biryukov added a comment. Sorry, didn't see your comment when submitting mine. I think the offending code is clearly wrong here and adding the `isLayoutIdentical` seems like the right thing to do. This looks like a small change and I'm happy to L

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:3-35 +// NOLINTBEGIN +namespace std { +template +struct remove_reference; + +template +struct remove_reference { ccotte

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 489007. ccotter added a comment. - two more tests - Minimize test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcoreguideli

[clang-tools-extra] f88c6b9 - Move definitions to prevent incomplete types.

Author: Jens Massberg Date: 2023-01-13T16:44:49+01:00 New Revision: f88c6b9166f885e7089cb15095e38868aaba04da URL: https://github.com/llvm/llvm-project/commit/f88c6b9166f885e7089cb15095e38868aaba04da DIFF: https://github.com/llvm/llvm-project/commit/f88c6b9166f885e7089cb15095e38868aaba04da.diff

[PATCH] D141671: Move definitions to prevent incomplete types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf88c6b9166f8: Move definitions to prevent incomplete types. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >