massberg added a comment.


> Having as few code in headers as possible is the general style guide in LLVM, 
> so I'd rather err towards that and put definitions out-of-line as much as 
> possible. Therefore if we can getaway by just moving definitions out-of-line, 
> while keeping rest of the header ordering the same, let's go with that if 
> it's feasible

Thanks! I will check if I can get a version without reordering.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141671/new/

https://reviews.llvm.org/D141671

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to