[PATCH] D140294: clang: Replace implementation of __builtin_isnormal

sepavloff added a comment. This change can have negative consequences in some cases. Some targets have dedicated instruction to test FP class and often this instruction is faster than arithmetic operations. Replacement of one operation with two arithmetic and two logic plus cost of FP constant

[clang] 301f3da - [CLANG] Fix typo in test/CodeGen/c-strings.c

Author: Muhammad Omair Javaid Date: 2022-12-20T13:59:16+05:00 New Revision: 301f3da5162499965287338a0cd52309fb28e8b8 URL: https://github.com/llvm/llvm-project/commit/301f3da5162499965287338a0cd52309fb28e8b8 DIFF: https://github.com/llvm/llvm-project/commit/301f3da5162499965287338a0cd52309fb28e8

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#4000612 , @MoritzS wrote: > In D122215#3998105 , @pmatos wrote: > >> In D122215#3991648 , @MoritzS >> wrote: >> >>> Thanks for the patc

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

BeMg updated this revision to Diff 484180. BeMg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139995/new/ https://reviews.llvm.org/D139995 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h clang/lib/Sema/SemaRIS

[clang] 0d4c650 - [RISCV] Refactor RVV Policy by structure

Author: Piyou Chen Date: 2022-12-20T01:13:13-08:00 New Revision: 0d4c6506100b339311283c10d841d7693287666a URL: https://github.com/llvm/llvm-project/commit/0d4c6506100b339311283c10d841d7693287666a DIFF: https://github.com/llvm/llvm-project/commit/0d4c6506100b339311283c10d841d7693287666a.diff LO

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d4c6506100b: [RISCV] Refactor RVV Policy by structure (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D140377: [clang][Interp] Compound assign operators for FP values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik, sepavloff. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not quite sure I got the different

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske abandoned this revision. balazske added a comment. A new solution is in D135247 . The new approach is that only `StdLibraryFunctionsChecker` adds the errno modeling part, together with other checks (that are applicable if StreamChecker is turned off) f

[PATCH] D140379: [clangd] Avoid triggering linkage computation for decl with unstable linkage in SymbolRelevanceSignals::computeASTSignals()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes htt

[PATCH] D140379: [clangd] Avoid triggering linkage computation for decl with unstable linkage in SymbolRelevanceSignals::computeASTSignals()

nridge added inline comments. Comment at: clang-tools-extra/clangd/Quality.cpp:306 if (const NamedDecl *ND = SemaResult.getDeclaration()) { +if (hasUnstableLinkage(ND)) + return; Would it be better to reuse [this getSymbolID overload](https://searchf

[PATCH] D132249: [clang][analyzer] Add some functions to StreamChecker with errno modeling.

balazske abandoned this revision. balazske added a comment. See D135247 and related for a new solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132249/new/ https://reviews.llvm.org/D132249 _

[PATCH] D140380: [include-cleaner] Respect IWYU pragmas during analyze

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140380 Fi

[PATCH] D140195: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

jmmartinez added a comment. In D140195#4001989 , @aprantl wrote: > How does this affect the generated DWARF? Have you tested that this does the > right thing in LLDB? It shouldn't affect the generated DWARF on LLVM's main branch. Currently, LLVM relies

[PATCH] D140380: [include-cleaner] Respect IWYU pragmas during analyze

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:184 #include "b.h" +#include "keep.h" // IWYU pragma: keep add the `export` c

[PATCH] D140380: [include-cleaner] Respect IWYU pragmas during analyze

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:184 #include "b.h" +#include "keep.h" // IWYU pragma: keep hokein wrote: > add the `export` case as well. i don't think we should be testing the behaviour

[PATCH] D140380: [include-cleaner] Respect IWYU pragmas during analyze

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb76cc30e1585: [include-cleaner] Respect IWYU pragmas during analyze (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang-tools-extra] b76cc30 - [include-cleaner] Respect IWYU pragmas during analyze

Author: Kadir Cetinkaya Date: 2022-12-20T10:47:22+01:00 New Revision: b76cc30e15855bf3ed094e680448e08e42e7d99d URL: https://github.com/llvm/llvm-project/commit/b76cc30e15855bf3ed094e680448e08e42e7d99d DIFF: https://github.com/llvm/llvm-project/commit/b76cc30e15855bf3ed094e680448e08e42e7d99d.dif

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:772 + + if ((Exts.count("zvkb") || Exts.count("zvknhb")) && !Exts.count("zve64x")) +return createStringError( With this check, the check for these extensions on top are redundant. =

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

eopXD added inline comments. Comment at: llvm/test/MC/RISCV/rvv/rv64zvksed_invalid.s:1 +# RUN: not llvm-mc -triple=riscv64 --mattr=+zve32x --mattr=+experimental-zvksed -show-encoding %s 2>&1 \ +# RUN:| FileCheck %s --check-prefix=CHECK-ERROR I see simila

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 added a comment. On 32-bit / 64-bit machines, a function returning lower types (via a register) should an explicit sign/zero extension to full fill the register. But on AVR, a 8-bit register is used to return 8-bit values, so the sign/zero extension is unnecessary, and lead to extra u

[clang] d20101d - [clang][NFC] Clean up createDefaultOutputFile()

Author: Timm Bäder Date: 2022-12-20T11:29:44+01:00 New Revision: d20101db48945e9d7a19ce3edcfd91d7e1aeadab URL: https://github.com/llvm/llvm-project/commit/d20101db48945e9d7a19ce3edcfd91d7e1aeadab DIFF: https://github.com/llvm/llvm-project/commit/d20101db48945e9d7a19ce3edcfd91d7e1aeadab.diff LO

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

Miss_Grape added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139908/new/ https://reviews.llvm.org/D139908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] 1953c7e - [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion

Author: eopXD Date: 2022-12-20T02:35:10-08:00 New Revision: 1953c7e03b086e0680545980ef1c9461a7513e29 URL: https://github.com/llvm/llvm-project/commit/1953c7e03b086e0680545980ef1c9461a7513e29 DIFF: https://github.com/llvm/llvm-project/commit/1953c7e03b086e0680545980ef1c9461a7513e29.diff LOG: [N

[PATCH] D139025: [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion

This revision was automatically updated to reflect the committed changes. Closed by commit rG1953c7e03b08: [NFC][RISCV] Extract utility to calculate value through MajorVersion and… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[clang] 1a24bbe - Revert "[clang][NFC] Clean up createDefaultOutputFile()"

Author: Timm Bäder Date: 2022-12-20T11:46:09+01:00 New Revision: 1a24bbeefd2ad29e579f871144cfb17a4afb4320 URL: https://github.com/llvm/llvm-project/commit/1a24bbeefd2ad29e579f871144cfb17a4afb4320 DIFF: https://github.com/llvm/llvm-project/commit/1a24bbeefd2ad29e579f871144cfb17a4afb4320.diff LO

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. This caused an issue in the libc benchmarks, fix here: 2a261a7b5764 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D1

[PATCH] D137838: [Support] Move TargetParsers to new component

barannikov88 added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:11 +/// This header is deprecated in favour of +/// `llvm/TargetParser/AArch64TargetParser.h`. /// Invalid comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 484210. Sockke added a comment. Added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/test/clang-

[PATCH] D140379: [clangd] Avoid triggering linkage computation for decl with unstable linkage in SymbolRelevanceSignals::computeASTSignals()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Quality.cpp:306 if (const NamedDecl *ND = SemaResult.getDeclaration()) { +if (hasUnstableLinkage(ND)) + return;

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 484212. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/

[PATCH] D140294: clang: Replace implementation of __builtin_isnormal

arsenm added a comment. In D140294#4007073 , @sepavloff wrote: > This change can have negative consequences in some cases. Some targets have > dedicated instruction to test FP class and often this instruction is faster > than arithmetic operations. Repl

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary marked an inline comment as done. lenary added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:11 +/// This header is deprecated in favour of +/// `llvm/TargetParser/AArch64TargetParser.h`. /// barannikov88 wrote: > Invalid comment. Fixed in h

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb7940e25f6c: [llvm] Make llvm::Any similar to std::any (authored by sebastian-ne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bb7940e - [llvm] Make llvm::Any similar to std::any

Author: Sebastian Neubauer Date: 2022-12-20T13:28:30+01:00 New Revision: bb7940e25f6ca201ca57943544016390f1d2e504 URL: https://github.com/llvm/llvm-project/commit/bb7940e25f6ca201ca57943544016390f1d2e504 DIFF: https://github.com/llvm/llvm-project/commit/bb7940e25f6ca201ca57943544016390f1d2e504.

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

Roelio81 added a comment. Herald added a project: All. This change also has impact which was undesired on our code base as it now considers all attributes to be "bound" to the if-expression rather than to the if-body. For example, we had this in our code base if (condition) [[maybe_unuse

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 484217. 4vtomat added a comment. Update to final draft 20221208 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-features

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. Couple of nits, since you will be updating this anyway after dropping D140221 , otherwise LGTM. Comment at: clang/lib/Sema/SemaChecki

[PATCH] D140389: [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140389: [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD added a comment. Just throwing out the question here, I would be happy to rename it to anything else that makes sense rather than the current. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 __

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary marked an inline comment as done. lenary added a comment. Another fixup for the llvm examples was required, landed in https://reviews.llvm.org/rG16c4c4e04c14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 484224. 4vtomat added a comment. Address Eop's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-features.c llv

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

kito-cheng added a comment. Ken has updated spec to clarify requirements of those vector crypto extensions: https://github.com/riscv/riscv-crypto/commit/40695306f628e6dc764d1d0f35392eac792d2c3b These Vector Crypto Extensions can be built on any RISC-V base. However, XLEN=32 implementations

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 484226. 4vtomat added a comment. Correct OPERAND_LAST_RISCV_IMM in OperandType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

Szelethus added a reviewer: gamesh411. Szelethus added a comment. Some of the changes are also present in D135247 . I suppose you're in the middle of splitting those patches apart and remaking the patch stack? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. And a fixup for the compiler-rt symbolizer: https://reviews.llvm.org/rGecaab107e4d0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___

[PATCH] D140395: [clang][analyzer] Extend StreamChecker with some new functions.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. Thanks @efriedma , I'm wait to see if there is any objection before landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 ___ cf

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske added a comment. The changes D135360 and D135247 are now replaced by D140387 and D140395 . The two new patches together add out almost the same co

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGebe530ef7a49: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record… (authored by yronglin). Repo

[clang] ebe530e - [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

Author: yronglin Date: 2022-12-20T22:06:01+08:00 New Revision: ebe530ef7a49988a531a8928eac3ce0925f1c199 URL: https://github.com/llvm/llvm-project/commit/ebe530ef7a49988a531a8928eac3ce0925f1c199 DIFF: https://github.com/llvm/llvm-project/commit/ebe530ef7a49988a531a8928eac3ce0925f1c199.diff LOG:

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. commit in ebe530ef7a49988a531a8928eac3ce0925f1c199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

balazske added a comment. This patch and D140395 is (almost) the same code as D135360 and D135247 . The changes are separated for the different checkers. Tests are added at the second patch.

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1683 -if (Tok->isOneOf(tok::kw_class, tok::kw_enum, tok::kw_concept, -

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks added a comment. In D140312#4006106 , @rymiel wrote: > What if I make this depend on D140339 ? > Then this change would no longer impact concept definitions. Yep, that would be right. It seems I can't

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno requested changes to this revision. bruno added a comment. This revision now requires changes to proceed. Nice, thanks for adding the builtin layer. Comment at: clang/lib/Sema/SemaChecking.cpp:7808 +/// Handle __builtin_assume_separate_storage. For now this is a no-op, bu

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

BeMg updated this revision to Diff 484251. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

carlosgalvezp added a comment. Now that I think a bit better about this I wonder - does it really make sense that we increase the complexity of the check to cover for cases where code does not compile? If it fails to include a header, there's many other things that can possibly go wrong - shoul

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno added a comment. Additionally, this likely deserves an entry in `./clang/docs/ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 ___ cfe-c

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5009 + if (isStaticInit(D, getLangOpts()) && NeedsGlobalCtor && NeedsGlobalDtor) { +EmitCXXCtorInit(D, GV, true, 201, llvm::StringLiteral("ctor"), false

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484258. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { Do you agree this should be done only when one of those flags is on? CHANGES SI

[PATCH] D137838: [Support] Move TargetParsers to new component

thakis added a comment. Thanks for the heads-up. I updated the GN build in 4ac51dd53d93b8dd18c58093766483c657fe3a08 and 2aa998d22fe09191cd6c1b697e373266c1131502

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" The prefix must remain LLVM_* In other comp

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" barannikov88 wrote: > The prefix must remai

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4007920 , @thakis wrote: > Thanks for the heads-up. I updated the GN build in > 4ac51dd53d93b8dd18c58093766483c657fe3a08 > and > 2aa998d22fe09191cd

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

Szelethus added a comment. In D140387#4007751 , @balazske wrote: > This patch and D140395 is (almost) the > same code as D135360 and D135247 > . The

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484278. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/test/CodeGenCXX/PR19955.cpp:20 +// CHECK-64: store ptr @"?var@@3HA", ptr @"?varp@@3PEAHEA" +// CHECK: ret void @rnk was concerned about varp pointing to dllimport var. That does it I think. CHANGES SINCE LAS

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary edited the summary of this revision. lenary updated this revision to Diff 484281. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/D140222 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/He

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary marked 3 inline comments as done. lenary added a comment. Nits addressed. Will land in the new year, when I'm back at work. Right now it's time for a break! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484283. fpetrogalli added a comment. Herald added a subscriber: pengfei. This update is not based anymore on D137516 , but uses the refactoring of `TargetParser` as part of `LLVMSupport` into the new component `LLVMTarge

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli abandoned this revision. fpetrogalli added a comment. Replaced by D137838 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137516/new/ https://reviews.llvm.org/D137516 ___

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. In D139986#4005997 , @dblaikie wrote: > In D139986#4003873 , @Mordante > wrote: > >> In D139986#4001180 , @Michael137 >> wrote: >> >>> Missed c

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 484290. koops added a comment. Taking care of : 1. "The nowait clause may only appear on a taskwait directive if the depend clause is present.". 2. "Please do not add any new tests using -no-opaque-pointers". 3. Added a new test to expect failure for point 1.

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

hans added a comment. This seems to have broken the instrprof-darwin-exports.c test, see e.g. https://green.lab.llvm.org/green/job/clang-stage1-RA/32351/ I'll revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139938/new/ https://revie

[clang] 49dd02b - Revert "[clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin"

Author: Hans Wennborg Date: 2022-12-20T17:45:07+01:00 New Revision: 49dd02bd081901db6011bdbe676573bfd5482627 URL: https://github.com/llvm/llvm-project/commit/49dd02bd081901db6011bdbe676573bfd5482627 DIFF: https://github.com/llvm/llvm-project/commit/49dd02bd081901db6011bdbe676573bfd5482627.diff

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1818-1857 +// int fgetpos(FILE *restrict stream, fpos_t *restrict pos); +// From 'The Open Group Base Specifications Issue 7, 2018 edition': +// "The fgetpos(

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) Why do we need to touch CMake file that aren't RISC-V? ===

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

ABataev accepted this revision. ABataev added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. Can you please update `llvm/include/llvm/module.modulemap` for this change or revert the patch? This is breaking all bots that build with `-DLLVM_ENABLE_MODULES=On`. For example: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/lastFailedBuild/consoleFull#1110

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

paulkirth added a comment. Hi, we're seeing a build failure in Fuchsia's Clang CI. We're seeing this on all of our builders: arm64 & x64 linux, mac and windows FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir/cpu_model.c.o /b/s/w/ir/x/w/recipe_cleanup/cxx-rbevgw5lbzc/reclient-cxx-wrapper.sh

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4008443 , @aprantl wrote: > Can you please update `llvm/include/llvm/module.modulemap` for this change or > revert the patch? This is breaking all bots that build with > `-DLLVM_ENABLE_MODULES=On`. > > For example: >

[PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. I think I fixed it in a685bb8e333e , but please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D1

[PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. Sorry, I pasted in the wrong hash: 6bdf378dcd349d97152846bb687c1d1de511d138 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.ll

[clang] 2cf550a - Add missing textual header to module map

Author: Adrian Prantl Date: 2022-12-20T10:05:55-08:00 New Revision: 2cf550a80a0177f8a1aa9ae45c40b0d17ef7f11d URL: https://github.com/llvm/llvm-project/commit/2cf550a80a0177f8a1aa9ae45c40b0d17ef7f11d DIFF: https://github.com/llvm/llvm-project/commit/2cf550a80a0177f8a1aa9ae45c40b0d17ef7f11d.diff

[clang] e9babe7 - [OpenMP] Clang Support for taskwait nowait clause

Author: Sunil Kuravinakop Date: 2022-12-20T12:13:56-06:00 New Revision: e9babe7571609c9de41d4d0dfc1bc4d2f02021d0 URL: https://github.com/llvm/llvm-project/commit/e9babe7571609c9de41d4d0dfc1bc4d2f02021d0 DIFF: https://github.com/llvm/llvm-project/commit/e9babe7571609c9de41d4d0dfc1bc4d2f02021d0.d

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9babe757160: [OpenMP] Clang Support for taskwait nowait clause (authored by koops, committed by cchen). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9cd6fbe - Fix module build after TargetParser

Author: Steven Wu Date: 2022-12-20T10:31:19-08:00 New Revision: 9cd6fbee7ed881f8e80b735e95567040e56f189e URL: https://github.com/llvm/llvm-project/commit/9cd6fbee7ed881f8e80b735e95567040e56f189e DIFF: https://github.com/llvm/llvm-project/commit/9cd6fbee7ed881f8e80b735e95567040e56f189e.diff LOG

[PATCH] D137838: [Support] Move TargetParsers to new component

steven_wu added a comment. Also needed a follow up fix to completely fix module `9cd6fbee7ed8` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___ cfe-commits m

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added a comment. Thanks for the rebase! Nit: I'd just replace `std::function` with `auto` as it saves us repeating the parameter types (and `#include `). Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:617 + // Printers that print extent into OS and sets ExtKnow

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. I'm working on a follow-up, which should make the split a bit clearer, but I'm also not a modulemap expert and the `-DLLVM_ENABLE_MODULES=On` configuration is broken on my linux dev box. I'll post it for review if those two patches have at least made the build greener.

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

lenary added a comment. One comment on the build changes, I don't have opinions on the RISC-V changes. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/)

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. Hi - gentle ping on reviewing this Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) lenary wrote: > craig.topper wrote: >

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) fpetrogalli wrote: > lenary wrote: > > craig.topper wrote: > > > Why

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) craig.topper wrote: > fpetrogalli wrote: > > lenary wrote: > > > crai

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. Sorry for the delay here; this patch LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ cfe-commits mailing list cfe-com

[PATCH] D140195: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. > Unluckly, I wasn't able to test the combination of > https://reviews.llvm.org/D96334 and this patch together. If you have some > pointers about how to trigger a test job on "Green Dragon",

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4008451 , @paulkirth wrote: > Hi, we're seeing a build failure in Fuchsia's Clang CI. We're seeing this on > all of our builders: arm64 & x64 linux, mac and windows > > FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir

  1   2   >