[PATCH] D140379: [clangd] Avoid triggering linkage computation for decl with unstable linkage in SymbolRelevanceSignals::computeASTSignals()

[Nathan Ridge via Phabricator via cfe-commits]

nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/Quality.cpp:306
   if (const NamedDecl *ND = SemaResult.getDeclaration()) {
+    if (hasUnstableLinkage(ND))
+      return;
----------------
Would it be better to reuse [this getSymbolID 
overload](https://searchfox.org/llvm/rev/ec87b7231586865f7b0adfe22a0d056e40ae9264/clang-tools-extra/clangd/CodeComplete.cpp#606-621)
 instead? (Would require plumbing in a SourceManager to this call site.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140379/new/

https://reviews.llvm.org/D140379

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits