[clang-tools-extra] 0ab57bd - [include-cleaner] Fix the member-expr-access usage for sugar type.

Author: Haojian Wu Date: 2022-12-19T08:48:32+01:00 New Revision: 0ab57bdc9745bfc8147831c09ed05073f87e7040 URL: https://github.com/llvm/llvm-project/commit/0ab57bdc9745bfc8147831c09ed05073f87e7040 DIFF: https://github.com/llvm/llvm-project/commit/0ab57bdc9745bfc8147831c09ed05073f87e7040.diff LO

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG0ab57bdc9745: [include-cleaner] Fix the member-expr-access usage for sugar type. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] 8551563 - [include-cleaner] Fix a missing review comment.

Author: Haojian Wu Date: 2022-12-19T09:14:33+01:00 New Revision: 8551563c0d77e54c3904fa853c32f82649f65fc1 URL: https://github.com/llvm/llvm-project/commit/8551563c0d77e54c3904fa853c32f82649f65fc1 DIFF: https://github.com/llvm/llvm-project/commit/8551563c0d77e54c3904fa853c32f82649f65fc1.diff LO

[PATCH] D140284: [include-cleaner] Base-type usage from member exprs is implicit.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140284 Files:

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:48 NamedDecl *resolveType(QualType Type) { if (Type->isPointerType()) please rebase the patch, this API is changed in https://github.com/llvm/llvm-project/commi

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)`

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300

[clang] 8e029d9 - [CLANG] XFAIL c-strings.c & volatile-1.c AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-12-19T14:03:30+05:00 New Revision: 8e029d9e35092d1440dafc8991e73fb8c3b323d7 URL: https://github.com/llvm/llvm-project/commit/8e029d9e35092d1440dafc8991e73fb8c3b323d7 DIFF: https://github.com/llvm/llvm-project/commit/8e029d9e35092d1440dafc8991e73fb8c3b323

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Also I tried to use it now, and I'm not sure where it is a good idea to allow this tweak from within a function body. Because it is quite annoying that in every function you get this code action. On the other hand maybe it is ok to allow it from within the body, but the

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

iains added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12957-12958 + // units. + if (getLangOpts().CPlusPlus20 && getLangOpts().CPlusPlusModules && + !ModuleScopes.empty() && ModuleScopes.back().Module->isHeaderUnit()) { +if (VDecl->getFormalLinkage() ==

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! The change looks good to me (I assume our internal lit support part is completed). (I think we can do a cleanup in `clang/test/Index` as well). Comment at: llvm/util

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12957-12958 + // units. + if (getLangOpts().CPlusPlus20 && getLangOpts().CPlusPlusModules && + !ModuleScopes.empty() && ModuleScopes.back().Module->isHeaderUnit()) { +if (VDecl->getFormalLinkage()

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 483881. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-too

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:51 Type = Type->getPointeeType(); +if (const TemplateSpecializationType *TST = +Type->getAs()) { hokein wrote: > nit: we can u

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 483882. VitaNuo added a comment. Remove unusued include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

hokein added inline comments. Comment at: llvm/utils/relative_lines.py:45 +for file in args.files: +contents = open(file).read() +failures = 0 it would be nice to make the script more robust (capture and bailout the `UnicodeDecodeError` exception)-- ther

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jsilvanus accepted this revision. jsilvanus added a comment. This revision is now accepted and ready to land. LGTM, but let's wait for the other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 483884. 4vtomat added a comment. Address most of Eric's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-featur

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. Does anyone have any more objections? I'm going to merge it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127812/new/ https://reviews.llvm.org/D127812 ___ cfe-commits mailing lis

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. Just thoughts. llvm::any_isa is usually paired with llvm::any_cast; replacing them with llvm::any_cast and nullptr check seems fine. However, - std::any uses RTTI, so it is unlikely to ever replace llvm::Any. - llvm::any_isa<> is kind of convenient and is aligned w

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar marked an inline comment as done. fahadnayyar added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14115 +/// Analyze the given compound assignment for the possible losing of +/// floating-point precision. aaron.ballman wrote: > Moving

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added inline comments. Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91 assert(parser.has_value()); -assert(llvm::any_isa(parser)); +assert(llvm::any_cast(&parser)); return llvm::any_cast(parser); } This is not intu

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-co

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

uabelho added a comment. Hi, The following starts crashing with this patch: clang -cc1 -analyze -analyzer-checker=core bbi-77010.c It crashes with bbi-77010.c:6:1: warning: non-void function does not return a value [-Wreturn-type] } ^ clang: ../../clang/lib/StaticAnalyzer/Core/Range

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

carlosgalvezp added a comment. Looks good in general, IMHO it would be good with a couple more comments to make the code and test easier to understand. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:63 + if (MatchedDecl->isInvalidDecl())

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jsilvanus added a comment. In D139973#4004344 , @barannikov88 wrote: > - std::any uses RTTI, so it is unlikely to ever replace llvm::Any. I just checked on Godbolt that gcc 12.2 with libstdc++, clang 15.0 with both libstd++ and libc++ and MSVC 19.33 su

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. In D112621#4004372 , @uabelho wrote: > Hi, > > The following starts crashing with this patch: > > clang -cc1 -analyze -analyzer-checker=core bbi-77010.c > > It crashes with > > bbi-77010.c:6:1: warning: non-void function does

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

Szelethus added a comment. In D137790#3992216 , @balazske wrote: > Some reports can be found here > (if the > link works and the data does not expire), the runs stored on 2022-12-09. > >

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

uabelho added a comment. In D112621#4004409 , @steakhal wrote: > In D112621#4004372 , @uabelho wrote: > >> Hi, >> >> The following starts crashing with this patch: >> >> clang -cc1 -analyze -analyzer-checker=cor

[clang] f61a08b - [analyzer] Fix crash inside RangeConstraintManager.cpp introduced by D112621

Author: Balazs Benics Date: 2022-12-19T12:49:43+01:00 New Revision: f61a08b67f5c8b0202dd30821766ee029e880b7c URL: https://github.com/llvm/llvm-project/commit/f61a08b67f5c8b0202dd30821766ee029e880b7c DIFF: https://github.com/llvm/llvm-project/commit/f61a08b67f5c8b0202dd30821766ee029e880b7c.diff

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Static declarations in head

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. In D139973#4004408 , @jsilvanus wrote: > I just checked on Godbolt that gcc 12.2 with libstdc++, clang 15.0 with both > libstd++ and libc++ and MSVC 19.33 support `std::any` without RTTI. > But gcc and clang do not provide

[clang] 658ed95 - Fix host call to nohost function with host variant.

Author: Doru Bercea Date: 2022-12-19T06:13:26-06:00 New Revision: 658ed9547cdd6657895339a6c390c31aa77a5698 URL: https://github.com/llvm/llvm-project/commit/658ed9547cdd6657895339a6c390c31aa77a5698 DIFF: https://github.com/llvm/llvm-project/commit/658ed9547cdd6657895339a6c390c31aa77a5698.diff L

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

doru1004 closed this revision. doru1004 added a comment. Commit 658ed9547cdd6657895339a6c390c31aa77a5698 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140155/new/ https://review

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

TIFitis created this revision. TIFitis added reviewers: kiranchandramohan, clementval, jdoerfert, jsjodin. Herald added subscribers: guansong, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added

[clang] 07ff3c5 - Fix abs labs and llabs to work in C code.

Author: Doru Bercea Date: 2022-12-19T06:28:15-06:00 New Revision: 07ff3c5ccce68aed6c1a270b3f89ea14de7aa250 URL: https://github.com/llvm/llvm-project/commit/07ff3c5ccce68aed6c1a270b3f89ea14de7aa250 DIFF: https://github.com/llvm/llvm-project/commit/07ff3c5ccce68aed6c1a270b3f89ea14de7aa250.diff L

[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193 - OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD, - LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD) }; I am not sure if this ch

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

iains updated this revision to Diff 483909. iains added a comment. rebased, addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140261/new/ https://reviews.llvm.org/D140261 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

doru1004 closed this revision. doru1004 added a comment. Commit: 07ff3c5ccce68aed6c1a270b3f89ea14de7aa250 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://revie

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483910. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.c

[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

iains marked 2 inline comments as done. iains added a comment. OK so this is what I plan to land assuming testing goes OK. I suspect that this might cause some user code to flag errors - there are quite a number of ODR violations "in the wild". Comment at: clang/lib/Sema/SemaD

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483911. VitaNuo added a comment. Add guard calls to headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeader

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:161 +TEST_F(FindHeadersTest, TargetIsArgumentExpandedFromMacroInHeader) { + llvm::Annotations MainFile(R"cpp( h

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added inline comments. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:193 - if (any_isa(IR)) { -const Function *F = any_cast(IR); -return F->getName().str(); + if (const auto **F = any_cast(&IR)) { +return (*F)->getName().str();

[clang-tools-extra] 0e54581 - [include-cleaner] Handle dependent type members in AST.

Author: Viktoriia Bakalova Date: 2022-12-19T12:45:41Z New Revision: 0e545816a9e582af29ea4b9441fea8ed376cf52a URL: https://github.com/llvm/llvm-project/commit/0e545816a9e582af29ea4b9441fea8ed376cf52a DIFF: https://github.com/llvm/llvm-project/commit/0e545816a9e582af29ea4b9441fea8ed376cf52a.diff

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e545816a9e5: [include-cleaner] Handle dependent type members in AST. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. In D112621#4004409 , @steakhal wrote: > In D112621#4004372 , @uabelho wrote: > >> Hi, >> >> The following starts crashing with this patch: >> >> clang -cc1 -analyze -analyzer-checker=co

[PATCH] D139629: clang: Stop emitting "strictfp"

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); arsenm wrote: > andrew.w.kaylor wrote: > > arsenm wrote: > >

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: llvm/utils/relative_lines.py:17 + +USAGE = """Example usage: +find clang/test/CodeCompletion | grep -v /Inputs/ | \ hokein wrote: > This variable is not used in anywhere,

[PATCH] D140294: clang: Replace implementation of __builtin_isnormal

arsenm created this revision. arsenm added reviewers: bkramer, foad, sepavloff, andrew.w.kaylor, kpn. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This was doing an explicit non-canonical isnan check, then two unordered comparisons. We can

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)`

v1nh1shungry added a comment. @nridge Thank you for reviewing! If this patch is ready to land, could you please help me commit it? Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300 _

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

hokein added a comment. thanks, the test looks better now, a few more suggestions. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:162 +struct CustomVisitor : RecursiveASTVisitor { + const Decl *Out = nullptr; Move the definition

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rGcf9b25e0adc4: [lit] Script to automate use of %(line-n). Use in CodeComplete tests. (authored by sammccal

[PATCH] D140295: [Fix][OpenMP] Fix commit for nohost variant.

doru1004 created this revision. doru1004 added reviewers: ABataev, carlo.bertolli, ronl. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscriber

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

hokein added a comment. looks like you forgot to upload the new diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140217/new/ https://reviews.llvm.org/D140217 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

sammccall added a comment. In D140217#4004657 , @hokein wrote: > looks like you forgot to upload the new diff. The changes were trivial/mechanical so I wasn't planning on another round of review, but was waiting for the tests to finish before landing. S

[PATCH] D140294: clang: Replace implementation of __builtin_isnormal

foad added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3308 case Builtin::BI__builtin_isnormal: { -// isnormal(x) --> x == x && fabsf(x) < infinity && fabsf(x) >= float_min +// isnormal(x) --> fabs(x) < infinity && !(fabs(x) < float_min) CodeGenFu

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483926. VitaNuo marked 7 inline comments as done. VitaNuo added a comment. Address most recent review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files:

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483927. VitaNuo added a comment. Remove extra variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

lebedev.ri added a comment. This patch says what it does, but not why it does what it does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140281/new/ https://reviews.llvm.org/D140281 ___ cfe-commits mail

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:219 + /// @param State The state of the generated node. + /// @param Pred The transition will be generated from the specified Pred node + /// to the

[clang] b5c809a - Fix tests for commit 658ed9547cdd6657895339a6c390c31aa77a5698.

Author: Doru Bercea Date: 2022-12-19T07:46:34-06:00 New Revision: b5c809acd34c2489679300eb0b8a8b824aeb URL: https://github.com/llvm/llvm-project/commit/b5c809acd34c2489679300eb0b8a8b824aeb DIFF: https://github.com/llvm/llvm-project/commit/b5c809acd34c2489679300eb0b8a8b824aeb.diff L

[PATCH] D140295: [Fix][OpenMP] Fix commit for nohost variant.

doru1004 closed this revision. doru1004 added a comment. Commit b5c809acd34c2489679300eb0b8a8b824aeb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140295/new/ https://review

Re: [patch] libcxx win32 support

Sent from Mail for Windows ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r189354 - cpp11-migrate: Add a class to support include directives modifications

Sent from Mail for Windows ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:176 +llvm::StringRef DeclareHeader; +llvm::StringRef MacroHeader; + } TestCases[]

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

Szelethus added a comment. In D137790#3992216 , @balazske wrote: > On the postgres results, the second is one that can be fixed in the checker > (add special cases to `StdLibraryFunctionsChecker` for zero `len` or `size` > `fread` and `fwrite` arguments

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske added a comment. Here is a postgers result link

[PATCH] D140300: [lit] Fix a few issues in relative_lines.py

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - fixes error: Line: 91 result += contents[pos:m.start(index)] TypeError: can only conca

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483941. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-too

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang-tools-extra] 81c3739 - [include-cleaner] Use expansion locations for macros.

Author: Viktoriia Bakalova Date: 2022-12-19T14:18:16Z New Revision: 81c3739156fe2e98160fb4364ed78edacc293a68 URL: https://github.com/llvm/llvm-project/commit/81c3739156fe2e98160fb4364ed78edacc293a68 DIFF: https://github.com/llvm/llvm-project/commit/81c3739156fe2e98160fb4364ed78edacc293a68.diff

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81c3739156fe: [include-cleaner] Use expansion locations for macros. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske added a comment. About the first postgres result in pg_backup_tar.c: At step 3 we see that original value of `len` is 1. The condition in step 5 is true, then `th->filelen-th->pos` should be < 1. This is the new value assigned to `len`. In step 6 `len` can be only <=0. Still the conditi

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

Szelethus added a comment. I have a fear that we may have too few results as well -- maybe we should expand our testing infrastructure with more POSIX API heavy codebases. Looking at a few new projects, https://github.com/audacity/audacity looks like a good candidate, but of course it often tur

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); kpn wrote: > arsenm wrote: > > andrew.w.kaylor wrote: > >

[PATCH] D140300: [lit] Fix a few issues in relative_lines.py

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. thank you! I guess I tested this only on files with no matches/bad utf-8 :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140300/new/ htt

[PATCH] D140306: [clang][dataflow] Remove stray lines from `Environment::join`

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Removes an assertion and a useless line. The asser

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

uabelho added a comment. Hello, I noticed that the following crashes with this patch: clang -Weverything bbi-77071.c Result: clang-16: ../../clang/lib/Analysis/UnsafeBufferUsage.cpp:248: void (anonymous namespace)::DeclUseTracker::discoverDecl(const clang::DeclStmt *): Assertion `Defs.co

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:219 + /// @param State The state of the generated node. + /// @param Pred The transition will be generated from the specified Pred node + /// to the

[clang-tools-extra] bf452f9 - [clang-tidy][NFC] Replace custom isStatic matcher with the existing isStaticStorageClass

Author: Carlos Galvez Date: 2022-12-19T15:23:50Z New Revision: bf452f9b347aa0e1f8f368da925b8e1ca27df0c5 URL: https://github.com/llvm/llvm-project/commit/bf452f9b347aa0e1f8f368da925b8e1ca27df0c5 DIFF: https://github.com/llvm/llvm-project/commit/bf452f9b347aa0e1f8f368da925b8e1ca27df0c5.diff LOG:

[PATCH] D139629: clang: Stop emitting "strictfp"

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); arsenm wrote: > kpn wrote: > > arsenm wrote: > > > andrew.w.

[clang] a18cf8d - [clang][dataflow] Remove stray lines from `Environment::join`

Author: Yitzhak Mandelbaum Date: 2022-12-19T15:28:30Z New Revision: a18cf8d14f5552c13bd1cef112ba5b88a7fc75ff URL: https://github.com/llvm/llvm-project/commit/a18cf8d14f5552c13bd1cef112ba5b88a7fc75ff DIFF: https://github.com/llvm/llvm-project/commit/a18cf8d14f5552c13bd1cef112ba5b88a7fc75ff.diff

[PATCH] D140306: [clang][dataflow] Remove stray lines from `Environment::join`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa18cf8d14f55: [clang][dataflow] Remove stray lines from `Environment::join` (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D140307: Match derived types in in modernize-loop-convert

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch allows clang-tidy to rep

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

arsenm updated this revision to Diff 483964. arsenm added a comment. Add unreachable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139564/new/ https://reviews.llvm.org/D139564 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/libcal

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StaticDeclarationInHeaderCheck.cpp:46 +: ClangTidyCheck(Name, Context), + RawStringHeaderFileExtensions(Options.getLocalOrGlobal( + "HeaderFileExtensions", utils::defaultHeaderF

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StaticDeclarationInHeaderCheck.cpp:46 +: ClangTidyCheck(Name, Context), + RawStringHeaderFileExtensions(Options.getLocalOrGlobal( + "HeaderFileExtensions", utils::defaultHeaderFi

[PATCH] D140308: [clang][dataflow][NFC] Fix comments related to widening.

ymandel created this revision. ymandel added reviewers: gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The comments describing the API for analy

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

ahatanak updated this revision to Diff 483973. ahatanak marked an inline comment as done. ahatanak added a comment. Check that the destructor is called conditionally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136639/new/ https://reviews.llvm.or

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

shangwuyao added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1198 -def CUDAGlobal : InheritableAttr { - let Spellings = [GNU<"global">, Declspec<"__global__">]; +def CUDAGlobal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"global">, Declsp

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. Related: https://reviews.llvm.org/D139974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ cfe-commits mailing list cfe-commits

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

ahatanak added inline comments. Comment at: clang/test/CodeGenObjC/nontrivial-c-struct-property.m:89 + +// CHECK: call void @__destructor_8_s0(ptr %[[AGG_TMP_ENSURED]]) + rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > It looks like we're copying `a`

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne updated this revision to Diff 483975. sebastian-ne marked 2 inline comments as done. sebastian-ne added a comment. > It is surprising to me that std::any can work without RTTI. Never thought it > could be implemented. It seems like libstdc++ and libc++ both implement it the way llvm

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne added inline comments. Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91 assert(parser.has_value()); -assert(llvm::any_isa(parser)); +assert(llvm::any_cast(&parser)); return llvm::any_cast(parser); } barannikov88 wro

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1198 -def CUDAGlobal : InheritableAttr { - let Spellings = [GNU<"global">, Declspec<"__global__">]; +def CUDAGlobal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"global">, Declspec<

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

carlosgalvezp updated this revision to Diff 483981. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Add description in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140290/new/ https://reviews.llvm.org/

  1   2   >