balazske added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:219 + /// @param State The state of the generated node. + /// @param Pred The transition will be generated from the specified Pred node + /// to the newly generated node. ---------------- Szelethus wrote: > What I'm missing here is some guidance. Why would I pick this overload > instead of the 2-parameter one? Especially for beginners, this is very > confusing. The whole documentation contains not enough information, at least not for beginners. This overload works the same way as at `generateNonFatalErrorNode` (and this documentation is made similar as at that function). `addTransition` works similar too, there is a bit more documentation. Probably somebody who understands `addTransition` and the `Pred` parameter can understand `generateErrorNode` too. If the name would be `addErrorNode` the similarity would be even stronger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137722/new/ https://reviews.llvm.org/D137722 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
