sebastian-ne added inline comments.
================
Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91
assert(parser.has_value());
- assert(llvm::any_isa<ParserT *>(parser));
+ assert(llvm::any_cast<ParserT *>(&parser));
return llvm::any_cast<ParserT *>(parser);
}
----------------
barannikov88 wrote:
> This is not intuitively clear. In assert you pass an address, but in 'return'
> below the object is passed by reference.
>
I changed it to use an address + explicit dereference in the return. I hope
that makes it clearer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139973/new/
https://reviews.llvm.org/D139973
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
