[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

2022-12-05 Thread Kevin Athey via Phabricator via cfe-commits
kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 ___ cfe-c

[PATCH] D139137: add floor library function

2022-12-05 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. @bob80905 if you haven't already, you should follow the steps here (https://www.llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) to get commit access. Repository: rG LLVM Gi

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

2022-12-05 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139154: [clang-doc] Add template support

2022-12-05 Thread Brett Wilson via Phabricator via cfe-commits
brettw updated this revision to Diff 480251. brettw added a reviewer: paulkirth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

2022-12-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D138807#3962417 , @craig.topper wrote: > Anything that uses OP-P needs to have a DecoderNamespace assigned and > RISCVDisassembler::getInstruction will need to lookup that table when V/Zve > is enabled. Otherwise we wil

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

2022-12-05 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

2022-12-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) || Module.getLangOpts().Sanitize.has(SanitizerKind::Re

[clang] 200007e - [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers.

2022-12-05 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2022-12-05T15:13:42-08:00 New Revision: 27ec85f81122fd260a4e68308e54607ca37a URL: https://github.com/llvm/llvm-project/commit/27ec85f81122fd260a4e68308e54607ca37a DIFF: https://github.com/llvm/llvm-project/commit/27ec85f81122fd260a4e68308e54607ca37a.dif

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

2022-12-05 Thread Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ec85f8: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers. (authored by Artem Dergachev ). Heral

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

2022-12-05 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:168-169 + static Matcher matcher() { +// FIXME: What if the index is integer literal 0? Should this be +// a safe gadget in this case? +return stmt( NoQ wrote: > aa

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

2022-12-05 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

2022-12-05 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. In D138337#3972138 , @samitolvanen wrote: > In D138337#3972009 , @pcc wrote: > >> Can't this be implicit if LTO is being used? > > I would prefer to keep this behind a flag (similarly to `-mi

[clang] bc06177 - Revert "[-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers."

2022-12-05 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2022-12-05T15:38:52-08:00 New Revision: bc0617795f8bdcd5deab3e48b120107cc2833cdc URL: https://github.com/llvm/llvm-project/commit/bc0617795f8bdcd5deab3e48b120107cc2833cdc DIFF: https://github.com/llvm/llvm-project/commit/bc0617795f8bdcd5deab3e48b120107cc2833cdc.dif

[clang] 6b992bc - [Driver][test] Fix test by creating empty archive instead of empty file

2022-12-05 Thread Jacob Lambert via cfe-commits
Author: Jacob Lambert Date: 2022-12-05T15:39:09-08:00 New Revision: 6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521 URL: https://github.com/llvm/llvm-project/commit/6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521 DIFF: https://github.com/llvm/llvm-project/commit/6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521.diff

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

2022-12-05 Thread Jacob Lambert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b992bcce0c5: [Driver][test] Fix test by creating empty archive instead of empty file (authored by lamb-j). Repository: rG LLVM Github Monorepo C

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 3)

2022-12-05 Thread John McIver via Phabricator via cfe-commits
jmciver updated this revision to Diff 480265. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 3) The following tests have been updated: - avx512f-builtins.c - avx512fp16-builtins.c - matri

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

2022-12-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:637 +def : ProcessorModel<"scr1-min", SCR1Model, + [FeatureRV32E, FeatureStdExtC], + [TuneNoDefaultUnroll]>; Shouldn't this also need Feature32B

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

2022-12-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSCR1.td:208 +} \ No newline at end of file Add new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139302/new/ https://reviews.ll

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

2022-12-05 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added a comment. In D138337#3972493 , @pcc wrote: > Isn't that just a bug in the optimization? It shouldn't be applying this to > symbols where `VisibleToRegularObj` is set. The current patch simply replicates ibt-seal behavior, but sure, l

[PATCH] D138983: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 3 or 3)

2022-12-05 Thread John McIver via Phabricator via cfe-commits
jmciver updated this revision to Diff 480267. jmciver added a comment. Updating D138983 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 3 or 3) The following tests have been updated: - matrix-type-operators.c Repository: rG LLVM Gi

Re: [clang] a446827 - [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

2022-12-05 Thread David Blaikie via cfe-commits
On Mon, Dec 5, 2022 at 5:27 AM Juan Manuel MARTINEZ CAAMAÑO via cfe-commits wrote: > > > Author: Juan Manuel MARTINEZ CAAMAÑO > Date: 2022-12-05T07:27:10-06:00 > New Revision: a446827249bdeb2f27e55a9f4942bd7425ecb0ff > > URL: > https://github.com/llvm/llvm-project/commit/a446827249bdeb2f27e55a9f4

[clang] bb5bcdd - [CodeView] Don't generate dummy unnamed strcut/class/union type.

2022-12-05 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2022-12-06T08:29:55+08:00 New Revision: bb5bcddcdbc151119f449be2d1e0d90f2e9c4258 URL: https://github.com/llvm/llvm-project/commit/bb5bcddcdbc151119f449be2d1e0d90f2e9c4258 DIFF: https://github.com/llvm/llvm-project/commit/bb5bcddcdbc151119f449be2d1e0d90f2e9c4258.diff LOG

[PATCH] D138326: [CodeView] Don't generate dummy unnamed strcut/class/union type.

2022-12-05 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. Landed at: https://reviews.llvm.org/rGbb5bcddcdbc151119f449be2d1e0d90f2e9c4258. Forgot to add the "Revision" line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138326/new/ https://reviews.llvm.org/D138326 __

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

2022-12-05 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/93300/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ https://reviews.llvm.org/D137275

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

2022-12-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie updated this revision to Diff 480292. dblaikie added a comment. Rebase on top of committed LLVM changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139025: [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion

2022-12-05 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD marked an inline comment as done. eopXD added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139025/new/ https://reviews.llvm.org/D139025 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

2022-12-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie updated this revision to Diff 480296. dblaikie added a comment. Don't use the since-v5-published codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

2022-12-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D138597#3966638 , @probinson wrote: > One not-yet-asked question, does gcc produce the C++17/20 codes? If so, does > fstrict-dwarf affect that? Looks like GCC uses C++17 for both 17 and 20: https://gcc.gnu.org/git/?p=gcc.gi

[PATCH] D139025: [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion

2022-12-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139025/new/ https://reviews.llvm.org/D1390

[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

2022-12-05 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 480305. FreddyYe added a comment. Rebase and add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139170/new/ https://reviews.llvm.org/D139170 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic

[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

2022-12-05 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. THX for review. I'll land! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139170/new/ https://reviews.llvm.org/D139170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

2022-12-05 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat added a comment. In D138807#3972441 , @craig.topper wrote: > In D138807#3962417 , @craig.topper > wrote: > >> Anything that uses OP-P needs to have a DecoderNamespace assigned and >> RISCVDisassembler::

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

2022-12-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 480310. NoQ marked 17 inline comments as done. NoQ added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137348/new/ https://reviews.llvm.org/D137348 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadg

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

2022-12-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def:1 +//=- UnsafeBufferUsageGadgets.def - List of ways to use a buffer --*- C++ -*-=// +// NoQ wrote: > aaron.ballman wro

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

2022-12-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:168-169 + static Matcher matcher() { +// FIXME: What if the index is integer literal 0? Should this be +// a safe gadget in this case? +return stmt( xazax.hun wrote: > No

[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

2022-12-05 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdef720726b73: [X86][clang] Lift _BitInt() supported max width. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] def7207 - [X86][clang] Lift _BitInt() supported max width.

2022-12-05 Thread Freddy Ye via cfe-commits
Author: Freddy Ye Date: 2022-12-06T11:02:27+08:00 New Revision: def720726b73e0d7ab139376ab3ea955f25f4d89 URL: https://github.com/llvm/llvm-project/commit/def720726b73e0d7ab139376ab3ea955f25f4d89 DIFF: https://github.com/llvm/llvm-project/commit/def720726b73e0d7ab139376ab3ea955f25f4d89.diff LOG

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

2022-12-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:155-176 +class ArraySubscriptGadget : public UnsafeGadget { + const ArraySubscriptExpr *ASE; + +public: + ArraySubscriptGadget(const MatchFinder::MatchResult &Result) + : UnsafeGadget(Kind::Arr

[PATCH] D139154: [clang-doc] Add template support

2022-12-05 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added a comment. Can we also update the end-to-end tests with some relevant test cases? I think that's especially important, given that I'm not sure the unittests are running as part of the normal test suite. Overall this is mostly LGTM with some minor comments/questions. =

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

2022-12-05 Thread ChenZheng via Phabricator via cfe-commits
shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138105/new/ https://reviews.llvm.org/D138105

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

2022-12-05 Thread Ben Boeckel via Phabricator via cfe-commits
ben.boeckel added a comment. In D137059#3934448 , @dblaikie wrote: > I'm still curious what about the details of other compilers - I think from > the sounds of it, @iains suggested GCC doesn't support this yet so we'll need > to pick/name the flag ourse

[PATCH] D139387: [Clang] Support policy function for all vector segment load.

2022-12-05 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All. 4vtom

[PATCH] D139387: [Clang] Support policy function for all vector segment load.

2022-12-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Title is not clear this is NFC and only adding tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139387/new/ https://reviews.llvm.org/D139387 ___ cfe-commits mailing list

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

2022-12-05 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat updated this revision to Diff 480320. 4vtomat added a comment. Resolved Craig's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocessor/riscv-target-features.c l

[PATCH] D139387: [Clang] Support policy function for all vector segment load.

2022-12-05 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat updated this revision to Diff 480321. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139387/new/ https://reviews.llvm.org/D139387 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

2022-12-05 Thread Gedare Bloom via Phabricator via cfe-commits
gedare added a comment. In D137762#3969770 , @owenpan wrote: > @gedare do you need us to commit this patch on your behalf (using "Gedare > Bloom ")? Yes, please. I don't have any llvm permissions, this is my first patch set for llvm actually. Anything

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

2022-12-05 Thread Iain Sandoe via Phabricator via cfe-commits
iains added a comment. In D137059#3973016 , @ben.boeckel wrote: > In D137059#3934448 , @dblaikie > wrote: > >> I'm still curious what about the details of other compilers - I think from >> the sounds of it, @ia

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

2022-12-05 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 480329. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h clang/lib/Tooling/D

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

2022-12-05 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:155 +// CHECK-MAKE: [[PREFIX]]/impl_part.o: +// CHECK-MAKE: [[PREFIX]]/impl_part.cppm ben.boeckel wrote: > ben.boeckel wrote: > > ChuanqiXu wrote: > > > ben.boeckel wrote: > > >

[clang-tools-extra] 649ef33 - [clang-tools-extra] Use std::nullopt instead of llvm::None (NFC)

2022-12-05 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-12-05T21:49:31-08:00 New Revision: 649ef3386b90363af3c807ebe82d0facc75fa381 URL: https://github.com/llvm/llvm-project/commit/649ef3386b90363af3c807ebe82d0facc75fa381 DIFF: https://github.com/llvm/llvm-project/commit/649ef3386b90363af3c807ebe82d0facc75fa381.diff L

[clang-tools-extra] 15ba27e - [clang-tools-extra] Use std::nullopt instead of llvm::None (NFC)

2022-12-05 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-12-05T22:37:22-08:00 New Revision: 15ba27ebd0cbf96659b729399f89eb9f11ae1d5e URL: https://github.com/llvm/llvm-project/commit/15ba27ebd0cbf96659b729399f89eb9f11ae1d5e DIFF: https://github.com/llvm/llvm-project/commit/15ba27ebd0cbf96659b729399f89eb9f11ae1d5e.diff L

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

2022-12-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 480335. vitalybuka added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeG

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

2022-12-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) || Modu

[clang] 166c8cc - [msan][CodeGen] Set noundef for C return value

2022-12-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-12-05T22:58:29-08:00 New Revision: 166c8cccde010ea01fdc20945a2a25fa1971cb73 URL: https://github.com/llvm/llvm-project/commit/166c8cccde010ea01fdc20945a2a25fa1971cb73 DIFF: https://github.com/llvm/llvm-project/commit/166c8cccde010ea01fdc20945a2a25fa1971cb73.diff L

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

2022-12-05 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vitalybuka marked an inline comment as done. Closed by commit rG166c8cccde01: [msan][CodeGen] Set noundef for C return value (authored by vitalybuka). Repository: rG

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

2022-12-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 480340. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

2022-12-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:44 + + // Cache for decl to header mappings, as the same decl might be referenced in + // multiple locations and finding providers for each location is expensive. hok

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

2022-12-05 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137488: [clang][Interp] Array initialization via string literal

2022-12-05 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. @tahonermann Anything still missing here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

2022-12-05 Thread Dmitrii Petrov via Phabricator via cfe-commits
dnpetrov-sc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:637 +def : ProcessorModel<"scr1-min", SCR1Model, + [FeatureRV32E, FeatureStdExtC], + [TuneNoDefaultUnroll]>; craig.topper wrote: > Shouldn't this

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

2022-12-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks, mostly LG. some small changes. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:261 if (Symbol.empty()) +F.Message = llvm::formatv("{0} {1}", nit: `llvm::StringLiteral DirectiveSpelling = Directive == tooling::In

[PATCH] D139395: Add support for integer types notmalization

2022-12-05 Thread Ramon de C Valle via Phabricator via cfe-commits
rcvalle created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. rcvalle requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This commit adds support for normalizing integer types as vendor extended t

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

2022-12-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Do I understand correctly that for the time being, the strategy is to assume apiModeling to be enabled by default and not enforce it explicitly? I suppose I have the ol' reliable question: did you evaluate this on any project yet? In D135247#3839543

[clang-tools-extra] 2402c46 - [clang-tools-extra] Use std::nullopt instead of llvm::None (NFC)

2022-12-05 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-12-05T23:55:23-08:00 New Revision: 2402c46b7155d04dc2a1ec618294fc6bb70f3e18 URL: https://github.com/llvm/llvm-project/commit/2402c46b7155d04dc2a1ec618294fc6bb70f3e18 DIFF: https://github.com/llvm/llvm-project/commit/2402c46b7155d04dc2a1ec618294fc6bb70f3e18.diff L

[PATCH] D139395: Add support for integer types normalization

2022-12-05 Thread Ramon de C Valle via Phabricator via cfe-commits
rcvalle updated this revision to Diff 480349. rcvalle retitled this revision from "Add support for integer types notmalization" to "Add support for integer types normalization". rcvalle added a comment. Fixed typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

<    1   2