NoQ added inline comments.
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:155-176
+class ArraySubscriptGadget : public UnsafeGadget {
+ const ArraySubscriptExpr *ASE;
+
+public:
+ ArraySubscriptGadget(const MatchFinder::MatchResult &Result)
+ : UnsafeGadget(Kind::ArraySubscript),
+ ASE(Result.Nodes.getNodeAs<ArraySubscriptExpr>("arraySubscr")) {}
----------------
Carryover from the nearby patch - let's make a named constant for "arraySubscr"!
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:175
+
+ const Stmt *getBaseStmt() const override { return ASE; }
+};
----------------
Carryover from nearby patch - let's use covariant return types!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137379/new/
https://reviews.llvm.org/D137379
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
