[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940289 , @WowbaggersLiquidLunch wrote: > Hi, this seems to be causing some problems when generating Xcode project. > > When I try to generate the Xcode project with the following command: > > cmake -G "Xcode" -D

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM but wait for @WowbaggersLiquidLunch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138403/new/ https://reviews.llvm.org/D138403 __

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3940143 , @nridge wrote: > A couple of high-level thoughts on this: > > 1. Based on the discussion in https://github.com/clangd/clangd/issues/1115, I > believe highlighting of **built-in** operators should be out of

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. > I get the following error: > >> CMake Error: Could not create named generator Xcode Sorry, I forgot to mention that Xcode is only available on macOS. > But when I change Xcode to Ninja, no error output is generated. Indeed. Ninja works fine for me as wel

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. In D136906#3940377 , @gonglingqin wrote: > Can you use https://reviews.llvm.org/D138403 to solve this problem? Thanks for letting me know. I'll give it a try. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

WowbaggersLiquidLunch accepted this revision. WowbaggersLiquidLunch added a comment. Yes this works! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138403/new/ https://reviews.llvm.org/D138403 ___

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

sammccall added a comment. In D136594#3940143 , @nridge wrote: > I believe highlighting of **built-in** operators should be out of scope for > semantic highlighting, at least in the default mode; client-side highlighting > should be sufficient for these

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

sammccall added a comment. Not sure this is ready for review again, ignore me if not... I'm still not sure why this is correct in principle. Without that, if someone finds a misparse 6 months from now I don't know how we determine where to fix it. For example, this path is called from `Parser

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

sammccall added a comment. In D137205#3939720 , @njames93 wrote: > @sammccall I have a feeling you're gonna want to examine this checks > feasibility in clangd. Thanks! As it uses the CFG, by default we're going to have to turn it off (AFAIK building t

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940427 , @WowbaggersLiquidLunch wrote: >> I get the following error: >> >>> CMake Error: Could not create named generator Xcode > > Sorry, I forgot to mention that Xcode is only available on macOS. > >> But when I

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940432 , @WowbaggersLiquidLunch wrote: > In D136906#3940377 , @gonglingqin > wrote: > >> Can you use https://reviews.llvm.org/D138403 to solve this problem? > > Thanks fo

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > sammccall wrote: > > sammccall wrote: > > > Can you give some background here or on the bug tracker a

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138143/new/ https://reviews.llvm.org/D138143 ___

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:231 +/// Special Location-like type to be used for textDocument/references +/// Contains an additional field for the context in which the reference occurs This doesn't seem as clea

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng marked 2 inline comments as done. kito-cheng added a comment. @kadircet ooops, sorry for missing your comment, let me figure out how to fix that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/ https://reviews.llvm.org/D124730

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

sammccall added a subscriber: kito.cheng. sammccall added a comment. I think there almost certainly *is* a better way here, but it may be a significant amount of work and we need to get back to a correct state (revert doesn't seem feasible). Not approving yet in the hope that @kito-cheng (@kito

Re: [PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

thanks Kito! not sure if you've noticed D138287, but if landing a solution is going to take a long while here, i'd like to move forward with that approach to make sure this doesn't stay in a broken state. so it'd be great if you can give some updates/estimates about fixing this soon. On Mon, Nov 2

[PATCH] D137943: [clangd] Mark "override" and "final" as keywords

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM with optional mechanical replacement of `Keyword` with `Modifier`. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:52 Macro, + Keyword, -

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

arichardson added a comment. Herald added subscribers: sunshaoce, StephenFan, shiva0217. Herald added a project: All. I just noticed that target features (e.g. -mrelax) are broken in all LLVM 14 releases due to D113336 . This should have been cherry-picked back

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

sammccall added a comment. Since this is a protocol extension, you might want to add an end-to-end test: variant of `clang-tools-extra/clangd/test/xrefs.test` (`xrefs-container.test`? to avoid complicating all the existing tests). And one this lands, one of us should update https://github.com/

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

kito-cheng added a comment. Apparently I missed those comments during llvm dev meeting, I'll figure out a fix soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138287/new/ https://reviews.llvm.org/D138287 ___

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

sammccall added a comment. In D138287#3940602 , @kito-cheng wrote: > Apparently I missed those comments during llvm dev meeting, I'll figure out a > fix soon. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D137943: [clangd] Mark "override" and "final" as modifiers

ckandeler updated this revision to Diff 476843. ckandeler marked 3 inline comments as done. ckandeler retitled this revision from "[clangd] Mark "override" and "final" as keywords" to "[clangd] Mark "override" and "final" as modifiers". ckandeler edited the summary of this revision. ckandeler adde

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. Now that Kona is over, I'm hoping to get back to that in the coming weeks. Rebasing will be... fun. I want to make sure we are all okay making that a DR following WG21 guidance, given that not making it a DR would have potentially large impact on the PR. Thanks! Repos

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1434-1436 + if (Style.UseTab == FormatStyle::UT_Never) { +ReplacementText.append(Spaces, ' '); + } else { owenpan wrote: > Doing this would lose some of

[clang] aff838f - [clang-format][NFC] Remove unneeded braces

Author: Björn Schäpers Date: 2022-11-21T13:24:17+01:00 New Revision: aff838fb8f1d398e8d9fc6ec15b5a10db3e1c057 URL: https://github.com/llvm/llvm-project/commit/aff838fb8f1d398e8d9fc6ec15b5a10db3e1c057 DIFF: https://github.com/llvm/llvm-project/commit/aff838fb8f1d398e8d9fc6ec15b5a10db3e1c057.diff

[clang] c89d2fd - [clang-format][NFC] Format lambda in conditional

Author: Björn Schäpers Date: 2022-11-21T13:24:18+01:00 New Revision: c89d2fd596cec8cf3a8100c504f045b9727fa98a URL: https://github.com/llvm/llvm-project/commit/c89d2fd596cec8cf3a8100c504f045b9727fa98a DIFF: https://github.com/llvm/llvm-project/commit/c89d2fd596cec8cf3a8100c504f045b9727fa98a.diff

[clang] 9e00909 - [clang-format][NFC] Don't add a load of 0es

Author: Björn Schäpers Date: 2022-11-21T13:24:18+01:00 New Revision: 9e00909b00f9e75b4f710bc60f13ceea1215746c URL: https://github.com/llvm/llvm-project/commit/9e00909b00f9e75b4f710bc60f13ceea1215746c DIFF: https://github.com/llvm/llvm-project/commit/9e00909b00f9e75b4f710bc60f13ceea1215746c.diff

[clang] 5ba5f7c - [clang-format][NFC] Removed unused include

Author: Björn Schäpers Date: 2022-11-21T13:24:19+01:00 New Revision: 5ba5f7c46ccfe98fd68d6e31d25f386d67d484b4 URL: https://github.com/llvm/llvm-project/commit/5ba5f7c46ccfe98fd68d6e31d25f386d67d484b4 DIFF: https://github.com/llvm/llvm-project/commit/5ba5f7c46ccfe98fd68d6e31d25f386d67d484b4.diff

[PATCH] D138354: [clang-format][NFC] Remove unneeded braces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaff838fb8f1d: [clang-format][NFC] Remove unneeded braces (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138357: [clang-format][NFC] Don't add a load of 0es

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e00909b00f9: [clang-format][NFC] Don't add a load of 0es (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D138356: [clang-format][NFC] Format lambda in conditional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc89d2fd596ce: [clang-format][NFC] Format lambda in conditional (authored by HazardyKnusperkeks). Herald added a project: clang. Herald added a subscr

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

grosser added a comment. This patch overcomes the issue of cl options being defined multiple times. That is great! I just tried it on Windows on top of e7fb6c394f519d6e6812f1fbbff1571d5e51f5c4 with (msys2), as well as LLVM_L

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald adde

[PATCH] D137794: [clangd] Enable configuring include insertions

sammccall added a comment. The replacement rules design is just too complicated I'm afraid. It's unclear that it solves a widespread problem, and even when there is one and the solution applies, the result is still difficult to use. Angles vs quotes is something we've had multiple reports on, th

[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D138088#3938687 , @kawashima-fj wrote: > In D138088#3937680 , @aaron.ballman > wrote: > >>

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. In D124351#3940786 , @cor3ntin wrote: > Now that Kona is over, I'm hoping to get back to that in the coming weeks. > Rebasing will be... fun. > I want to make sure we are all o

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. In D124351#3940888 , @aaron.ballman wrote: > In D124351#3940786 , @cor3ntin > wrote: > >> Now that Kona is over, I'm hoping to get back to that in the coming weeks. >> Rebasing will be

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3935740 , @rjmccall wrote: > I'm too often slow to actually apply edits to the ABI document. There's been > plenty of time for feedback on this one; go ahead and act like it's accepted. CWG 2596 was discussed at Kona a

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

aaron.ballman added a comment. In D127462#3939243 , @ksaunders wrote: > Hi Aaron. Unfortunately, I don't feel I can make a great case for why these > extensions should be in Clang. Although there are users of Plan 9 C > extensions, I don't see these fea

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

aaron.ballman added a comment. In D124351#3940890 , @cor3ntin wrote: > In D124351#3940888 , @aaron.ballman > wrote: > >> In D124351#3940786 , @cor3ntin >> wrote: >> >>>

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

aaron.ballman added a comment. In D137818#3939213 , @anderslanglands wrote: > Arg just noticed an issue: clang_Type_getReplacementType should be in the > LLVM_16 block in libclang.map not in the LLVM_13 block. I've blown away my > local branch so don't

[clang] 281a5c7 - [llvm,polly,clang] Stop setting config.enable_shared in most places

Author: Nico Weber Date: 2022-11-21T08:54:14-05:00 New Revision: 281a5c7ef112d5d09dd947ecd3f85484047c5502 URL: https://github.com/llvm/llvm-project/commit/281a5c7ef112d5d09dd947ecd3f85484047c5502 DIFF: https://github.com/llvm/llvm-project/commit/281a5c7ef112d5d09dd947ecd3f85484047c5502.diff LO

[PATCH] D138301: [llvm, polly, clang] Stop setting config.enable_shared in most places

This revision was automatically updated to reflect the committed changes. Closed by commit rG281a5c7ef112: [llvm,polly,clang] Stop setting config.enable_shared in most places (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry created this revision. v1nh1shungry added reviewers: nridge, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clan

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. The behaviour of tabs still doesn't match that of spaces, but at least this makes it idempotent. This also fixes https://github.com/llvm/llvm-project/issues/51808, I'm closing it as duplicate

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. Thanks for your feedback @rnk! I hope some of the ObjCARCOpts authors will share their opinions as well. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:767 +const ColorVector &CV = BlockColors.find(BB)->second; +assert(CV.size() == 1

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. This patch implements: - Template specialization type - Class template specialization declaration - Variable template specialization declaration - Function specialization declaration It would be sweet to also implement: template constexpr int value = 0; int

[PATCH] D138426: Fix #58958 on github

krsch created this revision. krsch added reviewers: NoQ, xazax.hun. Herald added a subscriber: rnkovacs. Herald added a project: All. krsch requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not suggest to take the address of a const pointe

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a comment. In D126818#3940898 , @dfrib wrote: > In D126818#3935740 , @rjmccall > wrote: > >> I'm too often slow to actually apply edits to the ABI document. There's >> been plenty of time for f

[clang] eb4373a - Remove -cc1 -fconcepts-ts flag

Author: Erich Keane Date: 2022-11-21T06:31:29-08:00 New Revision: eb4373abe829f8731b3e6d4da97ad88a9a93aa28 URL: https://github.com/llvm/llvm-project/commit/eb4373abe829f8731b3e6d4da97ad88a9a93aa28 DIFF: https://github.com/llvm/llvm-project/commit/eb4373abe829f8731b3e6d4da97ad88a9a93aa28.diff L

[PATCH] D138425: [clangd] Parameter hints for template specialization

sammccall added a comment. The code looks pretty good and this makes a lot of logical sense. However, there's an ugly practical issue: it's overwhelmingly common for template parameters to have cryptic and useless names. It seems like turning `vector` into `vector` actually makes things worse.

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

kito-cheng created this revision. kito-cheng added reviewers: ilya-biryukov, kadircet, sammccall, khchen. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

kito-cheng added a comment. Proposed fix: D138429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138287/new/ https://reviews.llvm.org/D138287 ___ cfe-commits mailing lis

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng added a comment. @kadircet Proposed fix: D138429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/ https://reviews.llvm.org/D124730 ___ cfe-commits m

[PATCH] D138434: [Clang][Sema] Added space after ',' in a warning

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a typo in a warning message. rdar://79707705 Repository: rG LLVM Github Monorepo https://rev

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from a thread-safety perspective, thanks! Approving because it looks mechanically "obviously correct", but you may want to wait for another reviewer to confirm the API changes are san

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

yaxunl updated this revision to Diff 476892. yaxunl added a comment. Herald added subscribers: kerbowa, jvesely. add test emulation-amdgpu.s CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138221/new/ https://reviews.llvm.org/D138221 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp clan

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3941036 , @erichkeane wrote: > In D126818#3940898 , @dfrib wrote: > >> In D126818#3935740 , @rjmccall >> wrote: >> >>> I'm too often sl

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

grosser added a comment. I just checked and I get the same error on a linux system. @nhaehnle, did you try an mlir build with the previously mentioned cmake options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.or

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitCheckSourceLocation(Loc); + Builder.Cr

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

yaxunl marked an inline comment as done. yaxunl added a comment. In D138221#3939384 , @MaskRay wrote: >> Some host relocatable objects may not contain device relocatable objects, >> where an empty file is passed to lld, which causes lld to fail. > > How

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. @sammccall Thank you for reviewing and giving suggestions! I must admit I didn't use it for very long. But I do think this is helpful, at least for templates I'm unfamiliar with. Yes, there is a common situation where people use a meaningless template parameter na

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

kadircet added a comment. thanks! +1 from my side as well for thread-safety purposes (and I hope having 2 separate caches for tablegen and sema doesn't have unexpected effects). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138429/new/ https://rev

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a comment. In D126818#3941165 , @dfrib wrote: > In D126818#3941036 , @erichkeane > wrote: > >> In D126818#3940898 , @dfrib wrote: >> >>> In D126818#39357

[PATCH] D138434: [Clang][Sema] Added space after ',' in a warning

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138434/new/ https://reviews.llvm.org/D138434

[PATCH] D138425: [clangd] Parameter hints for template specialization

sammccall added a comment. In D138425#3941183 , @v1nh1shungry wrote: > @sammccall Thank you for reviewing and giving suggestions! > > I must admit I didn't use it for very long. But I do think this is helpful, > at least for templates I'm unfamiliar wit

[clang-tools-extra] fd733a6 - [clangd] Extend --check to time clang-tidy checks, so we can block slow ones

Author: Sam McCall Date: 2022-11-21T16:24:47+01:00 New Revision: fd733a65de5c37c8d5ec4fbe45c8f1a347816858 URL: https://github.com/llvm/llvm-project/commit/fd733a65de5c37c8d5ec4fbe45c8f1a347816858 DIFF: https://github.com/llvm/llvm-project/commit/fd733a65de5c37c8d5ec4fbe45c8f1a347816858.diff LO

[PATCH] D136082: [clangd] Extend --check to time clang-tidy checks, so we can block slow ones

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:66 +llvm::cl::desc("Print the overhead of checks matching this glob"), +llvm::cl::init("")); + kadircet wrote: > i guess we al

[PATCH] D136082: [clangd] Extend --check to time clang-tidy checks, so we can block slow ones

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGfd733a65de5c: [clangd] Extend --check to time clang-tidy checks, so we can block slow ones (authored by sammccall). Changed prior to commit: https://reviews.l

[clang-tools-extra] 5696f2d - [clangd] Move --check options into Check.cpp. Add --check-completion.

Author: Sam McCall Date: 2022-11-21T16:39:27+01:00 New Revision: 5696f2dfce5f23967a047f68897a7ff2e3d8e7d1 URL: https://github.com/llvm/llvm-project/commit/5696f2dfce5f23967a047f68897a7ff2e3d8e7d1 DIFF: https://github.com/llvm/llvm-project/commit/5696f2dfce5f23967a047f68897a7ff2e3d8e7d1.diff LO

[clang-tools-extra] c67b710 - [clangd] Add option to skip per-location checks.

Author: Sam McCall Date: 2022-11-21T16:41:53+01:00 New Revision: c67b710379402a48b0a158fa6247ae421ff9aa77 URL: https://github.com/llvm/llvm-project/commit/c67b710379402a48b0a158fa6247ae421ff9aa77 DIFF: https://github.com/llvm/llvm-project/commit/c67b710379402a48b0a158fa6247ae421ff9aa77.diff LO

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

aaron.ballman added a comment. In D137020#3940523 , @sammccall wrote: > Not sure this is ready for review again, ignore me if not... > > I'm still not sure why this is correct in principle. Without that, if someone > finds a misparse 6 months from now I

[PATCH] D138234: [clang-format] Support new file formatting with vim

jsji updated this revision to Diff 476905. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138234/new/ https://reviews.llvm.org/D138234 Files: clang/tools/clang-format/clang-format.py Index: clang/tools/cl

[clang] 9e3264a - [FPEnv] Enable strict fp for AArch64 in clang

Author: John Brawn Date: 2022-11-21T16:02:54Z New Revision: 9e3264ab2021e07246e2cb491497d9cd514c213c URL: https://github.com/llvm/llvm-project/commit/9e3264ab2021e07246e2cb491497d9cd514c213c DIFF: https://github.com/llvm/llvm-project/commit/9e3264ab2021e07246e2cb491497d9cd514c213c.diff LOG: [F

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3264ab2021: [FPEnv] Enable strict fp for AArch64 in clang (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138143/new/ https://revi

[PATCH] D138439: clang: Fix cast failure when using -fsanitize=undefined for HIP

arsenm created this revision. arsenm added reviewers: yaxunl, samsonov, tra, bkramer. Herald added a subscriber: arichardson. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This was assuming a direct reference to the global variable. The con

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 476913. zahiraam marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/L

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1732 +.. option:: -fexcess-precision: + + By default, Clang uses excess precision to calculate ``_Float16`` rjmccall wrote: > >The C and C++ standards allow floating-point expressions t

[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

ilya-biryukov added a comment. The error itself makes sense, but I don't quite understand why usages of `invalid` did not produce errors before. Any idea why that happened? Are there some other bugs hiding? It seems that at some point when parsing this code: static_assert(invalid also here ;

[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

ilya-biryukov added a comment. E.g. gcc actually accepts the concept definition, but later fails with "wrong number of template arguments". I wonder why Clang has not been doing the latter before this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D138441: [clang-format][docs] Fix invalid CSS syntax in versionbadge

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSS uses colons, not the equals sign. The final semicolon

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders updated this revision to Diff 476918. tom-anders marked 7 inline comments as done. tom-anders added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137894/new/ https://reviews.llvm.org/D137894 Files: clang-to

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders added a comment. In D137894#3940600 , @sammccall wrote: > Since this is a protocol extension, you might want to add an end-to-end test: > variant of `clang-tools-extra/clangd/test/xrefs.test` > (`xrefs-container.test`? to avoid complicating a

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

aaron.ballman added a comment. Thank you for working on this, I know it was a slog! I think this is pretty close to ready, though you should definitely add a release note about the changes. Comment at: clang/include/clang/Parse/Parser.h:1605-1606 // C99 6.9: External Defin

[PATCH] D138377: add clang_Type_getFullyQualifiedName

aaron.ballman added a comment. In terms of testing, I'd recommend adding `-test-print-qualified-type` and see if you can thread a qualified vs unqualified parameter through `PrintType()` and friends to try to share as much code as possible. You'll probably need new wrapper functions that calls

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1250-1251 bool ADL = UseArgumentDependentLookup(SS, Result, NextToken.is(tok::l_paren)); - if (Result.isSingleResult() && !ADL && !FirstDecl->isCXXClassMember()) + if (Result.isSingleResult() && !A

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows for the creation of permalinks to specific cl

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands updated this revision to Diff 476935. anderslanglands added a comment. Move getReplacementType to LLVM_16 block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137818/new/ https://reviews.llvm.org/D137818 Files: clang/docs/ReleaseN

[PATCH] D136603: [analyzer] getBinding should auto-detect type only if it was not given

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Sounds reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136603/new/ https://reviews.llvm.org/D136603 _

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

xazax.hun added a comment. I did not spend too much time thinking about this yet, but this sounds scary. I wonder if we should target the underlying problem instead, i.e., making sure we never have dead symbols as representatives for eq. classes. What do you think? Repository: rG LLVM Github

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

aaron.ballman added subscribers: njames93, sammccall, LegalizeAdulthood, klimek. aaron.ballman added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:34 +// through the handler class. +void checkUnsafeBufferUsage(const Decl *D, UnsafeBufferUs

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

aaron.ballman added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def:1 +//=- UnsafeBufferUsageGadgets.def - List of ways to use a buffer --*- C++ -*-=// +// Is this file named properly if it is also going to handle

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:168-169 + static Matcher matcher() { +// FIXME: What if the index is integer literal 0? Should this be +// a safe gadget in this case? +return stmt( xazax.hun w

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

aaron.ballman added a comment. Precommit CI found that this change breaks clang/test/Sema/PR28181.c which was introduced to fix https://bugs.llvm.org/show_bug.cgi?id=28181 which was a regression caused by https://github.com/llvm/llvm-project/commit/5a5319062300166a747807339349766341a2c2b2 CHA

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd marked 5 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1605-1606 // C99 6.9: External Definitions. DeclGroupPtrTy ParseExternalDeclaration(ParsedAttributes &Attrs, +

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 476949. compnerd marked an inline comment as done. compnerd added a comment. Address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

aaron.ballman added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1096-1097 +ParsingDeclSpec &DS, AccessSpecifier AS) { + DS.SetRangeStart(DeclSpecAttrs.Range.getBegin()); + DS.SetRangeEnd(DeclSpecAttrs.Range.getEnd()); + DS.takeAttributesFrom(DeclSpecAttrs); ---

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the question about whether we want to add an assert or not (I don't insist on adding one) and adding a release note (which doesn't need further review unless you want it). Thank you for these changes! CHANGES

  1   2   >