fahadnayyar created this revision.
Herald added a project: All.
fahadnayyar requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This change fixes a typo in a warning message.
rdar://79707705
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D138434
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/test/SemaObjC/atomic-property-synthesis-rules.m
Index: clang/test/SemaObjC/atomic-property-synthesis-rules.m
===================================================================
--- clang/test/SemaObjC/atomic-property-synthesis-rules.m
+++ clang/test/SemaObjC/atomic-property-synthesis-rules.m
@@ -108,7 +108,7 @@
// read-write - might warn
@property int GetSet;
@property int Get; // expected-note {{property declared here}} \
- // expected-note {{setter and getter must both be
synthesized}}
+ // expected-note {{setter and getter must both be
synthesized, or both be user defined, or the property must be nonatomic}}
@property int Set; // expected-note {{property declared here}} \
// expected-note {{setter and getter must both be
synthesized}}
@property int None;
Index: clang/include/clang/Basic/DiagnosticSemaKinds.td
===================================================================
--- clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -1326,7 +1326,7 @@
"with a user defined %select{getter|setter}2">,
InGroup<DiagGroup<"atomic-property-with-user-defined-accessor">>;
def note_atomic_property_fixup_suggest : Note<"setter and getter must both be "
- "synthesized, or both be user defined,or the property must be nonatomic">;
+ "synthesized, or both be user defined, or the property must be nonatomic">;
def err_atomic_property_nontrivial_assign_op : Error<
"atomic property of reference type %0 cannot have non-trivial assignment"
" operator">;
Index: clang/test/SemaObjC/atomic-property-synthesis-rules.m
===================================================================
--- clang/test/SemaObjC/atomic-property-synthesis-rules.m
+++ clang/test/SemaObjC/atomic-property-synthesis-rules.m
@@ -108,7 +108,7 @@
// read-write - might warn
@property int GetSet;
@property int Get; // expected-note {{property declared here}} \
- // expected-note {{setter and getter must both be synthesized}}
+ // expected-note {{setter and getter must both be synthesized, or both be user defined, or the property must be nonatomic}}
@property int Set; // expected-note {{property declared here}} \
// expected-note {{setter and getter must both be synthesized}}
@property int None;
Index: clang/include/clang/Basic/DiagnosticSemaKinds.td
===================================================================
--- clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -1326,7 +1326,7 @@
"with a user defined %select{getter|setter}2">,
InGroup<DiagGroup<"atomic-property-with-user-defined-accessor">>;
def note_atomic_property_fixup_suggest : Note<"setter and getter must both be "
- "synthesized, or both be user defined,or the property must be nonatomic">;
+ "synthesized, or both be user defined, or the property must be nonatomic">;
def err_atomic_property_nontrivial_assign_op : Error<
"atomic property of reference type %0 cannot have non-trivial assignment"
" operator">;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
