[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212 // Produce replacements to add the qualifiers. std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::"; for (auto Loc : IdentsToQua

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

chrish_ericsson_atx added a comment. Herald added a reviewer: njames93. @mizvekov , I'm willing/trying to assist in addressing the buildbot failures that caused you to revert this change. We are eager to see this fix land stably upstream as the crash it addresses is breaking a number of our int

[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

benlangmuir updated this revision to Diff 475534. benlangmuir added a comment. - Removed outdated FIXME - Ran clang-format - Attempt to fix Windows test failure: the `StringSet` of paths was failing to match, so switch to `DenseSet`. Note: the path that ends up in the command-line is from a `Fil

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

stellaraccident accepted this revision. stellaraccident added a comment. Thanks for this. Patch lgtm. Has a couple of format issues but probably ok as-is (this file is very inconsistently formatted and it looks like you overrode clang-format a bit for consistency with adjacent code). Repositor

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475538. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files: clang/lib/CodeGen/Backe

[clang] 88eb3c6 - Add FP8 E4M3 support to APFloat.

Author: Reed Date: 2022-11-15T20:26:42+01:00 New Revision: 88eb3c62f25d820a80bc73af786002e1fc4a URL: https://github.com/llvm/llvm-project/commit/88eb3c62f25d820a80bc73af786002e1fc4a DIFF: https://github.com/llvm/llvm-project/commit/88eb3c62f25d820a80bc73af786002e1fc4a.diff LOG: Add

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88eb3c62f25d: Add FP8 E4M3 support to APFloat. (authored by reedwm, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Tue, 15 Nov 2022 at 19:08, Paul Eggert wrote: > > On 2022-11-15 06:50, Jonathan Wakely wrote: > > Could you clarify what you mean, with a concrete example? Surely as > > long as errors are reported on stderr and the compiler exits with > > non-zero status, that's an acceptable way to report err

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. @aaron.ballman Do you have any objection to us landing this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137346/new/ https://reviews.llvm.org/D13734

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

reedwm added a comment. In D137760#3928314 , @stellaraccident wrote: > Thanks for this. Patch lgtm. Has a couple of format issues but probably ok > as-is (this file is very inconsistently formatted and it looks like you > overrode clang-format a bit fo

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel updated this revision to Diff 475544. ymandel marked 7 inline comments as done. ymandel added a comment. reshape widen to update in place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files:

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:29 + /// Invoked when an unsafe operation over raw pointers is found. + virtual void handleUnsafeOperation(const Stmt *Operation) = 0; +}; What is the purpos

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:114 bool isEqualTypeErased(const TypeErasedLattice &E1, const TypeErasedLattice &E2) final { const

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel updated this revision to Diff 475548. ymandel marked an inline comment as done. ymandel added a comment. tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137948/new/ https://reviews.llvm.org/D137948 Files: clang/include/clang/Analysi

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:114 bool isEqualTypeErased(const TypeErasedLattice &E1,

[clang] 9332ddf - [Clang] Extend the number of case Sema::CheckForIntOverflow covers

Author: Shafik Yaghmour Date: 2022-11-15T12:07:03-08:00 New Revision: 9332ddfba69c38f9ceef4175b042fba0bb8e67bb URL: https://github.com/llvm/llvm-project/commit/9332ddfba69c38f9ceef4175b042fba0bb8e67bb DIFF: https://github.com/llvm/llvm-project/commit/9332ddfba69c38f9ceef4175b042fba0bb8e67bb.dif

[PATCH] D137897: Extend the number of case Sema::CheckForIntOverflow covers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9332ddfba69c: [Clang] Extend the number of case Sema::CheckForIntOverflow covers (authored by shafik). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D137897?vs=475528&

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ben.boeckel added a comment. I'm not too concerned with the spelling of the flag myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 ___ cfe-commits mailing

[PATCH] D136176: Implement support for option 'fexcess-precision'.

andrew.w.kaylor added a comment. Can you update the clang user's manual to describe the behavior of this option? The excess precision issue is also mentioned in the clang language extensions document (https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point). ===

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Tue, Nov 15, 2022 at 2:08 PM Paul Eggert wrote: > > On 2022-11-15 06:50, Jonathan Wakely wrote: > > Could you clarify what you mean, with a concrete example? Surely as > > long as errors are reported on stderr and the compiler exits with > > non-zero status, that's an acceptable way to report e

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; Aren't `N` and `NumEle

[PATCH] D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a bug where an lvalue `ExtVectorElementExpr` was created when the base expression was an ObjC property dot oper

[PATCH] D135488: [codegen] Display stack layouts in console

nickdesaulniers added a comment. Can we add a `Note` diagnostic when we emit a `-Wframe-larger-than=` that alludes to re-running with `-mllvm -print-stack-frame` to get additional info? We should update the release notes of clang to mention this feature, too. Repository: rG LLVM Github Monor

[PATCH] D135488: [codegen] Display stack layouts in console

arsenm added a comment. In D135488#3928557 , @nickdesaulniers wrote: > Can we add a `Note` diagnostic when we emit a `-Wframe-larger-than=` that > alludes to re-running with `-mllvm -print-stack-frame` to get additional info? > > We should update the re

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Tue, Nov 15, 2022 at 3:27 PM Paul Eggert wrote: > > On 2022-11-15 11:27, Jonathan Wakely wrote: > > Another perspective is that autoconf shouldn't get in the way of > > making the C and C++ toolchain more secure by default. > > Can you cite any examples of a real-world security flaw what would

[PATCH] D135488: [codegen] Display stack layouts in console

nickdesaulniers added a comment. In D135488#3928559 , @arsenm wrote: > In D135488#3928557 , > @nickdesaulniers wrote: > >> Can we add a `Note` diagnostic when we emit a `-Wframe-larger-than=` that >> alludes to

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-15 06:50, Jonathan Wakely wrote: Could you clarify what you mean, with a concrete example? Surely as long as errors are reported on stderr and the compiler exits with non-zero status, that's an acceptable way to report errors? Not if the "error" is harmless as far as Autoconf is conc

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-15 11:27, Jonathan Wakely wrote: Another perspective is that autoconf shouldn't get in the way of making the C and C++ toolchain more secure by default. Can you cite any examples of a real-world security flaw what would be found by Clang erroring out because 'char foo(void);' is the

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137823/new/ https://reviews.llvm.org/D137823 ___ cfe-commits mailing list cfe-comm

[PATCH] D137826: [clang] Allow comparing pointers to string literals

tahonermann added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12951-12954 + // ObjC's @encode() + if (isa(E->getLHS()->IgnoreParenImpCasts()) || + isa(E->getRHS()->IgnoreParenImpCasts())) return Error(E); A comment to e

[PATCH] D135488: [codegen] Display stack layouts in console

nickdesaulniers added a comment. In D135488#3928567 , @nickdesaulniers wrote: > In D135488#3928559 , @arsenm wrote: > >> In D135488#3928557 , >> @nickdesaulniers wrote:

[PATCH] D135488: [codegen] Display stack layouts in console

arsenm added a comment. In D135488#3928567 , @nickdesaulniers wrote: > In D135488#3928559 , @arsenm wrote: > >> In D135488#3928557 , >> @nickdesaulniers wrote: >> >>> Ca

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD added a comment. @mikerice @jyu2 May you accept the revision please if this patch looks good to you? Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD updated this revision to Diff 475563. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570 Files: clang/lib/Sema/SemaStmtAttr.cpp Index: clang/lib/Sema/S

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

asbirlea added a comment. IIUC compile time impact for adding another SROA (the one outside LTO) is negligible? Regarding the principle of adding another pass and where in the pipeline, we're still at a case by case basis. We had a discussion/round table at LLVM Dev on the documenting the curr

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 475570. compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseHL

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

mstorsjo added a comment. This looks reasonable to me, overall. I didn't quite try to follow all the wall-of-text changes in the tests though, but overall fine. Just a couple comments and one case where I didn't find where code went in the refactoring. Comment at: clang/test/

[clang] 05ec16d - [clang][deps] Avoid leaking modulemap paths across unrelated imports

Author: Ben Langmuir Date: 2022-11-15T13:59:26-08:00 New Revision: 05ec16d90deb747414c8534f98617d25d90bb714 URL: https://github.com/llvm/llvm-project/commit/05ec16d90deb747414c8534f98617d25d90bb714 DIFF: https://github.com/llvm/llvm-project/commit/05ec16d90deb747414c8534f98617d25d90bb714.diff

[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

This revision was automatically updated to reflect the committed changes. Closed by commit rG05ec16d90deb: [clang][deps] Avoid leaking modulemap paths across unrelated imports (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

ldionne created this revision. ldionne added reviewers: MaskRay, phosek, arphaman. Herald added subscribers: pmatos, asb, abrachet, StephenFan, jgravelle-google, sbc100, dschuff. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, aheejin.

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

ldionne added a reviewer: clang-vendors. ldionne added a comment. I'm not sure who else to add on this review. Since changing the behavior of user-facing flags can be breaking, I'm adding the vendors. Feel free to suggest more. Note that this was discovered when landing D136683

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3928663 , @asbirlea wrote: > IIUC compile time impact for adding another SROA (the one outside LTO) is > negligible? Yup. > Regarding the principle of adding another pass and where in the pipeline, > we're still

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

jhuber6 added a comment. Thanks for the feedback. Another significant portion of getting this workflow to work for Windows / COFF is parsing the linker arguments. I should be able to look at `lld-link` and add necessarily aliases to what `ld.lld` takes I assume? E.g. we use values like `-o` an

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475574. haowei added a comment. I have to revert back to use process cwd instead of base fs cwd. There are a few tests relied the behavior of using process cwd that I need to take a closer look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D137851: [OPENMP]Initial support for at clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG628fdc3f57ad: [OPENMP]Initial support for at clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. Thanks for the feedback! I have a few questions I'm hoping you can answer. In D135488#3928559 , @arsenm wrote: > I don't think we should be pointing users to -mllvm flags. Plus, I don't > really think random dbgs() printing is

[clang] dcfb250 - [clang][deps] Remove checks that were just for exhaustiveness

Author: Ben Langmuir Date: 2022-11-15T14:22:23-08:00 New Revision: dcfb25078c2629450b393e696b9760721a9f URL: https://github.com/llvm/llvm-project/commit/dcfb25078c2629450b393e696b9760721a9f DIFF: https://github.com/llvm/llvm-project/commit/dcfb25078c2629450b393e696b9760721a9f.diff

[clang] 70dc3b8 - [AggressiveInstCombine] Remove legacy PM pass

Author: Arthur Eubanks Date: 2022-11-15T14:35:15-08:00 New Revision: 70dc3b811e4926fa2c88bd3b53b29c46fcba1a90 URL: https://github.com/llvm/llvm-project/commit/70dc3b811e4926fa2c88bd3b53b29c46fcba1a90 DIFF: https://github.com/llvm/llvm-project/commit/70dc3b811e4926fa2c88bd3b53b29c46fcba1a90.diff

[PATCH] D137116: [AggressiveInstCombine] Remove legacy PM pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70dc3b811e49: [AggressiveInstCombine] Remove legacy PM pass (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D137116?vs=4

[clang] 6dee239 - [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

Author: eopXD Date: 2022-11-15T14:37:27-08:00 New Revision: 6dee23919a36a30f3df7e9b20fba8b9edf65340c URL: https://github.com/llvm/llvm-project/commit/6dee23919a36a30f3df7e9b20fba8b9edf65340c DIFF: https://github.com/llvm/llvm-project/commit/6dee23919a36a30f3df7e9b20fba8b9edf65340c.diff LOG: [C

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dee23919a36: [Clang][Sema] Refactor category declaration under… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://revi

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

mstorsjo added a comment. In D137470#3928731 , @jhuber6 wrote: > Another significant portion of getting this workflow to work for Windows / > COFF is parsing the linker arguments. I should be able to look at `lld-link` > and add necessarily aliases to w

[PATCH] D135488: [codegen] Display stack layouts in console

dblaikie added a comment. Any chance we could squirrel the info away (I assume there's a reason we can't compute the info where the warn-stack-size LLVM feature is implemented in PrologEpilogInserter.cpp) somewhere, and emit it as part of the frame-larger-than/warn-stack-size diagnostic? (also

[clang] 063a43b - [ObjC] Fix an assertion failure in EvaluateLValue

Author: Akira Hatanaka Date: 2022-11-15T14:41:28-08:00 New Revision: 063a43b4fd9f869d57c20145302eb41068bfb54e URL: https://github.com/llvm/llvm-project/commit/063a43b4fd9f869d57c20145302eb41068bfb54e DIFF: https://github.com/llvm/llvm-project/commit/063a43b4fd9f869d57c20145302eb41068bfb54e.diff

[PATCH] D135488: [codegen] Display stack layouts in console

dblaikie added a comment. > as a more general diagnostic output, like the other printing passes. As an aside: I don't think any "printing pass" is designed to be used beyond LLVM compiler engineers - they're implementation details of the compiler, even/much moreso than the optimization remarks

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 475589. Febbe added a comment. fixed lamda detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

jhuber6 added a comment. In D137470#3928828 , @mstorsjo wrote: > Sorry, I'm not quite up to speed with exactly what is being done linker-wise > here - can you give a more detailed overview? Keep in mind that there's two > separate interfaces to lld for

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475591. haowei added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml cla

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 ___

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:1010 + std::error_code makeAbsolute(StringRef WorkingDir, + SmallVectorImpl &Path) const; bnbarham wr

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. In D135488#3928831 , @dblaikie wrote: > Any chance we could squirrel the info away (I assume there's a reason we > can't compute the info where the warn-stack-size LLVM feature is implemented > in PrologEpilogInserter.cpp) som

[PATCH] D135488: [codegen] Display stack layouts in console

dblaikie added a comment. In D135488#3928963 , @paulkirth wrote: > In D135488#3928831 , @dblaikie > wrote: > >> Any chance we could squirrel the info away (I assume there's a reason we >> can't compute the info

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 475602. paulkirth added a comment. Rebase and address comments - Replace magic comparison with `MFI.isDeadIbjectIndex()` - Small code improvement by using a constructor w/ `emplace_back` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919 __

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn commandeered this revision. fhahn added a reviewer: CJ-Johnson. fhahn added a comment. Commandeering after the recent updates to make review + follow-ups easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.or

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. In D135488#3928975 , @dblaikie wrote: > Fair enough - could the warn-stack-size warning be moved to there, then, and > then the information included in the warning? It could have both a warning > and remark form, so folks coul

[PATCH] D137259: [clang][modules][deps] WIP: In-memory module transfer

jansvoboda11 updated this revision to Diff 475613. jansvoboda11 added a comment. Fixed two tests: - modules-pch.c by always marking identifier info as not out-of-date when getting leaf module macros, - modules-module-map-order.m by updating the sorting logic for gathering `SortedFiles`. Repos

[PATCH] D137346: -Wunsafe-buffer-usage: Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:29 + /// Invoked when an unsafe operation over raw pointers is found. + virtual void handleUnsafeOperation(const Stmt *Operation) = 0; +}; xazax.hun wrote: > What

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Previously file na

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added a comment. If you're curious, you can see the simplification the YAML output format change makes in the consuming code: https://fuchsia-review.git.corp.google.com/c/fuchsia/+/760570/2/tools/cppdocgen/clangdoc/clangdoc.go Since it allows us to remove some special-casing code for loadi

[PATCH] D135488: [codegen] Display stack layouts in console

nickdesaulniers added a comment. In D135488#3928831 , @dblaikie wrote: > Any chance we could ... emit it as part of the > frame-larger-than/warn-stack-size diagnostic? This pass prints a TON of (helpful) information...we have a lot of `-Wframe-larger-t

[PATCH] D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138058/new/ https://reviews.llvm.org/D138058 ___

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:112 + // double' mode. + static SmallDenseMap AIXLongDoubleBuiltins{ + {Builtin::BI__builtin_frexpl, "frexp"}, Please rename to "AIXLongDouble64Builtins". =

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, jyknight, efriedma, craig.topper. Herald added subscribers: StephenFan, jdoerfert, pengfei, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. He

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 475633. bob80905 added a comment. - remove int overloads - remove double - update tests after new builtin landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 File

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

arsenm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:187 + two inputs may have compared equal in the inline assembly. This is no longer + garunteed (and necessary to support outputs along indirect edges, which is + still not yet supported). T

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

nickdesaulniers updated this revision to Diff 475634. nickdesaulniers added a comment. - typo, iwyu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138078/new/ https://reviews.llvm.org/D138078 Files: clang/docs/ReleaseNotes.rst llvm/docs/LangRef

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

nickdesaulniers updated this revision to Diff 475635. nickdesaulniers added a comment. - another typo in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138078/new/ https://reviews.llvm.org/D138078 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb0ffa529a0f: [lldb] Fix simple template names and template params with scope qualifiers (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212 // Produce replacements to add the qualifiers. std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::"; for (auto Loc : IdentsToQ

[clang] 81e3360 - [Sema] Use the value category of the base expression when creating an

Author: Akira Hatanaka Date: 2022-11-15T17:14:48-08:00 New Revision: 81e33602f78d135c11b0d74d738263fc6cfaae12 URL: https://github.com/llvm/llvm-project/commit/81e33602f78d135c11b0d74d738263fc6cfaae12 DIFF: https://github.com/llvm/llvm-project/commit/81e33602f78d135c11b0d74d738263fc6cfaae12.diff

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: nikic, aeubanks, tejohnson. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, ormris, cota, teijeong,

[PATCH] D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG81e33602f78d: [Sema] Use the value category of the base expression when creating an (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri updated this revision to Diff 475649. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. @rjmccall thank you for taking a look! I do believe this now does the right thing. I would like to keep this patch minimal. I have not looked into `-fno-exceptions`, and i'm n

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2028 +// FIXME: what about FuncletPads? +if (llvm::BasicBlock *InvokeBB = Builder.GetInsertBlock(); +SanOpts.has(SanitizerKind::Exception

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. As a quick test, I hacked the printer pass to generate an output string, and passed that into the remarks emitter. From opt or llc things look as expected. There's some additional output, but its limited. I see a more serious issue when using it from Clang, as the out

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ChuanqiXu updated this revision to Diff 475663. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/test/Driver/save-

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ChuanqiXu updated this revision to Diff 475664. ChuanqiXu added a comment. Use tests with `-###` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/test/Driver/s

[PATCH] D135488: [codegen] Display stack layouts in console

arsenm added a comment. The kernel resource remarks added in 67357739c6d36a61972c1fc0e829e35cb5375279 are probably the current heaviest remarks. I believe there were some changes to newline handling for it Repository: rG

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added a comment. In D137217#3926601 , @tejohnson wrote: > @MaskRay wondering if this is a good change to make for ELF as well, wdyt? Yes, I think this is a good idea and improves debuggability. The change is non-trivial so so this patch focusing

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added inline comments. Comment at: lld/COFF/LTO.cpp:229 +StringRef ltoObjName; +if (bitcodeFilePath == "ld-temp.o") { + ltoObjName = MaskRay wrote: > tejohnson wrote: > > zequanwu wrote: > > > tejohnson wrote: > > > > This case should always

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

kawashima-fj created this revision. kawashima-fj added a project: clang. Herald added a project: All. kawashima-fj requested review of this revision. Herald added a subscriber: cfe-commits. Sphinx has the `option` directive. Most option descriptions in `clang/docs/UsersManual.rst` used it but som

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

efriedma added a comment. You can't put transforms that are necessary for correctness in CodeGenPrepare; it isn't enabled at -O0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138078/new/ https://reviews.llvm.org/D138078 _

[clang] 40c1476 - [clang-format][NFC] Improve documentation on ReflowComments

Author: Björn Schäpers Date: 2022-11-16T07:02:10+01:00 New Revision: 40c1476e3ae24766426802a61b15f374285c443b URL: https://github.com/llvm/llvm-project/commit/40c1476e3ae24766426802a61b15f374285c443b DIFF: https://github.com/llvm/llvm-project/commit/40c1476e3ae24766426802a61b15f374285c443b.diff

[clang] cb01bef - [clang-format][NFC] Improve documentation of FixNamespaceComments

Author: Björn Schäpers Date: 2022-11-16T07:02:10+01:00 New Revision: cb01befda5479b0368d40582f046eec44fda3cec URL: https://github.com/llvm/llvm-project/commit/cb01befda5479b0368d40582f046eec44fda3cec DIFF: https://github.com/llvm/llvm-project/commit/cb01befda5479b0368d40582f046eec44fda3cec.diff

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40c1476e3ae2: [clang-format][NFC] Improve documentation on ReflowComments (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo C

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman, urnathan. Herald added a project: All. shafik requested review of this revision. Currently `Sema::ClassifyName(...)` in some cases when an `enumerator` is brought into scope via `using enum` during lookup it can end

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

rsmith added a comment. In D137751#3919162 , @alexfh wrote: > I wonder whether we can include SLoc usage information into `-print-stats` > output? Yeah, we could extend the source manager information there with something like this. It's a bit awkward t

<    1   2   3   >