arsenm added a comment. In D135488#3928557 <https://reviews.llvm.org/D135488#3928557>, @nickdesaulniers wrote:
> Can we add a `Note` diagnostic when we emit a `-Wframe-larger-than=` that > alludes to re-running with `-mllvm -print-stack-frame` to get additional info? > > We should update the release notes of clang to mention this feature, too. I don't think we should be pointing users to -mllvm flags. Plus, I don't really think random dbgs() printing is going to interact correctly with other diagnostics ================ Comment at: llvm/lib/CodeGen/StackFramePrinterPass.cpp:120-122 + // This is a dead slot, so skip it + if (Size == ~0ULL) + continue; ---------------- Check MFI.isDead instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
