dblaikie added a comment.

Any chance we could squirrel the info away (I assume there's a reason we can't 
compute the info where the warn-stack-size LLVM feature is implemented in 
PrologEpilogInserter.cpp) somewhere, and emit it as part of the 
frame-larger-than/warn-stack-size diagnostic?

(also, we do already have an opt remark for stack frame size in general (in 
PrologEpilogInserter, very close to where warn-stack-size is implemented), so 
it seems OK to use the remark infrastructure for a more detailed stack report - 
but ideally if the point is to make frame-larger-than better, it'd be good to 
include the info in that diagnostic)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to