[clang] 316e259 - [clang-format][NFC] More sorting in getLLVMStyle()

Author: Björn Schäpers Date: 2022-11-10T22:36:25+01:00 New Revision: 316e2599029ef2c4c742d225dec1bc12f30acbf7 URL: https://github.com/llvm/llvm-project/commit/316e2599029ef2c4c742d225dec1bc12f30acbf7 DIFF: https://github.com/llvm/llvm-project/commit/316e2599029ef2c4c742d225dec1bc12f30acbf7.diff

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

rjmccall added a comment. You really can't ask whether a class template pattern is standard layout; it's not meaningful. How are pointers and references passed to kernels? Does the pointee get copied or something? If so, you may have a requirement that pointee types be complete, in which cas

Re: How can Autoconf help with the transition to stricter compilation defaults?

* Rich Felker: > I've been writing/complaining about autoconf doing this wrong for > decades, with the best writeup around 9 years ago at > https://ewontfix.com/13/. Part of the reason is that this has bitten > musl libc users over and over again due to configure finding symbols > that were intend

[PATCH] D137753: [Clang][GNU][AIX}[p]Enable -p Functionality

francii updated this revision to Diff 474604. francii added a comment. Added Linux implementation and test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOp

[PATCH] D137545: [clang][Interp] DerivedToBase casts

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137545/new/ https://reviews.llvm.org/D137545 ___

[PATCH] D137558: [clang][Interp] Reject reinterpret_casts

shafik added a comment. In D137558#3915350 , @aaron.ballman wrote: > This is lacking test coverage. (Other interesting related test coverage are > casts that perform a reinterpret_cast under the hood but that might be > somewhat separate.) Well I thin

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

Anastasia added a comment. In D134445#3920188 , @rjmccall wrote: > You really can't ask whether a class template pattern is standard layout; > it's not meaningful. Well the templates have to be instantiated with concrete types as kernels can't be calle

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

michele.scandale accepted this revision. michele.scandale added a comment. This revision is now accepted and ready to land. This looks good for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137578/new/ https://reviews.llvm.org/D137578

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

shafik added a comment. I am in the committee meeting this week but if you ping next week I should have time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 _

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost updated this revision to Diff 474615. red1bluelost added a comment. Adds tests for the TokenAnnotator as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137755/new/ https://reviews.llvm.org/D137755 Files: clang/lib/Format/TokenA

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost marked an inline comment as done. red1bluelost added a comment. Made a GitHub issue and addressed the current comments. :) Comment at: clang/lib/Format/TokenAnnotator.cpp:2355 +NextToken->isOneOf(tok::arrow, tok::equal, tok::kw_noexcept, tok::comma, +

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar added a comment. In D137669#3915899 , @mstorsjo wrote: > This does, somewhat, coincide with what I'm trying to do in D131052 > . There, I don't point out the binaries for > `FileCheck` and similar, but point ou

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mstorsjo added a comment. In D137669#3920309 , @tstellar wrote: > In D137669#3915899 , @mstorsjo > wrote: > >> This does, somewhat, coincide with what I'm trying to do in D131052 >>

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

fhahn accepted this revision. fhahn added a comment. LGTM with the suggested changes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits ma

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8767-8770 const_cast(*Context), Context->getTranslationUnitDecl(), /*Inline*/ false, SourceLocation(), SourceLocation(), &Context->Idents.get("std"), +/*PrevDecl*/ nullptr, /

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. For me this looks good, but please wait for one of the others to double confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 474620. reames added a comment. Address Kito's review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/lib/

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

arphaman accepted this revision. arphaman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D137806: [AST] Fix class layout when using external layout under MS ABI.

zequanwu created this revision. zequanwu added a reviewer: rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137806 Files: clang/li

[PATCH] D137806: [AST] Fix class layout when using external layout under MS ABI.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/override-layout-virtual-base.cpp:25-43 +// CHECK: *** Dumping AST Record Layout +// CHECK-NEXT: 0 | struct S2 +// CHECK-NEXT: 0 | (S2 vftable pointer) +// CHECK-NEXT: 8 | (S2 vbt

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-10 10:19, Aaron Ballman wrote: In terms of the Clang side of things, I don't think we've formed any sort of official stance on how to handle that yet. It's UB (you can declare the C standard library interface without UB but calling any function with a mismatched signature is UB) The

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

rjmccall added a comment. In D134445#3920257 , @Anastasia wrote: > In D134445#3920188 , @rjmccall > wrote: > >> You really can't ask whether a class template pattern is standard layout; >> it's not meaningful. >

[clang] 97105e5 - [libclang] Expose completion result kind in `CXCompletionResult`

Author: Egor Zhdan Date: 2022-11-10T16:16:36-08:00 New Revision: 97105e5bf70fae5d9902081e917fd178b57f1717 URL: https://github.com/llvm/llvm-project/commit/97105e5bf70fae5d9902081e917fd178b57f1717 DIFF: https://github.com/llvm/llvm-project/commit/97105e5bf70fae5d9902081e917fd178b57f1717.diff LO

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 474628. bob80905 added a comment. - add dependency on architecture before testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensi

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

This revision was automatically updated to reflect the committed changes. Closed by commit rG97105e5bf70f: [libclang] Expose completion result kind in `CXCompletionResult` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added inline comments. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1 << 1 }; + aaron.ballman wrote: > I'm not really loving the `F_` prefixes -- the enumerators are already > privately scoped

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added inline comments. Comment at: clang/test/AST/ast-dump-decl.cpp:1 -// Test without serialization: -// RUN: %clang_cc1 -std=c++11 -triple x86_64-linux-gnu -fms-extensions \ -// RUN: -ast-dump -ast-dump-filter Test %s \ -// RUN: | FileCheck --strict-whitespace %s -// -

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

SixWeining added a comment. This change was pushed yesterday, but it's not the last diff. I will submit a follow-up change as soon as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136146/new/ https://reviews.llvm.org/D136146 ___

[clang] 6890b9b - Add missing changes for "[Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options"

Author: Weining Lu Date: 2022-11-11T09:06:53+08:00 New Revision: 6890b9b71e525020ab58d436336664beede71575 URL: https://github.com/llvm/llvm-project/commit/6890b9b71e525020ab58d436336664beede71575 DIFF: https://github.com/llvm/llvm-project/commit/6890b9b71e525020ab58d436336664beede71575.diff LO

[clang] da34aff - [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

Author: gonglingqin Date: 2022-11-11T09:16:57+08:00 New Revision: da34aff90d2b08f8172dd4942e398fc0c012399c URL: https://github.com/llvm/llvm-project/commit/da34aff90d2b08f8172dd4942e398fc0c012399c DIFF: https://github.com/llvm/llvm-project/commit/da34aff90d2b08f8172dd4942e398fc0c012399c.diff L

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda34aff90d2b: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add… (authored by gonglingqin). Changed prior to commit: http

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130326/new/ https://reviews.llvm.org/D130326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. R

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

ChuanqiXu added a comment. I think it might be necessary/better to add a test for this. Otherwise, it looks not good to change this. > This fixes the assertion for a downstream case in ROOT/Cling with the > involvement of modules. If anyone has ideas how to test this, please let me > know...

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Although I'm not familiar with Objc, the change here looks good generally. Comment at: clang/include/clang/Sema/Sema.h:10091-10096 ObjCProtocolDecl *ActOnStartProtoc

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ChuanqiXu added a comment. @dblaikie @ben.boeckel gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ChuanqiXu added a comment. @ben.boeckel gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D137531: [clang] Add the check of decltype in derived templates for issue #58674

shafik added inline comments. Comment at: clang/docs/ReleaseNotes.rst:787 operator. -- ``clang_Cursor_getNumTemplateArguments``, ``clang_Cursor_getTemplateArgumentKind``, - ``clang_Cursor_getTemplateArgumentType``, ``clang_Cursor_getTemplateArgumentValue`` and +- ``clang_

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18251-18252 + SemaRef.tryCaptureVariable(V, Loc, Sema::TryCapture_Implicit, + /*EllipsisLoc*/ SourceLocation(), + /*BuildAndDiagnose*/ true, CaptureType,

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

shafik added inline comments. Comment at: clang/lib/AST/ExprConcepts.cpp:112-113 + return ConceptSpecializationExpr::Create( + C, NNS, TemplateKWLoc, ConceptNameInfo, FoundDecl, NamedConcept, nullptr, + nullptr, Satisfaction); +} I think I got the para

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

shafik added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3980 +Elem.second = new GlobalVariable( +M, Ty, /*IsConstant*/ false, GlobalValue::CommonLinkage, +Constant::getNullValue(Ty), Elem.first(), Repository: r

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

shafik added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:2251 + uint64_t CountedSize = 0; + for (int IDIndex = -(int)LoadedSLocEntryTable.size() - 1; + IDIndex < (int)LocalSLocEntryTable.size(); ++IDIndex) { alexfh wrote: > Could you ad

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:720 (!Previous.Previous || !Previous.Previous->isOneOf( - tok::kw_for, tok::kw_while, tok::kw_switch)) && + tok::r_paren, tok::kw_for, tok

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXVentana.td:14 +//===--===// +// -XVentanaCondOps +//===--==

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

bruno accepted this revision. bruno added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Very nice how this has improved since the version I worked on in the past, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130326/new/ http

[clang] a5d14f7 - Add builtin_elementwise_sin and builtin_elementwise_cos

Author: Joshua Batista Date: 2022-11-10T23:30:27-08:00 New Revision: a5d14f757bb1afa47925d7d77bea6bf73bbe0434 URL: https://github.com/llvm/llvm-project/commit/a5d14f757bb1afa47925d7d77bea6bf73bbe0434 DIFF: https://github.com/llvm/llvm-project/commit/a5d14f757bb1afa47925d7d77bea6bf73bbe0434.diff

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5d14f757bb1: Add builtin_elementwise_sin and builtin_elementwise_cos (authored by bob80905, committed by python3kgae). Changed prior to commit: https://reviews.llvm.org/D135011?vs=474628&id=474667#toc

[clang] 7863646 - [clang][Interp] DerivedToBase casts

Author: Timm Bäder Date: 2022-11-11T08:38:06+01:00 New Revision: 7863646fd206952492b9abdbf690be2c4198d728 URL: https://github.com/llvm/llvm-project/commit/7863646fd206952492b9abdbf690be2c4198d728 DIFF: https://github.com/llvm/llvm-project/commit/7863646fd206952492b9abdbf690be2c4198d728.diff LO

[PATCH] D137545: [clang][Interp] DerivedToBase casts

This revision was automatically updated to reflect the committed changes. Closed by commit rG7863646fd206: [clang][Interp] DerivedToBase casts (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137545/new/ https://reviews.llvm.org/

[clang] 0dcfd0c - [clang][Interp] Support alignof()

Author: Timm Bäder Date: 2022-11-11T08:38:06+01:00 New Revision: 0dcfd0ce020b4d5fb8d9eb549150d750a6bab68d URL: https://github.com/llvm/llvm-project/commit/0dcfd0ce020b4d5fb8d9eb549150d750a6bab68d DIFF: https://github.com/llvm/llvm-project/commit/0dcfd0ce020b4d5fb8d9eb549150d750a6bab68d.diff LO

[PATCH] D137240: [clang][Interp] Support alignof()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0dcfd0ce020b: [clang][Interp] Support alignof() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 99d3ead - [clang][Interp] Protect Record creation against infinite recursion

Author: Timm Bäder Date: 2022-11-11T08:38:06+01:00 New Revision: 99d3ead44cfb21dca24c63a0b0731eaad54b491e URL: https://github.com/llvm/llvm-project/commit/99d3ead44cfb21dca24c63a0b0731eaad54b491e DIFF: https://github.com/llvm/llvm-project/commit/99d3ead44cfb21dca24c63a0b0731eaad54b491e.diff LO

[PATCH] D136831: [clang][Interp] Protect Record creation against infinite recusion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99d3ead44cfb: [clang][Interp] Protect Record creation against infinite recursion (authored by tbaeder). Changed prior to commit: https://reviews.l

<    1   2