mstorsjo added a comment. In D137669#3920309 <https://reviews.llvm.org/D137669#3920309>, @tstellar wrote:
> In D137669#3915899 <https://reviews.llvm.org/D137669#3915899>, @mstorsjo > wrote: > >> This does, somewhat, coincide with what I'm trying to do in D131052 >> <https://reviews.llvm.org/D131052>. There, I don't point out the binaries >> for `FileCheck` and similar, but point out preexisting native `llvm-tblgen`, >> `clang-tblgen` etc (to avoid needing to build them in a nested native cmake >> when cross compiling) - but if they exist, they would probably be in the >> same directory. Would it make sense to try to settle on a common variable >> name for both of these? Or is there a case where we specifically need to be >> able to differentiate between the two? > > Do you mean creating a common variable name for the path to llvm utils? Yes, exactly. The use cases are maybe slightly separate, but still, in both cases it'd be a path to a directory containing native versions of `not`, `FileCheck`, `llvm-tblgen` etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137669/new/ https://reviews.llvm.org/D137669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
