[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. I'd really use some help with the buildbot failures because I can't even figure out how to reproduce them: https://lab.llvm.org/buildbot#builders/169/builds/13146 https://lab.llvm.org/buildbot#builders/70/builds/29330 https://lab.llvm.org/buildbot#builders/37/builds/17758

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang updated this revision to Diff 472219. HaoyuZhang added a comment. 1. Modify the DocBrief contents for fsample-profile-use-profi. 2. Add a checking for -fsample-profile-use-profi that this args only allowed with -fprofile-sample-use (has a profile). 3. Modify the test case and change th

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added inline comments. Comment at: clang/include/clang/Driver/Options.td:1254 +HelpText<"Use profi to infer block and edge counts.">, +DocBrief<[{Profi - a flow-based profile inference algorithm is an extended + and significantly re-engineered cla

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

iains added a comment. In D137059#3898239 , @ChuanqiXu wrote: > In D137059#3896661 , @dblaikie > wrote: > >> Could you link to the email/discourse discussion about supporting this mode >> (I think you've linked

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 47. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ChuanqiXu added a comment. In D137059#3898463 , @iains wrote: > In D137059#3898239 , @ChuanqiXu > wrote: > >> In D137059#3896661 , @dblaikie >> wrote: >> >>> Could you l

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

nridge added a comment. In D121593#3896892 , @Abpostelnicu wrote: > was there any progress on this so far? This would be really useful to be a > clang-tidy check. My impression is that it's actively being worked on: https://reviews.llvm.org/search/que

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ChuanqiXu added a comment. In D137058#3896999 , @dblaikie wrote: > @ben.boeckel maybe this'd be the place to discuss the motivation for this > feature (picking up from your comment here: > https://reviews.llvm.org/D134267#3892629 ) > > admittedly there

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

pcwang-thead updated this revision to Diff 472228. pcwang-thead added a comment. - Add release note. - Add tests to `riscv-cpus.c`. - Add `getRISCVTargetCPU`. - Make diagnostic more exact for `native`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added a comment. In D135937#3898228 , @FreddyYe wrote: > For saving capacity of ProcessorSubtypes, gcc decided to not support part of > compiler features of these two cpus: > > __builtin_cpu_is("meteorlake") > __attribute__((target("arch=rap

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

iains added a comment. In D137059#3898482 , @ChuanqiXu wrote: > In D137059#3898463 , @iains wrote: > >> In D137059#3898239 , @ChuanqiXu >> wrote: >> >>> In D137059#389666

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

ssarda added a comment. Herald added a project: All. This patch is causing issue mentioned in https://discourse.llvm.org/t/sema-section-type-conflict/66000 @chill can you check once? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ChuanqiXu added a comment. > Having a mechanism to specify the place for the file is fine by me ( I was > only commenting on the motivation point for separate pcm and object phases ). > > (I think we should move this discussion somewhere else, again - unless it is > considered a key factor in de

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge updated this revision to Diff 472235. nridge added a comment. Improve handling of config file diagnostics in lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 Files: clang-tools-extra/clan

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added inline comments. Comment at: clang-tools-extra/clangd/test/system-include-extractor.test:82 + +# Skip past the lack of diagnostics in the workspace and user config files... +# CHECK2: "method": "textDocument/publishDiagnostics", nridge wrote: > Ugh

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhenderson added inline comments. Comment at: llvm/test/tools/llvm-objdump/Offloading/elf_dynamic.test:1 -## Check that we can dump an offloading binary directly. -# RUN: yaml2obj %S/Inputs/binary.yaml -o %t.bin -# RUN: llvm-objdump --offloading %t.bin | FileCheck %s --match-full

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

nikic added a comment. In D134410#3895253 , @nlopes wrote: > In D134410#3895077 , @nikic wrote: > >> In D134410#3894995 , @nlopes wrote: >> >>> We wanted this patch to mak

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:458 // data. Later we may want to support some backward compatibility. -constexpr static uint32_t Version = 17; +constexpr static uint32_t Version = 18; I don't think in

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2966 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"), - cls("na::nb::Clangd4")}, + cls("na::nb::Clangd4"), enmConstant("na::C::Clangd5")}, Opts); -

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

nlopes added a comment. In D134410#3898563 , @nikic wrote: > In D134410#3895253 , @nlopes wrote: > >> In D134410#3895077 , @nikic wrote: >> >>> In D134410#3894995

[PATCH] D136090: Handle errors in expansion of response files

uabelho added a comment. Hello, I'm wondering if this is really working as expected/intended. With this patch, if I do clang empty.c @atfileesc.txt -dry-run on an empty file empty.c and atfileesc.txt containing just -I @name-with-at/ then I get the following error cannot open file: /r

[PATCH] D82562: Implement AVX ABI Warning/error

jajadude added a comment. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. if (Callee->getReturnType()->isVectorType() && CGM.getContext().getTypeSize(Callee->getReturnType()) > 128) { } I think this condition will make features like ext_vector_type to be warnings

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, hiraditya. Herald added a project: All. hdelan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jholewinski. Herald added projects: clang, LLVM. This patch adds __nvvm_refl

[PATCH] D137073: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5020 +std::string AsmName; +if (auto *A = FD->getAttr()) { + StringRef UserLabelPrefix = rnk wrote: > I think you can call CGM.getMangledName, but I might be wrong. It's worth

[PATCH] D137073: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

mstorsjo updated this revision to Diff 472257. mstorsjo added a comment. Use `CGM.getMangledName()`, simplifying the code instead of complicating it further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137073/new/ https://reviews.llvm.org/D13707

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + ``` static_assert(IntRem(9, 0) == 12, ""); // Not constexpr static_assert(IntRem(__INT_MIN_

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn< samitolvane

[PATCH] D137073: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

mstorsjo added reviewers: serge-sans-paille, nickdesaulniers. mstorsjo added a comment. This seems like a followup to D134362 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137073/new/ https://reviews.llvm.org/D13

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 updated this revision to Diff 472265. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136796/new/ https://reviews.llvm.org/D136796 Files: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

[PATCH] D137075: [clang-format] Fix document of AlignTrailingComments

yusuke-kadowaki added a comment. Thank you. Please land when you have time. name: Yusuke Kadowaki email: yusuke.kadowaki.1...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137075/new/ https://reviews.llvm.org/D137075 ___

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane updated this revision to Diff 472268. erichkeane added a comment. fix clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/inclu

[PATCH] D137154: Adding nvvm_reflect clang builtin

asavonic added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:1581 def int_nvvm_reflect : - Intrinsic<[llvm_i32_ty], [llvm_anyptr_ty], [IntrNoMem], "llvm.nvvm.reflect">; + Intrinsic<[llvm_i32_ty], [llvm_ptr_ty], [IntrNoMem], "llvm.nvvm.reflect">, + ClangB

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added a comment. Thanks. What was wrong with the v9-A features? Comment at: llvm/unittests/Support/TargetParserTest.cpp:1083 + AArch64::AEK_SVE | AArch64::AEK_SVE2 | + AArch64::AEK_SVE2BITPERM | AArch64::AEK_SB | +

[PATCH] D136554: Implement CWG2631

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9602-9604 +return Ctx.Context == + ExpressionEvaluationContext::PotentiallyEvaluatedIfUsed || + Ctx.IsCheckingDefaultArgumentOrInitializer; Hmm, it'd be n

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis updated this revision to Diff 472270. TIFitis marked an inline comment as done. TIFitis added a comment. Fixed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/ https://reviews.llvm.org/D136872 Files: clang/lib/CodeGen/C

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

hans added a comment. Relatedly, we ran into a problem with `clang-cl /showIncludes` not including all files in its output when they're linked: https://github.com/llvm/llvm-project/issues/58726 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135220/

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

tschuett added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. What happened with native detection?

[PATCH] D136554: Implement CWG2631

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5927 + bool VisitSourceLocExpr(SourceLocExpr *E) { +HasImmediateCalls = true; +return RecursiveASTVisitor::VisitStmt(E); aaron.ballman wrote: > It may be worth a comment that th

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added a subscriber: david-arm. dmgreen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. t

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:1581 def int_nvvm_reflect : - Intrinsic<[llvm_i32_ty], [llvm_anyptr_ty], [IntrNoMem], "llvm.nvvm.reflect">; + Intrinsic<[llvm_i32_ty], [llvm_ptr_ty], [IntrNoMem], "llvm.nvvm.reflect">, + ClangBui

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:1254 +HelpText<"Use profi to infer block and edge counts.">, +DocBrief<[{Profi - a flow-based profile inference algorithm is an extended + and significantly re-engineered classic M

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:272 +- Fix a number of recursively-instantiated constraint issues, which would possibly + result in clang's stack-exhaustion. + `Issue 44304 `_ -

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Ok, I think I know what the problem is — these buildbots rely on being able to override `LLVM_CONFIG_PATH`. I'm going to see if I can provide backwards compatibility with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:150 +namespace { +struct SatisfactionStackRAII { + Sema &SemaRef; aaron.ballman wrote: > Er, it'd be nice for this not to shadow the name of

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny updated this revision to Diff 472285. mgorny added a comment. Add a backwards compatibility path that uses `LLVM_CONFIG_PATH` to locate LLVM CMake files. I think it's sufficient to use path relative to the specified location, and we don't want to actually call it. Restore the explicit wa

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. @phosek, could you take another look? The only changes are on top of `load_llvm_config`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list cfe-comm

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane updated this revision to Diff 472286. erichkeane added a comment. Fix issues aaron came up with. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:150 +namespace { +struct SatisfactionStackRAII { + Sema &SemaRef; erichkeane wrote: > aaron.ballman wrote: > > Er, it'd be nice for this not to shadow the name of the class from `Sem

[PATCH] D137154: Adding nvvm_reflect clang builtin

asavonic added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:1581 def int_nvvm_reflect : - Intrinsic<[llvm_i32_ty], [llvm_anyptr_ty], [IntrNoMem], "llvm.nvvm.reflect">; + Intrinsic<[llvm_i32_ty], [llvm_ptr_ty], [IntrNoMem], "llvm.nvvm.reflect">, + ClangB

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

tschuett added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``. dmgreen wrote: > tschuett wrote: > > Wh

[PATCH] D137082: [clang][Interp] Fix dereferencing arrays with no offset applied

aaron.ballman added a comment. > There is a difference between a Pointer and a "Pointer to the first element > of an array". I'm pretty confused because this statement is false per the language standard (http://eel.is/c++draft/expr.sub#2). Basically, array subscripting works through pointer ar

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:261 `Issue 47136 `_ +- Fix a crash when btf_type_tag attr is

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw accepted this revision. sstwcw added a comment. This revision is now accepted and ready to land. Thanks for fixing the problem I caused. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe

[PATCH] D136936: [clang][Interp] Handle undefined functions better

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:30 if (!FuncDecl->isDefined(FuncDecl) || - (!FuncDecl->hasBody() && FuncDecl->willHaveBody())) -return nullptr; + (FuncDecl->hasBody() && FuncDecl->willHaveBody())) +Has

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 472224. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h cl

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/disambiguate-decl-stmt.cpp:28-33 +namespace Ns {namespace Ns { void Ns(); void Fs();}} +void Ns::Ns::Ns() { printf("void Ns::Ns::Ns()\n"); } +void Ns::Ns::Fs() {} + +Ns::Ns::Fs(); +Ns::Ns::Ns(); --

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

aaron.ballman added a comment. Can you also add a test for `#elifdef` and `#elifndef`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw added a comment. It just occurred to me that klimek is the one who added all this stuff. Why didn't you include him as a reviewer? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 ___ cfe-com

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:150 +namespace { +struct SatisfactionStackRAII { + Sema &SemaRef; aaron.ballman wrote: > erichkeane wrote: > > aaron.ballman wrote: > > > Er

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane updated this revision to Diff 472298. erichkeane marked an inline comment as done. erichkeane added a comment. A quick 'quality of life' improvement, otherwise same as before. Should be ready for commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://revi

[clang] 0933b8c - Update a stale comment; NFC

Author: Aaron Ballman Date: 2022-11-01T10:47:30-04:00 New Revision: 0933b8c72c52dd7f11c6af5f86ce8af01cb194be URL: https://github.com/llvm/llvm-project/commit/0933b8c72c52dd7f11c6af5f86ce8af01cb194be DIFF: https://github.com/llvm/llvm-project/commit/0933b8c72c52dd7f11c6af5f86ce8af01cb194be.diff

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ben.boeckel added a comment. In D137058#3896999 , @dblaikie wrote: > Could you expound a bit on why "write the .pcm to the same path as the .o" > isn't sufficient? (like Split DWARF does this, for instance - not sure we > have lots of other things to ex

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song updated this revision to Diff 472305. yonghong-song added a comment. - improve the bug description in release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136807/new/ https://reviews.llvm.org/D136807 Files: clang/docs/Releas

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

tahonermann updated this revision to Diff 472306. tahonermann added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX

[clang] 2f047b5 - [clang][Sema] Fix a clang crash with btf_type_tag

Author: Yonghong Song Date: 2022-11-01T08:07:13-07:00 New Revision: 2f047b56ba0e4830b617999a386f6fea79c16c91 URL: https://github.com/llvm/llvm-project/commit/2f047b56ba0e4830b617999a386f6fea79c16c91 DIFF: https://github.com/llvm/llvm-project/commit/2f047b56ba0e4830b617999a386f6fea79c16c91.diff

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f047b56ba0e: [clang][Sema] Fix a clang crash with btf_type_tag (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan updated this revision to Diff 472310. hdelan added a comment. Removing redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137154/new/ https://reviews.llvm.org/D137154 Files: llvm/lib/Target/NVPTX/NVVMReflect.cpp Index: llvm/l

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan updated this revision to Diff 472311. hdelan added a comment. Removing redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137154/new/ https://reviews.llvm.org/D137154 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/t

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:282 + bool isGlobalDecl(const VarDecl *VD) const { +return !VD->hasLocalStorage() || VD->isConstexpr(); + } shafik wrote: > tbaeder wrote: > > shafik wrote: > > > Why not `has

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472315. cor3ntin marked 8 inline comments as done. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @aaron.ballman I tried to address your comment, except that: - There is a bug with default parameter in blocks so that can't be tested - Clang does not support default initialization of capture, and if it did, I don't thee how we could support immediate calls in that e

[PATCH] D137082: [clang][Interp] Fix dereferencing arrays with no offset applied

tbaeder added a comment. In D137082#3899032 , @aaron.ballman wrote: >> There is a difference between a Pointer and a "Pointer to the first element >> of an array". > > I'm pretty confused because this statement is false per the language standard > (htt

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472319. cor3ntin added a comment. Revert code committed accidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D136554: Implement CWG2631

tahonermann added a comment. > There is a bug with default parameter in blocks so that can't be tested Block expressions don't actually support default arguments due to the type erasure that is fundamental to how they are implemented. Clang should diagnose default arguments in block expressions

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 472321. friss added a comment. Add version number in cache file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKi

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ben.boeckel added a comment. There is another motivating factor for 1-phase: the build graph is far simpler. With 2-phase, CMake will have to write out rules to perform: - source -> .bmi - .bmi -> .withbmi.o - source -> .o because we do not know if a BMI is needed or not. If it isn't we use the

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. Just to be clear, in any case, this patch here is ready to go as long as it doesn't flip the default, yes? > @thakis do you mind explaining the issues you see and how to replicate them > and I can have a look. See above (`-fmessage-length` gets embedded and is machine-d

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || philnik wrote: > a

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137172 Files: clang/docs/ReleaseNotes.rst clang/lib/

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472337. cor3ntin added a comment. Thanks Tom for the useful info. I modified the code and comment accordingly. Ideally we would assert but we can't until that other issue is fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D137073: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137073/new/ https://reviews.llvm.org/D137073 _

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

lenary added a comment. Reverse ping. This has been accepted, what is the status of landing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D137175: [Driver][test] Remove one more obselete REQUIRES: clang-driver

lamb-j created this revision. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These were globally removed by 63fbc77 but this one wa

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added a comment. In D123630#3899550 , @lenary wrote: > Reverse ping. This has been accepted, what is the status of landing this? As far as I can tell this has landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://r

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

lenary added a comment. Oh, can you close this revision and link it to the landed commit please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits

[PATCH] D137154: Adding nvvm_reflect clang builtin

tra added a subscriber: yaxunl. tra added a comment. I don't think it's a good idea. `__nvvm_reflect` is a hack that we should not propagate. The only code that currently relies on it is NVIDIA's libdevice bitcode and I'd prefer to keep it that way. Can you elaborate on what motivates this chan

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ldionne added a comment. In D136533#3896536 , @mizvekov wrote: > Now that you mention it, looking at the code, I think we don't diagnose an > use of a type alias itself, if that is what you mean? > > Ie, clang doesn't, GCC does, MSVC doesn't: https://god

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

aeubanks updated this revision to Diff 472351. aeubanks added a comment. on by default Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. Thank you for the update to this! Comment at: clang/lib/Parse/ParseExpr.cpp:1526 +// This is a temporary fix while we don't support C2x 6.5.2.5p4 +if (getLangOpts().C2x && GetLookAheadToken(2).getKind() == tok::l_brace) { + Diag(Tok,

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

dexonsmith added a comment. In D135220#3870991 , @hans wrote: > One thought, which I'm not sure is relevant, is that this is only observable > for headers which are included more than once, which is rare because normally > there are include guards (or p

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

dexonsmith added a comment. In D135220#3898849 , @hans wrote: > Relatedly, we ran into a problem with `clang-cl /showIncludes` not including > all files in its output when they're linked: > https://github.com/llvm/llvm-project/issues/58726 Interestingl

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || philnik wrote: > a

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

MyDeveloperDay added subscribers: curdeius, djasper, klimek. MyDeveloperDay added a comment. In D137052#3899094 , @sstwcw wrote: > It just occurred to me that klimek is the one who added all this stuff. Why > didn't you include him as a reviewer? @djas

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

ychen added a comment. Thanks for the patch. It looks good to me. About > Note that we DO need to be careful to make sure we still check > constraints properly that are caused by a previous constraint, but not > derived from (such as when a check causes us to check special member > function gene

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane added a comment. In D136975#3899703 , @ychen wrote: > Thanks for the patch. It looks good to me. > > About > >> Note that we DO need to be careful to make sure we still check >> constraints properly that are caused by a previous constraint, but

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 472355. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Driver/Options.td clang/incl

[PATCH] D137179: [clang][Lex] Header search case insensitivity

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Correct D135801 to be case insensitive. Repository: rG LLV

  1   2   3   >