[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder updated this revision to Diff 471161. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.

[PATCH] D136830: [clang-format][NFC] Move BracesRemover tests out of FormatTest.cpp

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136830/new/ https://reviews.llvm.org/D136830 ___

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 471163. tblah edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/li

[PATCH] D136848: [clang][AST] Compare UnresolvedLookupExpr in structural equivalence.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. In D136474#3888455 , @aganea wrote: > In D136474#3888330 , @thakis wrote: > >>> I read that, and I'm indicating that I don't agree. Chromium's requirements >>> are driven by its particular

[PATCH] D135721: [HLSL] Added HLSL this as a reference

aaron.ballman added a comment. Thank you for your patience while I sat and thought about this for a while. I'm not against the idea, but I've definitely got some design concerns with it which I've pointed out in the review. I think this also needs considerably more testing of the codegen and se

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

dblaikie added a comment. Could the test be expanded to test more specifically than "does not crash"? Like is there some part of the output that can't be observed in any other test (that didn't/doesn't crash without this patch) - like the location emitted in some debug info, etc? Repository:

[PATCH] D136828: [clang][Interp] Diagnose uninitialized array record fields

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:501 } else if (FieldType->isArrayType()) { - // FIXME: Arrays need to be handled here as well I think. + const ArrayType *AT = FieldType->getAsArray

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT added a comment. > Do you need someone to land these changes on your behalf? If so, please let > me know what name and email address you'd like used for patch attribution. Yes. My name is Nenad Mikša, e-mail address: dodoentertainm...@gmail.com Comment at: .gitignore:

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

dexonsmith added a comment. In D136624#3888387 , @jansvoboda11 wrote: > I tried optimizing this patch a bit. Instead of creating compact data > structure and using binary search to find the preceding non-affecting file, I > now store the adjustment inf

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

dexonsmith added inline comments. Comment at: clang/test/Modules/non-affecting-module-maps-source-locations.m:32 + +// RUN: %clang_cc1 -I %t/first -I %t/second -I %t/third -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache %t/tu.m -o %t/tu.o dexonsmi

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 471173. mgorny added a comment. Move `LLVM_COMMON_CMAKE_UTILS` earlier and use it for CMakePolicy path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 Files: clang/CMakeLists.txt cmake/Modules/CMakePol

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a reviewer: mstorsjo. mgorny added a comment. @mstorsjo, could you check this version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske added a comment. About the "ftell" problem: The POSIX rules are really an extension of the C standard rules. At `ftell` according to C standard `errno` should be set to a positive value if error occurs. The POSIX rules extend this: `errno` is not changed if no error occurs. This can be

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

rnk added a comment. In D136474#3888527 , @thakis wrote: > That sounds good to me, assuming that you have someone concrete in mind for > who "we" is who's removing the irrelevant flags :) But if nobody's in charge > of that at the moment, imho it makes

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 471174. DoDoENT added a comment. updated new tests that appeared after rebasing to main and removed vim-specific files from .gitignore (I'll keep that downstream). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a comment. I realized I forgot some things I should've mentioned: - This probably deserves a release note, if it doesn't have one already that I missed or forgot about - We should tag #clang-vendors , since this does change ABI. You've alre

[clang] ae116f4 - [RISCV] Drop single letter b extension support

Author: Kito Cheng Date: 2022-10-27T23:53:32+08:00 New Revision: ae116f43ff140edfae166370ab6bc9ae3f556710 URL: https://github.com/llvm/llvm-project/commit/ae116f43ff140edfae166370ab6bc9ae3f556710 DIFF: https://github.com/llvm/llvm-project/commit/ae116f43ff140edfae166370ab6bc9ae3f556710.diff LO

[PATCH] D136812: [RISCV] Drop single letter b extension support

This revision was automatically updated to reflect the committed changes. Closed by commit rGae116f43ff14: [RISCV] Drop single letter b extension support (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136812/new/ https://rev

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. There were no objections on the call. Looks good to me - two minor changes before landing that would make sense: - Fraser suggested tweaking the patch description - Probably worth adding this to `do

[PATCH] D136817: [RISCV] Add H extension

kito-cheng planned changes to this revision. kito-cheng added a comment. Let me do that within this patch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 ___

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/PrimType.h:39 PT_Bool, + PT_Float, PT_Ptr, tbaeder wrote: > sepavloff wrote: > > In contrast to other members of this enumeration, `PT_Float` does not > > designate a concrete type, and it

[PATCH] D136090: Handle errors in expansion of response files

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136090/new/ https://reviews.llvm.org/D136090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

majnemer added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; Izaron wrote: > jcranmer-intel wrote: > > Izaron wrote: > > > aaron.bal

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Add an option -f[no-]hiplib-add-rpath to control whether to pass -rpath to linker for HIP runtime library. By default it is off to

[PATCH] D136789: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager flags

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ReleaseNotes.rst:161 + - The -fexperimental-new-pass-manager and -fno-legacy-pass-manager flags have +been removed. These have been no-ops

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

clementval added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:828 +(`use_device_addr` `(` $use_device_addr^ `:` type($use_device_addr) `)` )? +(`map` `(` $map_type_modifier_val `,` $map_type_val `:` $map_operands^ `:` type($map_operands) `)`

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; majnemer wrote: > Izaron wrote: > > jcranmer-intel wrote: > > > Izaron wr

[PATCH] D136846: [Driver] Enable profi flag as user-facing flag

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. > [Driver] Enable profi flag as user-facing flag Please avoid unclear term "profi" and use "-fsample-profile-use-profi" instead. ==

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

erichkeane added a comment. I noticed in a downstream that this changes how we emit structs to IR sometimes (see https://godbolt.org/z/74xeq9rTj for an example, but the 'no-opaque-pointers' isn't necessary to cause this, just anything that causes emission of the struct). Are we OK with that?

[PATCH] D136859: [HIP] add fmax/fmin for fp16

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added a project: All. yaxunl requested review of this revision. https://reviews.llvm.org/D136859 Files: clang/lib/Headers/__clang_hip_libdevice_declares.h Index: clang/lib/Headers/__clang_hip_libdevice_declares.h

[PATCH] D136846: [Driver] Enable profi flag as user-facing flag

wenlei added a comment. I'm curious why do you need profi to be a driver flag? There're many similar tuning flags that don't have corresponding driver flag. profi is narrower than most tuning flags as it's specific to one component (profile inference) unique to sample PGO. Repository: rG LL

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. Adding clang-vendors because of the potential for disruption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051

[PATCH] D136633: [clang][AST] avoid unnecessary FunctionProtoTypes.FindNodeOrInsertPos call

bruno added a comment. Nice catch, thanks for improving this. Any chance you've got any small enough example that trigger this that could be transformed into a testcase? It would be nice to have a unittest for this, see others in `clang/unittests/AST`. Nitpick: please capitalize `avoid` in the

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 471204. DoDoENT added a comment. apply git-clang-format to changed files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134453/new/ https://reviews.llvm.org/D134453 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D136190: [clang][Sema] remove redundant isTypeValid

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice cleanup, before landing please capitalize `remove` in the title and also add `[NFC]` to it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

sdesmalen created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. sdesmalen requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang. This patch adds the builtin type __SVCount_t to Clang, w

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 471209. craig.topper added a comment. Add to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h llvm/docs/R

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:4156 HelpText<"Do not add -rpath with architecture-specific resource directory to the linker flags">; +def fhiplib_add_rpath: Flag<["-"], "fhiplib-add-rpath">, Flags<[NoArgumentUnused]>, + HelpText

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song added a comment. In D136807#3888317 , @aaron.ballman wrote: > The changes generally look good to me, but can you add a release note for the > fix as well? Yes, will add the bug fix brief description to clang/docs/ReleaseNotes.rst =

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song updated this revision to Diff 471216. yonghong-song added a comment. - Add the bug fix description in Release Note - Actually compare debuginfo btf_type_tag output instead of marking 'expected-no-diagnostics'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

MaskRay added a comment. If an option does not affect compilation, I prefer `--` to `-f` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136854/new/ https://reviews.llvm.org/D136854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 7f93ae8 - [clang] Implement -fstrict-flex-arrays=3

Author: Bill Wendling Date: 2022-10-27T10:50:04-07:00 New Revision: 7f93ae808634e33e4dc9bce753c909aa5f9a6eb4 URL: https://github.com/llvm/llvm-project/commit/7f93ae808634e33e4dc9bce753c909aa5f9a6eb4 DIFF: https://github.com/llvm/llvm-project/commit/7f93ae808634e33e4dc9bce753c909aa5f9a6eb4.diff

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f93ae808634: [clang] Implement -fstrict-flex-arrays=3 (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.or

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; Izaron wrote: > majnemer wrote: > > Izaron wrote: > > > j

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl added a comment. In D136854#3889141 , @MaskRay wrote: > If an option does not affect compilation, I prefer `--` to `-f` I will rename it as --offload-add-rpath Comment at: clang/include/clang/Driver/Options.td:4158 + HelpText<

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; hubert.reinterpretcast wrote: > Izaron wrote: > > majneme

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 471235. paulkirth added a comment. Address comments - fix brancing style - update parameters to use const - use llvm::sort in place of std::sort - remove path strings from debug info in test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; hubert.reinterpretcast wrote: > hubert.reinterpretcast wr

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

MaskRay added a comment. It'll be good if we have a wiki describing how downstream users invoke cmake, so that large cmake refactoring can be verified beforehand. (like usage verification https://github.com/opencollab/llvm-toolchain-integration-test-suite, but for cmake invocations) CHANGES S

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo accepted this revision. mstorsjo added a comment. In D136572#3888630 , @mgorny wrote: > @mstorsjo, could you check this version? LGTM, this seems to work for my usecase (with lld,lldb,clang enabled this way). Thanks for the quick revert and fix

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 471240. akhuang added a comment. Add another debug info strategy to the description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rs

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. Also for the record, I'd love to get rid of this symlink based setup, if I could make cmake produce project files where caching works in the same way. The main requirement for that would be to have the whole cmake build started from the toplevel llvm-project directory

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > That works for me, I just want to make it clear that the long term goal for > the project is that we emit the command line in LF_BUILDINFO by default, > rather than disabling it once and for all. If it's not ready yet, great, > let's disable it and continue. Fully on

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. I am fine with this plan as well. And I am willing to chip in and try to fix the issues with the current implementation since we actually use the feature. @thakis do you mind explaining the issues you see and how to replicate them and I can have a look. Repository: r

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis created this revision. TIFitis added a reviewer: jdoerfert. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis published this revision for review. TIFitis added reviewers: ABataev, jhuber6. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a comment. In D119051#3888906 , @erichkeane wrote: > I noticed in a downstream that this changes how we emit structs to IR > sometimes (see https://godbolt.org/z/74xeq9rTj for an example, but the > 'no-opaque-pointers' isn't necessary to caus

[PATCH] D136874: [clang][LTO] Passing vec-extabi to the Backend on AIX

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:2167 +Module &M, llvm::OffloadEntriesInfoManager &OffloadEntriesInfoManager, +bool isDevice); + Why is this in llvm namespace? This should be qualified further,

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. From what I know, we could always build the GlobalDecl with the base ctor/dtor variant. The complete and deleting variants always delegate to the base variants, and we will only ever emit the SEH fu

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOpts.Finit

[PATCH] D136080: [flang] Add -ffp-contract option processing

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks for implementing this! Comment at: clang/lib/Driver/ToolChains/Flang.cpp:98-99 +} else + // Clang's "fast-honor-pragmas" option is not supported because it is + // non-standard and pragmas

[clang] 488cf10 - [clang][Sema][NFC] Remove redundant isTypeValid

Author: Troy Johnson Date: 2022-10-27T12:48:11-07:00 New Revision: 488cf1038c88a6d7e5378d493a253e1dc6a97cd9 URL: https://github.com/llvm/llvm-project/commit/488cf1038c88a6d7e5378d493a253e1dc6a97cd9 DIFF: https://github.com/llvm/llvm-project/commit/488cf1038c88a6d7e5378d493a253e1dc6a97cd9.diff

[PATCH] D136190: [clang][Sema][NFC] Remove redundant isTypeValid

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG488cf1038c88: [clang][Sema][NFC] Remove redundant isTypeValid (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > hubert.

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. Not sure if this has come up already but this would still crash on template concept C = requires(T a) { foo(a); }; struct D1 { template D1(TO); }; struct D2 { friend void foo(D1); }; static_assert(C); as we only consider conversion to its

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

jcranmer-intel added inline comments. Comment at: clang/test/Sema/constant-builtins-ilogb.cpp:53-63 +// assert smallest subnormal and largest finite numbers +static_assert(__builtin_ilogbf(1.40129846E-45f) == -149); +static_assert(__builtin_ilogbf(3.40282347E+38f) == 127); + +sta

[clang] 439209d - [docs] Fix old path for clang-format

Author: Ji, Jinsong Date: 2022-10-27T13:14:05-07:00 New Revision: 439209dbcbf2ceb09cd445f8f59b26e8b98d4f8e URL: https://github.com/llvm/llvm-project/commit/439209dbcbf2ceb09cd445f8f59b26e8b98d4f8e DIFF: https://github.com/llvm/llvm-project/commit/439209dbcbf2ceb09cd445f8f59b26e8b98d4f8e.diff L

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); std::string ClangLoopStr = (llvm::Twine("clang

[clang] e4ec6ce - Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Author: David Blaikie Date: 2022-10-27T20:41:22Z New Revision: e4ec6ce8a75c208b49b163c81cda90dc7373c791 URL: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791 DIFF: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791.diff LOG:

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:1 //===--- InterpState.cpp - Interpreter for the constexpr VM -*- C++ -*-===// // Probably a separate NFC commit Comment at: clang/lib/AST/Interp/Interp.cpp:465 +b

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

kda added a comment. The bracket builds have finished and they seem to have a conclusive result. The test starts failing with this patch. Built at this patch: https://lab.llvm.org/buildbot/#/builders/236/builds/803 Built at prior patch: https://lab.llvm.org/buildbot/#/builders/236/builds/804

[PATCH] D136854: [HIP] add -fhiplib-add-rpath

yaxunl updated this revision to Diff 471289. yaxunl added a comment. rename to --offload-add-rpath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136854/new/ https://reviews.llvm.org/D136854 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Linux.cpp clang/t

[clang] 0cb65b0 - Revert "[OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info"

Author: Kevin Athey Date: 2022-10-27T13:57:25-07:00 New Revision: 0cb65b0a585c8b3d4a8a2aefe994a8fc907934f8 URL: https://github.com/llvm/llvm-project/commit/0cb65b0a585c8b3d4a8a2aefe994a8fc907934f8 DIFF: https://github.com/llvm/llvm-project/commit/0cb65b0a585c8b3d4a8a2aefe994a8fc907934f8.diff L

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3888667 , @rnk wrote: > I realized I forgot some things I should've mentioned: > > - This probably deserves a release note, if it doesn't have one already that > I missed or forgot about e4ec6ce8a75c208b49b163c81cda9

[PATCH] D136886: [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers created this revision. vabridgers added a reviewer: mizvekov. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. vabridgers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not su

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir created this revision. benlangmuir added a reviewer: steven_wu. Herald added a subscriber: hiraditya. Herald added a project: All. benlangmuir requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Avoid call

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:62 -static cl::opt +static cl::opt AsSecureLogFileName("as-secure-log-file-name", Interestingly, `opt` doesn't have a parser; this code only worked with the default value before. Repos

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added a comment. It might be easier to see the main changes here if you submit the (very nice) refactoring of `EmitAsmStores` first. Comment at: clang/lib/CodeGen/CGStmt.cpp:2358 +// the expression, do the conversion. +if (ResultRegTypes[i] != ResultTruncRegTypes[

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOp

[PATCH] D136886: [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers updated this revision to Diff 471303. vabridgers added a comment. remove commented line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov updated this revision to Diff 471304. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136797/new/ https://reviews.llvm.org/D136797 Files: clang-tools-extra/clang-tidy/

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov marked 3 inline comments as done. alexander-shaposhnikov added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249 unless(isVariadic()), parameterCountIs(0), +unless(hasP

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249 unless(isVariadic()), parameterCountIs(0), +unless(hasParent(functionTemplateDecl())), IsPublicOrOutOfLine

[clang] e8433a2 - Update docs for -fuse-ctor-homing

Author: Amy Huang Date: 2022-10-27T22:24:34Z New Revision: e8433a2b06d554df922d67f953a06701402536a1 URL: https://github.com/llvm/llvm-project/commit/e8433a2b06d554df922d67f953a06701402536a1 DIFF: https://github.com/llvm/llvm-project/commit/e8433a2b06d554df922d67f953a06701402536a1.diff LOG: Upd

[PATCH] D136188: Update docs for -fuse-ctor-homing

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8433a2b06d5: Update docs for -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D1

[PATCH] D136894: Add clang-doc readme

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds a readme to clang-doc with an overview of the structure of the code. Re

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(&E, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; mikerice w

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

steven_wu added a comment. If we have to fix it, I slightly prefer just give it a proper option in CodeGenOption and a `cc1` and `cc1as` flag. Comment at: llvm/lib/MC/MCContext.cpp:62 -static cl::opt +static cl::opt AsSecureLogFileName("as-secure-log-file-name", ---

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:62 -static cl::opt +static cl::opt AsSecureLogFileName("as-secure-log-file-name", steven_wu wrote: > benlangmuir wrote: > > Interestingly, `opt` doesn't have a parser; this code only work

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov updated this revision to Diff 471309. alexander-shaposhnikov marked an inline comment as done. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136797/new/ https://reviews

[clang] 01636fb - Fix documentation error in e8433a2b06d5

Author: Amy Huang Date: 2022-10-27T22:41:49Z New Revision: 01636fb0aef0ef06f1fa13292ce7682348b41d27 URL: https://github.com/llvm/llvm-project/commit/01636fb0aef0ef06f1fa13292ce7682348b41d27 DIFF: https://github.com/llvm/llvm-project/commit/01636fb0aef0ef06f1fa13292ce7682348b41d27.diff LOG: Fix

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(&E, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; vitalybuka w

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers updated this revision to Diff 471328. vabridgers added a comment. remove commented code from test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files: clang/lib/AST/ASTImporter.cpp c

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471329. ayzhao marked 11 inline comments as done. ayzhao added a comment. Fix PCH test and address some code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D12

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. In D129531#3880875 , @ayzhao wrote: > In D129531#3873872 , @royjacobson > wrote: > >> Thanks for working on it! It looks really good. Please remember to update >> the feature test macro (

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

arichardson added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:122 been removed. +* n32 was added to the RV64I datalayout string. Without additional context I don't think this makes much sense to most readers. Before looking at this patch descrip

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

jrtc27 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:122 been removed. +* n32 was added to the RV64I datalayout string. arichardson wrote: > Without additional context I don't think this makes much sense to most > readers. Before looking at

[Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

hubert.reinterpretcast added a subscriber: cfe-commits. BRANCHES main Users: dblaikie (Author) https://reviews.llvm.org/rGe4ec6ce8a75c ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

hubert.reinterpretcast added inline comments. BRANCHES main /clang/docs/ReleaseNotes.rst:612-613 Shouldn't the usage of POD here be clarified to say that we mean "POD for the purposes of Itanium ABI layout"? Users: dblaikie (Author) https://reviews.llvm.org/rGe4ec6ce8a75c

<    1   2   3   >