[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

owenpan added a comment. In D136658#3883372 , @rymiel wrote: > Is the intent here to somewhat reduce the 30k line behemoth of FormatTest.cpp? See https://reviews.llvm.org/D136437#3877250 for the motivation. In D136658#3883511

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1345 while (CurrentToken) { -if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator)) +if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) { Curre

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

thieta added a comment. We have been building a two stage clang and our internal projects with this version of rpmalloc and clang 15.x a while now and I haven't see the issue you see @aganea. I don't think this patch is the problem as @efriedma suggested, could be in rpmalloc but since I have u

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 470734. pmatos added a comment. Updated this revision on top of D122215 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: cl

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

ychen created this revision. ychen added reviewers: probinson, mizvekov. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. follow up d30e2eefc3cf8dfd2210aefd62f13a6e7c011b43 Repository: rG LLVM Github Mo

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov added a comment. In D136564#3884470 , @glandium wrote: > This broke building Firefox with: > > In file included from Unified_cpp_dom_canvas0.cpp:65: > /tmp/gecko/dom/canvas/ClientWebGLContext.cpp:355:19: error: call to deleted > function 'Id

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884468 , @glandium wrote: > This broke building Firefox with: Thanks for reporting. Do you have preprocessed source + cc1 flags to reproduce it, so I can have a look? Repository: rG LLVM Github Monorepo CHANGES

[clang] 31074f5 - Revert "[clang] Instantiate concepts with sugared template arguments"

Author: Matheus Izvekov Date: 2022-10-26T10:14:14+02:00 New Revision: 31074f5ec2bc89c2a1e3ae0dd94aff87741416b0 URL: https://github.com/llvm/llvm-project/commit/31074f5ec2bc89c2a1e3ae0dd94aff87741416b0 DIFF: https://github.com/llvm/llvm-project/commit/31074f5ec2bc89c2a1e3ae0dd94aff87741416b0.dif

[clang-tools-extra] a58d83b - Revert "[clang] Instantiate alias templates with sugar"

Author: Matheus Izvekov Date: 2022-10-26T10:14:21+02:00 New Revision: a58d83b2c97cd480a8533b11b86c7cd709c48176 URL: https://github.com/llvm/llvm-project/commit/a58d83b2c97cd480a8533b11b86c7cd709c48176 DIFF: https://github.com/llvm/llvm-project/commit/a58d83b2c97cd480a8533b11b86c7cd709c48176.dif

[clang] 8383c2a - Revert "[clang] Implement sugared substitution changes to infrastructure"

Author: Matheus Izvekov Date: 2022-10-26T10:14:31+02:00 New Revision: 8383c2a435ecf9a86dc8f903a3d0b0b561422eeb URL: https://github.com/llvm/llvm-project/commit/8383c2a435ecf9a86dc8f903a3d0b0b561422eeb DIFF: https://github.com/llvm/llvm-project/commit/8383c2a435ecf9a86dc8f903a3d0b0b561422eeb.dif

[clang] 434a238 - Revert "[clang] Perform sugared substitution of builtin templates"

Author: Matheus Izvekov Date: 2022-10-26T10:14:37+02:00 New Revision: 434a238a4247f37ab42dece0913ab1e007564db9 URL: https://github.com/llvm/llvm-project/commit/434a238a4247f37ab42dece0913ab1e007564db9 DIFF: https://github.com/llvm/llvm-project/commit/434a238a4247f37ab42dece0913ab1e007564db9.dif

[clang] a88ebd4 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Author: Matheus Izvekov Date: 2022-10-26T10:14:27+02:00 New Revision: a88ebd405da67b4cebf094c5a56f9aed97875423 URL: https://github.com/llvm/llvm-project/commit/a88ebd405da67b4cebf094c5a56f9aed97875423 DIFF: https://github.com/llvm/llvm-project/commit/a88ebd405da67b4cebf094c5a56f9aed97875423.dif

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

phosek added a comment. In D136664#3882989 , @smeenai wrote: > I might be missing it, but I don't see `crt` depending on `builtins` (or vice > versa). If there is actually no dep, could we build them together in a single > configure, instead of needing

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

omri123 created this revision. omri123 added reviewers: ftynse, gysit, llvm-commits, cfe-commits. Herald added subscribers: zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mg

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470739. lime added a comment. Solve the format issue further. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseTemplate.cpp clang/lib/Sema/Sema

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

courbet added a comment. I think there's a bug in the code though: // If this is memset, we just need to see if the offset is valid in the size // of the memset.. if (MI->getIntrinsicID() == Intrinsic::memset) should really be: // If this is memset, we just need to see if the offset

[clang-tools-extra] d2135df - [clangd] Hover: Only drop UsingDecl instead of BaseUsingDecl

Author: Tom Praschan Date: 2022-10-26T12:51:36+02:00 New Revision: d2135df4b5fb7eb5ca9135318adc3e20536301c0 URL: https://github.com/llvm/llvm-project/commit/d2135df4b5fb7eb5ca9135318adc3e20536301c0 DIFF: https://github.com/llvm/llvm-project/commit/d2135df4b5fb7eb5ca9135318adc3e20536301c0.diff

[PATCH] D135536: [clangd] Hover: Only drop UsingDecl instead of BaseUsingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2135df4b5fb: [clangd] Hover: Only drop UsingDecl instead of BaseUsingDecl (authored by tom-anders). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

gysit added inline comments. Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:150-153 } +// Saturation Arithmetic Intrinsics. + +def LLVM_SAddSat nit: There are quite a lot of changes in the diff for things that seemingly did not change (e.g. t

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470746. lime added a comment. Solve the conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseTempla

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. In D126903#3884873 , @courbet wrote: > I think there's a bug in the code though: > > // If this is memset, we just need to see if the offset is valid in the size > // of the memset.. > if (MI->getIntrinsicID() == Intri

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. I'm running it through creduce (as well as the one for D136564 . It's going to take a little while. Thank you for the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ ht

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong marked 9 inline comments as done. martong added a comment. Thanks for the assiduous review @ymandel ! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78-79 public: - TerminatorVisitor(const StmtToEnvMap &StmtToEnv, Environment &Env, + //

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong updated this revision to Diff 470748. martong marked an inline comment as done. martong added a comment. - Address ymandel's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133698/new/ https://reviews.llvm.org/D133698 Files: clang

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884904 , @glandium wrote: > I'm running it through creduce (as well as the one for D136564 > . It's going to take a little while. Thank > you for the revert. That's very helpful, t

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder updated this revision to Diff 470750. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/InterpFrame.cpp

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added inline comments. Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:2179 + for (unsigned I = 0; I < E->NumExprs; I++) +E->getTrailingObjects()[I] = Record.readSubExpr(); +} ayzhao wrote: > ilya-biryukov wrote: > > FYI: I think this is

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

hokein added a comment. Left a few initial comments, it looks roughly good to me (for the macro-usage case, I might miss some historical context there, I think we come to an agreement that what this patch proposes is the designed behavior). Comment at: clang-tools-extra/incl

[clang] aa12a48 - [analyzer] Fix assertion failure with conflicting prototype calls

Author: Balazs Benics Date: 2022-10-26T11:27:01+02:00 New Revision: aa12a48c8223aafafa45fb1e6e9ea49dc18a62d2 URL: https://github.com/llvm/llvm-project/commit/aa12a48c8223aafafa45fb1e6e9ea49dc18a62d2 DIFF: https://github.com/llvm/llvm-project/commit/aa12a48c8223aafafa45fb1e6e9ea49dc18a62d2.diff

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa12a48c8223: [analyzer] Fix assertion failure with conflicting prototype calls (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D136162?vs=469234&id=470756#toc Repository: r

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

balazske added a comment. This is really a NFC-like change but not NFC because it has visible effects of removing some crashes. I could not produce a test that provokes the wrong case (when `getParents` returns an empty list). Is it enough to have no new test here? If we can get a test for the

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a c++20 extension as far as I know. Repos

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle added a comment. Ping^2 after ~a week. The previous discussion seemed quite favorable, so is this just a case of everybody being too afraid to say "Yes" because this is a dark corner that few people ever look at? ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, this looks reasonable to me. (Although wait a little bit more if someone else responds to the ping this time...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2098 +TARGET_BUILTIN(__builtin_ia32_vpdpbssd128, "V4iV4iV4iV4i", "ncV:128:", "avxvnniint8") +TARGET_BUILTIN(__builtin_ia32_vpdpbssd256, "V8iV8iV8iV8i", "ncV:256:", "avxvnniint8")

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein updated this revision to Diff 470764. hokein added a comment. upload the full reland version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136539/new/ https://reviews.llvm.org/D136539 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Lexe

[clang] 11c1d8b - [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

Author: Haojian Wu Date: 2022-10-26T12:03:21+02:00 New Revision: 11c1d8b7fd82b32b37db47bcd8eac813b9667b5c URL: https://github.com/llvm/llvm-project/commit/11c1d8b7fd82b32b37db47bcd8eac813b9667b5c DIFF: https://github.com/llvm/llvm-project/commit/11c1d8b7fd82b32b37db47bcd8eac813b9667b5c.diff LO

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11c1d8b7fd82: [Lex] Bring back the magic number 50 in updateConsec

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

DavidSpickett updated this revision to Diff 470766. DavidSpickett added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Test that linux DWARFv4 uses data_bit_offset and that adding GDB tuning does not change that. - Add release notes for clang and llvm. Repos

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added a comment. Possibly rename the x86-64-* test files to *-64 (and *-32 equivalent) so that the 32/64 bit files are closer together for tracking (and to help avoid bitrot). Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. It should be fixed now @aganea . Can you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 ___ cfe-commits mailing list cfe-comm

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

lebedev.ri added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4531-4548 +// Get linking executable file's parent path as TracePath's parent path, +// default is ".". Filename may be determined and added into TracePath then. +// +// e.g. executable fil

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

omri123 updated this revision to Diff 470775. omri123 added a comment. Thanks for your comments! In this revision I fixed the diff and updated the intrinsics to use `LLVM_BinarySameArgsIntrOpI`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136746/new/ https://reviews.llvm.org/D136746

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 470724. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

gysit added a comment. Looks good from my side modulo the nit comment. Let's wait for @ftynse (the code owner) for the final approval. Comment at: mlir/test/Target/LLVMIR/Import/intrinsic.ll:778 +declare i32 @llvm.usub.sat.i32(i32, i32) +declare <8 x i32> @llvm.usub.sat.v8i32(

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

gysit added inline comments. Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:179 +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"sadd.sat">; +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"uadd.sat">; +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"ssub.sat">; --

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

ftynse added inline comments. Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:179 +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"sadd.sat">; +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"uadd.sat">; +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"ssub.sat">; -

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470779. lime added a comment. The previous update for conflicts lacks a comma, and the comma was added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/in

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

omri123 updated this revision to Diff 470780. omri123 added a comment. Thanks again! In this revision I fixed both issues mentioned above (removed `#0` from tests and renamed the tblgen definitions) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136746/new/ https://reviews.llvm.org/D136

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

ftynse accepted this revision. ftynse added a comment. This revision is now accepted and ready to land. Please wait for the tests to pass before submitting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136746/new/ https://reviews.llvm.org/D136746 __

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

aganea added a comment. In D126903#3885114 , @gchatelet wrote: > It should be fixed now @aganea . Can you check? Works now, thanks again for the quick response. Should D136752 be cherry-picked into the 15.0 branch? In

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a subscriber: ldionne. mizvekov added a comment. In D136533#3884364 , @glandium wrote: > (And specifically, FuzzerFork.cpp doesn't use any of those declared things. > Its only sin is to `#include `, which happens to have /some/ methods >

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

mizvekov accepted this revision. mizvekov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039 + + if (!Context.getTargetInfo().isTLSSupported()) +return; + Is this needed? It seems `getM

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https://reviews.llvm.org/D136120 _

[PATCH] D133698: [clang][dataflow] Implement transferBranch

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferBranchTest.cpp:73 + .getName())}), + /*VerifyResults=*/Match),

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added a comment. In D136568#3880711 , @jcranmer-intel wrote: > FWIW, I would be slightly wary of relying on cppreference as definitive for > niche semantic issues like this, althoug

[PATCH] D136532: [clang][Interp] Implement left and right shifts

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:57 +//c >>= 99; // expected-warning {{shift count >= width of type}} +//c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}} +//c >>= CHAR_BIT; // expected-warning {{

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. Still need release notes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added a comment. In D134453#3880794 , @mizvekov wrote: > In D134453#3880729 , @dblaikie > wrote: > >> I think we should restrict the discussion in this review to being only about >> the case where

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

martong marked 13 inline comments as done. martong added a comment. In D136668#3883241 , @ymandel wrote: > Nice!! Just nits. > > At a high level, I'm a little concerned about this as a demo, since I > wouldn't recommend this implementation in practice

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

martong updated this revision to Diff 470796. martong marked 2 inline comments as done. martong added a comment. - Address ymandel's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136668/new/ https://reviews.llvm.org/D136668 Files: clang

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT added a comment. > My thinking is that it's always more frustrating to have not enough > information in a diagnostic than too much information (both are problems in > their own ways though). > ... > I can understand it being less readable for deep nesting situations, but I do > not see

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && + La

[clang] 93ce23a - [clang][dataflow] Add initial sign analysis

Author: Gabor Marton Date: 2022-10-26T15:13:22+02:00 New Revision: 93ce23adb548240f3907e7dc0690a82cce060a96 URL: https://github.com/llvm/llvm-project/commit/93ce23adb548240f3907e7dc0690a82cce060a96 DIFF: https://github.com/llvm/llvm-project/commit/93ce23adb548240f3907e7dc0690a82cce060a96.diff

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93ce23adb548: [clang][dataflow] Add initial sign analysis (authored by martong). Changed prior to commit: https://reviews.llvm.org/D136668?vs=4707

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime updated this revision to Diff 470800. lime retitled this revision from "Resubmit an implemention for constrained template template parameters [P0857R0 Part B]" to "[P0857R0 Part B] Resubmit an implemention for constrained template template parameters". lime added a comment. Update release n

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

erichkeane accepted this revision. erichkeane added a comment. I'm happy with this once the release-note is clarified and all libcxx pre-commit works with it. Comment at: clang/docs/ReleaseNotes.rst:554 +- Implemented `P0857R0

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

erichkeane added a comment. ALSO: When you commit this: please try to use a more descriptive commit message, more similar to what I posted in Phab originally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D1341

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3885423 , @aaron.ballman wrote: > I can live with this approach if folks think it's the better way to go. But > my concern still remains that the user has no idea what's being constructed > by `{3}` or `{4}` without

[PATCH] D133698: [clang][dataflow] Implement transferBranch

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rGbb72d0dde29e: [clang][dataflow] Implement transferBranch (authored by martong). Changed prior to commit: https://reviews.llvm.org/D133698?vs=470748&id=470802#to

[clang] bb72d0d - [clang][dataflow] Implement transferBranch

Author: Gabor Marton Date: 2022-10-26T15:24:55+02:00 New Revision: bb72d0dde29edc2f240ab3d3650544251795ef9f URL: https://github.com/llvm/llvm-project/commit/bb72d0dde29edc2f240ab3d3650544251795ef9f DIFF: https://github.com/llvm/llvm-project/commit/bb72d0dde29edc2f240ab3d3650544251795ef9f.diff

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferBranchTest.cpp:73 + .getName())}), + /*VerifyResults=*/Match), + llvm::Succeeded()); ymandel wrote: > nit: maybe just ren

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske added a comment. If we look only at the C standard we can not tell much about if the functions should set `errno`. It seems that setting `errno` is totally implementation-dependent, except for a few functions that mention `errno`. These are `fgetpos`, `fsetpos`, `ftell` and should set

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

martong added a comment. In D136684#3884983 , @balazske wrote: > This is really a NFC-like change but not NFC because it has visible effects > of removing some crashes. I could not produce a test that provokes the wrong > case (when `getParents` returns

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; aaron.ballman wrote: > jcranmer-intel wrote: > > `long double` is `ppc_fp

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

martong added a comment. In D135360#3885494 , @balazske wrote: > If we look only at the C standard we can not tell much about if the functions > should set `errno`. It seems that setting `errno` is totally > implementation-dependent, except for a few fu

[PATCH] D136080: [flang] Add -ffp-contract option processing

awarzynski added a comment. Added Clang reviewers who touched the definition of `--fp-contract` most recently. Mostly for visibility, but lets give them at least a couple of days to take a look at the changes in Options.td. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ htt

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. In D126903#3885269 , @aganea wrote: > In D126903#3885114 , @gchatelet > wrote: > >> It should be fixed now @aganea . Can you check? > > Works now, thanks again for the quick response. S

[PATCH] D136554: [WIP] Implement CWG2631

cor3ntin updated this revision to Diff 470808. cor3ntin added a comment. Cleanup, add comments and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/inclu

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. This is working towards, but not yet fixing source_location. Subsequent patches are needed https://github.com/llvm/llvm-project/issues/56379#issuecomment-1288213743 Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15601 -ExprResult Sema::BuildCXXDefaultIn

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

omri123 added a comment. Thanks! Submitting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136746/new/ https://reviews.llvm.org/D136746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] e044824 - [Lex] Stop allocating/deallocating MacroInfo on a linked list. NFC

Author: Sam McCall Date: 2022-10-26T16:24:25+02:00 New Revision: e0448245671342ad4f0431aeabef8d575cfd80f5 URL: https://github.com/llvm/llvm-project/commit/e0448245671342ad4f0431aeabef8d575cfd80f5 DIFF: https://github.com/llvm/llvm-project/commit/e0448245671342ad4f0431aeabef8d575cfd80f5.diff LO

[PATCH] D136725: [Lex] Stop allocating/deallocating MacroInfo on a linked list. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGe04482456713: [Lex] Stop allocating/deallocating MacroInfo on a linked list. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13672

[clang] a688b5f - [clang][ASTImporter] Remove use of ParentMapContext.

Author: Balázs Kéri Date: 2022-10-26T16:25:10+02:00 New Revision: a688b5f92a17dccbad411b41e254addfbd4d2852 URL: https://github.com/llvm/llvm-project/commit/a688b5f92a17dccbad411b41e254addfbd4d2852 DIFF: https://github.com/llvm/llvm-project/commit/a688b5f92a17dccbad411b41e254addfbd4d2852.diff L

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa688b5f92a17: [clang][ASTImporter] Remove use of ParentMapContext. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136684/new/ https:/

[clang] 82a5081 - [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg

Author: Gabor Marton Date: 2022-10-26T16:33:25+02:00 New Revision: 82a50812f7e539b69fb8031bee9c823e5290d1c9 URL: https://github.com/llvm/llvm-project/commit/82a50812f7e539b69fb8031bee9c823e5290d1c9 DIFF: https://github.com/llvm/llvm-project/commit/82a50812f7e539b69fb8031bee9c823e5290d1c9.diff

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG82a50812f7e5: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg (authored by martong). R

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong added a comment. In D101526#3883871 , @NoQ wrote: > Looks great to me, thanks!! Thanks for the review! Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-notes.cpp:32-33 __buf_size_arg_constraint_con

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

jcranmer-intel added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; Izaron wrote: > aaron.ballman wrote: > > jcranmer-intel wrote: >

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime updated this revision to Diff 470816. lime added a comment. Update commit message, and remove the "for" in release notes, which should make the phrase correct in grammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://revie

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall updated this revision to Diff 470818. sammccall marked 5 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723 Files: clang-tools

[clang] a504ddc - [analyzer] Initialize regions returned by CXXNew to undefined

Author: Kristóf Umann Date: 2022-10-26T17:22:12+02:00 New Revision: a504ddc8bf9d5c406ea88b84b8495d7aae200d4c URL: https://github.com/llvm/llvm-project/commit/a504ddc8bf9d5c406ea88b84b8495d7aae200d4c DIFF: https://github.com/llvm/llvm-project/commit/a504ddc8bf9d5c406ea88b84b8495d7aae200d4c.diff

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

This revision was automatically updated to reflect the committed changes. Szelethus marked an inline comment as done. Closed by commit rGa504ddc8bf9d: [analyzer] Initialize regions returned by CXXNew to undefined (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D135375

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

david-arm added a comment. Hi @sagarkulkarni19, just a gentle ping to see if you are still planning to do more work on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:165 + TypeErasedDataflowAnalysis &Analysis; const StmtToEnvMap &StmtToEnv; Actually, this member is not used, I am not sure why was this added. Anyway

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert accepted this revision. jdoerfert added a comment. LG, thanks for all the changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] 5bd142c - [clang][dataflow] Remove unused 'Analysis' field from 'TerminatorVisitor'

Author: Gabor Marton Date: 2022-10-26T17:28:56+02:00 New Revision: 5bd142ca265d8243ecebb63ffed0c7afd3abf440 URL: https://github.com/llvm/llvm-project/commit/5bd142ca265d8243ecebb63ffed0c7afd3abf440 DIFF: https://github.com/llvm/llvm-project/commit/5bd142ca265d8243ecebb63ffed0c7afd3abf440.diff

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:165 + TypeErasedDataflowAnalysis &Analysis; const StmtToEnvMap &StmtToEnv; martong wrote: > Actually, this member is not used, I am not sure why was t

[PATCH] D136080: [flang] Add -ffp-contract option processing

awarzynski added a comment. Thanks for all the updates, Tom! I have a few more suggestions. From the summary: > implement these pragmas Could you explain what pragmas you are referring to here? (i.e. Clang pragmas for C and C++ + link) > gfortran uses "fast" by default For our future self, c

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

rnk added a comment. In D136474#3884248 , @thakis wrote: >> This is true, but the cc1 flag isn't inherently non-deterministic. I would >> prefer to fix the determinism bugs instead of adding flags and more >> divergence. > > See https://reviews.llvm.org

  1   2   3   >