rnk added a comment.

In D136474#3884248 <https://reviews.llvm.org/D136474#3884248>, @thakis wrote:
>> This is true, but the cc1 flag isn't inherently non-deterministic. I would 
>> prefer to fix the determinism bugs instead of adding flags and more 
>> divergence.
>
> See https://reviews.llvm.org/D136474#3875546

I read that, and I'm indicating that I don't agree. Chromium's requirements are 
driven by its particular usage of a cross-compiling distributed build system, 
which may not represent the average user's needs. Ubisoft's use case is also 
somewhat specialized, but IMO we really ought to write down the command line in 
the debug info. IMO it's useful. Sorry I don't have time to construct a more 
persuasive argument.

If you are still set on this course and don't want to try to address the 
determinism other ways, this flag seems fine to me, but I don't think it should 
be the default behavior. Does that provide a way forward?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136474/new/

https://reviews.llvm.org/D136474

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to