RKSimon added inline comments.
================ Comment at: clang/include/clang/Basic/BuiltinsX86.def:2098 +TARGET_BUILTIN(__builtin_ia32_vpdpbssd128, "V4iV4iV4iV4i", "ncV:128:", "avxvnniint8") +TARGET_BUILTIN(__builtin_ia32_vpdpbssd256, "V8iV8iV8iV8i", "ncV:256:", "avxvnniint8") ---------------- Add ' AVX-VNNI-INT8' title comment like we have for other intrinsic sets ================ Comment at: clang/include/clang/Basic/BuiltinsX86.def:2111 +TARGET_BUILTIN(__builtin_ia32_vpdpbuuds128, "V4iV4iV4iV4i", "ncV:128:", "avxvnniint8") +TARGET_BUILTIN(__builtin_ia32_vpdpbuuds256, "V8iV8iV8iV8i", "ncV:256:", "avxvnniint8") TARGET_HEADER_BUILTIN(_InterlockedAnd64, "WiWiD*Wi", "nh", "intrin.h", ALL_MS_LANGUAGES, "") ---------------- Move these earlier with the other vnni builtins ================ Comment at: llvm/lib/Target/X86/X86ISelLowering.h:592 + VPDPBSSD, + VPDPBSSDS, + ---------------- Do we actually need these? Are you intending to add DAG combines for these? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
