[PATCH] D136532: [clang][Interp] Implement left and right shifts

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1246-1256 if (V.isSigned() && !S.getLangOpts().CPlusPlus20) { // C++11 [expr.shift]p2: A signed left shift must have a non-negative // operand, and must not overflow the corresponding unsigned t

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

MaskRay added a comment. In D136660#3881647 , @mgorny wrote: > In D136660#3881617 , @MaskRay wrote: > >> In D136660#3881602 , @mgorny wrote: >> >>> I suppose you want to r

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a3603ff99ff: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton marked an inline comment as done. hel-ableton added a comment. > After you write a New Inline Comment, click the Save Draft button. Then click > the Submit button near the bottom of the screen. Makes sense, only I see no "Save Draft" button... Comment at: clang/li

[PATCH] D136435: [clang][Driver] Add gcc-toolset-12 and devtoolset-12 prefixes

tbaeder updated this revision to Diff 470390. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136435/new/ https://reviews.llvm.org/D136435 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driver/ToolChainTest.cpp ==

[PATCH] D136532: [clang][Interp] Implement left and right shifts

tbaeder updated this revision to Diff 470391. tbaeder added a comment. Excuse the code duplication here, I'll get rid of it as soon as we all agree that the functionality is correct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136532/new/ https://reviews.llvm.org/D136532 Files: cl

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1158 + +if (DiscardResult && !T) { + // If we need to discard the return value but the function returns its shafik wrote: > Coul

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder updated this revision to Diff 470392. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136457/new/ https://reviews.llvm.org/D136457 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/records.cpp Index: clang/test/AST

[PATCH] D132110: [IncludeCleaner] Handle more C++ constructs

kadircet updated this revision to Diff 470393. kadircet marked 4 inline comments as done. kadircet added a comment. - Rebase - Add FIXMEs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132110/new/ https://reviews.llvm.org/D132110 Files: clang-too

[clang-tools-extra] 772fc63 - [IncludeCleaner] Handle more C++ constructs

Author: Kadir Cetinkaya Date: 2022-10-25T09:58:49+02:00 New Revision: 772fc63f5bb50996370797e55682dd65960d921a URL: https://github.com/llvm/llvm-project/commit/772fc63f5bb50996370797e55682dd65960d921a DIFF: https://github.com/llvm/llvm-project/commit/772fc63f5bb50996370797e55682dd65960d921a.dif

[PATCH] D132110: [IncludeCleaner] Handle more C++ constructs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG772fc63f5bb5: [IncludeCleaner] Handle more C++ constructs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fd1d93d - [clang-format] Mark pragma region lines as StringLiterals

Author: Tobias Hieta Date: 2022-10-25T09:59:39+02:00 New Revision: fd1d93db71066bedc11944bd32f3540b8084b060 URL: https://github.com/llvm/llvm-project/commit/fd1d93db71066bedc11944bd32f3540b8084b060 DIFF: https://github.com/llvm/llvm-project/commit/fd1d93db71066bedc11944bd32f3540b8084b060.diff

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd1d93db7106: [clang-format] Mark pragma region lines as StringLiterals (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 9c48b7f - [AArch64][ARM] Alter v8.1a neon intrinsics to be target-based, not preprocessor based

Author: David Green Date: 2022-10-25T09:02:52+01:00 New Revision: 9c48b7f0e7a96e126a369d6036eff1bb259116c8 URL: https://github.com/llvm/llvm-project/commit/9c48b7f0e7a96e126a369d6036eff1bb259116c8 DIFF: https://github.com/llvm/llvm-project/commit/9c48b7f0e7a96e126a369d6036eff1bb259116c8.diff L

[PATCH] D135615: [AArch64][ARM] Alter v8.1a neon intrinsics to be target-based, not preprocessor based

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c48b7f0e7a9: [AArch64][ARM] Alter v8.1a neon intrinsics to be target-based, not preprocessor… (authored by dmgreen). Herald added a project: clang.

[clang] 885dadf - [NFC] Fix merge mistake in TokenAnnotator.cpp

Author: Tobias Hieta Date: 2022-10-25T10:08:51+02:00 New Revision: 885dadf648fc5b174e21175f726917e1528df218 URL: https://github.com/llvm/llvm-project/commit/885dadf648fc5b174e21175f726917e1528df218 DIFF: https://github.com/llvm/llvm-project/commit/885dadf648fc5b174e21175f726917e1528df218.diff

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

tbaeder updated this revision to Diff 470400. tbaeder marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135858/new/ https://reviews.llvm.org/D135858 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a subscriber: kcc. mizvekov added a comment. pinging @kcc for LibFuzzer, I believe this needs to be fixed there, if we don't want to bump the MacOs minimum version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://r

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

martong created this revision. martong added reviewers: xazax.hun, gribozavr2, sgatev, ymandel. Herald added subscribers: steakhal, rnkovacs. Herald added a reviewer: Szelethus. Herald added a project: All. martong requested review of this revision. Herald added a project: clang. Herald added a sub

[clang] d0d9d1e - [clang-format] Move bracket to correct line.

Author: Adrian Kuegel Date: 2022-10-25T11:06:02+02:00 New Revision: d0d9d1e3d232d4025bcb776117dc6a0df71da23c URL: https://github.com/llvm/llvm-project/commit/d0d9d1e3d232d4025bcb776117dc6a0df71da23c DIFF: https://github.com/llvm/llvm-project/commit/d0d9d1e3d232d4025bcb776117dc6a0df71da23c.diff

[PATCH] D136670: [clang][Interp] Fix InterpFrame::describe() for This pointers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since we pass this via the stack, we need to acco

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

diseraluca added a comment. In D136604#3879928 , @aaron.ballman wrote: > LGTM! > > Would you like to obtain commit access to land this one on your own > (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)? If not, > that's fine, I can

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonars

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

dang added a comment. However, I am not sure it's worthwhile and we might run into edge cases doing it this way with explicitly ignored symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136455/new/ https://reviews.llvm.org/D136455 __

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added inline comments. Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:2179 + for (unsigned I = 0; I < E->NumExprs; I++) +E->getTrailingObjects()[I] = Record.readSubExpr(); +} FYI: I think this is where the crash comes from. We should all

[PATCH] D136571: [RISCV] add svinval extension

BeMg updated this revision to Diff 470428. BeMg added a comment. Update RISCVUsage.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs

[clang] 9bd2730 - [Clang][AArch64] Add TargetParser support for defining CPU aliases

Author: Sjoerd Meijer Date: 2022-10-25T15:08:15+05:30 New Revision: 9bd273047d4f66e3f36416acb295a3fd75bc6af4 URL: https://github.com/llvm/llvm-project/commit/9bd273047d4f66e3f36416acb295a3fd75bc6af4 DIFF: https://github.com/llvm/llvm-project/commit/9bd273047d4f66e3f36416acb295a3fd75bc6af4.diff

[PATCH] D136611: [Clang][AArch64] Add TargetParser support for defining CPU aliases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bd273047d4f: [Clang][AArch64] Add TargetParser support for defining CPU aliases (authored by SjoerdMeijer). Herald added a project: clang. Herald ad

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

ilya-biryukov added a comment. My only ask is to add a few more tests (see the relevant comment), otherwise LG. Comment at: clang/lib/Sema/SemaOverload.cpp:1293 +// templates first; the remaining checks follow. +bool SameTemplateParameterList = TemplateParameterListsAre

[clang] 791fe26 - [clang][ExtractAPI] Allow users to specify a list of symbols to ignore

Author: Daniel Grumberg Date: 2022-10-25T11:46:04+01:00 New Revision: 791fe26d758173e569d26d831b36ee8527e1a766 URL: https://github.com/llvm/llvm-project/commit/791fe26d758173e569d26d831b36ee8527e1a766 DIFF: https://github.com/llvm/llvm-project/commit/791fe26d758173e569d26d831b36ee8527e1a766.dif

[PATCH] D136450: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore

This revision was automatically updated to reflect the committed changes. Closed by commit rG791fe26d7581: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136450

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a reviewer: erichkeane. mizvekov added a subscriber: erichkeane. mizvekov added a comment. @erichkeane since you reviewed and approved 5 patches that depend on this one, can you also have a look at this please? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton marked an inline comment as done. hel-ableton added a comment. I filed an issue now in the llvm repo, it just describes how the formatting in our case changes, and what _might_ be done to keep it from doing so. I have consciously left out any proposed unit tests, because at this poin

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

isuckatcs added a comment. > This eliminate the crash in `getDynamicElementCount` on that region I think that if the crash comes from `getDynamicElementCount`, we should address it there too, so when the function is called elsewhere under the same circumstances it won't crash again. What do y

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D127462#3877815 , @ksaunders wrote: > Ping. Sorry for not noticing this patch was languishing! As far as the patch itself goes, I don't see any major concerns. Because thi

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

tomasz-kaminski-sonarsource added a comment. In D136671#3882166 , @isuckatcs wrote: >> This eliminate the crash in `getDynamicElementCount` on that region > > I think that if the crash comes from `getDynamicElementCount`, we should > address it there too

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

aaron.ballman added a comment. In D136604#3881949 , @diseraluca wrote: > In D136604#3879928 , @aaron.ballman > wrote: > >> LGTM! >> >> Would you like to obtain commit access to land this one on your own >> (htt

[PATCH] D136532: [clang][Interp] Implement left and right shifts

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:57 +//c >>= 99; // expected-warning {{shift count >= width of type}} +//c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}} +//c >>= CHAR_BIT; // expected-warning {{

[PATCH] D136670: [clang][Interp] Fix InterpFrame::describe() for This pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136670/new/ https://reviews.llvm.org/D136670

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 470449. vhscampos marked 2 inline comments as done. vhscampos added a comment. Comments addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/doc

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added support for the Cortex-X3 CPU. + dmgreen wrote: > Can you add a reference to neoverse-v2 too. I could do this in another patch, but I prefer to restrict this one to X3. Reposi

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added support for the Cortex-X3 CPU. + vhscampos wrote: > dmgreen wrote: > > Can you add a reference to neoverse-v2 too. > I could do this in another patch, but I prefer to restrict t

[PATCH] D136602: NFC: [clang] Template argument cleanups.

thakis added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101 +const TemplateArgument &Arg = +FunctorParentType->template_arguments()[ArgNum]; if (Arg.getKind() != TemplateArgument::Type) Th

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

aaron.ballman added a comment. In D134902#3848616 , @kees wrote: > In D134902#3848595 , > @serge-sans-paille wrote: > >> I second the opinion here. C99 says nothing about flexible array member for >> unions, tha

[PATCH] D135340: [PGO] Make emitted symbols hidden

thakis added a comment. This is still breaking ` Profile-x86_64 :: instrprof-darwin-dead-strip.c` on mac. I'm reverting this again for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135340/new/ https://reviews.llvm.org/D135340 ___ cfe-

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

steakhal added a comment. In D136671#3882166 , @isuckatcs wrote: >> This eliminate the crash in `getDynamicElementCount` on that region > > I think that if the crash comes from `getDynamicElementCount`, we should > address it there too, so > when the fu

[clang] 76745d2 - Revert "[PGO] Make emitted symbols hidden"

Author: Nico Weber Date: 2022-10-25T08:54:47-04:00 New Revision: 76745d2b58b5931a2a591f3d876f08ddce7fec15 URL: https://github.com/llvm/llvm-project/commit/76745d2b58b5931a2a591f3d876f08ddce7fec15 DIFF: https://github.com/llvm/llvm-project/commit/76745d2b58b5931a2a591f3d876f08ddce7fec15.diff LO

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

erichkeane added a comment. In D133874#3882101 , @mizvekov wrote: > @erichkeane since you reviewed and approved 5 patches that depend on this > one, can you also have a look at this please? > > Thanks! Thanks for the ping, I missed this is in the massiv

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein updated this revision to Diff 470457. hokein marked 4 inline comments as done. hokein added a comment. address comments and add a stress test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136539/new/ https://reviews.llvm.org/D136539 Files:

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein added a comment. > This is a subtle change that needs careful review, and honestly should have a > test. I agree, and thanks for the nice review comments! I'd like to add a unittest, but I don't see a straight way (I manually test it by comparing the number of allocated SLocEntries and

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

Anastasia updated this revision to Diff 470458. Anastasia added a comment. Addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134445/new/ https://reviews.llvm.org/D134445 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaOpenCLCXX/invalid-kernel.clcpp Index:

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

erichkeane added a comment. The test changes are a little bizarre, are there any better tests you can write that shows this behavior? Also, at the 'end' of this patch set, we should make sure we have a detailed release note. Comment at: clang/include/clang/Sema/Sema.h:8285 +

[clang] af1bb28 - [AArch64][ARM] Alter v8.3a complex neon intrinsics to be target-based, not preprocessor based

Author: David Green Date: 2022-10-25T14:35:11+01:00 New Revision: af1bb287b4de3c5a5d82679ceb001c7d70f09c82 URL: https://github.com/llvm/llvm-project/commit/af1bb287b4de3c5a5d82679ceb001c7d70f09c82 DIFF: https://github.com/llvm/llvm-project/commit/af1bb287b4de3c5a5d82679ceb001c7d70f09c82.diff L

[PATCH] D135647: [AArch64][ARM] Alter v8.3a complex neon intrinsics to be target-based, not preprocessor based

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf1bb287b4de: [AArch64][ARM] Alter v8.3a complex neon intrinsics to be target-based, not… (authored by dmgreen). Herald added a project: clang. Heral

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

isuckatcs added a comment. > For me, it makes sense that getDynamicElementCount() is not intended to be > called on a null MemRegion. It would still be helpful to have an assertion on that inside `getDynamicElementCount()`, so the caller will know it right away. What I want to say is that it s

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus added a comment. Seems like the issues mentioned above are real, but orthogonal to this patch. Would it be okay to address them in followup patches? @martong @NoQ Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:927 SVal RetVal = State->getSVal(CNE, L

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D135375#3882491 , @Szelethus wrote: > Seems like the issues mentioned above are real, but orthogonal to this patch. > Would it be okay to address

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis requested changes to this revision. TIFitis added inline comments. This revision now requires changes to proceed. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:817-818 + Variadic:$use_device_addr, + MapTypeModifierAttr:$map_type_modifie

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

tomasz-kaminski-sonarsource updated this revision to Diff 470489. tomasz-kaminski-sonarsource added a comment. Added assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136671/new/ https://reviews.llvm.org/D136671 Files: clang/lib/StaticAna

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 470496. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inclu

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 470505. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files: clang/incl

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 added inline comments. Comment at: clang/test/SemaTemplate/concepts-using-decl.cpp:112 + expect<1>(baz{}.foo()); // expected-error {{call to member function 'foo' is ambiguous}} +} +} ilya-biryukov wrote: > Could you also check that `requires` clauses

[PATCH] D136532: [clang][Interp] Implement left and right shifts

shafik added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:57 +//c >>= 99; // expected-warning {{shift count >= width of type}} +//c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}} +//c >>= CHAR_BIT; // expected-warning {{shift c

[clang] cb088e8 - Add more C99 DR test cases and update the status page

Author: Aaron Ballman Date: 2022-10-25T11:14:52-04:00 New Revision: cb088e8c3abf30456e2891f90b5194d0070c387a URL: https://github.com/llvm/llvm-project/commit/cb088e8c3abf30456e2891f90b5194d0070c387a DIFF: https://github.com/llvm/llvm-project/commit/cb088e8c3abf30456e2891f90b5194d0070c387a.diff

[clang] 3d0e9ed - [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

Author: Jan Sjodin Date: 2022-10-25T11:15:36-04:00 New Revision: 3d0e9edd8e53fb72e85084f4170513159212839a URL: https://github.com/llvm/llvm-project/commit/3d0e9edd8e53fb72e85084f4170513159212839a DIFF: https://github.com/llvm/llvm-project/commit/3d0e9edd8e53fb72e85084f4170513159212839a.diff LO

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d0e9edd8e53: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region… (authored by jsjodin). Herald added a project: clang. H

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

martong added a comment. I am not sure, if the `ExprEngine::VisitCast` is the proper place to add these new modifications and call SValBuilder's evalCast. I think it might be better positioned in `RegionStoreManager::getBinding`. Considering, we already do a cast evaluation for certain kind of

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

martong added a comment. > PS: I'm not sure how/when we should get rid of the LocAsInteger and > represent this by a SymbolCast. > Maybe @ASDenysPetrov or @martong could help me review this. Whenever this https://reviews.llvm.org/D117229 gets accepted and when we emit all symbolCasts for all int

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Do you plan to support arithmetic operators for bf16 or implement the FMA instruction support? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136311/new/ https://reviews.llvm.org

[PATCH] D133698: [clang][dataflow] Implement transferBranch

ymandel requested changes to this revision. ymandel added a comment. This revision now requires changes to proceed. Overall, looks quite good. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:87-88 + /// Applies the analysis transfer funct

[clang] 5be51ac - Speculatively fix the test bots

Author: Aaron Ballman Date: 2022-10-25T11:35:53-04:00 New Revision: 5be51acbf01a921a23c000c17c3ba4577fab967e URL: https://github.com/llvm/llvm-project/commit/5be51acbf01a921a23c000c17c3ba4577fab967e DIFF: https://github.com/llvm/llvm-project/commit/5be51acbf01a921a23c000c17c3ba4577fab967e.diff

[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. It is very good that we can get rid of the `ParentMapContext` because it was sub-optimal to build that up for **//all//** declaration contexts of the tra

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:8285 + TemplateArgument &SugaredConverted, + TemplateArgument &CanonicalConverted, + CheckTemplateArgu

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/Sema.h:8285 + TemplateArgument &SugaredConverted, + Templ

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && +

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferBranchTest.cpp:9-11 +// This file defines a simplistic version of Sign Analysis as an example +// of a forward, monotonic dataflow analysis. The analysis tracks all +// variables in the s

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3882350 , @erichkeane wrote: > The test changes are a little bizarre, are there any better tests you can > write that shows this behavior? > > Also, at the 'end' of this patch set, we should make sure we have a detai

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 470517. pmatos added a comment. Removed address space wasm_externref which is unnecessary with current design. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files:

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos planned changes to this revision. pmatos added a comment. Whole integration plan still in the works, so marking as planning changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215

[PATCH] D133698: [clang][dataflow] Implement transferBranch

xazax.hun accepted this revision. xazax.hun added a comment. With the rest of the comments addressed it looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133698/new/ https://reviews.llvm.org/D133698 __

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

Allen added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:186 + !eq(name, "v2f16"): Float16x2Regs, + !eq(name, "bf16"): Float16Regs, + !eq(name, "v2bf16"): Float16x2Regs, sorry for a basic question: what's the different between

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to do this, even for global variables (it s

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

thakis added a comment. +1, this breaks building LLVM on macOS. This isn't limited to libFuzzer. See the many hits for "error:" on https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8799329305964156353/+/u/package_clang/stdout?format=raw Let's revert this until LLVM can build ag

[clang] 60809cd - Revert "[clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access"

Author: Nico Weber Date: 2022-10-25T12:23:10-04:00 New Revision: 60809cd29308e78d662375e6957a2b1b85415def URL: https://github.com/llvm/llvm-project/commit/60809cd29308e78d662375e6957a2b1b85415def DIFF: https://github.com/llvm/llvm-project/commit/60809cd29308e78d662375e6957a2b1b85415def.diff LO

[PATCH] D136571: [RISCV] add svinval extension

reames added inline comments. Comment at: llvm/docs/RISCVUsage.rst:56 ``V``Supported + ``Svinval`` Assembly Support ``Zba`` Supported This table is sorted alphabetically, please move above V. Repository: rG LLVM Git

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

RKSimon added inline comments. Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:46 + auto SecondSemiPos = Line.find(';', FirstSemiPos + 1); + if (FirstSemiPos == std::string::npos) +continue; @cor3ntin Should this be SecondSemi

[clang] 6fcaaf8 - Whitespace fix in a comment; NFC

Author: Aaron Ballman Date: 2022-10-25T12:35:35-04:00 New Revision: 6fcaaf89fe83ebc821df0e5e774fd8a7f4b1dba3 URL: https://github.com/llvm/llvm-project/commit/6fcaaf89fe83ebc821df0e5e774fd8a7f4b1dba3 DIFF: https://github.com/llvm/llvm-project/commit/6fcaaf89fe83ebc821df0e5e774fd8a7f4b1dba3.diff

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin added inline comments. Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:46 + auto SecondSemiPos = Line.find(';', FirstSemiPos + 1); + if (FirstSemiPos == std::string::npos) +continue; RKSimon wrote: > @cor3ntin Should

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

sammccall added a comment. In D136539#3882316 , @hokein wrote: >> This is a subtle change that needs careful review, and honestly should have >> a test. > > I agree, and thanks for the nice review comments! > > I'd like to add a unittest, but I don't see

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

tra added a comment. In D136311#3882748 , @yaxunl wrote: > LGTM. Thanks. > > Do you plan to support arithmetic operators for bf16 or implement the FMA > instruction support? Yes. sm_90 has introduced a handful of new bf16 operations that will be eventu

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:186 + !eq(name, "v2f16"): Float16x2Regs, + !eq(name, "bf16"): Float16Regs, + !eq(name, "v2bf16"): Float16x2Regs, tra wrote: > Allen wrote: > > sorry for a basic question: w

[clang-tools-extra] 3e067d4 - [include-cleaner] Move vocabulary types into separate header for layering. NFC

Author: Sam McCall Date: 2022-10-25T19:01:59+02:00 New Revision: 3e067d4e59b73b0eaeda7c369d93a6e18f2cdde8 URL: https://github.com/llvm/llvm-project/commit/3e067d4e59b73b0eaeda7c369d93a6e18f2cdde8 DIFF: https://github.com/llvm/llvm-project/commit/3e067d4e59b73b0eaeda7c369d93a6e18f2cdde8.diff LO

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. I don't have access to a macOS machine, and I don't believe any of the pre-commit CI machines are running it either. So I don't have much to go on here. How do you think we shall proceed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Please mention the default value of the flag in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://r

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

smeenai added a comment. I might be missing it, but I don't see `crt` depending on `builtins` (or vice versa). If there is actually no dep, could we build them together in a single configure, instead of needing to add another one for crt? If there is a dep and I missed it, then this LGTM. Rep

[clang] dce5bb9 - [clang-format] Correctly annotate UDLs as OverloadedOperator

Author: Emilia Dreamer Date: 2022-10-25T20:11:52+03:00 New Revision: dce5bb9a6f89b18366c6f27aeb435a6e48e85639 URL: https://github.com/llvm/llvm-project/commit/dce5bb9a6f89b18366c6f27aeb435a6e48e85639 DIFF: https://github.com/llvm/llvm-project/commit/dce5bb9a6f89b18366c6f27aeb435a6e48e85639.diff

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rymiel marked an inline comment as done. Closed by commit rGdce5bb9a6f89: [clang-format] Correctly annotate UDLs as OverloadedOperator (authored by rymiel). Repository

[clang] d03ee70 - [Tooling] Avoid StandardLibrary.h including Decl. NFC

Author: Sam McCall Date: 2022-10-25T19:12:45+02:00 New Revision: d03ee70de156d638ebb820cd6f578c19b14c6d2b URL: https://github.com/llvm/llvm-project/commit/d03ee70de156d638ebb820cd6f578c19b14c6d2b DIFF: https://github.com/llvm/llvm-project/commit/d03ee70de156d638ebb820cd6f578c19b14c6d2b.diff LO

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

tra updated this revision to Diff 470544. tra added a comment. whitespace fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136311/new/ https://reviews.llvm.org/D136311 Files: clang/lib/Basic/Targets/NVPTX.cpp clang/lib/Basic/Targets/NVPTX.h

  1   2   3   >