MaskRay added a comment. In D136660#3881647 <https://reviews.llvm.org/D136660#3881647>, @mgorny wrote:
> In D136660#3881617 <https://reviews.llvm.org/D136660#3881617>, @MaskRay wrote: > >> In D136660#3881602 <https://reviews.llvm.org/D136660#3881602>, @mgorny wrote: >> >>> I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see >>> Flang has copied the same logic too, so might be worthwhile to remove it >>> there as well. >> >> `set(BACKEND_PACKAGE_STRING "LLVM ${LLVM_PACKAGE_VERSION}")` and another set >> in `clang/CMakeLists.txt` is used by `clang/cmake/modules/AddClang.cmake`. >> Perhaps just simplify `VERSION_STRING "${CLANG_VERSION} >> (${BACKEND_PACKAGE_STRING})"` to `VERSION_STRING "${CLANG_VERSION}"` ? The >> backend package string is probably not useful. > > Perhaps it was used to account for LLVM and Clang minor version mismatch — > though I don't know if anyone is actually building a configuration like that. Yes, and that's used in a minor place for a Windows build... The LLVM version should really not matter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ https://reviews.llvm.org/D136660 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
