hel-ableton marked an inline comment as done.
hel-ableton added a comment.

> After you write a New Inline Comment, click the Save Draft button. Then click 
> the Submit button near the bottom of the screen.

Makes sense, only I see no "Save Draft" button...



================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:814
+    if (Style.BreakBeforeBinaryOperators == FormatStyle::BOS_None ||
+        Style.BreakBeforeBinaryOperators == FormatStyle::BOS_NonAssignment) {
       CurrentState.LastSpace = State.Column;
----------------
MyDeveloperDay wrote:
> ok so now you don't actually have a test for this, so I don't know if this is 
> needed any more.
Yes, this test can probably be ditched once we find a more fitting one. 
Assuming that there is agreement on your side about the proposed other fix with 
the `TT_...` tokens.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136154/new/

https://reviews.llvm.org/D136154

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to