[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton updated this revision to Diff 468793. hel-ableton added a comment. Sorry about the plus sign! I'm fairly unfamiliar with your process, so something between making a diff and making a patch must have gone wrong. About the brackets, I was wondering why there weren't any, but didn't see

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. In D136154#3867328 , @MyDeveloperDay wrote: > Can we log a GitHub issue I can’t see what you are trying to fix I'm sorry if this is unclear. The background to this is that our repository is currently formatted using clang-f

[PATCH] D136229: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136229/new/ https://reviews.llvm.org/D136229 ___

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. In D136154#3867328 , @MyDeveloperDay wrote: > Can we log a GitHub issue I can’t see what you are trying to fix Without the fix, the arguments to the Base class would be on the same level as the Base class itself. But this a

[clang-tools-extra] 2e73129 - [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON

Author: Kai Luo Date: 2022-10-19T07:26:08Z New Revision: 2e73129483c4be78d32f4bbe3f9a3130d9fc83b7 URL: https://github.com/llvm/llvm-project/commit/2e73129483c4be78d32f4bbe3f9a3130d9fc83b7 DIFF: https://github.com/llvm/llvm-project/commit/2e73129483c4be78d32f4bbe3f9a3130d9fc83b7.diff LOG: [incl

[PATCH] D136229: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e73129483c4: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136229/new/ h

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske added a comment. If `StdCLibraryFunctionsChecker` is added as dependency to `StreamChecker` and no other thing is changed these tests fail, and I could not find out the reason: Errors in test **stream.c**: error: 'warning' diagnostics expected but not seen: File /local/clang/llvm

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. > must have been introduced somewhere between 7.1.0 and 10.0.0 In fact, someone in our team thought that this must have been introduced exactly with this commit: https://github.com/llvm/llvm-project/commit/4636debc271f09f730697ab6873137a657c828f9 CHANGES SINCE LAS

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

pengfei updated this revision to Diff 468806. pengfei added a comment. Remove the dependence to D136145 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://reviews.llvm.org/D136040 Files: clang/d

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

pengfei added inline comments. Comment at: clang/lib/Headers/prfchiintrin.h:16 +/// Loads an instruction sequence containing the specified memory address into +///all level cache. +/// craig.topper wrote: > craig.topper wrote: > > It looks old that this inden

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

pengfei added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7574 - if (NumArgs > 3) + if (NumArgs > 4) return Diag(TheCall->getEndLoc(), craig.topper wrote: > craig.topper wrote: > > Not clear to me that we should be changing the definitio

[PATCH] D136078: [RFC] Use-after-return binary metadata.

dvyukov updated this revision to Diff 468815. dvyukov added a comment. WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic

[PATCH] D136078: [RFC] Use-after-return binary metadata.

dvyukov updated this revision to Diff 468816. dvyukov added a comment. WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

martong added a comment. In D135247#3867445 , @balazske wrote: > If `StdCLibraryFunctionsChecker` is added as dependency to `StreamChecker` > and no other thing is changed these tests fail, and I could not find out the > reason: > Errors in test **strea

[PATCH] D136078: [RFC] Use-after-return binary metadata.

dvyukov added a comment. Marco, does this look reasonable? Any high-level comments? There are lots of plumbing to add a new flag and integrate a new pass, so you can look only at: llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp llvm/lib/CodeGen/SanitizerMetadata.cpp As far as I

[PATCH] D136078: [RFC] Use-after-return binary metadata.

dvyukov added a comment. Unrelated, but looking at the metadata format more closely, I think this can benefit from LEB128-like varlen encoding. Function size is small. Features are very small. Stack args size is small. Function start (if we encode it from the end of the previous one) is very smal

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3867400 , @owenpan wrote: > In D129443#3867364 , @rymiel wrote: > >> How should I proceed with a stale rejecting review? > > You can commit as https://reviews.llvm.or

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah marked 8 inline comments as done. tblah added a comment. >> The omission of the fast-honor-pragmas argument from the compiler driver is >> deliberate. > > Where is it omitted? This argument is only supported in the frontend driver, not the compiler driver: flang-new -ffp-contract=fast-h

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:54-62 + explicit operator int8_t() const { return toAPSInt().getExtValue(); } + explicit operator uint8_t() const { return toAPSInt().getExtValue(); } + explicit operator int16_t() const { return toAP

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. Adding two inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6599-6601 + Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; + Style.BinPackParameters = false; + Style.ContinuationIndentWidth = 2; Hazardy

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff added a comment. In D134337#3866267 , @mgorny wrote: > In D134337#3865905 , @tstellar > wrote: > >> In D134337#3865753 , @mgorny wrote: >> >>> In D134337#386554

[PATCH] D136154: [clang-format] Fix the continuation indenter

HazardyKnusperkeks added a comment. In D136154#3867461 , @hel-ableton wrote: >> must have been introduced somewhere between 7.1.0 and 10.0.0 > > In fact, someone in our team thought that this must have been introduced > exactly with this commit: > > htt

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 468840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/include/flang/Frontend/CompilerInvocation.h flang/includ

[PATCH] D136239: [testcase] [OpenMP] Fix the testcase error of check-all when DCLANG_DEFAULT_OPENMP_RUNTIME is not libomp

zixuan-wu created this revision. zixuan-wu added reviewers: jdoerfert, MaskRay. Herald added subscribers: StephenFan, arphaman, guansong, yaxunl. Herald added a project: All. zixuan-wu requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[clang] 0dec5e1 - Keep configuration file search directories in ExpansionContext. NFC

Author: Serge Pavlov Date: 2022-10-19T17:20:14+07:00 New Revision: 0dec5e164f9d289b6e576655c7cf21a3dd0389f8 URL: https://github.com/llvm/llvm-project/commit/0dec5e164f9d289b6e576655c7cf21a3dd0389f8 DIFF: https://github.com/llvm/llvm-project/commit/0dec5e164f9d289b6e576655c7cf21a3dd0389f8.diff

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0dec5e164f9d: Keep configuration file search directories in ExpansionContext. NFC (authored by sepavloff). Repository: rG LLVM Github Monorepo CH

[clang] 66bd607 - [Attr][Doc] Fix pragma unroll documentation.

Author: Alexey Bader Date: 2022-10-19T03:50:47-07:00 New Revision: 66bd6074c133402e45075b591c062c22f308ef26 URL: https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26 DIFF: https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26.diff

[PATCH] D136160: [Attr][Doc] Fix pragma unroll documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66bd6074c133: [Attr][Doc] Fix pragma unroll documentation. (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136160/new/ https://reviews.ll

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. You've dropped the test on your most recent updated Comment at: clang/unittests/Format/FormatTest.cpp:6603-6622 + EXPECT_EQ( + "struct Derived {\n" + " Derived(\n" + "int firstArgWithLongName,\n" + "int secondArgWith

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. I get why this fix works for you, but I don't agree that the fix is the correct one.. for example you don't have any BinaryOperators in that code, lets just say in my style I had BreakBeforeBinaryOperators: All Then your fix wouldn't cover me and I'd get exac

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Its probably worth looking at how to fix this more in the context of the original bug, Its something I don't like is where we pile in all these expressions, without any comments about what cases we are handling here.. I'd rather handle each one at a time.. as I do

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Doesn't something like this achieve the same CurrentState.Indent = State.Column; CurrentState.LastSpace = State.Column; - } else if ((Previous.isOneOf(TT_BinaryOperator, TT_ConditionalExpr, - TT_CtorInitializerColon

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. I think in hindsight D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All was overly aggressive again the `TT_CtorInitializerColon` case CHANGES SINCE LAST ACTION

[PATCH] D136162: [analyzer] Fix assertion failure in RegionStore within bindArray()

steakhal added a comment. In D136162#3865081 , @martong wrote: > Hmm, seems like the conflicting prototype (i.e. the obsolescent use of zero > parameters) is needed to reproduce the assertion failure. That makes me > wonder, how does the redecl chain of

[PATCH] D136248: [Index] consider `delete X` a reference to ~X() if it can be resolved

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. In D136154#3867935 , @MyDeveloperDay wrote: > You've dropped the test on your most recent updated Oh, that's why it appeared from the diff. Apologies again, I'm really unfamiliar with your process. I guess it puzzles me why

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:233 + auto IsPublicOrOutOfLineUntilCPP20 = + LangOpts.CPlusPlus20 || LangOpts.C

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton updated this revision to Diff 468874. hel-ableton added a comment. This should bring back the formerly introduced unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 Files: clang/lib/Format/ContinuationIndenter.cpp clang

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:841 +if (Ty->isPromotableIntegerType() && +// Avoid promote integer type to int. +!getLangOpts().HLSL) { rjmccall wrote: > Hmm, the downside to the change being appl

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

sammccall marked 3 inline comments as done. sammccall added a comment. Ugh, sorry for the sloppiness, think I was tired. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:469 {"struct foo { [[^~foo()]]; };", "CXXDestructorDecl"}, - // FIXME: The foll

[clang-tools-extra] 62116c8 - [clangd] consider ~^foo() to target the destructor, not the type

Author: Sam McCall Date: 2022-10-19T14:12:31+02:00 New Revision: 62116c8f0b5b7aac3d53f1bd2445356ae6866048 URL: https://github.com/llvm/llvm-project/commit/62116c8f0b5b7aac3d53f1bd2445356ae6866048 DIFF: https://github.com/llvm/llvm-project/commit/62116c8f0b5b7aac3d53f1bd2445356ae6866048.diff LO

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG62116c8f0b5b: [clangd] consider ~^foo() to target the destructor, not the type (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D136

[PATCH] D136078: [RFC] Use-after-return binary metadata.

dvyukov updated this revision to Diff 468876. dvyukov added a comment. take args alignment into account Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 Files: clang/include/clang/Basic/CodeGenOptions.de

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. > The problem as I see it was that the original bug, highly constrained the > cases where "CurrentState.LastSpace = State.Column;" to one particular style > (which if it happens to be your style great but not if its not. You mean the original bugfix was already unne

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton updated this revision to Diff 468878. hel-ableton added a comment. Using verifyFormat() now instead of EXPECT_EQ() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 468881. DoDoENT retitled this revision from "Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy" to "Disambiguate type names when printing NTTP types". DoDoENT edited the summary of this revision. DoDoENT added a comment. Implem

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT updated this revision to Diff 468883. DoDoENT added a comment. Update comment/documentation of the new policy to correctly reflect the change in previous diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134453/new/ https://reviews.llvm.

[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

ymandel updated this revision to Diff 468884. ymandel marked an inline comment as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135964/new/ https://reviews.llvm.org/D135964 Files: clang/include/cla

[clang] 8cadac4 - [clang][dataflow] Add equivalence relation `Value` type.

Author: Yitzhak Mandelbaum Date: 2022-10-19T12:23:09Z New Revision: 8cadac41e9f63b2494805042573792cc2cc2a8ea URL: https://github.com/llvm/llvm-project/commit/8cadac41e9f63b2494805042573792cc2cc2a8ea DIFF: https://github.com/llvm/llvm-project/commit/8cadac41e9f63b2494805042573792cc2cc2a8ea.diff

[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cadac41e9f6: [clang][dataflow] Add equivalence relation `Value` type. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton marked an inline comment as done. hel-ableton added a comment. In D136154#3867968 , @MyDeveloperDay wrote: > Doesn't something like this achieve the same > >CurrentState.Indent = State.Column; >CurrentState.LastSpace = State.

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

usaxena95 added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return 2

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, I think the new diagnostic wording is an improvement. Can you please add a release note to mention the diagnostic wording was patched up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. > Beyonce rule "If they liked it they should have put a test on it" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. In D136154#3868151 , @hel-ableton wrote: > If you think this would be the better fix, AFAICS it does what we need. > What's the Beyonce rule, by the way? I do, but I'd like to hear @owenpan and @HazardyKnusperkeks view..

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6615 + " fourthArgWithLongName) {}\n" + "};", Style);} missing newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://review

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > anderslanglands wro

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

beanz added a comment. I don’t think you should be deleting all those frontend tests. Those tests existed before your change to remove the global constructor global variable, they provide valuable coverage of the frontend constructor generation. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei added inline comments. Comment at: clang/lib/Headers/avx512bf16intrin.h:13 +#ifdef __SSE2__ + LuoYuanke wrote: > What is this macro check used for? `__bf16` is not available without SSE2. This is to make sure no error generated if user include

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:54-62 + explicit operator int8_t() const { return toAPSInt().getExtValue(); } + explicit operator uint8_t() const { return toAPSInt().getExtValue(); } + explicit operator int16_t() const { return toAPSI

[PATCH] D136017: [clang][Interp] Materializing primitive temporaries

tbaeder updated this revision to Diff 468895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136017/new/ https://reviews.llvm.org/D136017 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcod

[clang] a6b4204 - [analyzer] Fix the liveness of Symbols for values in regions referred by LazyCompoundVal

Author: Tomasz Kamiński Date: 2022-10-19T16:06:32+02:00 New Revision: a6b42040ad30c13474c06d3e0291a4675475fec3 URL: https://github.com/llvm/llvm-project/commit/a6b42040ad30c13474c06d3e0291a4675475fec3 DIFF: https://github.com/llvm/llvm-project/commit/a6b42040ad30c13474c06d3e0291a4675475fec3.dif

[PATCH] D134947: [analyzer] Fix the liveness of Symbols for values in regions referred by LazyCompoundVal

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6b42040ad30: [analyzer] Fix the liveness of Symbols for values in regions referred by… (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 6194229 - [analyzer] Make directly bounded LazyCompoundVal as lazily copied

Author: Tomasz Kamiński Date: 2022-10-19T16:06:32+02:00 New Revision: 6194229c6287fa5d8a9a30aa489bcbb8a9754ae0 URL: https://github.com/llvm/llvm-project/commit/6194229c6287fa5d8a9a30aa489bcbb8a9754ae0 DIFF: https://github.com/llvm/llvm-project/commit/6194229c6287fa5d8a9a30aa489bcbb8a9754ae0.dif

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

This revision was automatically updated to reflect the committed changes. Closed by commit rG6194229c6287: [analyzer] Make directly bounded LazyCompoundVal as lazily copied (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

tbaeder updated this revision to Diff 468905. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135513/new/ https://reviews.llvm.org/D135513 Files: clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Inte

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132329/new/ https://reviews.llvm.org/D132329

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton updated this revision to Diff 468907. hel-ableton added a comment. Fixed missing newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton marked an inline comment as done. hel-ableton added a comment. > I do, but I'd like to hear @owenpan and @HazardyKnusperkeks view.. (each of > us is better in different part of clang-format, and I value their opinion!) Fair enough. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added a comment. Add a short description to clang ReleaseNotes about the new bf/bh types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132329/new/ https://reviews.llvm.org/D132329 ___ cfe-commit

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

beanz added a comment. In addition to restoring the test cases that you deleted, I think you should also reduce and simplify the test cases you're adding. These new tests are very large blobs of IR generated by clang. They include a lot of extra instructions that aren't needed to exercise the c

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https://github.com/llvm/llvm-project/issues/53354 Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 468914. qiongsiwu1 added a comment. Address the review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ https://reviews.llvm.org/D136187 Files: clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:193 - -void CGHLSLRuntime::generateGlobalCtorDtorCalls() { - llvm::Module &M = CGM.getModule(); I think you've been a bit too aggressive about what code you're moving. The code that ge

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:814 +if (Style.BreakBeforeBinaryOperators == FormatStyle::BOS_None || +Style.BreakBeforeBinaryOperators == FormatStyle::BOS_NonAssignment) { CurrentState.LastSpace = Sta

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Looking at the documentation, I think BreakBeforeBinaryOperators is unrelated to your test case. I would remove any references of it from your fix. F24968180: image.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132329/new/ https://reviews.llvm.org/D132329 ___ cfe-commits mailing list cfe-commits

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. `Andreas Hollandt ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Going back to the original bug that caused this.. if you leave in your BOS_NonAssignment I think you'll reintroduce the original bug.. which possibly should have been called "incorrectly adds extra continuation indent spaces with BreakBeforeBinaryOperators set

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 updated this revision to Diff 468925. usaxena95 added a comment. Added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136259/new/ https://reviews.llvm.org/D136259 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaTe

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 updated this revision to Diff 468928. ZhiyaoMa98 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136203/new/ https://reviews.llvm.org/D136203 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/Driver/arm-execute-only.c llvm/lib/

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 marked an inline comment as done. ZhiyaoMa98 added a comment. I have updated the diff to avoid the extra indirection. I am thinking about adding a new option, say `-mgot-calls` to allow code generation with the extra indirection. Is it sensible and shall I create another diff to discu

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5807 bool TraverseTemplateName(TemplateName Template) { -if (auto *TTP = -dyn_cast(Template.getAsTemplateDecl())) - if (TTP->getDepth() == Depth) -Used[TTP->g

[clang] d146a52 - Move HLSL builtins into hlsl namespace

Author: Chris Bieneman Date: 2022-10-19T10:59:31-05:00 New Revision: d146a5241c5039fd25e8bf5a4ae1200ad201d06c URL: https://github.com/llvm/llvm-project/commit/d146a5241c5039fd25e8bf5a4ae1200ad201d06c DIFF: https://github.com/llvm/llvm-project/commit/d146a5241c5039fd25e8bf5a4ae1200ad201d06c.diff

[PATCH] D135973: Move HLSL builtins into hlsl namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rGd146a5241c50: Move HLSL builtins into hlsl namespace (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135973/new/ https://reviews.llvm.org

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:54-62 + explicit operator int8_t() const { return toAPSInt().getExtValue(); } + explicit operator uint8_t() const { return toAPSInt().getExtValue(); } + explicit operator int16_t() const { return toAP

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135513/new/ https://reviews.llvm.org/D135513 ___ cfe-commits mailing list

[PATCH] D136154: [clang-format] Fix the continuation indenter

HazardyKnusperkeks added a comment. In D136154#3868036 , @hel-ableton wrote: > In D136154#3867935 , > @MyDeveloperDay wrote: > >> You've dropped the test on your most recent updated > > Oh, that's why it appeare

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added a comment. > I am thinking about adding a new option, say -mgot-calls to allow code > generation with the extra indirection. Is it sensible and shall I create > another diff to discuss that? That probably makes sense, yes. Comment at: llvm/lib/Target/ARM/ARMIS

[clang] 6149589 - [OMPIRBuilder] Support depend clause for task

Author: Prabhdeep Singh Soni Date: 2022-10-19T13:11:43-04:00 New Revision: 614958912784a13737720de39b2da40fe6f26e75 URL: https://github.com/llvm/llvm-project/commit/614958912784a13737720de39b2da40fe6f26e75 DIFF: https://github.com/llvm/llvm-project/commit/614958912784a13737720de39b2da40fe6f26e7

[PATCH] D135695: [OMPIRBuilder] Support depend clause for task construct

This revision was automatically updated to reflect the committed changes. Closed by commit rG614958912784: [OMPIRBuilder] Support depend clause for task (authored by psoni2628, committed by Prabhdeep Singh Soni (A) ). Herald added a subscriber: cfe-commits. Repository

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping, could someone please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D136239: [testcase] [OpenMP] Fix the testcase error of check-all when DCLANG_DEFAULT_OPENMP_RUNTIME is not libomp

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136239/new/ https://reviews.llvm.org/D136239 ___

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration aaron.ballman wrote: > dblaikie wrote: > >

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. I still don't think "keep full NTTP type printing behind a policy, for those that want/need that" is a policy we should add. String printed names aren't meant to be a tool for type reflection - the AST can be queried for that information. Comment at

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 updated this revision to Diff 468957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136203/new/ https://reviews.llvm.org/D136203 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/Driver/arm-execute-only.c llvm/lib/Target/ARM/ARMISelLowering.cpp llvm/test/CodeG

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. > Then just assert we aren't execute-only in the non-movw path. When we are not execute-only, existing code handles it by using constant pools and we are all good. In the case where we are execute-only and long-calls at the same time, we assert that we have `movt` l

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT added a comment. In D134453#3868789 , @dblaikie wrote: > I still don't think "keep full NTTP type printing behind a policy, for those > that want/need that" is a policy we should add. String printed names aren't > meant to be a tool for type ref

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. I'm OK with sticking with the existing `-fmodule-file` if that works for everyone. Yeah, it's short and ambiguous in a space with many concepts of what a "module file" is, but also the fact that it's a `-f` flag might help disambiguate it a bit - it's probably not the

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

  1   2   >