[PATCH] D136154: [clang-format] Fix the continuation indenter

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

Going back to the original bug that caused this.. if you leave in your 
BOS_NonAssignment I think you'll reintroduce the original bug..  which possibly 
should have been called

"incorrectly adds extra continuation indent spaces with 
BreakBeforeBinaryOperators set to All *(and NonAssignement)*"

i.e.

  bool BreakBeforeBinaryOperators(
          bool someVeryVeryLongConditionThatBarelyFitsOnALine,
          bool someOtherLongishConditionPart1,
          bool someOtherEvenLongerNestedConditionPart2) {
          return someVeryVeryLongConditionThatBarelyFitsOnALine
                  && (someOtherLongishConditionPart1
                          || someOtherEvenLongerNestedConditionPart2);
  }

will bcome

  bool BreakBeforeBinaryOperators(
          bool someVeryVeryLongConditionThatBarelyFitsOnALine,
          bool someOtherLongishConditionPart1,
          bool someOtherEvenLongerNestedConditionPart2) {
          return someVeryVeryLongConditionThatBarelyFitsOnALine
                  && (someOtherLongishConditionPart1
                             || someOtherEvenLongerNestedConditionPart2);
                       ^^^^^^^^
  }

                     


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136154/new/

https://reviews.llvm.org/D136154

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits