[clang] f461e80 - [NFC] Judge if we have std c++ modules in RenderModulesOptions

Author: Chuanqi Xu Date: 2022-10-17T15:51:02+08:00 New Revision: f461e8045e220c3848b572cb5afd0e9db8d41681 URL: https://github.com/llvm/llvm-project/commit/f461e8045e220c3848b572cb5afd0e9db8d41681 DIFF: https://github.com/llvm/llvm-project/commit/f461e8045e220c3848b572cb5afd0e9db8d41681.diff LO

[PATCH] D136040: [X86] Support PREFETCHI instructions

LuoYuanke added inline comments. Comment at: clang/include/clang/Driver/Options.td:4651 def mno_popcnt : Flag<["-"], "mno-popcnt">, Group; +def mprefetchi : Flag<["-"], "mprefetchi">, Group; +def mno_prefetchi : Flag<["-"], "mno-prefetchi">, Group; I notice in l

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 468134. domada added a comment. 1. Changed DenseMap to MapVector. MapVector provides that the iteration order is the same as insertion order CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/l

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff updated this revision to Diff 468137. sepavloff added a comment. Change parameter type of findConfigFile, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.org/D135439 Files: clang/include/clang/Dri

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2138 + /// directories specified by SearchDirs field. + bool findConfigFile(StringRef FileName, std::string &FilePath); + mgorny wrote: > I'm sorry if I'm missing something obv

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu updated this revision to Diff 468138. ChuanqiXu added a comment. Address @tschuett's opinion: - Use new introduced `-fc++-module-cache-path=` instead of `-fc++-module-path` to avoid many logics about modules cache in clang modules. - Use new introduced `-fmodule-bmi-output=` instead of

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

ChuanqiXu updated this revision to Diff 468139. ChuanqiXu added a comment. Update to reflect the change in D134267 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134269/new/ https://reviews.llvm.org/D134269 Files: clang/docs/StandardCPlusPlusModules.

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. Everything good now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

sammccall added a comment. In D127403#3861619 , @ckandeler wrote: > Everything good now? Yes :-) (I also marked it as accepted above, so feel free to land!) Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. @dblaikie @iains @tschuett @boris There are many opinions in this page. They are about problems in the higher level. They are pretty important and helpful indeed. I'm really appreciated it. But most of them are not related to this diff itself and I don't think they a

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

ChuanqiXu added a comment. LGTM basically. Comment at: clang/lib/Sema/SemaExpr.cpp:6748 + SourceLocation ConstraintFailLoc = NakedFn->getBeginLoc(); + It looks like `ConstraintFailLoc` is not used? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1357

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

hokein added a comment. +1, it looks a great start to me (left some initial comments). The plan also looks good to me. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Hooks.h:1 +//===--- Hooks.h - Record compiler events --

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. Could you please land it for me? I don't have the privileges. (How does one attain those, by the way?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 _

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

owenpan added a comment. In D135918#3857711 , @HazardyKnusperkeks wrote: > Fun fact, there is one instance of such a case within the clang-format code. > I can't remember where (I stumbled upon this in January, and tried to fix it > ever since), should

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1186-1199 +tok::amp, tok::ampamp)) { CurrentToken->Previous->setType(TT_OverloadedOperator); } +// User defined literal without a

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

Trass3r added a comment. https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mail

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 4 inline comments as done. FreddyYe added a comment. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 ___ cfe-commits mailing lis

[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Value.cpp:15 +#include "llvm/Support/Casting.h" +#include + This seems unnecessary. Comment at: clang/unittests/Analysis/FlowSensitive/Va

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked 2 inline comments as done. domada added inline comments. Comment at: clang/test/OpenMP/irbuilder_simd_aligned.cpp:69 +// CHECK: omp_loop.preheader: +// CHECK-COUNT-3: call void @llvm.assume(i1 true) [ "align" +// CHECK-NEXT:br label [[OMP_LOOP_HEADER:%.*]]

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:553 - Fix 32-bit ``__fastcall`` and ``__vectorcall`` ABI mismatch with MSVC. +- Support ISA of ``AVX-VNNI-INT8``. Please add a bullet list of the added intrinsics Comment

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

zixuan-wu added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:411 // implemented such that the stack will always be 16 byte aligned. unsigned LibCallFrameSize = alignTo((STI.getXLen() / 8) * LibCallRegs, 16); RVFI->setLibCallStackSize(Li

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe marked 5 inline comments as done. FreddyYe added a comment. THX for reviews! Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is supported */ +#if defined(__AVXNECONVERT__) && defined(__AVX512FP16__) pengfei wr

[PATCH] D136070: [LIT] Add AArch64/Windows to LP64 feature

omjavaid created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds AArch64 to the LP64 feature to avoid running LLP64 incompatible

[PATCH] D136070: [LIT] Add AArch64/Windows to LP64 feature

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136070/new/ https://reviews.llvm.org/D136070 _

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

aaron.ballman added a comment. In D91000#3770071 , @whisperity wrote: > Generally LGTM. Please revisit the documentation and let's fix the style, and > then we can land. > > In D91000#3197851 , @aaron.ballman > wr

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3861615 , @ChuanqiXu wrote: > Address @tschuett's opinion: > > - Use new introduced -fc++-module-cache-path= instead of -fc++-module-path to > avoid many logics about modules cache in clang modules. > - Use new introduce

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I haven't tested it but eyeball-review, it looks neat. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.or

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead marked an inline comment as done. pcwang-thead added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:411 // implemented such that the stack will always be 16 byte aligned. unsigned LibCallFrameSize = alignTo((STI.getXLen() / 8) * L

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein created this revision. hokein added reviewers: sammccall, kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. PragmaIncludes captures the progma-based header-mapping information, it is used in the "Location => Header" s

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein added a comment. Post it early in order to get initial feedback on the APIs.It is not finished, I plan to implement the IWYU keep pragma and add unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136071/new/ https://reviews.llvm.org/D1

[PATCH] D135025: [clang][Interp] Support base class constructors

aaron.ballman added a comment. Do you think we should address some of the FIXMEs with base class ctor functionality as part of this patch, given that the failures all seem to be related to that functionality? Or are these failures due to other missing functionality that happened to be exposed h

[PATCH] D134681: [Clang][AArch64] Add SME outer product intrinsics

sagarkulkarni19 added a comment. In D134681#3858849 , @rsandifo-arm wrote: > Thanks for the patch. This is going to be inconvenient, sorry, but: while > implementing the specification in GCC, I noticed that the ZA functions > weren't consistent about

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:17397 + auto *MA = llvm::find(MisalignedMembers, MisalignedMember(Op)); + const bool IsDiscardMisalignedPointer = + T->isPointerType() && We don't typically use to

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

hans added a comment. The build system folks replied saying they're not using symlinks, but hard links for compiler inputs. Dropping the `-s` flag in the repro above demonstrates this. Here's a new version of the reproducer that's a little less convoluted: $ echo 1, 2, 3 > /tmp/foo.h $ ln

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

aaron.ballman added a comment. Can you also add documentation and a release note for the new feature testing macro? Comment at: clang/lib/Lex/PPMacroExpansion.cpp:370 // Clang Extensions. - Ident__FILE_NAME__ = RegisterBuiltinMacro(*this, "__FILE_NAME__"); - Ident__h

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. In D134128#3860993 , @lime wrote: > I think I located the problem. In the line 4014 of the file > `SemaTemplateInstantiateDecl.cpp`, the requires clause is not instantiated as > the parameters of the template parameter list,

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6748 + SourceLocation ConstraintFailLoc = NakedFn->getBeginLoc(); + ChuanqiXu wrote: > It looks like `ConstraintFailLoc` is not used? Woops!

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added inline comments. Comment at: llvm/test/MC/X86/avx-ne-convert-att.s:1 +// RUN: llvm-mc -triple i686-unknown-unknown --show-encoding %s | FileCheck %s + merge the att + intel test files and use --check-prefixes to test both Repository: rG LLVM Gi

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane updated this revision to Diff 468185. erichkeane marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

aaron.ballman added a comment. In D135690#3858621 , @Trass3r wrote: > In D135690#3858541 , @aaron.ballman > wrote: > >> In D135690#3856863 , @Trass3r >> wrote: >> >>> Di

[PATCH] D136078: [RFC] Use-after-return binary metadata.

dvyukov created this revision. Herald added a subscriber: ormris. Herald added a project: All. dvyukov requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136078 Files:

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder marked an inline comment as done. tbaeder added a comment. In D135025#3862031 , @aaron.ballman wrote: > Do you think we should address some of the FIXMEs with base class ctor > functionality as part of this patch, given that the failures all see

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

martong added a comment. In D135375#3849261 , @Szelethus wrote: > Some early results: > > https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?review-status=Unreviewed&review-status=Confirmed%20bug&detection-status=New&detection-status=Reope

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

martong added a comment. I am happy with the change and with the result. However, [[ https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?review-status=Unreviewed&review-status=Confirmed%20bug&detection-status=New&detection-status=Reopened&detection-status=Unresolved&is-unique

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah created this revision. tblah added reviewers: kiranchandramohan, MatsPetersson, DavidTruby, rovka, vzakhari. tblah added a project: Flang. Herald added a subscriber: jdoerfert. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a project: All. tblah request

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. In D91000#3861942 , @aaron.ballman wrote: > My concern with that approach was that we pay the full expense of doing the > matches only get get into the `check()` function to bail out on all the Annex > K functions, but now th

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire updated this revision to Diff 468193. junaire added a comment. Address Aaron's comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136018/new/ https://reviews.llvm.org/D136018 Files: clang/lib/Sema/SemaChecking.cpp clang/te

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

yaxunl added a comment. need some Sema tests to verify a constexpr builtin is const evaluated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136036/new/ https://reviews.llvm.org/D136036 ___ cfe-commits m

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468195. pengfei added subscribers: uweigand, t.p.northover. pengfei added a comment. 1. Address review comments; 2. Optimize prefetchit0/1 to prefetcht0/1 for non-rip address; 3. Add semacheck for prefetch write to instruction cache; 4. Fix a bug that set `rw`

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei added inline comments. Comment at: clang/include/clang/Driver/Options.td:4651 def mno_popcnt : Flag<["-"], "mno-popcnt">, Group; +def mprefetchi : Flag<["-"], "mprefetchi">, Group; +def mno_prefetchi : Flag<["-"], "mno-prefetchi">, Group; LuoYuanke wrote

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

martong added a comment. Thanks for patch and the many test cases. You still haven't answered my below concern: > Is there a way to stop the analysis with an error if "ModelPOSIX=true" is not > set but the 'alpha.unix.Stream' checker is enabled? Comment at: clang/lib/Static

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

martong added a comment. In D135360#3839890 , @balazske wrote: > I found some anomalies during development: > > - If the checker **StdCLibraryFunctions** is added as dependency for > **alpha.unix.Stream** in //checkers.td// I get some "unexplainable" tes

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1818-1857 +// int fgetpos(FILE *restrict stream, fpos_t *restrict pos); +// From 'The Open Group Base Specifications Issue 7, 2018 edition': +// "The fgetpos()

[PATCH] D136040: [X86] Support PREFETCHI instructions

uweigand added a comment. In D136040#3862225 , @pengfei wrote: > 3. Add semacheck for prefetch write to instruction cache; > > I think the affected ARM and SystemZ tests are not valid before. Could > @t.p.northover and @uweigand help to have a look? Thi

[PATCH] D136082: [clangd] Extend --check to time clang-tidy checks, so we can block slow ones

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. mis

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam created this revision. zahiraam added reviewers: jrtc27, saugustine, aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. See details in comment https://reviews.llvm.org/D135097#3859893 and https://reviews.llvm.org/D135097

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2290 List.insert(List.end(), InnerList.begin(), InnerList.end()); - continue; } steakhal wrote: > Here is the `continue` which previously prevented `getInter

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam added a comment. @saugustine A, @jrtc27. Thanks for your comments. Adding '-target x86_64' is restrictive, but not sure what option to use to express that I want target with zero as default address. @aaron.ballman what do you think? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely added a comment. Hi, sorry for the late answer, did not have time to check this in the last few weeks. I will try to address all of the remaining comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135832/new/ https://reviews.llvm.org/D135832 __

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei added a comment. In D136040#3862265 , @uweigand wrote: > In D136040#3862225 , @pengfei wrote: > >> 3. Add semacheck for prefetch write to instruction cache; >> >> I think the affected ARM and SystemZ tests

[PATCH] D136087: [clang] Fix func-attr.c test

diohabara created this revision. Herald added a project: All. diohabara requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test was introduced by 84a9ec2ff1ee . The che

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.org/D135439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2843 -// subregions of the `LCS.getRegion()` also lazily copied. -if (const MemRegion *R = LCS->getRegion()) - SymReaper.markLazilyCopied(R);

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added a comment. In D135690#3862112 , @aaron.ballman wrote: > Pretty sure that was after `/Zc:inline` (IIRC that existed in MSVC 2015 which > was roughly when I recall we were hitting this). I see, yeah `/Zc:inline` got added slightly earlier:

[PATCH] D136089: [clang] Add MorphOS Target

js created this revision. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. js requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds MorphOS to Target and sets up the required defines. Repository: rG LLVM Git

[PATCH] D135414: [clang][deps] Don't share in-memory VFS across scans

DavidSpickett added a comment. Hi @jansvoboda11 , we (Linaro) happen to be one of the few running a bot with threading disabled (for reasons that aren't important here). It has been red a lot lately so you won't have seen the report from it. https://lab.llvm.org/buildbot/#/builders/178/builds/3

[PATCH] D136089: [clang] Add MorphOS Target

js updated this revision to Diff 468226. js added a reviewer: chandlerc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136089/new/ https://reviews.llvm.org/D136089 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTargets.h clang/lib/Basic/Targets/PPC.h clang/test/Sema

[clang] 970e1ea - [clang] Fix crash with -funique-internal-linkage-names

Author: Ellis Hoag Date: 2022-10-17T08:57:23-07:00 New Revision: 970e1ea01aa0dce4f606eee1610c92b8b838f303 URL: https://github.com/llvm/llvm-project/commit/970e1ea01aa0dce4f606eee1610c92b8b838f303 DIFF: https://github.com/llvm/llvm-project/commit/970e1ea01aa0dce4f606eee1610c92b8b838f303.diff LO

[PATCH] D135926: [clang] Fix crash with -funique-internal-linkage-names

This revision was automatically updated to reflect the committed changes. Closed by commit rG970e1ea01aa0: [clang] Fix crash with -funique-internal-linkage-names (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135926/new/ https://

[PATCH] D136090: Handle errors in expansion of response files

sepavloff created this revision. sepavloff added reviewers: kadircet, mgorny, MaskRay, smeenai. Herald added subscribers: StephenFan, hiraditya. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. sepavloff requested review of this revision. Herald added subscribers: llvm-commit

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks for working on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 ___ cfe-c

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

aaron.ballman added reviewers: efriedma, rjmccall. aaron.ballman added a comment. I've added some more codegen reviewers; I think we usually try to avoid CodeGen tests that rely on specific optimization levels. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D136040: [X86] Support PREFETCHI instructions

uweigand added a comment. In D136040#3862386 , @pengfei wrote: > Sure, it is possible. But at least for now, there's no real target requires > it. Checked with `grep -rwn 'llvm.prefetch.*i32 0\s*)' llvm/test/CodeGen/`. But that's just within the LLVM so

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

erichkeane added inline comments. Comment at: clang/test/CodeGen/func-attr.c:1 -// RUN: %clang -c -ffast-math -emit-llvm -S -o - %s \ -// RUN: | FileCheck %s +// RUN: %clang -c -O2 -target x86_64 -ffast-math\ +// RUN: -emit-llvm -S -o - %s | FileCheck %s It isn'

[PATCH] D136040: [X86] Support PREFETCHI instructions

craig.topper added a comment. There are too many things in this patch. Please up MC layer changes from intrinsic/builtin changes. The RIP optimization probably also be separate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://rev

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam added inline comments. Comment at: clang/test/CodeGen/func-attr.c:1 -// RUN: %clang -c -ffast-math -emit-llvm -S -o - %s \ -// RUN: | FileCheck %s +// RUN: %clang -c -O2 -target x86_64 -ffast-math\ +// RUN: -emit-llvm -S -o - %s | FileCheck %s erichkean

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

yonghong-song added a comment. @aprantl The following example shows the difference between gcc and clang w.r.t. reserved names. [$ ~/tmp3] cat t.c extern void *__bpf_kptr_new(int, int, void *) __attribute__((section(".ksyms"))); #define bpf_kptr_new(x) __bpf_kptr_new(x, 0, 0) struct

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

erichkeane added inline comments. Comment at: clang/test/CodeGen/func-attr.c:1 -// RUN: %clang -c -ffast-math -emit-llvm -S -o - %s \ -// RUN: | FileCheck %s +// RUN: %clang -c -O2 -target x86_64 -ffast-math\ +// RUN: -emit-llvm -S -o - %s | FileCheck %s zahiraa

[clang] 245da0a - [modules] Fix callback argument thinko

Author: Nathan Sidwell Date: 2022-10-17T09:30:50-07:00 New Revision: 245da0a451e193dc4229ed8aed28cf34fa083ed4 URL: https://github.com/llvm/llvm-project/commit/245da0a451e193dc4229ed8aed28cf34fa083ed4 DIFF: https://github.com/llvm/llvm-project/commit/245da0a451e193dc4229ed8aed28cf34fa083ed4.diff

[PATCH] D135958: [clang] modules: Fix callback argument thinko

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG245da0a451e1: [modules] Fix callback argument thinko (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D109460: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

ldionne added a comment. In D109460#3860750 , @calebzulawski wrote: > I'm interested in this feature--is there any reason this wasn't completed? If > not, I might be able to take over implementing this. Lack of bandwidth. It would be awesome if someone

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam updated this revision to Diff 468236. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136084/new/ https://reviews.llvm.org/D136084 Files: clang/test/CodeGen/func-attr.c Index: clang/test/CodeGen/func-attr.c === --

[PATCH] D135894: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:256 + if (hasFeature("v")) +// Minium VLEN=128, Maximum VLEN=64k, and RISCV::RVVBitsPerBlock is 64. +return std::pair(2, 1024); Minimum Repository: rG LLVM Github Monor

[PATCH] D135894: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

reames updated this revision to Diff 468239. reames added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135894/new/ https://reviews.llvm.org/D135894 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h clang/test/CodeGen/riscv-vector-bits-v

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

shafik added a comment. In D136036#3860945 , @Izaron wrote: > This macro will be needed because we are making constexpr `` and > ``. We will conditionally make the functions constexpr until all > supported compilers have full support. > > We had a discu

[PATCH] D135894: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135894/new/ https://reviews.llvm.org/D135894 ___ cfe-commits mailing list c

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 added a comment. Ah I just saw 5d3139aef113881fff9430c96069faf96630a5d8 . Thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

tahonermann added inline comments. Comment at: clang/docs/StandardCPlusPlusModules.rst:228-229 + +Also if when we compile an importable module unit to an object file, +the compiler will generate the corresponding BMI implicitly. + When an importable module unit i

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

shafik added a comment. The changes to the various `Vist*CallExpr` functions don't seem directly related to supporting `__has_constexpr_builtin`, can you explain the purpose of those changes? If they are not directly related maybe it makes more sense for them to be split off into a follow-up PR

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

aprantl accepted this revision as: aprantl. aprantl added a comment. This revision is now accepted and ready to land. I think this is reasonable. Ideally the LLVM and Clang patches should be two independent commits. Please wait a few days for others to chime in though. Do you have any idea how m

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 468258. tblah added a comment. clang-format plus cleaning up typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp fl

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 added a comment. In D136041#3862741 , @aprantl wrote: > I think this is reasonable. Ideally the LLVM and Clang patches should be two > independent commits. > Please wait a few days for others to chime in though. Do you have any idea > how much t

[PATCH] D136017: [clang][Interp] Materializing primitive temporaries

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:476 + + assert(E->getNumObjects() == 0 && "TODO: Implement cleanups"); + return this->visit(SubExpr); What cases do we have multiple objects? Can we add failing tests for those?

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

rjmccall added a comment. With these changes in place, this looks fine to me. The underlying problem here is that portable IR generation has gotten too difficult to test textually. FileCheck mostly works fine for testing IR passes, where we rarely worry about target dependencies and carefully

[clang] d0a4741 - Fix LIT test func-attr.c added by https://reviews.llvm.org/D135097.

Author: Zahira Ammarguellat Date: 2022-10-17T14:26:17-04:00 New Revision: d0a4741392a3df0fb4083e12bef0cef14af439e1 URL: https://github.com/llvm/llvm-project/commit/d0a4741392a3df0fb4083e12bef0cef14af439e1 DIFF: https://github.com/llvm/llvm-project/commit/d0a4741392a3df0fb4083e12bef0cef14af439e1

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a4741392a3: Fix LIT test func-attr.c added by https://reviews.llvm.org/D135097. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13608

[clang] 4467c78 - [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

Author: Philip Reames Date: 2022-10-17T11:33:03-07:00 New Revision: 4467c781d7bbf25a3b89a25ccbc0382731f51322 URL: https://github.com/llvm/llvm-project/commit/4467c781d7bbf25a3b89a25ccbc0382731f51322 DIFF: https://github.com/llvm/llvm-project/commit/4467c781d7bbf25a3b89a25ccbc0382731f51322.diff

[PATCH] D135894: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG4467c781d7bb: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

mcgrathr added a comment. The C++ ABI is not part of the Fuchsia system ABI, nor what we call the "Fuchsia compiler ABI". Different users of C++ are free to use whatever C++ ABI they like. Only the backend ABI independent of language-specific issues is necessary to interoperate with other code

  1   2   3   >