sagarkulkarni19 added a comment.

In D134681#3858849 <https://reviews.llvm.org/D134681#3858849>, @rsandifo-arm 
wrote:

> Thanks for the patch.  This is going to be inconvenient, sorry, but: while 
> implementing the specification in GCC, I noticed that the ZA functions 
> weren't consistent about whether they had an `_m` suffix.  `svwrite` (MOVA) 
> had one, but the MOP intrinsics that you're implementing here didn't.  Since 
> SME2 does have some unpredicated instructions, it seems like it would be 
> better to make the MOP intrinsics consistent with `svwrite`, with an `_m` 
> suffix.
>
> I've created https://github.com/ARM-software/acle/pull/218 for that change.  
> Please let me know if it looks reasonable to you.

Thanks for letting me know. I can make the changes to MOP and ADD intrinsics 
and add a `_m` suffix. 
Yes, this looks reasonable to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134681/new/

https://reviews.llvm.org/D134681

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D134681: [Clang]... Richard Sandiford via Phabricator via cfe-commits
    • [PATCH] D134681: [C... Sagar Kulkarni via Phabricator via cfe-commits

Reply via email to