erichkeane marked an inline comment as done. erichkeane added inline comments.
================ Comment at: clang/lib/Sema/SemaExpr.cpp:6748 + SourceLocation ConstraintFailLoc = NakedFn->getBeginLoc(); + ---------------- ChuanqiXu wrote: > It looks like `ConstraintFailLoc` is not used? Woops! Thanks for the catch! I'll remove it. It was a part of a previous implementation. ================ Comment at: clang/lib/Sema/SemaExpr.cpp:6785 + // other than to declare it, is ill-formed. [...] +// if (CheckReferencedFunctionTrailingRequiresClause(FD, ConstraintFailLoc)) +// return ExprError(); ---------------- shafik wrote: > This code is commented out, did you mean to remove it? Since this is the only > code using `ConstraintFailLoc ` then that should go to if you delete this > code. Woops! Yes, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
