[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-ar

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7baddc7557e: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC (authored by SixWeining). Repository: rG LLVM Github Monorepo C

[clang] b7baddc - [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

Author: Weining Lu Date: 2022-09-29T15:02:08+08:00 New Revision: b7baddc7557e5c35a0f6a604a134d849265a99d4 URL: https://github.com/llvm/llvm-project/commit/b7baddc7557e5c35a0f6a604a134d849265a99d4 DIFF: https://github.com/llvm/llvm-project/commit/b7baddc7557e5c35a0f6a604a134d849265a99d4.diff LO

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay added a comment. yeah I'm ok with that too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-arang

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; Did I miss where this comes from now? Repository: rG LLVM Github Mono

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff accepted this revision. sepavloff added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-ar

[clang-tools-extra] 4c862da - [clangd] Avoid using constructor/destructor of vector

Author: Sam McCall Date: 2022-09-29T09:30:03+02:00 New Revision: 4c862da8d43f32bed7ad7e3b700e01d04b3b0f8d URL: https://github.com/llvm/llvm-project/commit/4c862da8d43f32bed7ad7e3b700e01d04b3b0f8d DIFF: https://github.com/llvm/llvm-project/commit/4c862da8d43f32bed7ad7e3b700e01d04b3b0f8d.diff LO

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Driver.h:758 + /// Return the typical executable name for the specified driver \p Mode. + static const char *getExecutableForDriverMode(DriverMode Mode); }; This should be private

[PATCH] D134790: [Driver] Add --config= as canonical spelling of --config

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I don't know the fancy option magic you're using here, I haven't tested it but it seems to make sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 08af5ba - [Driver] Add --config= as canonical spelling of --config

Author: Fangrui Song Date: 2022-09-29T00:38:12-07:00 New Revision: 08af5ba3713523d9596a414e6a64b26494199fdd URL: https://github.com/llvm/llvm-project/commit/08af5ba3713523d9596a414e6a64b26494199fdd DIFF: https://github.com/llvm/llvm-project/commit/08af5ba3713523d9596a414e6a64b26494199fdd.diff

[PATCH] D134790: [Driver] Add --config= as canonical spelling of --config

This revision was automatically updated to reflect the committed changes. Closed by commit rG08af5ba37135: [Driver] Add --config= as canonical spelling of --config (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134790/new/ http

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel commandeered this revision. rymiel added a reviewer: eoanermine. rymiel added a comment. Commandeering to finish the final nits as per https://github.com/llvm/llvm-project/issues/56283#issuecomment-1261653291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 463772. rymiel added a comment. Resolve nits: - Re-sorted uses of the name RequiresExpressionIndentationKind - Updated version to be 16 - Add test for demonstrating indentation as subexpression - Reformatted Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 463773. rymiel added a comment. Missed a spot when re-sorting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 Files: clang/docs/ClangFormatStyleOptions.rst clang/i

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

sammccall added a comment. TL;DR: let's go with this patch as-is rather than borrowing problems from the future. This enum isn't growing very rapidly. In D134728#3822775 , @ckandeler wrote: > In D134728#3822653

[PATCH] D134824: Fix frint ACLE intrinsic names

jaykang10 accepted this revision. jaykang10 added a comment. This revision is now accepted and ready to land. Thanks for fixing it! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134824/new/ https://reviews.llvm.org/D134824 ___

[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for digging into the rabbit role and the great analysis. It looks good from my side. Re the test case `ID(I TWO 3)` we discussed yesterday, I verified that there is no issue. (we don't

[clang] 04a65d6 - Revert D134638 "[Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC"

Author: Fangrui Song Date: 2022-09-29T00:54:56-07:00 New Revision: 04a65d62a0c67da0ee383c8f1d74dea6d8b83a7e URL: https://github.com/llvm/llvm-project/commit/04a65d62a0c67da0ee383c8f1d74dea6d8b83a7e DIFF: https://github.com/llvm/llvm-project/commit/04a65d62a0c67da0ee383c8f1d74dea6d8b83a7e.diff

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler added a comment. In D134728#3822898 , @sammccall wrote: > If the distinction isn't important, maybe we should add a single "constructor > or destructor" modifier... No, it's not. I will update the patch accordingly. Repository: rG LLVM Git

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

MaskRay added a comment. `Constraint_k` somehow broke AArch64 and X86 inlineasm. Please run `check-llvm` for generic changes which may have farreaching effects to other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/ https://rev

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske updated this revision to Diff 463776. balazske added a comment. added test, added a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133119/new/ https://reviews.llvm.org/D133119 Files: clang-tools-extra/clang-tidy/bugprone/Bugprone

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 463778. azat added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/deb

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat marked 2 inline comments as done. azat added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel added a comment. Ping? This is fixing a segmentation fault. Please let me know if there are other people I should add as reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413 _

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This only handles floats for now, so 32 bit floatin

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 463785. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Cont

[PATCH] D134733: [clang-format][chore] transparent #include name regex

kwk updated this revision to Diff 463786. kwk added a comment. - Remove ad-hoc instantiated IncludeRegex objects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134733/new/ https://reviews.llvm.org/D134733 Files: clang/include/clang/Tooling/Inclus

[clang] dba8fce - Fix frint ACLE intrinsic names

Author: Michael Platings Date: 2022-09-29T09:13:07+01:00 New Revision: dba8fced969e2eca9e8650a874293927db17d131 URL: https://github.com/llvm/llvm-project/commit/dba8fced969e2eca9e8650a874293927db17d131 DIFF: https://github.com/llvm/llvm-project/commit/dba8fced969e2eca9e8650a874293927db17d131.di

[PATCH] D134824: Fix frint ACLE intrinsic names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdba8fced969e: Fix frint ACLE intrinsic names (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

kwk added a comment. I didn't see much difference in what this patch does compare to mine but I saw that it removes the need for instantiating multiple `llvm::Regex` objects from a single static pattern. But that's something I've just done in a new revision of my own patch: https://reviews.llvm

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

tbaeder updated this revision to Diff 463791. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134804/new/ https://reviews.llvm.org/D134804 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/In

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

Amanieu added a comment. Currently using Clang with -mgeneral-regs-only generates perfectly fine soft-float AArch64, with the except of the va_arg() implementation which is fixed here. In fact Rust even has a aarch64-unknown-none-softfloat which relies on this behavior in LLVM. I believe this b

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

rovka added inline comments. Herald added a subscriber: zero9178. Comment at: flang/test/Driver/convert.f90:1 +! Ensure argument -fconvert= works as expected. + jpenix-quic wrote: > awarzynski wrote: > > rovka wrote: > > > Nit: Shouldn't you also check that valid

[PATCH] D134733: [clang-format][chore] transparent #include name regex

kwk added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:407 +const llvm::SmallVectorImpl &Matches) { + if (Matches.size() >= 3) { +return Matches[2]; MyDeveloperDay wrote: > kwk wrote: > > MyDeveloperDay wrote: > > > ‘>= 2’

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

DoDoENT added a comment. > Generally the way to do it, if you want to introspect into the type, its > template parameters, etc, then yes, keeping pointers to the AST or reparsing > the name with Clang as-needed, would be the way to go - or walking the AST > up-front and generating your own data

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

sammccall accepted this revision. sammccall added a comment. Sorry about the delay, I've been juggling too many things :-( TL;DR: yes, I think it's reasonable. I think the implementation complexity is justified by what we get. Thanks for explaining! I think to minimize interface complexity, we

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

phosek added a comment. A possible alternative solution would be to build `clangSupport_sources` as an object library, and then link that library into `clangSupport` and `clang-tblgen` which could be done unconditionally; the advantage is that you don't need to compile `clangSupport_sources` tw

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

DavidSpickett added a comment. Has Microsoft documented this option? Not doubting it exists but I mostly see how to use it rather than a specific page describing the option and its behaviour. Not a big deal but if there is one, please include a link to it in the commit message.

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:130 + if (T->isFloatingType()) { +unsigned Bytes = getASTContext().getTypeSize(T); +if (Bytes == 32) Comment at: clang/lib/AST/Interp/Floating.h:106 + // ---

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. > Suppose we have found the way to handle it. But what if we find a > contradiction while simplifying, like (short)(int x) = 0 and (int x) = 1. So > that we would already know that it is impossible. What SVal should we return > in such case? Undef? Unknown? Original one

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 463807. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Cont

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

dmgreen added a comment. > With -mgeneral-regs-only, all arguments are passed in GPRs, so we should use > gr_top/gr_offs in va_list even for floating-point types. I don't believe that -mgeneral-regs-only was intended to define an ABI passing floats in GPRs for AArch64. If it has that is likely

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. Actually, you already have a logic for checking if there is a contradiction in your D103096 patch, in ConstraintAssignor::updateExistingConstraints: // Update constraints in the map which bitwidth is equal or lower then // `MinBitW

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

Amanieu added a comment. I fully agree that this likely wasn't intentional, but this is still very useful for code that can't use FP registers for whatever reason (e.g. kernels). Regarding the ABI, it doesn't need to be officially defined: it just needs to be compatible with other code compiled

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske updated this revision to Diff 463812. balazske added a comment. rebase to current main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133119/new/ https://reviews.llvm.org/D133119 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyM

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463815. SixWeining added a comment. Herald added a subscriber: pengfei. The flag in the INLINEASM SDNode in llvm/test/CodeGen/X86/callbr-asm-kill.mir is updated because enum `Constraint_k` is added before `Constraint_m`. Repository: rG LLVM Github Mono

[PATCH] D133885: [Clang][Arm] Convert -fallow-half-arguments-and-returns to a target option. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG123064dc397d: [Clang][Arm] Convert -fallow-half-arguments-and-returns to a target option. NFC (authored by dmgreen). Herald added a project: clang.

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. In D134638#3822926 , @MaskRay wrote: > `Constraint_k` somehow broke AArch64 and X86 inlineasm. Please run at least > `check-llvm check-clang` for generic changes which may have farreaching > effects to other targets. Sorry f

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463825. mgorny marked 2 inline comments as done. mgorny added a comment. Address @MaskRay 's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst clang/docs/Users

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/include/clang/Driver/Driver.h:758 + /// Return the typical executable name for the specified driver \p Mode. + static const char *getExecutableForDriverMode(DriverMode Mode); }; MaskRay wrote: > This should be pr

[PATCH] D133659: [Clang] P1169R4: static operator()

cor3ntin added a comment. I only left a few comments because I'm not familiar enough with that part of the code to be certain the changes are correct but overall it looks fine to me. Comment at: clang/include/clang/Sema/Overload.h:524-526 +/// StaticObjectArgumentConversio

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

xen0n added a comment. The previous test results (with some of my WIP patches but unrelated to this) before the fix: Failed Tests (6): LLVM :: CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll LLVM :: CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll LLVM :: CodeGen/Generic/

[PATCH] D133856: [clang][Interp] Pass initializer through when creating variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGda62ed6ceb12: [clang][Interp] Pass initializer when creating globals (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D133856?vs=460057&id=463834#toc Repository: rG LLVM Githu

[clang] da62ed6 - [clang][Interp] Pass initializer when creating globals

Author: Timm Bäder Date: 2022-09-29T12:50:54+02:00 New Revision: da62ed6ceb12031992d863ce272bc4863505b84b URL: https://github.com/llvm/llvm-project/commit/da62ed6ceb12031992d863ce272bc4863505b84b DIFF: https://github.com/llvm/llvm-project/commit/da62ed6ceb12031992d863ce272bc4863505b84b.diff LO

[clang] 18a5fc5 - [clang][Interp][NFC] Remove an unnecessary include.

Author: Timm Bäder Date: 2022-09-29T12:50:55+02:00 New Revision: 18a5fc52b28e9a612c8c531209f6bda5ff0964b7 URL: https://github.com/llvm/llvm-project/commit/18a5fc52b28e9a612c8c531209f6bda5ff0964b7 DIFF: https://github.com/llvm/llvm-project/commit/18a5fc52b28e9a612c8c531209f6bda5ff0964b7.diff LO

[clang] 1d31549 - [clang][Interp][NFC] Forward-declare Pointer in InterpFrame.h

Author: Timm Bäder Date: 2022-09-29T12:50:55+02:00 New Revision: 1d31549e9373962a1a76eb83b304b0c616aa21e7 URL: https://github.com/llvm/llvm-project/commit/1d31549e9373962a1a76eb83b304b0c616aa21e7 DIFF: https://github.com/llvm/llvm-project/commit/1d31549e9373962a1a76eb83b304b0c616aa21e7.diff LO

[clang] 1c35f3b - [clang][Interp][NFC] Unify emit() implementations

Author: Timm Bäder Date: 2022-09-29T12:50:55+02:00 New Revision: 1c35f3b93aff7c39832f42f470c45fd24c3a779c URL: https://github.com/llvm/llvm-project/commit/1c35f3b93aff7c39832f42f470c45fd24c3a779c DIFF: https://github.com/llvm/llvm-project/commit/1c35f3b93aff7c39832f42f470c45fd24c3a779c.diff LO

[clang] ee2e414 - [clang][Interp] Handle sizeof()

Author: Timm Bäder Date: 2022-09-29T12:50:55+02:00 New Revision: ee2e414d66a4b3b4e1a3bade11168a108f349d8a URL: https://github.com/llvm/llvm-project/commit/ee2e414d66a4b3b4e1a3bade11168a108f349d8a DIFF: https://github.com/llvm/llvm-project/commit/ee2e414d66a4b3b4e1a3bade11168a108f349d8a.diff LO

[clang] 7c4cad4 - [clang][Interp][NFC] Make a few InterpStack functions const

Author: Timm Bäder Date: 2022-09-29T12:50:55+02:00 New Revision: 7c4cad43309ebce4a9f3c656ca4629f8ac9ed877 URL: https://github.com/llvm/llvm-project/commit/7c4cad43309ebce4a9f3c656ca4629f8ac9ed877 DIFF: https://github.com/llvm/llvm-project/commit/7c4cad43309ebce4a9f3c656ca4629f8ac9ed877.diff LO

[clang] df1cc80 - [clang][Interp] Record item types in InterpStack

Author: Timm Bäder Date: 2022-09-29T12:50:55+02:00 New Revision: df1cc801da05a6436f6dc3062ccd490f236cd7ec URL: https://github.com/llvm/llvm-project/commit/df1cc801da05a6436f6dc3062ccd490f236cd7ec DIFF: https://github.com/llvm/llvm-project/commit/df1cc801da05a6436f6dc3062ccd490f236cd7ec.diff LO

[clang] c090295 - [clang][Interp] Handle enums

Author: Timm Bäder Date: 2022-09-29T12:50:56+02:00 New Revision: c090295916a921e809184f589c6830475e293b8b URL: https://github.com/llvm/llvm-project/commit/c090295916a921e809184f589c6830475e293b8b DIFF: https://github.com/llvm/llvm-project/commit/c090295916a921e809184f589c6830475e293b8b.diff LO

[clang] 202ff42 - [clang][Interp] Rename a local variable to be more specific

Author: Timm Bäder Date: 2022-09-29T12:50:56+02:00 New Revision: 202ff42f8990fb0bd0236a413c30dab357fd809a URL: https://github.com/llvm/llvm-project/commit/202ff42f8990fb0bd0236a413c30dab357fd809a DIFF: https://github.com/llvm/llvm-project/commit/202ff42f8990fb0bd0236a413c30dab357fd809a.diff LO

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGee2e414d66a4: [clang][Interp] Handle sizeof() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133934/new/ https://reviews.llvm.org/D133

[clang] eadd505 - [clang][Interp][NFC] Limit includes to neccessary ones

Author: Timm Bäder Date: 2022-09-29T12:50:56+02:00 New Revision: eadd505b0c054eacba7d0349505ea9ca1acf54f0 URL: https://github.com/llvm/llvm-project/commit/eadd505b0c054eacba7d0349505ea9ca1acf54f0 DIFF: https://github.com/llvm/llvm-project/commit/eadd505b0c054eacba7d0349505ea9ca1acf54f0.diff LO

[clang] d5360b9 - [clang][Interp][NFC] Make classes final that can be final

Author: Timm Bäder Date: 2022-09-29T12:50:56+02:00 New Revision: d5360b932ecd6fc7ca45f89d7c87ffb39f7edfe2 URL: https://github.com/llvm/llvm-project/commit/d5360b932ecd6fc7ca45f89d7c87ffb39f7edfe2 DIFF: https://github.com/llvm/llvm-project/commit/d5360b932ecd6fc7ca45f89d7c87ffb39f7edfe2.diff LO

[clang] 8f5b061 - [clang][Interp][NFC] Make some Record methods const

Author: Timm Bäder Date: 2022-09-29T12:50:56+02:00 New Revision: 8f5b061254744dedd95b6c0d03b909b4084611a3 URL: https://github.com/llvm/llvm-project/commit/8f5b061254744dedd95b6c0d03b909b4084611a3 DIFF: https://github.com/llvm/llvm-project/commit/8f5b061254744dedd95b6c0d03b909b4084611a3.diff LO

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf1cc801da05: [clang][Interp] Record item types in InterpStack (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D133941?vs

[clang] 84f1df8 - [clang][Interp] Properly destruct allocated Records

Author: Timm Bäder Date: 2022-09-29T12:50:56+02:00 New Revision: 84f1df8aacd0c3eb72f20f91c9af227b65d4c7da URL: https://github.com/llvm/llvm-project/commit/84f1df8aacd0c3eb72f20f91c9af227b65d4c7da DIFF: https://github.com/llvm/llvm-project/commit/84f1df8aacd0c3eb72f20f91c9af227b65d4c7da.diff LO

[clang] f927b71 - [clang][Interp] Specify Boolean conversion operartors as (u)int32

Author: Timm Bäder Date: 2022-09-29T12:50:57+02:00 New Revision: f927b71376c198a41f0c578be896bf231a6a5fd1 URL: https://github.com/llvm/llvm-project/commit/f927b71376c198a41f0c578be896bf231a6a5fd1 DIFF: https://github.com/llvm/llvm-project/commit/f927b71376c198a41f0c578be896bf231a6a5fd1.diff LO

[clang] e8ad133 - [clang][Interp][NFC] Remove unused function

Author: Timm Bäder Date: 2022-09-29T12:50:57+02:00 New Revision: e8ad1339d441931326554bdc4ec6b7198f289028 URL: https://github.com/llvm/llvm-project/commit/e8ad1339d441931326554bdc4ec6b7198f289028 DIFF: https://github.com/llvm/llvm-project/commit/e8ad1339d441931326554bdc4ec6b7198f289028.diff LO

[clang] 7c65d57 - [clang][Interp][NFC] Unify the two ReadArg() implementations

Author: Timm Bäder Date: 2022-09-29T12:50:57+02:00 New Revision: 7c65d57af0ef20ce28ca9c1efae8e3214d57268d URL: https://github.com/llvm/llvm-project/commit/7c65d57af0ef20ce28ca9c1efae8e3214d57268d DIFF: https://github.com/llvm/llvm-project/commit/7c65d57af0ef20ce28ca9c1efae8e3214d57268d.diff LO

[clang] 9837a3b - [clang][Interp][NFC] Remove unused opcode argument types

Author: Timm Bäder Date: 2022-09-29T12:50:57+02:00 New Revision: 9837a3bd4b91317b1f84eab9ffc1c3c1c57e59a0 URL: https://github.com/llvm/llvm-project/commit/9837a3bd4b91317b1f84eab9ffc1c3c1c57e59a0 DIFF: https://github.com/llvm/llvm-project/commit/9837a3bd4b91317b1f84eab9ffc1c3c1c57e59a0.diff LO

[PATCH] D134020: [clang][Interp] Handle enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc090295916a9: [clang][Interp] Handle enums (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] f55c4b4 - [clang][Interp] Print Function address in dump()

Author: Timm Bäder Date: 2022-09-29T12:50:57+02:00 New Revision: f55c4b4ee3d11cb8028edeabed91284ec7c3276d URL: https://github.com/llvm/llvm-project/commit/f55c4b4ee3d11cb8028edeabed91284ec7c3276d DIFF: https://github.com/llvm/llvm-project/commit/f55c4b4ee3d11cb8028edeabed91284ec7c3276d.diff LO

[PATCH] D134054: [clang][Interp] Properly destruct allocated Records

This revision was automatically updated to reflect the committed changes. Closed by commit rG84f1df8aacd0: [clang][Interp] Properly destruct allocated Records (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D134054?vs=460813&id=463839#toc Repository: rG LLVM Github M

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

mgorny created this revision. mgorny added reviewers: python3kgae, beanz, MaskRay, zturner. Herald added subscribers: StephenFan, delcypher. Herald added a project: All. mgorny requested review of this revision. Herald added a project: LLVM. Move the `%clang_dxc` substitution from local definition

[clang] e6171e8 - [Clang][Arm] Fix fp16 return error tests under AArch64/Arm. NFC

Author: David Green Date: 2022-09-29T12:16:13+01:00 New Revision: e6171e87e16c59df5fba642d1f48de6f0a2d93d8 URL: https://github.com/llvm/llvm-project/commit/e6171e87e16c59df5fba642d1f48de6f0a2d93d8 DIFF: https://github.com/llvm/llvm-project/commit/e6171e87e16c59df5fba642d1f48de6f0a2d93d8.diff L

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. In D133468#3823143 , @sammccall wrote: > Sorry about the delay, I've been juggling too many things :-( No worries, thanks! > TL;DR: yes, I think it's reasonable. I think the implementation complexity is > justified by what we

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

sammccall added subscribers: hokein, sammccall. sammccall added a comment. Herald added a project: All. In D20401#2770059 , @nickdesaulniers wrote: > I know this was sped up slightly in 3339c568c43e4644f02289e5edfc78c860f19c9f, > but this change makes `u

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 463846. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Cont

[PATCH] D134020: [clang][Interp] Handle enums

tbaeder added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; shafik wrote: > Maybe some edge case values for enumerators like `__INT_MAX__ *2U +1U` > (UINT_MAX) > > and > > ``` > enum E { // warning: enumeration val

[clang] f444a7c - Revert "[clang][Interp] Handle enums"

Author: Timm Bäder Date: 2022-09-29T13:45:52+02:00 New Revision: f444a7cc16bb0bbfdac719b46b7e0950e6e78ce2 URL: https://github.com/llvm/llvm-project/commit/f444a7cc16bb0bbfdac719b46b7e0950e6e78ce2 DIFF: https://github.com/llvm/llvm-project/commit/f444a7cc16bb0bbfdac719b46b7e0950e6e78ce2.diff LO

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463847. SixWeining added a comment. Herald added subscribers: kosarev, kerbowa, jvesely. update CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll and CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. In D134638#3823379 , @xen0n wrote: > The previous test results (with some of my WIP patches but unrelated to this) > before the fix: > > Failed Tests (6): > LLVM :: CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll >

[PATCH] D134020: [clang][Interp] Handle enums

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; tbaeder wrote: > shafik wrote: > > Maybe some edge case values for enumerators like `__INT_MAX__ *2U +1U` > > (UINT_MAX) > > > > and > > > > ``` > >

[clang] b934be2 - [Support] Class for response file expansion (NFC)

Author: Serge Pavlov Date: 2022-09-29T19:15:01+07:00 New Revision: b934be2c059a99351d08069bb80155e49f047b6e URL: https://github.com/llvm/llvm-project/commit/b934be2c059a99351d08069bb80155e49f047b6e DIFF: https://github.com/llvm/llvm-project/commit/b934be2c059a99351d08069bb80155e49f047b6e.diff

[clang] e62b3a9 - Unwind-tables: move back to original logic outline for kind.

Author: Tim Northover Date: 2022-09-29T13:39:06+01:00 New Revision: e62b3a9375d8694efe5bf3d1409bec9be0d288e9 URL: https://github.com/llvm/llvm-project/commit/e62b3a9375d8694efe5bf3d1409bec9be0d288e9 DIFF: https://github.com/llvm/llvm-project/commit/e62b3a9375d8694efe5bf3d1409bec9be0d288e9.diff

[PATCH] D134640: Unwind-tables: move back to original logic outline for kind.

t.p.northover closed this revision. t.p.northover added a comment. Sorry about that, committed as e62b3a9375d8 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134640/new/ https:/

[PATCH] D130510: Missing tautological compare warnings due to unary operators

uabelho added a comment. In D130510#3821641 , @aaron.ballman wrote: > In D130510#3817148 , @ebevhan wrote: > >> Hi! A bit of late feedback on this patch. We found a failure in our >> downstream testing likely or

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

hans added a comment. In D131465#3821701 , @aaron.ballman wrote: > Perhaps the simple rule we're going for is "when executed on Windows, Clang > defaults to C++17 unless it is executed from a context in which an MSVC > library can be detected, in which

[PATCH] D134872: AMDGPU: Add __builtin_amdgcn_permlane64

arsenm created this revision. arsenm added reviewers: yaxunl, AMDGPU. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: llvm-commits, wdng. Herald added a project: L

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

urnathan added a comment. Does this still apply with the fix for dr2621 landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134303/new/ https://reviews.llvm.org/D134303 ___ cfe-commits mailing list cfe

[PATCH] D134020: [clang][Interp] Handle enums

tbaeder added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; aaron.ballman wrote: > tbaeder wrote: > > shafik wrote: > > > Maybe some edge case values for enumerators like `__INT_MAX__ *2U +1U` > > > (UINT_MAX) > > >

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane created this revision. erichkeane added reviewers: tahonermann, shafik. Herald added a project: All. erichkeane requested review of this revision. As fallout of the Deferred Concept Instantiation patch (babdef27c5 ),

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 marked 7 inline comments as done. 10ne1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:363 const StringRef TripleStr = GCCInstallation.getTriple().str(); - const Multilib &Multilib = GCCInstallation.getMultilib(); + std::string Path = (Install

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 updated this revision to Diff 463864. 10ne1 marked an inline comment as done. 10ne1 added a comment. Updated based on feedback from Nick. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454 Files: clang/lib/Driver/ToolChains/Linux.cpp In

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. In D134128#3813708 , @lime wrote: > Well, Something happened after rebasing this patch on D126907 > . `s41` below was rejected as the constrain > generated from `template ` was no longer cons

[PATCH] D134020: [clang][Interp] Handle enums

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > shafik wrote: > > > > Maybe some edge case values for enumerators like `__INT_MAX__ *2U +1

  1   2   3   >