MaskRay added inline comments.
================ Comment at: clang/include/clang/Driver/Driver.h:758 + /// Return the typical executable name for the specified driver \p Mode. + static const char *getExecutableForDriverMode(DriverMode Mode); }; ---------------- This should be private ================ Comment at: clang/lib/Driver/Driver.cpp:1094 + // (e.g. i386-pc-linux-gnu-clang++.cfg). + // 2. <triple>-<mode>.cfg using executable suffix + // (e.g. i386-pc-linux-gnu-clang-g++.cfg). ---------------- "executable suffix" is less clear. An example will help. ================ Comment at: clang/lib/Driver/Driver.cpp:1101 + + // Try loading full config (variants 1. and 2.) llvm::SmallString<128> CfgFilePath; ---------------- Mention "first part" ? (And what does "first part refer to") CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
