[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2258 +Width = 0; \ +Align = 8; /* ? */

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added inline comments. Comment at: flang/test/Driver/emit-mlir.f90:16 ! CHECK-NEXT: } +! CHECK-NEXT: fir.global @_QQEnvironmentDefaults constant : !fir.ref, !fir.ref> { +! CHECK-NEXT: %[[VAL_0:.*]] = fir.zero_bits !fir.ref, !fir.ref> jpenix-qui

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. Can someone do a final review on this? And apply it if everything is OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 ___ cfe-commits m

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:317 +// CHECK-NEXT:store [10 x i32]* [[AA]], [10 x i32]** [[RAA]], align 8 +// CHECK-NEXT:[[TMP2:%.*]] = load i32*, i32** [[K]], align 8 +// CHECK-NEXT:[[TMP3:%.*]] = geteleme

[PATCH] D134137: [clangd] Return earlier when snippet is empty

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017 +TEST(CompletionTests, EmptySnippetDoesNotCrash) { +// See https://github.com/clangd/clang

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, dblaikie, Bigcheese, vsapsai. ChuanqiXu added projects: clang, clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This patch tries to make clang

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, dblaikie, ruoso, ben.boeckel. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the fo

[clang] 41dbee1 - [clang] Update ReleaseNotes about a crash fix (Issue 53628)

Author: Dmitry Polukhin Date: 2022-09-20T02:05:36-07:00 New Revision: 41dbee1e66937fe7d579b73d30dc790cd79b8738 URL: https://github.com/llvm/llvm-project/commit/41dbee1e66937fe7d579b73d30dc790cd79b8738 DIFF: https://github.com/llvm/llvm-project/commit/41dbee1e66937fe7d579b73d30dc790cd79b8738.dif

[PATCH] D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41dbee1e6693: [clang] Update ReleaseNotes about a crash fix (Issue 53628) (authored by DmitryPolukhin). Changed prior to commit: https://reviews.llvm.org/D134112?vs=461009&id=461514#toc Repository: r

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

Izaron abandoned this revision. Izaron added a comment. In D134136#3801495 , @efriedma wrote: > These patches are hard to review, yes; the reviewer has to go through and > verify for each function that the substitutes you've written actually match > the

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 461518. pmatos added a comment. Address further concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos planned changes to this revision. pmatos added a comment. Current patch addresses most of the concerns - also passed through `./clang/tools/clang-format/git-clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://re

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

abhinavgaba added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:351 +// CHECK: omp_offload.failed: +// CHECK-NEXT:call void @{{__omp_offloading_[0-9a-z]+_[0-9a-z]+}}_main_l145(i32* [[TMP2]]) #[[ATTR5:[0-9]+]] +// CHECK-NEXT:br l

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Support specifying multiple configuration files via multiple `--config` options. When multiple files are specifie

[PATCH] D134271: [clang] [docs] Improve formatting & fix typo in config docs

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Fix teletype formatting in configuration file documentation to use double backticks rather than single backticks.

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

luismarques added a comment. Regarding the overkill of "RISCVInstrInfoZawrs.td", how about having a "RISCVInstrInfoExtra.td" (or "RISCVInstrInfoExt.td") as a grab bag for everything that doesn't merit its own .td file? I think this is fine regarding the versioning issue. Seems to only be missin

[clang] 58f9aba - AAArch64: disable asynchronous unwind by default for MachO.

Author: Tim Northover Date: 2022-09-20T10:47:18+01:00 New Revision: 58f9abaed4aa148566d5f14afdf473e57b20d687 URL: https://github.com/llvm/llvm-project/commit/58f9abaed4aa148566d5f14afdf473e57b20d687 DIFF: https://github.com/llvm/llvm-project/commit/58f9abaed4aa148566d5f14afdf473e57b20d687.diff

[clang] 4388b56 - Refactor unwind table driver interface to expose default level. NFC.

Author: Tim Northover Date: 2022-09-20T10:47:18+01:00 New Revision: 4388b56d525c08ce3cf941cfbad2428b0e1695b0 URL: https://github.com/llvm/llvm-project/commit/4388b56d525c08ce3cf941cfbad2428b0e1695b0 DIFF: https://github.com/llvm/llvm-project/commit/4388b56d525c08ce3cf941cfbad2428b0e1695b0.diff

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover closed this revision. t.p.northover added a comment. Just noticed it'd already been approved with those suggestions, so pushed the revised version: 4388b56d and 58f9abaed4aa

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

awarzynski added inline comments. Comment at: flang/include/flang/Optimizer/Builder/Runtime/EnvironmentDefaults.h:7 +// +//===--===// + Could you document what these are? And what are they used

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. In D133468#3801838 , @davrec wrote: > If I understand this correctly: whenever isDivergent() is true, `getDecl()` > or `getFoundDecl()` is an arbitrary choice between multiple candidate > (re)declarations of a typedef or using

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

avogelsgesang added inline comments. Comment at: clang/docs/StandardCPlusPlusModules.rst:916 +We call this manner as two-phase compilation +(sources to BMIs and BMIs to object files) to disambiguate the tranditional +compilation process (sources to object files directly), ---

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin added a comment. Thanks for take a review @aaron.ballman @rjmccall , can you land this patch for me? Please use 'yronglin ' to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133583/new/ https://reviews.llvm.org/D133583

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

urnathan added a comment. Might be mooted by fixing https://github.com/llvm/llvm-project/issues/57659, which I am working on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134243/new/ https://reviews.llvm.org/D134243 __

[PATCH] D133834: [RISCV] Remove support for the unratified Zbt extension.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. There seemed to be consensus on this in last week's meeting, and there's no upstream activity on the spec, so removing zbt makes sense to me. Comment at: llvm/docs/ReleaseNotes.rs

[PATCH] D133698: [clang][dataflow] SignAnalysis, edgeTransfer, branchTransfer

martong planned changes to this revision. martong added a comment. Aligned with the RFC, I am going to dissect this patch into two patches: 1. This patch will remain a simple infrastructural change that introduces transferBranch. This could be useful for complex lattices (e.g integer value rang

[PATCH] D134233: [clang-format] Wrap inserted braces only if preceded by comments

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I love the little and often approach, its so much easier to review, LGTM... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134233/

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

rovka added a comment. IMO this is a reasonable approach, I only have a few nits. Comment at: flang/runtime/environment.cpp:42 +#else +if (setenv(name, value, 0) == -1) { +#endif Comment at: flang/runtime/environment.cpp:77 +#else + env

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

MyDeveloperDay added a comment. Should we test nested if/else/endif CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

MyDeveloperDay added a comment. @rymiel you definitely deserve the commit access: comments and initial investigations and possible bug locations in github issues, defect focused initial commits, way to go!, Welcome aboard.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

sammccall added a comment. In D134243#3802457 , @urnathan wrote: > Might be mooted by fixing https://github.com/llvm/llvm-project/issues/57659, > which I am working on Great! Agree that larger changes around using-enum parsing would probably end up sol

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 461544. pmatos added a comment. Address most of the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h clang/include/c

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added inline comments. Comment at: flang/test/Driver/emit-mlir.f90:16 ! CHECK-NEXT: } +! CHECK-NEXT: fir.global @_QQEnvironmentDefaults constant : !fir.ref, !fir.ref> { +! CHECK-NEXT: %[[VAL_0:.*]] = fir.zero_bits !fir.ref, !fir.ref> awarzynski

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

davrec accepted this revision. davrec added a comment. Agree this needs a brief commit message, just explaining that previously the underlying type had to be canonical, but now it can be sugared, allowing a better/more informative representation. Comment at: clang/include/cla

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

RKSimon added a comment. A few minors - and this probably needs a release notes entry for 16.x? Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2185 +addRegisterClass(MVT::v32bf16, &X86::VR512RegClass); +setOperationAction(ISD::BUILD_VECTOR, MVT::bf16, Custom); +

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM to fix the crash. If @urnathan's changes happen to make this change obsolete, we could also revert consider reverting it afterwards. Comment at: clang/lib

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

davrec added a subscriber: sammccall. davrec added a comment. > In general, forgetting about just the above particular way of creating them, > there might still exist only one TypedefDecl in the whole program, which > every TypedefType is referencing, and they can still be divergent, ie have >

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 461561. barcisz added a comment. Inlined definition of size_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-tidy/CMakeLists.txt c

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin created this revision. DiggerLin added reviewers: jhenderson, daltenty, hubert.reinterpretcast. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check

barcisz updated this revision to Diff 461562. barcisz added a comment. Removed unused matcher definitions from bugprone-unused-return-value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133801/new/ https://reviews.llvm.org/D133801 Files: clang-t

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

jhenderson added a comment. Wouldn't it be better to change the lit config to specify the `OBJECT_MODE` environment variable on AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 __

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802763 , @jhenderson wrote: > Wouldn't it be better to change the lit config to specify the `OBJECT_MODE` > environment variable on AIX? I have tried it before, I added the following in clang/test/lit.cfg.py if 's

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

jhenderson added a comment. In D134284#3802766 , @DiggerLin wrote: > In D134284#3802763 , @jhenderson > wrote: > >> Wouldn't it be better to change the lit config to specify the `OBJECT_MODE` >> environment vari

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802791 , @jhenderson wrote: > In D134284#3802766 , @DiggerLin > wrote: > >> In D134284#3802763 , @jhenderson >> wrote: >> >>> Wou

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

jhenderson added a subscriber: jasonliu. jhenderson added a comment. In D134284#3802793 , @DiggerLin wrote: > In D134284#3802791 , @jhenderson > wrote: > >> In D134284#3802766

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > If OBJECT_MODE isn't an environment variable that clang uses, surely it > should ignore it? The clang driver does in fact respect OBJECT_MODE on AIX, but I'm guessing it doesn't accept the `any` setting (since it doesn't really make sense in that context). Reposit

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802806 , @daltenty wrote: >> If OBJECT_MODE isn't an environment variable that clang uses, surely it >> should ignore it? > > The clang driver does in fact respect OBJECT_MODE on AIX, but I'm guessing it > doesn't

[clang] 8aed4bb - [CMake] [NFC] Add clang headers to IDE projects

Author: Chris Bieneman Date: 2022-09-20T10:41:27-05:00 New Revision: 8aed4bb2783d32c40fae998b6518cd40a16b6ec5 URL: https://github.com/llvm/llvm-project/commit/8aed4bb2783d32c40fae998b6518cd40a16b6ec5 DIFF: https://github.com/llvm/llvm-project/commit/8aed4bb2783d32c40fae998b6518cd40a16b6ec5.diff

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > It looks to me like > https://github.com/llvm/llvm-project/blob/b982ba2a6e0f11340b4e75d1d4eba9ff62a81df7/clang/lib/Driver/Driver.cpp#L554 > should be modified to accept the OBJECT_MODE values you've implemented for > llvm-nm and llvm-ar. Otherwise, you'll never be ab

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

hubert.reinterpretcast added a comment. Instead of applying `OBJECT_MODE` to everything, maybe we can apply it only to the tool invocations via a LIT expansion? Something like `%llvm-nm` that expands (for AIX) to `OBJECT_MODE=any llvm-nm`? Would need to check that the LIT internal shell accepts

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, jyknight, rsmith, rjmccall, clang-language-wg. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project:

[clang] 0c89b34 - [HLSL] Pass flags to cc1 based on language

Author: Chris Bieneman Date: 2022-09-20T10:56:17-05:00 New Revision: 0c89b343371fca437a86093a01dc5eb6ed1a4a9b URL: https://github.com/llvm/llvm-project/commit/0c89b343371fca437a86093a01dc5eb6ed1a4a9b DIFF: https://github.com/llvm/llvm-project/commit/0c89b343371fca437a86093a01dc5eb6ed1a4a9b.diff

[PATCH] D133958: [HLSL] Pass flags to cc1 based on language

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c89b343371f: [HLSL] Pass flags to cc1 based on language (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133958/new/ https://reviews.llvm

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman updated this revision to Diff 461583. aaron.ballman added a comment. Updated the C status page accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. In D133468#3802727 , @davrec wrote: > what is the different principle behind choosing a different underlying type? > Why can't the underlying type for `t29`/`t32` be sugar for X1 and friends > too? The underlying type is tak

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne accepted this revision. ldionne added inline comments. Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a regex in the + "expected" tests

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 461588. mingmingl added a comment. It has been a while since this patch was updated, rebase for review now that the Github PR was accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/ https://r

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. Hi folks, The ARM ACLE PR (https://github.com/ARM-software/acle/pull/199) was accepted. Would you take another look of this patch at your convenience? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

paulkirth added a comment. @iamarchit123 I think the standard advice is to start w/ the llvm-test-suite and then explore other benchmarks as needed. Also, Clang itself is often a very good starting point. As for profiles, it probably won't be representative, but you could collect the profile u

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

aaron.ballman added inline comments. Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a regex in the + "expected" tests to make it pass the CI. +

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8392f1cc7827: Fix __builtin_assume_aligned incorrect type descriptor and C++ object… (authored by yronglin, committed by aaron.ballman). Repository:

[clang] 8392f1c - Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

Author: yronglin Date: 2022-09-20T12:35:18-04:00 New Revision: 8392f1cc78270c7039970b413dfd836bf4def602 URL: https://github.com/llvm/llvm-project/commit/8392f1cc78270c7039970b413dfd836bf4def602 DIFF: https://github.com/llvm/llvm-project/commit/8392f1cc78270c7039970b413dfd836bf4def602.diff LOG:

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank updated this revision to Diff 461592. nicovank added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt clang-t

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

aaron.ballman added a comment. In D133583#3802451 , @yronglin wrote: > Thanks for take a review @aaron.ballman @rjmccall , can you land this patch > for me? Please use 'yronglin ' to commit the change. Happy to do so! I've landed on your behalf in http

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. F24615059: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits maili

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin updated this revision to Diff 461589. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 Files: clang/test/lit.cfg.py Index: clang/test/lit.cfg.py

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin updated this revision to Diff 461598. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 Files: clang/test/lit.cfg.py Index: clang/test/lit.cfg.py ===

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin added a comment. In D133583#3803002 , @aaron.ballman wrote: > In D133583#3802451 , @yronglin > wrote: > >> Thanks for take a review @aaron.ballman @rjmccall , can you land this patch >> for me? Please

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

erichkeane added a comment. I'm on the fence about re-using the same nodes for `typeof` and `typeof_unqual`. However, I have a preference to stop shuffling a bool around everywhere as parameters, and would like an enum (even if we store it as a bitfield : 1). Something like: enum class Typ

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. Thanks! Going to submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/ https://reviews.llvm.org/D127798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce7b4747e8b3: [AArch64] Define __ARM_FEATURE_RCPC (authored by mingmingl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] ce7b474 - [AArch64] Define __ARM_FEATURE_RCPC

Author: Mingming Liu Date: 2022-09-20T10:03:13-07:00 New Revision: ce7b4747e8b329ad6bc3362a3e3c245331127d6d URL: https://github.com/llvm/llvm-project/commit/ce7b4747e8b329ad6bc3362a3e3c245331127d6d DIFF: https://github.com/llvm/llvm-project/commit/ce7b4747e8b329ad6bc3362a3e3c245331127d6d.diff

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGeda2af575fdf: [RISCV][MC] Add support for experimental Zawrs extension (authored by reames). Changed prior to commit: h

[clang] eda2af5 - [RISCV][MC] Add support for experimental Zawrs extension

Author: Philip Reames Date: 2022-09-20T10:15:11-07:00 New Revision: eda2af575fdf038f3508112b42845516e7cb6192 URL: https://github.com/llvm/llvm-project/commit/eda2af575fdf038f3508112b42845516e7cb6192 DIFF: https://github.com/llvm/llvm-project/commit/eda2af575fdf038f3508112b42845516e7cb6192.diff

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

shafik added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1717 /// GCC extension. + QualType getTypeOfExprType(Expr *E, bool IsUnqual) const; I guess these are not purely extensions anymore? Comment at: clang/include/

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added a comment. In D133443#3801899 , @asb wrote: > It looks like they're still missing in this updated version of the patch? I have no idea what's going wrong here. I had been very careful to make sure the patch contained the new test file, but

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman added a reviewer: ahatanak. mwyman added a comment. Hi Akira, I'd reached out to John offline and he'd mentioned you might be able to help on some of these objc_direct reviews; if so, that would be wonderful! -Michael CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ h

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125418/new/ https://reviews.llvm.org/D125418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:4537 Expr *TOExpr; + bool IsUnqual; You can use the Type Bitfields in order to avoid bumping the size of the node. Comment at: clang/lib/AST/ASTContext.cpp:12910-

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:4601 +QualType QT = getUnderlyingType(); +return IsUnqual ? QT.getTypeofUnqualType() : QT; + } shafik wrote: > It is interesting that you do `getTypeofUnqualType` in the construct

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:4592 + T->getDependence()), TOType(T), IsUnqual(IsUnqual) { +assert(!isa(Can) && "Invalid canonical type"); } erichkeane wrote: > Are `TypedefType`'s EVER canonical? Shoul

[PATCH] D134284: [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM to unblock the AIX buildbots. We can follow up on a separate env later if desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4df84ac377df: [clang-doc] Centralize TypeInfo creation. (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134225/ne

[clang-tools-extra] 4df84ac - [clang-doc] Centralize TypeInfo creation.

Author: Brett Wilson Date: 2022-09-20T17:55:47Z New Revision: 4df84ac377dfc88da0217dc8cbb9aa69be6cbe55 URL: https://github.com/llvm/llvm-project/commit/4df84ac377dfc88da0217dc8cbb9aa69be6cbe55 DIFF: https://github.com/llvm/llvm-project/commit/4df84ac377dfc88da0217dc8cbb9aa69be6cbe55.diff LOG:

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12910-12916 +// FIXME:: is this assumption correct or do we need to do work here to find +// the common type sugar regarding the stripped qualifiers if only one side +// is unqual? +assert(ca

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 461627. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h clang/include/clang/

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 461628. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST

[PATCH] D134295: [clang] Fix missing template arguments in AST of access to member variable template

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Depends on D132816 Repository: rG LLVM Github Mono

[PATCH] D134231: [clang][C++20] p0960 Allow initializing aggregates from a parenthesized list of values

shafik added a comment. Hello Ed, thank you for picking up this work. I liked the approach in the first PR, did you consider reaching out to the author is asking if it was ok to commandeer the work to allow it to move forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao marked an inline comment as done. ayzhao added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379 // FIXME: This is not quite correct recovery as we don't transform SS // into the corresponding dependent form (and we don't diagnose missing

[PATCH] D132711: [HLSL] add sqrt library function

bob80905 updated this revision to Diff 461636. bob80905 added a comment. include both commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/test/CodeGenHLSL/builtins/sqrt.hlsl Index: cl

[clang] 16f735d - [Driver] Make --execute-only the default for aarch64-fuchsia

Author: Alex Brachet Date: 2022-09-20T18:25:16Z New Revision: 16f735d2fbe8660659f1dde10eea79b0f0f7c11d URL: https://github.com/llvm/llvm-project/commit/16f735d2fbe8660659f1dde10eea79b0f0f7c11d DIFF: https://github.com/llvm/llvm-project/commit/16f735d2fbe8660659f1dde10eea79b0f0f7c11d.diff LOG:

[PATCH] D134289: [Driver] Make --execute-only the default for aarch64-fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16f735d2fbe8: [Driver] Make --execute-only the default for aarch64-fuchsia (authored by abrachet). Herald added a project: clang. Herald added a subs

[PATCH] D134289: [Driver] Make --execute-only the default for aarch64-fuchsia

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:93 CmdArgs.push_back("--fix-cortex-a53-843419"); +CmdArgs.push_back("--execute-only"); } mcgrathr wrote: > This is a littl

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

modimo added a comment. In D132186#3802989 , @paulkirth wrote: > @iamarchit123 I think the standard advice is to start w/ the llvm-test-suite > and then explore other benchmarks as needed. Also, Clang itself is often a > very good starting point. > > As

[PATCH] D132711: [HLSL] add sqrt library function

bob80905 updated this revision to Diff 461638. bob80905 added a comment. add hlslintr.h file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h Index: clan

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

sammccall added a comment. The descriptions here are pretty general and opaque nad it's hard to follow what this means in practice. It sounds like the motivating cases are to do with template instantiation - can we see them? e.g. code + proposed diagnostics before/after, or some other descripti

[clang] f2949fe - Add explicit tests for the PS4/PS5 C/C++ standards version defaults.

Author: Douglas Yung Date: 2022-09-20T11:31:38-07:00 New Revision: f2949febf354eb8aded7db3e63d2c878fe86db3b URL: https://github.com/llvm/llvm-project/commit/f2949febf354eb8aded7db3e63d2c878fe86db3b DIFF: https://github.com/llvm/llvm-project/commit/f2949febf354eb8aded7db3e63d2c878fe86db3b.diff

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm added a comment. In D82087#3797883 , @jdoerfert wrote: > Can we land this? I'd like to use the new intrinsics as I don't understand > the old ones. What do you think about using the two separate builtins, vs. one magic builtin that auto-changes t

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

JonChesterfield added a comment. In D82087#3803464 , @arsenm wrote: > In D82087#3797883 , @jdoerfert wrote: > >> Can we land this? I'd like to use the new intrinsics as I don't understand >> the old ones. > > What

  1   2   3   >