nridge accepted this revision.
nridge added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017
+TEST(CompletionTests, EmptySnippetDoesNotCrash) {
+ // See https://github.com/clangd/clangd/issues/1216
----------------
tom-anders wrote:
> tom-anders wrote:
> > kadircet wrote:
> > > tom-anders wrote:
> > > > nridge wrote:
> > > > > Does this test trigger the crash for you when run without the fix?
> > > > Yes it does, I double checked. Not sure why it didn't work for you
> > > it doesn't trigger the crash for me either.
> > Huh, maybe this is a b
> Hmm could be a build type thing? I ran the tests for a Debug build, maybe
> it's different in Release?
>
> Maybe we could also ask the author of the GitHub issue to check if it fixes
> the crash for them?
Ok, I verified that the test case does produce completion proposals with empty
snippets, i.e. it does trigger the problematic code path, it just happens not
to crash for me. I think that's fine.
Thank you for tracking this down and fixing!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134137/new/
https://reviews.llvm.org/D134137
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
