[PATCH] D131853: [clangd] Add doxygen parsing for Hover

tom-anders added a comment. In D131853#3793831 , @nridge wrote: > In D131853#3792985 , @logankaser > wrote: > >> Is there anything I can do as a random member of the public that wants this >> and knows C++? > >

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny created this revision. mgorny added reviewers: sepavloff, asymptotically, MaskRay, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Add a `--no-default-config` option that disables the search for default set of config fi

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae updated this revision to Diff 460659. python3kgae added a comment. Limit BitInt vector to byte-sized and power of 2 BitInt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/ https://reviews.llvm.org/D133634 Files: clang/inclu

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

MaskRay added a comment. This makes sense. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae added a comment. Thanks for all the comments. I've limit BitInt vector to BitInt with byte-sized and power of 2 NumBits. For the ABI, is it OK to let mangleType of VectorType treat BitInt like other element types, call mangleType of BitInt for the element type part? Repository:

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv7l-clang.cfg'.

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance,

[PATCH] D134020: [clang][Interp] Handle enums

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Handle `DeclRefExpr`s pointing to `EnumConstantDecl

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

tbaeder added a comment. In D133941#3794441 , @junaire wrote: > Do you think `std::is_same_v` will be even better? I don't really have a preference. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133941/new/ https://reviews.llvm.org/D133941 __

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460663. anderslanglands added a comment. squashing all commits into one to hopefully fix the revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924 Files:

[PATCH] D133924: add clang_CXXMethod_isDeleted function

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:323 +- Introduced the new function `clang_CXXMethod_isDeleted`, which queries + whether the method is declared `= delete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny updated this revision to Diff 460665. mgorny added a comment. Replace `!x || !y` logic with `!(x && y)` that may be easier to comprehend. Replace `//` with empty lines on test boundaries. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv7l-clang.cfg'.

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/config-file3.c:44 + +//--- --no-default-config disables config search +// Append `.` after a complete sentence in a comment. Comment at: clang/test/Dri

[PATCH] D133698: [clang][dataflow] SignAnalysis, edgeTransfer, branchTransfer

dkrupp added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:241 +? SignLattice(R.Val.getInt().getExtValue()) +: SignLattice::bottom(); + } else { Isn't this SignLattice

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny marked 6 inline comments as done. mgorny added a comment. Thanks! I'm going to give others a few more hours to chime in before merging it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018 ___ c

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460672. anderslanglands added a comment. Adding in the dyn_cast_is_present change I missed on the previous one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands added a comment. OK that should all be good now. Thanks for your patience, it's my first time doing all this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924 _

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 460679. cor3ntin added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/UnicodeCharSets.h

[clang] e540965 - [AMDGPU] Added __builtin_amdgcn_ds_bvh_stack_rtn

Author: Stanislav Mekhanoshin Date: 2022-09-16T02:42:09-07:00 New Revision: e540965915a490f2f3cc51a09571ad5a573da05d URL: https://github.com/llvm/llvm-project/commit/e540965915a490f2f3cc51a09571ad5a573da05d DIFF: https://github.com/llvm/llvm-project/commit/e540965915a490f2f3cc51a09571ad5a573da0

[PATCH] D133966: [AMDGPU] Added __builtin_amdgcn_ds_bvh_stack_rtn

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe540965915a4: [AMDGPU] Added __builtin_amdgcn_ds_bvh_stack_rtn (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

sepavloff accepted this revision. sepavloff added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

tbaeder updated this revision to Diff 460689. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133941/new/ https://reviews.llvm.org/D133941 Files: clang/lib/AST/Interp/InterpStack.h Index: clang/lib/AST/Interp/InterpStack.h

[clang-tools-extra] aff1f63 - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-16T11:55:40+02:00 New Revision: aff1f6310e5f4cea92c4504853d5fd824754a74f URL: https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f DIFF: https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f.dif

[clang] aff1f63 - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-16T11:55:40+02:00 New Revision: aff1f6310e5f4cea92c4504853d5fd824754a74f URL: https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f DIFF: https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f.dif

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaff1f6310e5f: [clang] use getCommonSugar in an assortment of place

[PATCH] D133979: [clangd] XRef functions treat visible class definitions as primary.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:291 + // (This exception matches the spirit of our indexing heuristics). + if (/*PreferDef=*/[&] { +if (Def == TD) can we extract all of this into a `const TagDecl* g

[clang-tools-extra] 1d1a98e - Revert "[clang] use getCommonSugar in an assortment of places"

Author: Matheus Izvekov Date: 2022-09-16T12:03:34+02:00 New Revision: 1d1a98e9a06ed7a9289b2fd7925035dbcbb7e0ce URL: https://github.com/llvm/llvm-project/commit/1d1a98e9a06ed7a9289b2fd7925035dbcbb7e0ce DIFF: https://github.com/llvm/llvm-project/commit/1d1a98e9a06ed7a9289b2fd7925035dbcbb7e0ce.dif

[PATCH] D133968: [clangd] Enable standard library index by default.

kadircet added a comment. thanks, LG but seems to be failing on windows :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133968/new/ https://reviews.llvm.org/D133968 ___ cfe-commits mailing list cfe-comm

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added a comment. In D128462#3793266 , @beanz wrote: > I think we had no expectation that DXC-mode would be supported by the tooling > APIs at this point. Right, and as I mentioned in my previous comments this is completely fine, at least in th

[PATCH] D133962: [clang(d)] Include/Exclude CLDXC options properly

This revision was automatically updated to reflect the committed changes. Closed by commit rG23ace26e0d1a: [clang(d)] Include/Exclude CLDXC options properly (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133962/new/ https://re

[clang] 23ace26 - [clang(d)] Include/Exclude CLDXC options properly

Author: Kadir Cetinkaya Date: 2022-09-16T12:20:22+02:00 New Revision: 23ace26e0d1aa2283d65d192c37592fb0eef1b1f URL: https://github.com/llvm/llvm-project/commit/23ace26e0d1aa2283d65d192c37592fb0eef1b1f DIFF: https://github.com/llvm/llvm-project/commit/23ace26e0d1aa2283d65d192c37592fb0eef1b1f.dif

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 460696. pmatos marked an inline comment as done. pmatos added a comment. Fix a few of the issues mentioned in the revision comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos planned changes to this revision. pmatos added a comment. Still a few more changes are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 ___ cfe-

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

tbaeder updated this revision to Diff 460697. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133941/new/ https://reviews.llvm.org/D133941 Files: clang/lib/AST/Interp/InterpStack.h Index: clang/lib/AST/Interp/InterpStack.h ===

[PATCH] D133962: [clang(d)] Include/Exclude CLDXC options properly

kadircet added a comment. asked for a backport for 15.0.1 in https://github.com/llvm/llvm-project/issues/57779 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133962/new/ https://reviews.llvm.org/D133962

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/AST/Type.h:1972-1973 + /// Check if this is a WebAssembly Reference Type. + bool isWebAssemblyReferenceType() const; + bool isWebAssemblyExternrefType() const; /// Determi

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

kadircet added a comment. In D133757#3792930 , @nridge wrote: > Thanks for the feedback! Yeah I'd be wary of introducing a corner case where > the user passes `--query-driver`, and there is in fact a driver available to > query in `PATH`, but we end up

[clang] c7c0ce7 - Fix the clang Sphinx bot

Author: Aaron Ballman Date: 2022-09-16T07:19:30-04:00 New Revision: c7c0ce7d9ebdc0a49313bc77e14d1e856794f2e0 URL: https://github.com/llvm/llvm-project/commit/c7c0ce7d9ebdc0a49313bc77e14d1e856794f2e0 DIFF: https://github.com/llvm/llvm-project/commit/c7c0ce7d9ebdc0a49313bc77e14d1e856794f2e0.diff

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 10 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/AddressSpaces.h:59-60 + wasm_var, + wasm_externref, // This denotes the count of language-specific address spaces and also aaron.ballman wrote: >

[PATCH] D133924: add clang_CXXMethod_isDeleted function

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the one minor nit. Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int a; +struct B // no-error, struct B is not defined within __builtin_offsetof directly +{ inclyc wrote: > aaron.ballman wrote: > > inclyc wrote: > > > inclyc wrote: > >

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

serge-sans-paille updated this revision to Diff 460704. serge-sans-paille added a comment. Take reviews into account CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133108/new/ https://reviews.llvm.org/D133108 Files: clang/lib/Sema/SemaChecking.cpp Index: clang/lib/Sema/SemaChecking.c

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. Follow up fix: https://reviews.llvm.org/D133946 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 ___ cfe-commits mailing list cf

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 460706. pmatos marked 4 inline comments as done. pmatos added a comment. Further changes - more to come. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang

[PATCH] D133634: [clang] Allow vector of BitInt

erichkeane added a subscriber: eli.friedman. erichkeane added a comment. The CFE Changes look correct, but @eli.friedman/@craig.topper should comment as to whether this is acceptable. It still needs a few codegen tests however, to make sure the basic operations work, and that these are passed c

[PATCH] D134020: [clang][Interp] Handle enums

erichkeane added a comment. I can't come up with a way to get a reference to one of these, so the logic in the rest of the DeclRefExpr handling is a little MORE awkward looking now. I think I'm OK with this, but I want to give a few other folks a chance to look. Repository: rG LLVM Github M

[PATCH] D134020: [clang][Interp] Handle enums

erichkeane added a comment. Also note, the CI test is from your test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134020/new/ https://reviews.llvm.org/D134020 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 updated this revision to Diff 460718. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp clang/unittests/AST/ASTImporterT

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

aaron.ballman added a comment. Found a few more things while trying to convince myself this really is NFC, and I don't think it is. If you agree, then I think we should have some additional test coverage to show the behavioral changes. Comment at: clang/lib/Sema/SemaChecking.

[PATCH] D134020: [clang][Interp] Handle enums

tbaeder added a comment. In D134020#3795091 , @erichkeane wrote: > I can't come up with a way to get a reference to one of these, so the logic > in the rest of the DeclRefExpr handling is a little MORE awkward looking now. > I think I'm OK with this,

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. is_same_v would be an improvement, but otherwise I think this is fine. Comment at: clang/lib/AST/Interp/InterpStack.h:140 +else if constexpr (std::is_same::value

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 + +if (!ArgType->isConstantSizeType() || +ArgType->isDependentType()) Documentation for `isConstantSizedType` says it isn't legal to call it on dependent or in

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460723. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[libunwind] c9cffdd - [libunwind] Fix usage of `_dl_find_object` on 32-bit x86

Author: Adrian Vogelsgesang Date: 2022-09-16T06:29:49-07:00 New Revision: c9cffdde393f646acf62d6160e7fa6613e038508 URL: https://github.com/llvm/llvm-project/commit/c9cffdde393f646acf62d6160e7fa6613e038508 DIFF: https://github.com/llvm/llvm-project/commit/c9cffdde393f646acf62d6160e7fa6613e038508

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 2183fe2 - [clang-format] Parse the else part of `#if 0`

Author: sstwcw Date: 2022-09-16T13:30:46Z New Revision: 2183fe2160fbcb754893e98829f2bff4d0fccfa3 URL: https://github.com/llvm/llvm-project/commit/2183fe2160fbcb754893e98829f2bff4d0fccfa3 DIFF: https://github.com/llvm/llvm-project/commit/2183fe2160fbcb754893e98829f2bff4d0fccfa3.diff LOG: [clang

[clang] e596422 - [clang-format] Fix template arguments in macros

Author: sstwcw Date: 2022-09-16T13:30:46Z New Revision: e5964223d99a119e4077e3ed1f1322fa2b8cc703 URL: https://github.com/llvm/llvm-project/commit/e5964223d99a119e4077e3ed1f1322fa2b8cc703 DIFF: https://github.com/llvm/llvm-project/commit/e5964223d99a119e4077e3ed1f1322fa2b8cc703.diff LOG: [clang

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2183fe2160fb: [clang-format] Parse the else part of `#if 0` (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D133647?vs=459305&id=460729#toc Repository: rG LLVM Github Monorepo

[PATCH] D133954: [clang-format] Fix template arguments in macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5964223d99a: [clang-format] Fix template arguments in macros (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D133954?vs=460446&id=460730#toc Repository: rG LLVM Github Monore

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

aaron.ballman added a comment. In D133934#3794389 , @tbaeder wrote: > I can see that `HandleSizeOf()` uses 1 for void and function types as a gcc > extension, but I can't reproduce that: https://godbolt.org/z/njG9zh6PM C code allows the construct: https

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar created this revision. mitchell-stellar added reviewers: HazardyKnusperkeks, curdeius, MyDeveloperDay. mitchell-stellar added a project: clang-format. Herald added a project: All. mitchell-stellar requested review of this revision. Herald added a project: clang. Fixes https://gith

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

ahatanak updated this revision to Diff 460735. ahatanak added a comment. - Fix failing CodeGen test. - Add release note to the Potentially Breaking Changes section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. In D133737#3787066 , @RKSimon wrote: > The elementwise builtins should work for scalars as well (and IIRC we do test > this as well). Yep they should, it is specially specified here: https://clang.llvm.org/docs/LanguageExtensions

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

barcisz updated this revision to Diff 460743. barcisz added a comment. Herald added a subscriber: aheejin. documentation for the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133956/new/ https://reviews.llvm.org/D133956 Files: .clang-tidy

[PATCH] D134046: [OpenMP] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

domada created this revision. domada added reviewers: kiranchandramohan, kiranktp. domada added a project: OpenMP. Herald added subscribers: bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aart

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 + +if (!ArgType->isConstantSizeType() || +ArgType->isDependentType()) erichkeane wrote: > Documentation for `isConstantSi

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e229831154: [clang] use getCommonSugar in an assortment of place

[clang] 67e2298 - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-16T16:36:00+02:00 New Revision: 67e22983115451ef5512ad2813dd337762c52da3 URL: https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3 DIFF: https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3.dif

[clang-tools-extra] 67e2298 - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-16T16:36:00+02:00 New Revision: 67e22983115451ef5512ad2813dd337762c52da3 URL: https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3 DIFF: https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3.dif

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 + +if (!ArgType->isConstantSizeType() || +ArgType->isDependentType()) tbaeder wrote: > erichkeane wrote: > > Documentation for `isConstantSizedType` says it isn

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 460756. luken-google added a comment. Refactor to check during template overload evaluation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 Files: clang/docs/R

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 460757. luken-google added a comment. Remove extraneous comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. @ilya-biryukov something like this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder updated this revision to Diff 460758. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133934/new/ https://reviews.llvm.org/D133934 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Opco

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 + +if (!ArgType->isConstantSizeType() || +ArgType->isDependentType()) erichkeane wrote: > tbaeder wrote: > > erichkeane wrote: > > > Documentation for `isConstantS

[PATCH] D134034: [test] Use host platform specific error message substitution

abhina.sreeskantharajan updated this revision to Diff 460761. abhina.sreeskantharajan added a comment. Herald added subscribers: cfe-commits, ormris. Herald added a project: clang. Add some more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the following construction: `template requi

[PATCH] D134034: [test] Use host platform specific error message substitution

fanbo-meng accepted this revision. fanbo-meng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134034/new/ https://reviews.llvm.org/D134034 ___

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Good catch, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/ https://reviews.llvm.org/D133988 __

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 460764. pmatos added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/AddressSpace

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 + +if (!ArgType->isConstantSizeType() || +ArgType->isDependentType()) tbaeder wrote: > erichkeane wrote: > > tbaeder wrote: > > > erichkeane wrote: > > > > Documen

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder updated this revision to Diff 460766. tbaeder marked 11 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133934/new/ https://reviews.llvm.org/D133934 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/By

[clang] 00ce271 - [clang] extend getCommonSugaredType to merge sugar nodes

Author: Matheus Izvekov Date: 2022-09-16T17:04:10+02:00 New Revision: 00ce271712d407b5347681c36474b80cfb0033d3 URL: https://github.com/llvm/llvm-project/commit/00ce271712d407b5347681c36474b80cfb0033d3 DIFF: https://github.com/llvm/llvm-project/commit/00ce271712d407b5347681c36474b80cfb0033d3.dif

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG00ce271712d4: [clang] extend getCommonSugaredType to merge sugar nodes (authored by mizvekov). Changed prior to commit:

[PATCH] D134050: [clang][RISCV][NFC][WIP/RFC] Move riscv-abi.cpp and riscv32-*abi.c tests to use update_cc_test_checks.py

asb created this revision. asb added reviewers: reames, craig.topper, luismarques, kito-cheng. Herald added subscribers: wingo, sunshaoce, pmatos, VincentWu, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosb

[clang] 1b69ce1 - Currently the options ‘ffast-math’ and ‘ffp-contract’ are connected.

Author: Zahira Ammarguellat Date: 2022-09-16T11:08:41-04:00 New Revision: 1b69ce1208976c71bf7ee3932aa272462c1feb1b URL: https://github.com/llvm/llvm-project/commit/1b69ce1208976c71bf7ee3932aa272462c1feb1b DIFF: https://github.com/llvm/llvm-project/commit/1b69ce1208976c71bf7ee3932aa272462c1feb1b

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D133853#3793284 , @RIscRIpt wrote: > In D133853#3792518 , @aaron.ballman > wrote: > >> I

[clang] 591452e - NFC: [clang] add template AST test for make_integer_seq and type_pack_element

Author: Matheus Izvekov Date: 2022-09-16T17:12:49+02:00 New Revision: 591452eb235f0bdf5c22ba635114bf1b8dc7d01c URL: https://github.com/llvm/llvm-project/commit/591452eb235f0bdf5c22ba635114bf1b8dc7d01c DIFF: https://github.com/llvm/llvm-project/commit/591452eb235f0bdf5c22ba635114bf1b8dc7d01c.dif

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG591452eb235f: NFC: [clang] add template AST test for make_integer_seq and type_pack_element (authored by mizvekov). Repos

[PATCH] D133725: Searching for tokens including comments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Ah, thank you for the extra description, that helped a lot. The changes LGTM, though you should hold off on landing them until we're sure the clang-tidy changes are going in. R

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

erichkeane added a comment. In D133853#3795579 , @aaron.ballman wrote: > In D133853#3793284 , @RIscRIpt > wrote: > >> In D133853#3792518 , >> @aaron.ballman wrote: >> >

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

asb requested changes to this revision. asb added a comment. This revision now requires changes to proceed. Everything that's in this patch looks good to me - it's just missing some simple round-trip tests in the style of rv32zicboz-valid.s (and perhaps an -invalid.s that shows a sensible error

[PATCH] D133634: [clang] Allow vector of BitInt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3024 def err_attribute_invalid_vector_type : Error<"invalid vector element type %0">; +def err_attribute_invalid_bitint_vector_type : Error<"invalid vector element type %0, must b

[PATCH] D134034: [test] Use host platform specific error message substitution

zibi accepted this revision. zibi added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134034/new/ https://reviews.llvm.org/D134034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] f4ea3bd - [clang] Fixes how we represent / emulate builtin templates

Author: Matheus Izvekov Date: 2022-09-16T17:44:12+02:00 New Revision: f4ea3bd4b2086e6de10131b197aaf7d066a24df8 URL: https://github.com/llvm/llvm-project/commit/f4ea3bd4b2086e6de10131b197aaf7d066a24df8 DIFF: https://github.com/llvm/llvm-project/commit/f4ea3bd4b2086e6de10131b197aaf7d066a24df8.dif

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf4ea3bd4b208: [clang] Fixes how we represent / emulate builtin templates (authored by mizvekov). Changed prior to commit:

[PATCH] D134052: [clang-format] Disallow requires clauses to become function declarations

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There already exists logic to disallow requires

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. I understand your frustration with the regression, but let’s try to constructive. We all care about quality and we’re all working hard to do the best we can. In D128462#3794868 , @kadircet wrote: > My main complaint here's around

  1   2   3   >